Re: [PATCH v4 00/20] resurrect automatic dependencies

2013-09-24 Thread Paolo Bonzini
Il 25/09/2013 06:37, Alexandre Oliva ha scritto: > On Sep 23, 2013, Tom Tromey wrote: > >> First, I believe I've addressed all of the comments in Paolo's review. > > That's my feeling as well. Sorry that I didn't manage to go through > earlier versions of the patch before; I've just reviewed v4

Re: [v3] plus

2013-09-24 Thread Marc Glisse
On Wed, 25 Sep 2013, Jonathan Wakely wrote: I've had this sitting in my tree waiting to do something with, I did ask last week if someone had done it already... I'm about to go to sleep so didn't check if the test covers anything yours doesn't. In the test you have basic cover for all func

Re: [PATCH, libvtv] Fix configure/testsuite issues with libvtv

2013-09-24 Thread Alexandre Oliva
Hello, Caroline, On Sep 12, 2013, Caroline Tice wrote: > 2013-09-12 Caroline Tice > * Makefile.am: Re-instante ENABLE_VTABLE_VERIFY checks, to make > sure testsuite is not run if libstdc++ and libgcc were not built > with vtable verification. > * Makefile.in: R

Re: [PATCH v4 00/20] resurrect automatic dependencies

2013-09-24 Thread Alexandre Oliva
On Sep 23, 2013, Tom Tromey wrote: > First, I believe I've addressed all of the comments in Paolo's review. That's my feeling as well. Sorry that I didn't manage to go through earlier versions of the patch before; I've just reviewed v4 plus the discussions around v3. Save for one detail, I'm e

Go patch committed: Don't permit assigning nil to _

2013-09-24 Thread Ian Lance Taylor
This patch from Chris Manghane corrects the Go frontend to not permit assigning nil to the sink variable _. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline and 4.8 branch. Ian diff -r 869985e4ef63 go/parse.cc --- a/go/parse.cc Thu Sep 19 10:30:42 2013 -0700

Re: [google integration,gcc-4_8] Additional lightweight debug checks for std::deque

2013-09-24 Thread Paul Pluzhnikov
On Mon, Sep 23, 2013 at 6:29 PM, Paul Pluzhnikov wrote: > I've committed the patch below to google/integration (r202856) and > gcc-4_8 (r202857) branches. Google ref: b/10872448. I've committed r202880 to adjust line numbers for libstdc++ breakage on google/gcc-4_8 branch. Thanks, 2013-09-24

[PATCH, IRA] Fix ALLOCNO_MODE in the case of paradoxical subreg.

2013-09-24 Thread Wei Mi
Hi, This patch is to address the problem described here: http://gcc.gnu.org/ml/gcc/2013-09/msg00187.html The patch changes ALLOCNO_MODE of a pseudo reg to be outermode if the pseudo reg is used in a paradoxical subreg, so IRA will not mistakenly assign an operand with a bigger mode to a smaller h

Re: [v3] plus

2013-09-24 Thread Jonathan Wakely
On 24 September 2013 23:37, Marc Glisse wrote: > Hello, > > this was only minimally tested since trunk is broken at the moment. There > don't seem to be specific tests for the existing functors, so a couple tests > for the new specializations seem good enough. > I've had this sitting in my tree wa

Re: Fwd: [PATCH] Scheduling result adjustment to enable macro-fusion

2013-09-24 Thread Wei Mi
>> It doesn't look right. IP relative address is only possible >> with TARGET_64BIT and >> >> 1. base == pc. Or >> 2. UUNSPEC_PCREL, UNSPEC_GOTPCREL, and >> NSPEC_GOTNTPOFF. > > Target 64bit should be tested above. We however output RIP addresses > also for basic symbol references. I.e. when ba

[PATCH] Don't require class to be constructed (PR c++/58408)

2013-09-24 Thread David Bartley
2013-09-24 David Bartley PR c++/58408 * gcc/cp/class.c: Don't require class to be constructed if it has a trivial default constructor. * gcc/testsuite/g++.dg/tls/init-1.C: New testcase. --- gcc/cp/class.c| 14 +- gcc/testsuite/g++

Re: [v3] plus

2013-09-24 Thread Paolo Carlini
On 9/24/13 5:37 PM, Marc Glisse wrote: Hello, this was only minimally tested since trunk is broken at the moment. There don't seem to be specific tests for the existing functors, so a couple tests for the new specializations seem good enough. What about at least covering all of them? Just to m

[v3] plus

2013-09-24 Thread Marc Glisse
Hello, this was only minimally tested since trunk is broken at the moment. There don't seem to be specific tests for the existing functors, so a couple tests for the new specializations seem good enough. 2013-09-25 Marc Glisse * include/bits/stl_function.h: Include for std::forwa

[SH, committed] Fix minor formatting nits

2013-09-24 Thread Oleg Endo
Hello, The attached patch fixes a few formatting nits in sh.md. Committed as rev. 202876. Cheers, Oleg gcc/ChangeLog: config/sh/sh.md: Fix formatting. Index: gcc/config/sh/sh.md === --- gcc/config/sh/sh.md (revision 202873)

RE: [PATCH] Add a new option "-ftree-bitfield-merge" (patch / doc inside)

2013-09-24 Thread Zoran Jovanovic
Hello, This is new patch version. Comments from Bernhard Reutner-Fischer review applied. Also, test case bitfildmrg2.c modified - it is now execute test. Example: Original code: D.1351; D.1350; D.1349; D.1349_2 = p1_1(D)->f1; p2_3(D)->f1 = D.1349_2; D.1350_4 = p1_1(D)->f2; p2_3

Re: [PATCH] Portable Volatility Warning

2013-09-24 Thread Sandra Loosemore
I have some nit-picky documentation suggestions about this patch http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00100.html + warning_at (input_location, OPT_Wportable_volatility, + "the code to accesses this volatile member is dependent on" + " whether -fstrict-volati

Re: Fwd: [PATCH] Scheduling result adjustment to enable macro-fusion

2013-09-24 Thread Jan Hubicka
> > + gcc_assert (ok); > > + base = parts.base; > > + index = parts.index; > > + disp = parts.disp; > > + > > + if (TARGET_64BIT && !base && !index) > > +{ > > + rtx symbol = disp; > > + > > + if (GET_CODE (disp) == CONST > > + && GET_CODE (XEXP (disp, 0)) == PLUS > > +

Re: [PATCH] Set expr loc safely (PR c++/58516)

2013-09-24 Thread Jason Merrill
OK. Jason

Re: Fwd: [PATCH] Scheduling result adjustment to enable macro-fusion

2013-09-24 Thread H.J. Lu
On Tue, Sep 24, 2013 at 12:06 PM, Wei Mi wrote: > This is the updated patch2. > Changed: > 1. For cmp/test with rip-relative addressing mem operand, don't group > insns. Bulldozer also doesn't support fusion for cmp/test with both > displacement MEM and immediate operand, while m_CORE_ALL doesn't

Re: [PATCH, powerpc] Rework#2 VSX scalar floating point support, patch #3

2013-09-24 Thread Michael Meissner
This patch adds the initial support for putting DI, DF, and SF values in the upper registers (traditional Altivec registers) using the -mupper-regs-df and -mupper-regs-sf patches. Those switches will not be enabled by default until the rest of the changes are made. This patch passes the bootstrap

Re: [PATCH] Bug fix: *var and MEM[(const int *)var] (var has int* type) are not treated as the same data ref.

2013-09-24 Thread Cong Hou
Nice fix! I noticed that this patch is already combined to the trunk. Thank you very much, Richard! Cong On Tue, Sep 24, 2013 at 1:49 AM, Richard Biener wrote: > On Tue, 24 Sep 2013, Richard Biener wrote: > >> On Tue, 24 Sep 2013, Jakub Jelinek wrote: >> >> > Hi! >> > >> > On Mon, Sep 23, 201

Re: [PATCH, LRA] Remove REG_DEAD and REG_UNUSED notes.

2013-09-24 Thread Mike Stump
On Sep 24, 2013, at 12:23 PM, Steven Bosscher wrote: > On Tue, Sep 24, 2013 at 5:03 PM, Eric Botcazou wrote: >>> This patch removes REG_DEAD and REG_UNUSED notes >> DF framework is supposed to do it for you. > Unfortunately LRA uses its own DF framework. Is that a bug, or a feature?

[PATCH, PR 58441] Fix location where libvtv puts its headers

2013-09-24 Thread Caroline Tice
The following patch updates where libvtv installs its header files (fixing PR 58441). This is a trivial change, and affects only libvtv, so I am going to go ahead and commit it. -- Caroline Tice cmt...@google.com 2013-09-24 Caroline Tice * Makefile.am: Change libvtv_includedir to the direct

Re: [PATCH, LRA] Remove REG_DEAD and REG_UNUSED notes.

2013-09-24 Thread Steven Bosscher
On Tue, Sep 24, 2013 at 5:03 PM, Eric Botcazou wrote: >> This patch removes REG_DEAD and REG_UNUSED notes in update_inc_notes, >> as it is what the function is supposed to do (see the comments) and as >> keeping these notes produce some failures, at least on ARM. > > The description is too terse.

[gomp4] Taskgroup library support

2013-09-24 Thread Jakub Jelinek
Hi! This implements taskgroups in the library and their cancellation. The implementation has been pretty straightforward, though I had to consolidate some operations from {gomp_barrier_handle_tasks, GOMP_taskwait} and the new GOMP_taskgroup_end to new inlines, because it became non-maintainable.

[gomp4] Taskgroup and cancellation compiler fixes

2013-09-24 Thread Jakub Jelinek
Hi! This patch: 1) defers expansion of taskgroup into GOMP_taskgroup_start and GOMP_taskgroup_end until omplower/ompexp, mainly so that e.g. invalid nesting can be diagnosed (e.g. #pragma omp cancel * inside of #pragma omp taskgroup nested in some other construct) 2) diagnoses structured

Re: RFA: Store the REG_BR_PROB probability directly as an int

2013-09-24 Thread Andreas Schwab
Richard Sandiford writes: > Sorry for the breakage. I think we need to handle INT_LIST in the same way > as INSN_LIST though, and eliminate in XEXP (x, 1). > > How about the attached? Testing in progress... Works for me as well. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fing

Re: Fwd: [PATCH] Scheduling result adjustment to enable macro-fusion

2013-09-24 Thread Wei Mi
This is the updated patch2. Changed: 1. For cmp/test with rip-relative addressing mem operand, don't group insns. Bulldozer also doesn't support fusion for cmp/test with both displacement MEM and immediate operand, while m_CORE_ALL doesn't support fusion for cmp/test with MEM and immediate operand.

Re: [PATCH] Refactor type handling in get_alias_set, fix PR58513

2013-09-24 Thread H.J. Lu
On Tue, Sep 24, 2013 at 4:00 AM, Richard Biener wrote: > > As noted in PR58513 the alias type comparison in operand_equal_p for > MEM_REF and TARGET_MEM_REF is overly restrictive. The following > adds a new alias_ptr_types_compatible_p helper for a less conservative > comparison and refactors get

Re: [PATCH]: Fix use of __builtin_eh_pointer in EH_ELSE

2013-09-24 Thread Richard Henderson
On 09/03/2013 07:08 AM, Tristan Gingold wrote: > Hi, > > The field state->ehp_region wasn't updated before lowering constructs in the > eh > path of EH_ELSE. As a consequence, __builtin_eh_pointer is lowered to 0 (or > possibly to a wrong region number) in this path. > > The only user of EH_ELS

Re: [PATCH 0/3] Support some cases of inheritance in gengtype; use it for symtab

2013-09-24 Thread David Malcolm
On Mon, 2013-09-23 at 13:19 +0200, Richard Biener wrote: > On Fri, Sep 20, 2013 at 4:05 PM, David Malcolm wrote: > > There have been various discussions about how to handle inheritance > > within ggc and PCH: whether to extend gengtype to support C++ syntax > > such as templates, or to require peo

Re: [PATCH] Sanitize block partitioning under -freorder-blocks-and-partition

2013-09-24 Thread Teresa Johnson
Rong - can you answer the questions below on the comdat patch? On Tue, Sep 24, 2013 at 5:31 AM, Jan Hubicka wrote: >> Hi Honza, >> >> I am finally getting back to working on this after a few weeks of >> working on some other priorities. > > I am also trying to return to this, so good timming ;)

[wwwdocs] svnwrite.html -- extend documentation of gcc.gnu.org accounts

2013-09-24 Thread Gerald Pfeifer
Caroline made me realize that we should improve our documentation around gcc.gnu.org accounts. This is a first step in that direction. (As a side effect, wrap the e-mail address in to avoid undesired line breaks.) Applied. Gerald Index: svnwrite.html ==

Re: [PATCH] Sanitize block partitioning under -freorder-blocks-and-partition

2013-09-24 Thread Teresa Johnson
On Tue, Sep 24, 2013 at 10:57 AM, Jan Hubicka wrote: >> >> I looked at one that failed after 100 as well (20031204-1.c). In this >> case, it was due to expansion which was creating multiple branches/bbs >> from a logical OR and guessing incorrectly on how to assign the >> counts: >> >> if (octets

Re: [PATCH, PR 57748] Check for out of bounds access, Part 2

2013-09-24 Thread Martin Jambor
Hi, On Tue, Sep 24, 2013 at 12:02:17PM +0200, Richard Biener wrote: > On Tue, Sep 24, 2013 at 4:52 AM, Bernd Edlinger > wrote: > > Hi, > > > > with the attached patch the read-side of the out of bounds accesses are > > fixed. > > There is a single new test case pr57748-3.c that is derived from M

Re: [PATCH] Sanitize block partitioning under -freorder-blocks-and-partition

2013-09-24 Thread Jan Hubicka
> > I looked at one that failed after 100 as well (20031204-1.c). In this > case, it was due to expansion which was creating multiple branches/bbs > from a logical OR and guessing incorrectly on how to assign the > counts: > > if (octets == 4 && (*cp == ':' || *cp == '\0')) { > > The (*cp == ':

Re: [PATCH] Set expr loc safely (PR c++/58516)

2013-09-24 Thread Marek Polacek
On Tue, Sep 24, 2013 at 12:00:41PM -0500, Paolo Carlini wrote: > Hi, > > On 9/24/13 11:35 AM, Marek Polacek wrote: > >I admit I haven't spent much time on this, but it seems we should just > >check whether we can set the expr location before actually setting it... > > > >Regtested/bootstrapped on

[PATCH v2 2/4] Parse base classes for GTY-marked types

2013-09-24 Thread David Malcolm
Extend gengtype (and gtype.state reading/writing) so that it is able to parse base classes in simple cases, and only attempt to do it for GTY-marked types. * gengtype-parse.c (require_without_advance): New. (type): For GTY-marked types that are not GTY((user)), parse any ba

[PATCH v2 3/4] Handle simple inheritance in gengtype.

2013-09-24 Thread David Malcolm
Treat GTY structs that have a "desc" as being the root of an inheritance hierarchy. Generate a switch on desc within the marking function with cases for each subclass, visiting all fields of the type (including inherited ones). Don't create marking functions for subclasses, instead using the base

[PATCH v2 4/4] Add documentation about gengtype and inheritance

2013-09-24 Thread David Malcolm
gcc/ * doc/gty.texi (GTY Options): Add note about inheritance to description of desc and tag. (Inheritance and GTY): New. --- gcc/doc/gty.texi | 52 1 file changed, 52 insertions(+) diff --git a/gcc/doc/gty.texi b/gcc/do

[PATCH v2 0/4] Support some cases of inheritance in gengtype

2013-09-24 Thread David Malcolm
Here's an updated version of the patch series. Changes since v1 of the patch series: * Patch 1/4: this one is new: I noticed that the "public:" specifier within class cgraph_node confused gengtype, leading it to erroneously omit the first field within the class. This patch fixes this b

[PATCH v2 1/4] Ignore access-control keywords when parsing fields.

2013-09-24 Thread David Malcolm
Classes containing access-control keywords such as "public:" confuse struct_field_seq, leading it to call consume_until_eos i.e. ignore text until after the next semicolon. This leads to the first field after an access-control keyword being ignored by gengtype. This can be seen in: http://gcc.g

Re: [PATCH]Fix computation of offset in ivopt

2013-09-24 Thread Oleg Endo
On Tue, 2013-09-24 at 12:31 +0200, Richard Biener wrote: > On Tue, Sep 24, 2013 at 11:13 AM, bin.cheng wrote: > > Hi, > > This patch fix two minor bugs when computing offset in IVOPT. > > 1) Considering below example: > > #define MAX 100 > > struct tag > > { > > int i; > > int j; > > } > > str

Re: RFA: Store the REG_BR_PROB probability directly as an int

2013-09-24 Thread Richard Sandiford
Andreas Schwab writes: > Richard Sandiford writes: > >> REG_BR_PROB notes are stored as: >> >> (expr_list:REG_BR_PROB (const_int ) ) >> >> but a full const_int rtx seems a bit heavweight when all we want is >> a plain "int". This patch uses: >> >> (int_list:REG_BR_PROB ) >> >> instead. > >

wide-int: Re: patch to canonize small wide-ints.

2013-09-24 Thread Kenneth Zadeck
I just committed the patch to do this as revision 202871. there are two changes from the earlier patch: 1) the addition of frag in loop-doloop.c. This fixes an rtl canonization bug, but it is unique to the branch. it did not cause a problem on x86 but did on ppc. 2) the code in rtl.h for c

Re: [PATCH][ARM][testsuite] Add effective target check for arm conditional execution

2013-09-24 Thread Mike Stump
On Sep 13, 2013, at 8:25 AM, Kyrill Tkachov wrote: > gcc.target/arm/minmax_minus.c is really only valid when we have conditional > execution available, that is non Thumb1-only targets. I've added an effective > target check for that and used it in the test so that it does not get run and > give

Re: [PATCH i386 3/8] [AVX512] [1/n] Add AVX-512 patterns: VF iterator extended.

2013-09-24 Thread Richard Henderson
On 08/27/2013 11:37 AM, Kirill Yukhin wrote: > Hello, > >> This patch is still far too large. >> >> I think you should split it up based on every single mode iterator that >> you need to add or change. > > Problem is that some iterators are depend on each other, so patches are > not going to be t

Re: [PATCH] Set expr loc safely (PR c++/58516)

2013-09-24 Thread Paolo Carlini
Hi, On 9/24/13 11:35 AM, Marek Polacek wrote: I admit I haven't spent much time on this, but it seems we should just check whether we can set the expr location before actually setting it... Regtested/bootstrapped on x86_64-linux, ok for trunk? Two minor nits (assuming the general idea makes se

[PATCH] Set expr loc safely (PR c++/58516)

2013-09-24 Thread Marek Polacek
I admit I haven't spent much time on this, but it seems we should just check whether we can set the expr location before actually setting it... Regtested/bootstrapped on x86_64-linux, ok for trunk? 2013-09-24 Marek Polacek PR c++/58516 cp/ * semantics.c (finish_transaction_stm

Re: [PATCH, ARM, LRA] Prepare ARM build with LRA

2013-09-24 Thread Richard Sandiford
Eric Botcazou writes: >> Sorry, I'm not sure I understand well, it means that you prefer the >> shift_and _rotate_code_p notation, right ? > > Let's do the following in addition to the lsb_bitfield_op_p thing: > 1. Replace the LO_SUM test in set_address_base by a call to must_be_base_p, > 2. R

Re: [v3] More noexcept -- 6th

2013-09-24 Thread Paolo Carlini
Hi, On 9/24/13 11:13 AM, Marc Glisse wrote: Hello, bootstrap+testsuite ok. I think all container iterators are done, but not the containers themselves. Ok, thanks. Paolo.

Re: [PATCH, LRA] Remove REG_DEAD and REG_UNUSED notes.

2013-09-24 Thread Yvan Roux
> The description is too terse. In the RTL middle-end, you shouldn't have to > manually deal with the REG_DEAD and REG_UNUSED notes (unlike REG_EQUAL and > REG_EQUIV notes), as the DF framework is supposed to do it for you. Sorry, for that. The description of the LRA function update_inc_notes ex

Re: [PATCH, ARM, LRA] Prepare ARM build with LRA

2013-09-24 Thread Yvan Roux
Thanks Eric, here is the new patch, validation is ongoing for ARM. Yvan 2013-09-24 Yvan Roux Vladimir Makarov * rtlanal.c (lsb_bitfield_op_p): New predicate for bitfield operations from the least significant bit. (strip_address_mutations): Add bitfield op

Re: patch to canonize small wide-ints.

2013-09-24 Thread Richard Sandiford
Richard Biener writes: > On Tue, 24 Sep 2013, Kenneth Zadeck wrote: >> On 09/24/2013 09:39 AM, Richard Biener wrote: >> > On Tue, 17 Sep 2013, Kenneth Zadeck wrote: >> > >> > > Richi, >> > > >> > > This patch canonizes the bits above the precision for wide ints with >> > > types >> > > or >> >

Re: [ping][PATCH][1 of 2] Add value range info to SSA_NAME for zero sign extension elimination in RTL

2013-09-24 Thread Christophe Lyon
On 23 September 2013 22:34, Eric Botcazou wrote: > Nice patch, but the formatting is totally wrong wrt spaces, please reformat > using 2-space indentation and 8-space TABs, as already used in the files. > Sorry for missing this problem when committing Kugan's patch. I have just committed the att

Re: [patch] Cleanup tree-ssa-ter.c exports

2013-09-24 Thread Andrew MacLeod
On 09/16/2013 10:42 AM, Andrew MacLeod wrote: On 09/16/2013 04:55 AM, Richard Biener wrote: On Fri, Sep 13, 2013 at 9:15 PM, Andrew MacLeod wrote: OK, a slightly different take.. I realized that I should be adding tree-outof-ssa.h to handle the 3 exports from tree-outof-ssa.c that are in ss

Re: [PATCH, ARM, LRA] Prepare ARM build with LRA

2013-09-24 Thread Eric Botcazou
> Sorry, I'm not sure I understand well, it means that you prefer the > shift_and _rotate_code_p notation, right ? Let's do the following in addition to the lsb_bitfield_op_p thing: 1. Replace the LO_SUM test in set_address_base by a call to must_be_base_p, 2. Replace the MULT || ASHIFT test i

Re: [PATCH, ARM, LRA] Prepare ARM build with LRA

2013-09-24 Thread Yvan Roux
> So can we assert that we have a REG here and use GET_MODE (XEXP (x, 0))? Or > else return false if we don't have a REG. I'm currently testing the patch with the modification below +static bool +lsb_bitfield_op_p (rtx x) +{ + if (GET_RTX_CLASS (GET_CODE (x)) == RTX_BITFIELD_OPS) +{ +

Re: [PATCH, LRA] Remove REG_DEAD and REG_UNUSED notes.

2013-09-24 Thread Eric Botcazou
> This patch removes REG_DEAD and REG_UNUSED notes in update_inc_notes, > as it is what the function is supposed to do (see the comments) and as > keeping these notes produce some failures, at least on ARM. The description is too terse. In the RTL middle-end, you shouldn't have to manually deal

Re: [PATCH, ARM, LRA] Prepare ARM build with LRA

2013-09-24 Thread Eric Botcazou
> Indeed, I think it has to be the mode of loc, but I just wonder if it > is not always the same, as in the doc it is written that mode m is the > same as the mode that would be used for loc if it were a register. So can we assert that we have a REG here and use GET_MODE (XEXP (x, 0))? Or else r

[PATCH, LRA] Remove REG_DEAD and REG_UNUSED notes.

2013-09-24 Thread Yvan Roux
Hi, This patch removes REG_DEAD and REG_UNUSED notes in update_inc_notes, as it is what the function is supposed to do (see the comments) and as keeping these notes produce some failures, at least on ARM. Thanks, Yvan 2013-09-24 Yvan Roux * lra.c (update_inc_notes): Remove all REG_DE

Re: [patch, libgfortran, configure] Cross-compile support for libgfortran

2013-09-24 Thread Richard Earnshaw
On 23/09/13 18:43, Steve Ellcey wrote: > On Mon, 2013-09-23 at 16:26 +0100, Marcus Shawcroft wrote: >> On 4 June 2013 20:49, Steve Ellcey wrote: >>> This patch allows me to build libgfortran for a cross-compiling toolchain >>> using newlib. Currently the checks done by AC_CHECK_FUNCS_ONCE fail wi

Re: [PATCH, PR 57748] Check for out of bounds access, Part 2

2013-09-24 Thread Eric Botcazou
> Index: gcc/expr.c > === > --- gcc/expr.c (revision 202778) > +++ gcc/expr.c (working copy) > @@ -9878,7 +9878,7 @@ > && modifier != EXPAND_STACK_PARM > ? target : NULL_RTX), >

RE: [PATCH] Fix typo in check for null

2013-09-24 Thread Paulo Matos
> -Original Message- > From: Marek Polacek [mailto:pola...@redhat.com] > Sent: 24 September 2013 14:52 > To: Paulo Matos > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] Fix typo in check for null > > On Tue, Sep 24, 2013 at 01:44:30PM +, Paulo Matos wrote: > > Thanks for the comme

Re: patch to canonize small wide-ints.

2013-09-24 Thread Kenneth Zadeck
On 09/24/2013 09:51 AM, Richard Biener wrote: On Tue, 24 Sep 2013, Kenneth Zadeck wrote: On 09/24/2013 09:39 AM, Richard Biener wrote: On Tue, 17 Sep 2013, Kenneth Zadeck wrote: Richi, This patch canonizes the bits above the precision for wide ints with types or modes that are not a perfect

Re: patch to canonize small wide-ints.

2013-09-24 Thread Kenneth Zadeck
On 09/24/2013 09:39 AM, Richard Biener wrote: On Tue, 17 Sep 2013, Kenneth Zadeck wrote: Richi, This patch canonizes the bits above the precision for wide ints with types or modes that are not a perfect multiple of HOST_BITS_PER_WIDE_INT. I expect that most of the changes in rtl.h will go awa

Re: [PATCH] Fix typo in check for null

2013-09-24 Thread Marek Polacek
On Tue, Sep 24, 2013 at 01:44:30PM +, Paulo Matos wrote: > Thanks for the comments Marek, will fix it. > > 2013-09-24 Paulo Matos ^^ Two spaces between name and . Sorry for nitpicking like this. Thanks! Marek

Re: patch to canonize small wide-ints.

2013-09-24 Thread Richard Biener
On Tue, 24 Sep 2013, Kenneth Zadeck wrote: > On 09/24/2013 09:39 AM, Richard Biener wrote: > > On Tue, 17 Sep 2013, Kenneth Zadeck wrote: > > > > > Richi, > > > > > > This patch canonizes the bits above the precision for wide ints with types > > > or > > > modes that are not a perfect multiple o

RE: [PATCH] Fix typo in check for null

2013-09-24 Thread Paulo Matos
> -Original Message- > From: Richard Biener [mailto:richard.guent...@gmail.com] > Sent: 24 September 2013 10:03 > To: Paulo Matos > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] Fix typo in check for null > > On Mon, Sep 23, 2013 at 4:03 PM, Paulo Matos wrote: > > This is a patch fo

RE: [PATCH] Fix typo in check for null

2013-09-24 Thread Paulo Matos
> -Original Message- > From: Marek Polacek [mailto:pola...@redhat.com] > Sent: 24 September 2013 13:57 > To: Paulo Matos > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] Fix typo in check for null > > On Mon, Sep 23, 2013 at 02:03:02PM +, Paulo Matos wrote: > > This is a patch for

Re: patch to canonize small wide-ints.

2013-09-24 Thread Richard Biener
On Tue, 17 Sep 2013, Kenneth Zadeck wrote: > Richi, > > This patch canonizes the bits above the precision for wide ints with types or > modes that are not a perfect multiple of HOST_BITS_PER_WIDE_INT. > > I expect that most of the changes in rtl.h will go away. in particular, when > we decide

Re: [PATCH][ARM][testsuite] Add effective target check for arm conditional execution

2013-09-24 Thread Kyrill Tkachov
On 13/09/13 16:25, Kyrill Tkachov wrote: Hi all, gcc.target/arm/minmax_minus.c is really only valid when we have conditional execution available, that is non Thumb1-only targets. I've added an effective target check for that and used it in the test so that it does not get run and give a false ne

Re: [PATCH] Fix typo in check for null

2013-09-24 Thread Marek Polacek
On Mon, Sep 23, 2013 at 02:03:02PM +, Paulo Matos wrote: > This is a patch for master, where in number_of_loops, we want to check if the > loops (returned by loops_for_fn) is non-null but instead we are using fn, > which is the function argument. I haven't opened a bug report, please let me

Re: [PATCH] Sanitize block partitioning under -freorder-blocks-and-partition

2013-09-24 Thread Jan Hubicka
> Hi Honza, > > I am finally getting back to working on this after a few weeks of > working on some other priorities. I am also trying to return to this, so good timming ;) Martin has got smaller C++ programs (Inkscape) to not touch cold segment during the startup with FDO (w/o partitioning). Fir

Re: [Patch] match_results::format and regex_replace

2013-09-24 Thread Ed Smith-Rowland
On 09/23/2013 10:09 PM, Tim Shen wrote: On Sun, Sep 22, 2013 at 4:20 PM, Paolo Carlini wrote: If testing goes well patch is Ok to commit. Tested under -m32 and -m64 and committed :) I'll learn how locale in glibc works. Thank you all! Thank *you*! has been dogging us for years. I, for

Re: [PATCH]Construct canonical scaled address expression in IVOPT

2013-09-24 Thread Richard Biener
On Tue, Sep 24, 2013 at 1:40 PM, Bin.Cheng wrote: > On Tue, Sep 24, 2013 at 6:12 PM, Richard Biener > wrote: >> On Tue, Sep 24, 2013 at 8:20 AM, bin.cheng wrote: >>> >>> -Original Message- >> >> Or even [reg*scale] (not sure about that). But yes, at least reg*scale + >> offset >>

[PATCH][RFC] Remove quadratic loop with component_uses_parent_alias_set

2013-09-24 Thread Richard Biener
Eric, the current way component_uses_parent_alias_set is called from get_alias_set causes the reference tree chain to be walked O(n^2) in case there is any DECL_NONADDRESSABLE_P or TYPE_NONALIASED_COMPONENT reference in the tree chain. Also the comment above component_uses_parent_alias_set doesn'

Re: [PATCH]Construct canonical scaled address expression in IVOPT

2013-09-24 Thread Bin.Cheng
On Tue, Sep 24, 2013 at 6:12 PM, Richard Biener wrote: > On Tue, Sep 24, 2013 at 8:20 AM, bin.cheng wrote: >> >> >>> -Original Message- > > Or even [reg*scale] (not sure about that). But yes, at least reg*scale + > offset > and reg*scale + reg. > >> Apparently it's infeasible to check

Re: gimple build interface

2013-09-24 Thread Richard Biener
On Tue, Sep 24, 2013 at 1:31 PM, Andrew MacLeod wrote: > On 09/24/2013 05:50 AM, Richard Biener wrote: >> >> Did you forget to attach the patch? >>> Of course not! :-P >>> >>> Oh how I hate mondays. >> >> Old patch attached? >> >> Richard. >> >> > Errr. no. that last one has gimple

Re: gimple build interface

2013-09-24 Thread Andrew MacLeod
On 09/24/2013 05:50 AM, Richard Biener wrote: Did you forget to attach the patch? Of course not! :-P Oh how I hate mondays. Old patch attached? Richard. Errr. no. that last one has gimple-builder.[ch] and the ssa_replace_lhs renamed to gimple_replace_ssa_lhs.. I'll also wait for

RE: [PATCH, PR 57748] Check for out of bounds access

2013-09-24 Thread Bernd Edlinger
On Tue, 24 Sep 2013 13:13:09, Richard Biener wrote: That is, do you see anything break with just removing the movmisalign path? I'd rather install that (with the new testcases that then pass) separately as this is a somewhat fragile area and being able to more selectively

Re: [PATCH, PR 57748] Check for out of bounds access

2013-09-24 Thread Richard Biener
On Tue, Sep 17, 2013 at 2:08 PM, Bernd Edlinger wrote: > On Tue, 17 Sep 2013 12:45:40, Richard Biener wrote: >> >> On Tue, Sep 17, 2013 at 12:00 PM, Richard Biener >> wrote: >>> On Sun, Sep 15, 2013 at 6:55 PM, Bernd Edlinger >>> wrote: Hello Richard, attached is my second attempt

Re: New GCC options for loop vectorization

2013-09-24 Thread Richard Biener
On Mon, Sep 23, 2013 at 10:37 PM, Xinliang David Li wrote: > Thanks. I modified the patch so that the max allowed peel iterations > can be specified via a parameter. Testing on going. Ok for trunk ? +DEFPARAM(PARAM_VECT_MAX_PEELING_FOR_ALIGNMENT, + "vect-max-peeling-for-alignment", +

Re: [PATCH, ARM, LRA] Prepare ARM build with LRA

2013-09-24 Thread Yvan Roux
Hi Eric, Thanks for the review. > +/* Return true if X is a sign_extract or zero_extract from the least > + significant bit. */ > + > +static bool > +lsb_bitfield_op_p (rtx x) > +{ > + if (GET_RTX_CLASS (GET_CODE (x)) == RTX_BITFIELD_OPS) > +{ > + enum machine_mode mode = GET_MODE(x)

Re: Ping patch to enable *.cc files in gengtype

2013-09-24 Thread Basile Starynkevitch
On Fri, Sep 20, 2013 at 05:56:22PM +0200, Jakub Jelinek wrote: > On Fri, Sep 20, 2013 at 05:52:38PM +0200, Basile Starynkevitch wrote: > > On Fri, Sep 20, 2013 at 09:53:10AM -0400, Diego Novillo wrote: > > > On 2013-09-16 04:19 , Basile Starynkevitch wrote: > > > >Hello all, > > > > > > > >I'm ping

[PATCH] Refactor type handling in get_alias_set, fix PR58513

2013-09-24 Thread Richard Biener
As noted in PR58513 the alias type comparison in operand_equal_p for MEM_REF and TARGET_MEM_REF is overly restrictive. The following adds a new alias_ptr_types_compatible_p helper for a less conservative comparison and refactors get_alias_set and reference_alias_ptr_type to share code and behave

Re: expand_expr tweaks to fix PR57134

2013-09-24 Thread Richard Biener
On Tue, Sep 24, 2013 at 12:43 PM, Alan Modra wrote: > On Fri, Sep 13, 2013 at 12:37:20PM +0930, Alan Modra wrote: >> PR middle-end/57586 >> * stmt.c (expand_asm_operands): Call expand_expr with >> EXPAND_MEMORY for output operands that disallow regs. Don't >> use EXPAND_WR

Re: [PATCH]Construct canonical scaled address expression in IVOPT

2013-09-24 Thread Richard Biener
On Tue, Sep 24, 2013 at 12:36 PM, Richard Earnshaw wrote: > On 24/09/13 11:12, Richard Biener wrote: >> Or even [reg*scale] (not sure about that). But yes, at least reg*scale + >> offset >> and reg*scale + reg. > > I can't conceive of a realistic case where one would want to scale the > base add

Re: expand_expr tweaks to fix PR57134

2013-09-24 Thread Alan Modra
On Fri, Sep 13, 2013 at 12:37:20PM +0930, Alan Modra wrote: > PR middle-end/57586 > * stmt.c (expand_asm_operands): Call expand_expr with > EXPAND_MEMORY for output operands that disallow regs. Don't > use EXPAND_WRITE on inout operands. Ping? -- Alan Modra Australia Dev

Re: [PATCH, ARM, LRA] Prepare ARM build with LRA

2013-09-24 Thread Eric Botcazou
> Here is the new patch discussed in the other thread. > > Thanks > Yvan > > 2013-09-11 Yvan Roux > Vladimir Makarov > > * rtlanal.c (lsb_bitfield_op_p): New predicate for bitfield operations > from the least significant bit. > (strip_address_mutations): Add bi

Re: [PATCH]Construct canonical scaled address expression in IVOPT

2013-09-24 Thread Richard Earnshaw
On 24/09/13 11:12, Richard Biener wrote: > Or even [reg*scale] (not sure about that). But yes, at least reg*scale + > offset > and reg*scale + reg. I can't conceive of a realistic case where one would want to scale the base address. Scaling the offset is fine, but never the base. So reg*scale+

Re: [ping][PATCH][1 of 2] Add value range info to SSA_NAME for zero sign extension elimination in RTL

2013-09-24 Thread Richard Biener
On Tue, 24 Sep 2013, Richard Biener wrote: > On Mon, Sep 23, 2013 at 10:34 PM, Eric Botcazou wrote: > >> I have committed it for you (rev 202831), with a few modifications > >> (ChangeLog formatting, typos). > >> Here is what I have committed: > >> > >> 2013-09-23 Kugan Vivekanandarajah > >> >

Re: [PATCH]Fix computation of offset in ivopt

2013-09-24 Thread Richard Biener
On Tue, Sep 24, 2013 at 11:13 AM, bin.cheng wrote: > Hi, > This patch fix two minor bugs when computing offset in IVOPT. > 1) Considering below example: > #define MAX 100 > struct tag > { > int i; > int j; > } > struct tag arr[MAX] > > int foo (int len) > { > int i = 0; > for (; i < len; i

Re: [PR58463][Backport to 4.8] Adjust dumping for ref nodes

2013-09-24 Thread Richard Biener
On Tue, Sep 24, 2013 at 10:42 AM, Paulo Matos wrote: > Ping on this patch. > > Note I don't have write access. Please get yourself write access (I suppose you do have a copyright assignment), you can name me as sponsor. Richard. > Paulo Matos > > >> -Original Message- >> From: Richard B

Re: [PATCH]Construct canonical scaled address expression in IVOPT

2013-09-24 Thread Richard Biener
On Tue, Sep 24, 2013 at 8:20 AM, bin.cheng wrote: > > >> -Original Message- >> From: Richard Biener [mailto:richard.guent...@gmail.com] >> Sent: Monday, September 23, 2013 8:08 PM >> To: Bin Cheng >> Cc: GCC Patches >> Subject: Re: [PATCH]Construct canonical scaled address expression in IV

Re: [ping][PATCH][1 of 2] Add value range info to SSA_NAME for zero sign extension elimination in RTL

2013-09-24 Thread Kugan
On 24/09/13 19:23, Richard Biener wrote: On Mon, Sep 23, 2013 at 10:34 PM, Eric Botcazou wrote: I have committed it for you (rev 202831), with a few modifications (ChangeLog formatting, typos). Here is what I have committed: 2013-09-23 Kugan Vivekanandarajah * gimple-pretty-print.c (d

Re: [PATCH, PR 57748] Check for out of bounds access, Part 2

2013-09-24 Thread Richard Biener
On Tue, Sep 24, 2013 at 4:52 AM, Bernd Edlinger wrote: > Hi, > > with the attached patch the read-side of the out of bounds accesses are fixed. > There is a single new test case pr57748-3.c that is derived from Martin's > test case. > The test case does only test the read access and does not depe

Re: [ping][PATCH][1 of 2] Add value range info to SSA_NAME for zero sign extension elimination in RTL

2013-09-24 Thread Richard Biener
On Mon, Sep 23, 2013 at 10:34 PM, Eric Botcazou wrote: >> I have committed it for you (rev 202831), with a few modifications >> (ChangeLog formatting, typos). >> Here is what I have committed: >> >> 2013-09-23 Kugan Vivekanandarajah >> >> * gimple-pretty-print.c (dump_ssaname_info): New fun

Re: gimple build interface

2013-09-24 Thread Richard Biener
On Mon, Sep 23, 2013 at 7:16 PM, Andrew MacLeod wrote: > On 09/23/2013 01:05 PM, David Malcolm wrote: >> >> On Mon, 2013-09-23 at 12:21 -0400, Andrew MacLeod wrote: >>> >>> On 09/20/2013 04:08 AM, Richard Biener wrote: On Thu, Sep 19, 2013 at 6:56 PM, Andrew MacLeod wrote: > >>

Re: RFA: Store the REG_BR_PROB probability directly as an int

2013-09-24 Thread Andreas Schwab
Richard Sandiford writes: > REG_BR_PROB notes are stored as: > > (expr_list:REG_BR_PROB (const_int ) ) > > but a full const_int rtx seems a bit heavweight when all we want is > a plain "int". This patch uses: > > (int_list:REG_BR_PROB ) > > instead. I think you left out the handling of INT

Re: Fix PR middle-end/57393

2013-09-24 Thread Jakub Jelinek
On Tue, Sep 24, 2013 at 11:26:16AM +0200, Richard Biener wrote: > + if (iters >= MAX_UNASSIGNED_UIDS || uid == 0) > +renumber_gimple_stmt_uids_in_blocks (&bb, 1); > > so this will renumber uids whenever we have trailing zero-UID stmts at the > end of a basic-block? Trailing zero-UIDs at the

  1   2   >