Il 25/09/2013 06:37, Alexandre Oliva ha scritto: > On Sep 23, 2013, Tom Tromey <tro...@redhat.com> wrote: > >> First, I believe I've addressed all of the comments in Paolo's review. > > That's my feeling as well. Sorry that I didn't manage to go through > earlier versions of the patch before; I've just reviewed v4 plus the > discussions around v3. > > Save for one detail, I'm entirely comfortable and quite happy with the > entire patchset. The detail is the removal of support for compilers > without -c -o. However, since it has long been broken and Paolo > suggested we drop it altogether, I'm going along with that plan.
Yeah, if zlib can afford not having support for that, and also considering that we're now talking of a C++ compiler without -c -o (which is probably even more rare)... than I really think we can drop that. > As far as I'm concerned, the patch is approved, but I suggest giving > Paolo a couple more days to chime in, since he reviewed the previous > version. The series is good! Thanks, Paolo
