Re: [Patch, Fortran] PR57697 - Fix an issue with defined assignment

2013-09-15 Thread Tobias Burnus
Thomas Koenig wrote: Build and regtested on x86-64-gnu-linux. OK? The patch is OK, also for 4.8. Please add a test case which also checks for the ForTrilinos failure. Thanks for the review. I have now committed the current patch as Rev. 202609. I will later try to create a test case, which

Re: [RFC] Offloading Support in libgomp

2013-09-15 Thread Jakub Jelinek
On Sun, Sep 15, 2013 at 07:41:24PM +0400, Michael V. Zolotukhin wrote: > > Libgomp will start N-1 new threads, and all of them would want to look up > > mappings for i1,i2,...iK in the splay tree. The first one wouldn't find > > anything and would map and insert all the values to the tree. But th

Re: [Patch, Fortran] PR57697 - Fix an issue with defined assignment

2013-09-15 Thread Thomas Koenig
Hi Tobias, > As testing showed, it didn't fix the real-world code: ForTrilinos's > ForTrilinos_ADT_3D_Burgers_6th_Pade did still fail as it has: > > *_F.DA65 = matrix_diff_x (&parm.621); >_F.DA66 = ax->epetra_rowmatrix.universal; // Deref of "ax"! > > Build and regtested on x86

Re: [ping][PATCH][1 of 2] Add value range info to SSA_NAME for zero sign extension elimination in RTL

2013-09-15 Thread Kugan
Hi, Updated the patch to the latest changes in trunk that splits tree.h. I also noticed an error in printing double_int and fixed it. Is this OK? Thanks, Kugan +2013-09-12 Kugan Vivekanandarajah + + * cfgexpand.c (maybe_dump_rtl_for_gimple_stmt) : Add range to dump. + * gimpl

Re: Generic lambda and implicit function template commits reverted

2013-09-15 Thread Jason Merrill
Looks good. Jason

Re: Generic lambda and implicit function template commits reverted

2013-09-15 Thread Adam Butcher
On 15.09.2013 15:45, Jason Merrill wrote: On 09/15/2013 06:22 AM, Adam Butcher wrote: [PATCH 1/5] Fix uninitialized variables causing breakage with -Werror. [PATCH 2/5] Don't accept 'auto' as the 'type' of a template parameter. OK. I've also added a case for rejecting 'auto' in a catch par

C++ PATCH for c++/41933 (variadic lambda capture)

2013-09-15 Thread Jason Merrill
This patch fixes one of the few remaining holes in GCC's C++11 support: lambda capture of a variadic function parameter pack. The implementation involves introducing the internal notion of a FIELD_DECL pack, even though such a thing can not be written explicitly in C++11. Tested x86_64-pc-lin

Re: Recent IPA regression with internal functions

2013-09-15 Thread Jan Hubicka
> 2013-09-13 Jakub Jelinek > > * ipa-prop.c (ipa_compute_jump_functions_for_edge): Return early > for internal calls. That seems resonable. I wonder if we want to consider internal calls to form callgarph edges at all: perhaps we can just modify cgraph builder+verifier to skip the

Fwd: Re: [Patch, Fortran] PR57697 - Fix an issue with defined assignment [fwd: bur...@net-b.de]

2013-09-15 Thread Tobias Burnus
Yet another try to send this email - this time from a different server. For completeness: * The original email didn't made it, nor a repost. But the mail server didn't bounce back. * For another email, only the reply made it - but not the original email: http://gcc.gnu.org/ml/fortran/2013-09/ms

Re: [Patch, Fortran] PR43366 - add invalid-diagnostic for poly assignment

2013-09-15 Thread Tobias Burnus
Now with attachment… Tobias Burnus wrote: Fortran 2008 permits assignment to polymorphic variables with some constraints. The patch, which was sitting in my tree, adds diagnostic to reject invalid use. For valid code, it runs into the existing not-yet-implemented error. Build + regtested on

RE: [PATCH, PR 57748] Check for out of bounds access

2013-09-15 Thread Bernd Edlinger
Hello Richard, attached is my second attempt at fixing PR 57748. This time the movmisalign path is completely removed and a similar bug in the read handling of misaligned structures with a non-BLKmode is fixed too. There are several new test cases for the different possible failure modes. This p

Re: [RFC] Offloading Support in libgomp

2013-09-15 Thread Michael V. Zolotukhin
> Libgomp will start N-1 new threads, and all of them would want to look up > mappings for i1,i2,...iK in the splay tree. The first one wouldn't find > anything and would map and insert all the values to the tree. But the > following > ones would look-up these addresses in the exactly same order

Re: Generic lambda and implicit function template commits reverted

2013-09-15 Thread Jason Merrill
On 09/15/2013 06:22 AM, Adam Butcher wrote: [PATCH 1/5] Fix uninitialized variables causing breakage with -Werror. [PATCH 2/5] Don't accept 'auto' as the 'type' of a template parameter. OK. [PATCH 3/5] Fix location diagnostics by returning to the deprecated 'input_location' global; m

Re: Generic lambda and implicit function template commits reverted

2013-09-15 Thread Adam Butcher
Hi Jason, Could you cast your eyes over these changes please? I intend to roll them up into the appropriate patches. I will make sure I bootstrap and "before-and-after" the g++.dg testsuite before pushing next time! [PATCH 1/5] Fix uninitialized variables causing breakage with -Werror. Not

[Patch, Fortran] PR58356 - fix ICE with finalizer in type extension

2013-09-15 Thread Tobias Burnus
A rather obvious patch. Build and regtested on x86-64-gnu-linux. OK for the trunk? Tobias 2013-09-15 Tobias Burnus PR fortran/58356 * class.c (generate_finalization_wrapper): Init proc_tree if not yet resolved. 2013-09-15 Tobias Burnus PR fortran/58356 * gfortran.dg/finalize_19.f90

Re: [PATCH 2/6] Andes nds32: machine description of nds32 porting (3).

2013-09-15 Thread Richard Sandiford
Some comments about the final part: Chung-Ju Wu writes: > +(define_constraint "Ibms" > + "The immediate value with power of 2" > + (and (match_code "const_int") > + (match_test "(TARGET_ISA_V3 || TARGET_ISA_V3M) > + && (floor_log2 (ival) < 8) > + && (ival >

Re: [Patch, Fortran] PR57697 - Fix an issue with defined assignment

2013-09-15 Thread Thomas Koenig
Hi Tobias, the patch is OK, also for 4.8. Thanks a lot for fixing this. Just a couple of nits: - You may want to remove the output from the test case. - The two consecutive ifs in > > if (left != 0B) > { > if (_F.DA0 != 0B) goto L.2; > _F.DA0 = (struct paren

Re: [RFC] Offloading Support in libgomp

2013-09-15 Thread Michael V. Zolotukhin
Hi Jakub, This patch looks ok for me in general, but I am a bit worried about using splay-trees. Couldn't we end up with their worst case linear performance instead desired log? Imagine the following scenario: #pragma parallel ... // to produce N-threads { # pragma target map (i1, i2, ...i

Re: [v3] More noexcept for vectors

2013-09-15 Thread Marc Glisse
I had to separate the constructor that takes an allocator from the default constructor in debug/profile, since in release the noexcept only applies to one of them (and the testsuite asserts that release and debug agree on this). An alternative would be to make the release vector default constru