Re: [Patch x86/darwin] fix PR51784 'PIC register not correctly preserved...'

2013-07-17 Thread Uros Bizjak
Hello! > The PR is logged against Darwin, and (as Jakub points out in the PR thread) > indeed Darwin is > missing a nonlocal_goto_receiver to restore the PIC reg in code that uses it > (most of the patch). > > However, there is a second issue, and (if I've understood things correctly) > this af

Re: [PATCH] Rename callback in ipa-pure-const.c

2013-07-17 Thread David Malcolm
On Thu, 2013-07-18 at 03:34 +0200, Jakub Jelinek wrote: > On Wed, Jul 17, 2013 at 09:32:29PM -0400, David Malcolm wrote: > > * ipa-pure-const.c (generate_summary): Rename to... > > (pure_const_generate_summary): ... this. > > Ok, thanks. Thanks; committed to svn trunk as r

Re: [Patch x86/darwin] fix PR51784 'PIC register not correctly preserved...'

2013-07-17 Thread Mike Stump
On Jul 17, 2013, at 5:23 PM, Iain Sandoe wrote: > The PR is logged against Darwin, and (as Jakub points out in the PR thread) > indeed Darwin is missing a nonlocal_goto_receiver to restore the PIC reg in > code that uses it (most of the patch). Darwin bits, Ok. Thanks. > However, there is a s

Re: [Patch, Fortran] PR35862 - add input I/O rounding support - by setting the CPU rounding mode

2013-07-17 Thread David Edelsohn
On Wed, Jul 17, 2013 at 5:02 AM, Tobias Burnus wrote: > As there is again a CPU dependence: > - David, can you have a look at config/fpu-aix.h? > Build and regtested on x86-64-gnu-linux. > OK for the trunk? The AIX part of the patch looks okay to me. Thanks, David

Re: [testsuite] fix powerpc alignment tests for eabi

2013-07-17 Thread David Edelsohn
On Mon, Jul 8, 2013 at 3:47 PM, Janis Johnson wrote: > Tests gcc.target/powerpc/20020118-1.c and > gcc.c-torture/execute/nest-align-1.c sometimes fail because they expect > a stack alignment that is greater than that required for powerpc-eabi. > This patch forces stack alignment to 128 bits by pas

Re: [PATCH] Rename callback in ipa-pure-const.c

2013-07-17 Thread Jakub Jelinek
On Wed, Jul 17, 2013 at 09:32:29PM -0400, David Malcolm wrote: > * ipa-pure-const.c (generate_summary): Rename to... > (pure_const_generate_summary): ... this. Ok, thanks. > diff --git a/gcc/ipa-pure-const.c b/gcc/ipa-pure-const.c > index 9705db1..542d33a 100644 > --- a/gcc/ipa-pure-c

[PATCH] Rename callback in ipa-pure-const.c

2013-07-17 Thread David Malcolm
The following trivial patch renames pass_ipa_pure_const's generate_summary callback to something other than "generate_summary", since this causes trouble in a patch I'm working on that converts passes to C++ classes (the constructor gets confused in the member initializer for generate_summary, and

[PATCH 0/4] Move pass-creation logic into a passes.def file

2013-07-17 Thread David Malcolm
The following patch series moves the logic for creating the pipeline of optimization passes out from passes.c and into a new passes.def file (patches 1 and 2). It then explicitly numbers those passes that have multiple instances, by using a NEXT_PASS_NUM macro in place of NEXT_PASS (patch 3) The

[PATCH 3/4] Introduce NEXT_PASS_NUM macro

2013-07-17 Thread David Malcolm
gcc/ Explicitly number the instances of passes within passes.def. This is needed by a subsequent patch so that we can create fields within the pipeline class for each pass instance (to help locate pass instances when debugging). * passes.c (NEXT_PASS_NUM):

[PATCH 2/4] Move the construction of the pass hierarchy into a new passes.def file.

2013-07-17 Thread David Malcolm
gcc/ * passes.def: New. * passes.c (init_optimization_passes): Move the construction of the pass hierarchy into a new passes.def file. * Makefile.in (passes.o): Add dependency on passes.def. --- gcc/Makefile.in | 2 +- gcc/passes.c| 378 +

[PATCH 1/4] Introduce macros when constructing the tree of passes

2013-07-17 Thread David Malcolm
gcc/ * passes.c (init_optimization_passes): Introduce macros for constructing the tree of passes (INSERT_PASSES_AFTER, PUSH_INSERT_PASSES_WITHIN, POP_INSERT_PASSES, TERMINATE_PASS_LIST). --- gcc/passes.c | 108 +++-

[PATCH 4/4] Add contrib/check_passes.py script

2013-07-17 Thread David Malcolm
contrib/ * check_passes.py: New. --- contrib/check_passes.py | 58 + 1 file changed, 58 insertions(+) create mode 100644 contrib/check_passes.py diff --git a/contrib/check_passes.py b/contrib/check_passes.py new file mode 100755 index

[Patch x86/darwin] fix PR51784 'PIC register not correctly preserved...'

2013-07-17 Thread Iain Sandoe
Hi, The PR is logged against Darwin, and (as Jakub points out in the PR thread) indeed Darwin is missing a nonlocal_goto_receiver to restore the PIC reg in code that uses it (most of the patch). However, there is a second issue, and (if I've understood things correctly) this affects GOT target

Fix yet another partitioning bug

2013-07-17 Thread Jan Hubicka
Hi, Martin's local patch triggered latent bug in lto-partition.c where we forget to revert back to old varpool_pos when we undo some partitioning decisions. Will commit it after testing on x86_64-linux. Honza * lto-partition.c (lto_balanced_map): Fix -fno-toplevel-reorder partit

RE: RFA: Fix rtl-optimization/57425 (SPEC perl problem on MIPS)

2013-07-17 Thread Steve Ellcey
Joern, I created a smaller test case for this problem and have submitted a GCC bugzilla report (57921). After looking at it I am not sure if the bug is in GCC or if it is a bug in the perl source code. Steve Ellcey sell...@mips.com From: Steve Ellcey [s

Re: [ARM][Insn classification refactoring 4/N] Cleanup "insn" attribute

2013-07-17 Thread Ramana Radhakrishnan
On Tue, Jul 16, 2013 at 2:15 PM, Sofiane Naci wrote: > Hi, > > This patch is the part of the ongoing work of ARM instruction classification > cleanup. > > This patch deletes redundant values "mrs", "msr", "xtab" and "sat" from the > "insn" attribute, and moves the "clz" value to the "type" attribu

Re: [GOOGLE] Remove unnecessary functions in AutoFDO

2013-07-17 Thread Xinliang David Li
ok. David On Wed, Jul 17, 2013 at 2:25 PM, Dehao Chen wrote: > This patch removes unnecessary functions in AutoFDO. > > Bootstrapped and passed regression/benchmark tests. > > OK for google-4_8 branch? > > Thanks, > Dehao

[GOOGLE] Remove unnecessary functions in AutoFDO

2013-07-17 Thread Dehao Chen
This patch removes unnecessary functions in AutoFDO. Bootstrapped and passed regression/benchmark tests. OK for google-4_8 branch? Thanks, Dehao Index: gcc/auto-profile.c === --- gcc/auto-profile.c (revision 200957) +++ gcc/auto-pr

Re: [PATCH] Add a new option "-ftree-bitfield-merge" (patch / doc inside)

2013-07-17 Thread Andrew Pinski
On Wed, Jul 17, 2013 at 1:38 PM, Zoran Jovanovic wrote: > Hello, > This patch adds new optimization pass that combines several adjacent bit > field accesses that copy values from one memory location to another into > single bit field access. > > Example: > > Original code: >D.1351; >D.13

Re: PATCH (c,c++) for c++/57793

2013-07-17 Thread Jason Merrill
On 07/17/2013 04:50 AM, Kyrylo Tkachov wrote: With this patch we now get PASS->FAIL: gcc.dg/pr42611.c, because the error message now appears on the line of the definition of the struct. This patch fixes the testcase. Ok to apply to trunk? Please. Jason

Re: [PATCH] Add a new option "-ftree-bitfield-merge" (patch / doc inside)

2013-07-17 Thread Joseph S. Myers
On Wed, 17 Jul 2013, Zoran Jovanovic wrote: > This patch adds new optimization pass that combines several adjacent bit > field accesses that copy values from one memory location to another into > single bit field access. Could you clarify if this works correctly in the presence of unions? That

Re: Preserve label alignment info through dbr

2013-07-17 Thread Jeff Law
On 07/10/2013 03:37 AM, Eric Botcazou wrote: Hi, I was a little surprised to find out that dbr can silently drop the alignment information for labels computed when the CFG is valid (in compute_alignments). The pessimization can be significant for loops when the top label needs to be overaligned,

Re: MIPS elimate trap-if-zero instruction if possible for divisions

2013-07-17 Thread Jeff Law
On 07/10/2013 09:38 AM, Graham Stott wrote: Hi Jeff, Richard, Not sure if that working. I created some rtl using TRAP_IF to represent the TEQ and emiited via an expander The TRAP_IF rtl make ait all the way though the rtl optimizers which are run after expand even though it should be possibl

[PATCH] Add a new option "-ftree-bitfield-merge" (patch / doc inside)

2013-07-17 Thread Zoran Jovanovic
Hello, This patch adds new optimization pass that combines several adjacent bit field accesses that copy values from one memory location to another into single bit field access. Example: Original code:   D.1351;   D.1350;   D.1349;   D.1349_2 = p1_1(D)->f1;   p2_3(D)->f1 = D.1349_2;   D.1350

Re: cfgexpand.c patch for msp430-elf

2013-07-17 Thread Mike Stump
On Jul 17, 2013, at 12:56 PM, Jeff Law wrote: > Sorry, I must have missed this as being a partial integer issue. > > The partial integer modes have the same size/precision as their normal sized > cousins in terms of GCC's representation. In our compiler, we push forward the precision from the t

msp430 port

2013-07-17 Thread Jeff Law
Might as well clarify copyright status on *all* the msp430 files in libgcc. While one might claim some are so trivially small and thus not suitable for copyright protection, I'd rather not rely on that for anything in libgcc since those bits get included into user code and lawyers look at them

Re: cfgexpand.c patch for msp430-elf

2013-07-17 Thread Jeff Law
Sorry, I must have missed this as being a partial integer issue. The partial integer modes have the same size/precision as their normal sized cousins in terms of GCC's representation. However, they also have a target dependent implicit precision which is not exposed to GCC. PSI modes have al

Re: Group static constructors and destructors in specific subsections

2013-07-17 Thread Cary Coutant
>> > Yep, the problem is where to produce the section ordering file. >> > The scheme is as follows: >> > - with -fprofile-generate instrument every function entry point and >> > record >> > time of first and last invocation of the functoin >> > - At compile time we take functions that are

Re: [PATCH] MIPS: IEEE 754-2008 features support

2013-07-17 Thread Richard Sandiford
"Maciej W. Rozycki" writes: >> The patch mostly looks good apart from that, but please use a single >> enum for the 2008/legacy thing, both in mips.h and mips.opt. > > Also mips.c and mips.md (and last but not least mips-opts.h). Done. I wasn't trying to list all the places that use the C enum.

Re: [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power

2013-07-17 Thread Mike Stump
On Jul 17, 2013, at 7:40 AM, Iain Sandoe wrote: > This series broke bootstrap on powerpc-apple-darwin9. > fixed as below, committed as obvious as r201011. Thanks.

Re: [Patch, PR 57810] Wasted work in validate_const_int()

2013-07-17 Thread Jeff Law
On 07/17/2013 10:41 AM, pcha...@cs.wisc.edu wrote: Hi, The problem appears in revision 200945 in version 4.9. I attached a one-line patch that fixes it. I also reported this problem at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57810 . In method "validate_const_int()" in "gcc/read-rtl.c", th

[Patch, PR 57810] Wasted work in validate_const_int()

2013-07-17 Thread pchang9
Hi, The problem appears in revision 200945 in version 4.9. I attached a one-line patch that fixes it. I also reported this problem at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57810 . In method "validate_const_int()" in "gcc/read-rtl.c", the loop on line 804 should break immediately after "va

[Patch, PR 57805] Wasted work in write_roots()

2013-07-17 Thread pchang9
Hi, The problem appears in revision 200945 in version 4.9. I attached a one-line patch that fixes it. I also reported this problem at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57805. In method "write_roots()" in gcc/gengtype.c, the loop on line 4682 should break immediately after "skip_p" is

Re: [PATCH, i386, PR57623] Introduce synonyms for BMI intrinsics

2013-07-17 Thread Jakub Jelinek
On Wed, Jul 17, 2013 at 07:39:00PM +0400, Kirill Yukhin wrote: > Is it ok to install? Yes. Jakub

Re: [PATCH] MIPS: IEEE 754-2008 features support

2013-07-17 Thread Joseph S. Myers
On Wed, 17 Jul 2013, Maciej W. Rozycki wrote: > > I was a bit surprised that a change to the NaN format requires a change > > to the dynamic linker, but I suppose that's the consequence of forcing > > every ELF object to fall on one side of the fence? > > Yes, the dynamic linker has to enforce N

Re: [PATCH, i386, PR57623] Introduce synonyms for BMI intrinsics

2013-07-17 Thread Kirill Yukhin
On 7/3/2013 10:29 AM, Jakub Jelinek wrote: > On Wed, Jul 03, 2013 at 08:14:25AM +0200, Uros Bizjak wrote: >> On Tue, Jul 2, 2013 at 10:32 AM, Kirill Yukhin >> wrote: >> BTW: Do we want to backport this patch (and your previous) to 4.8 branch? > I'd say yes to both. Hello, I've backported both pat

Re: [PATCH, rs6000, libitm] Enable Hardware Transactional Memory (HTM) support on Power

2013-07-17 Thread Iain Sandoe
Hi, On 16 Jul 2013, at 22:07, Peter Bergner wrote: > On Tue, 2013-07-16 at 15:31 -0400, David Edelsohn wrote: >> On Tue, Jul 16, 2013 at 3:27 PM, Peter Bergner wrote: >>> On Tue, 2013-07-16 at 11:55 -0500, Peter Bergner wrote: * config/rs6000/rs6000.h (FIRST_PSEUDO_REGISTERS): Mention

[ping] Re: [PATCH] Fix documentation for x86 __builtin_ia32_cmp*s

2013-07-17 Thread Cameron McInally
Ping. On Fri, Jun 14, 2013 at 1:41 PM, Cameron McInally wrote: > Hey guys, > > The documentation states that the return types on the x86 > __builtin_ia32_cmp*s builtins are integer vectors. This is > inconsistent with the source. These builtins actually return floating > point vectors. Here is a

[ping] Re: [PATCH] Remove old x86 builtins from documentation

2013-07-17 Thread Cameron McInally
Ping. I do realize that patches of this nature are of low priority, but I would really like to see it committed to save my users from tripping over the docs. Thanks again, Cameron On Thu, Jun 13, 2013 at 9:58 PM, Cameron McInally wrote: > Hey guys, > > I'm a first time patch submitter, please b

Re: [PATCH] S/390: Hardware transactional memory support

2013-07-17 Thread Andreas Krebbel
On Tue, Jul 16, 2013 at 07:39:28PM +0200, Jakub Jelinek wrote: > Looks good to me from quick skimming. Ok. I've applied the following patch after successful testing. Bye, -Andreas- 2013-07-17 Andreas Krebbel * config/s390/s390.c: (s390_expand_builtin): Allow -mhtm to be enab

Re: [Patch, Fortran] PR57895 - avoid segfault and improve diagnostic

2013-07-17 Thread Mikael Morin
Le 17/07/2013 12:36, Tobias Burnus a écrit : > Without this patch, GCC 4.3 and later segfault. As Mikael wrote: > "gfc_restore_last_undo_checkpoint seems to take care of the cleanup, so > we don't need to do it in gfc_match_common." > > Additionally, this patch ensures that the error message about

Re: [ARM][Insn classification refactoring 5/N] Tidy alu/shift instruction classification types

2013-07-17 Thread Ramana Radhakrishnan
OK for trunk? This is OK. Ramana

Re: [Patch] Partially implement regex_search

2013-07-17 Thread Jonathan Wakely
On 17 July 2013 11:26, Tim Shen wrote: > A simple enumerating-first-position approach. Thanks for the new patch. A couple of quick comments before I review it properly: The changelog has a typo, _M__search_from_first has two underscores. The testcase dg-options should use -std=gnu++11 not -std=

[Patch, Fortran] PR57895 - avoid segfault and improve diagnostic

2013-07-17 Thread Tobias Burnus
Without this patch, GCC 4.3 and later segfault. As Mikael wrote: "gfc_restore_last_undo_checkpoint seems to take care of the cleanup, so we don't need to do it in gfc_match_common." Additionally, this patch ensures that the error message about the "$" gets printed - without the change, it does

[Patch] Partially implement regex_search

2013-07-17 Thread Tim Shen
A simple enumerating-first-position approach. -- Tim Shen regex_search.patch Description: Binary data

Re: [PATCH] MIPS: IEEE 754-2008 features support

2013-07-17 Thread Maciej W. Rozycki
On Tue, 16 Jul 2013, Richard Sandiford wrote: > > The run-time selection options are -mnan=2008 and -mnan=legacy for the > > 2008 NaN and the legacy NaN mode respectively. The binary patterns of NaN > > data produced by compiler builtins or otherwise is adjusted accordingly, > > as is a `.nan

Re: [Patch, Fortran] PR35862 - add input I/O rounding support - by setting the CPU rounding mode

2013-07-17 Thread Uros Bizjak
On Wed, Jul 17, 2013 at 11:02 AM, Tobias Burnus wrote: > As there is again a CPU dependence: > - David, can you have a look at config/fpu-aix.h? > - Eric and Gerald, can you have a look at config/fpu-sysv.h? > - Uros, can you have a look at config/fpu-387.h? Please use attached (untested for fort

[Patch, Fortran] PR35862 - add input I/O rounding support - by setting the CPU rounding mode

2013-07-17 Thread Tobias Burnus
As there is again a CPU dependence: - David, can you have a look at config/fpu-aix.h? - Eric and Gerald, can you have a look at config/fpu-sysv.h? - Uros, can you have a look at config/fpu-387.h? All: Does on any of the systems exists a rounding mode like nearest - but with rounding away from 0

Re: Go patch committed: Update libgo to 1.1.1

2013-07-17 Thread Uros Bizjak
On Wed, Jul 17, 2013 at 8:46 AM, Uros Bizjak wrote: > On Tue, Jul 16, 2013 at 5:45 PM, Ian Lance Taylor wrote: >> On Tue, Jul 16, 2013 at 6:07 AM, Uros Bizjak wrote: >>> I have committed a large patch to update libgo to the library that was part of the Go 1.1.1 release. As usual, I'm

Re: [PATCH] [ARM] Fix PR57909 : ICE with internal memcpy and -mno-unaligned-access

2013-07-17 Thread Ramana Radhakrishnan
On 07/17/13 09:53, Yvan Roux wrote: Hi, this patch fixes the issue described in PR57909, where we have an ICE during the internal memcpy, as some UNSPEC_UNALIGNED insns are emitted even if -mno-unaligned-access flag is passed. See the link below for a more detailled description: http://gcc.gnu.

[PATCH] [ARM] Fix PR57909 : ICE with internal memcpy and -mno-unaligned-access

2013-07-17 Thread Yvan Roux
Hi, this patch fixes the issue described in PR57909, where we have an ICE during the internal memcpy, as some UNSPEC_UNALIGNED insns are emitted even if -mno-unaligned-access flag is passed. See the link below for a more detailled description: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57909 Te

RE: PATCH (c,c++) for c++/57793

2013-07-17 Thread Kyrylo Tkachov
Hi Jason, > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Jason Merrill > Sent: 14 July 2013 00:00 > To: Joseph S. Myers > Cc: Eric Botcazou; gcc-patches@gcc.gnu.org; Richard Biener > Subject: PATCH (c,c++) for c++/57793 > > On 07/10/2013 01:24 AM, Eri