On Mon, Jul 8, 2013 at 3:47 PM, Janis Johnson <janis_john...@mentor.com> wrote: > Tests gcc.target/powerpc/20020118-1.c and > gcc.c-torture/execute/nest-align-1.c sometimes fail because they expect > a stack alignment that is greater than that required for powerpc-eabi. > This patch forces stack alignment to 128 bits by passing "-mno-eabi". > > Is this OK for mainline and the 4.8 branch, or would it be better to > skip these tests for powerpc-*-eabi*?
Both of the tests specifically are checking support for alignment, so passing -mno-eabi for powerpc-eabi seems to defeat the purpose. I would skip the 20020118-1.c test. It seems that nest-align-1.c should not fail, even with powerpc-eabi, so I think the testcase really is pointing to a problem. Thanks, David