Re: RFC: LRA for x86/x86-64 [0/9]

2012-10-04 Thread Vladimir Makarov
On 12-10-04 4:56 PM, Steven Bosscher wrote: On Tue, Oct 2, 2012 at 3:14 AM, Vladimir Makarov wrote: Analogous live ranges are used in IRA as intermidiate step to build a conflict graph. Right, ira-lives.c and lra-lives.c look very much alike, the only major difference is that the object of

[PATCH] PR 54789: Fix driver error when GCC_COMPARE_DEBUG is defined

2012-10-04 Thread Dmitry Gorbachev
This patch simplifies process_command a bit by using save_switch and sets the "known" switch field to "true". gcc/ChangeLog: 2012-10-05 Dmitry Gorbachev PR driver/54789 * gcc.c (process_command): Use save_switch for synthesized -fcompare-debug=* option; mark the switc

Re: PING^2: [patch] pr/54508: fix incomplete debug information for class

2012-10-04 Thread Paul_Koning
On Oct 4, 2012, at 8:26 PM, Cary Coutant wrote: >> Index: gcc/testsuite/g++.dg/debug/dwarf2/localclass1.C >> === >> --- gcc/testsuite/g++.dg/debug/dwarf2/localclass1.C (revision 192048) >> +++ gcc/testsuite/g++.dg/debug/dwarf2/lo

Re: PING^2: [patch] pr/54508: fix incomplete debug information for class

2012-10-04 Thread Paul_Koning
On Oct 4, 2012, at 8:26 PM, Cary Coutant wrote: >> Index: gcc/testsuite/g++.dg/debug/dwarf2/localclass1.C >> === >> --- gcc/testsuite/g++.dg/debug/dwarf2/localclass1.C (revision 192048) >> +++ gcc/testsuite/g++.dg/debug/dwarf2/lo

Re: PING^2: [patch] pr/54508: fix incomplete debug information for class

2012-10-04 Thread Cary Coutant
> Index: gcc/testsuite/g++.dg/debug/dwarf2/localclass1.C > === > --- gcc/testsuite/g++.dg/debug/dwarf2/localclass1.C (revision 192048) > +++ gcc/testsuite/g++.dg/debug/dwarf2/localclass1.C (working copy) > @@ -59,11 +59,11 @@ >

Re: [PATCH, gdc] - Merging gdc (GNU D Compiler) into gcc

2012-10-04 Thread Joseph S. Myers
On Thu, 4 Oct 2012, Iain Buclaw wrote: > The only patches to gcc proper are documentation-related and adding > the D frontend / libphobos to configure and make files. I would have > thought that these would typically only be included with the actual > front-end? Looking back at my previous revie

RE: [Ping]FW: [PATCH] Cilk Plus merging to trunk (2 of n)

2012-10-04 Thread Iyer, Balaji V
Hello Joseph, Please see my responses below: >-Original Message- >From: Joseph Myers [mailto:jos...@codesourcery.com] >Sent: Thursday, October 04, 2012 7:45 PM >To: Iyer, Balaji V >Cc: gcc-patches@gcc.gnu.org >Subject: Re: [Ping]FW: [PATCH] Cilk Plus merging to trunk (2 of n) > >On Thu,

Re: [PATCH, gdc] - Merging gdc (GNU D Compiler) into gcc

2012-10-04 Thread Joseph S. Myers
On Thu, 4 Oct 2012, Iain Buclaw wrote: > I would like to get a bump on this. > > It's been a while, and there have been quite a number of changes since > the initial post that address many of the issues raised. Rather than > reposting patches, someone mentioned attaching changelog, well, here >

Re: [SH] PR 54760 - Add thread pointer built-ins and GBR displacement addressing

2012-10-04 Thread Oleg Endo
On Thu, 2012-10-04 at 11:52 +0900, Kaz Kojima wrote: > sh4-unknown-linux-gnu build failed during compiling libmudflap: > > /exp/ldroot/dodes/xsh-gcc/./gcc/xgcc -B/exp/ldroot/dodes/xsh-gcc/./gcc/ > -B/usr/local/sh4-unknown-linux-gnu/bin/ > -B/usr/local/sh4-unknown-linux-gnu/lib/ -isystem > /usr

[C++ testcase] PR 52233

2012-10-04 Thread Paolo Carlini
Hi, I'm adding the testcase and closing the PR. Tested x86_64-linux. Thanks, Paolo. 2012-10-04 Paolo Carlini PR c++/52233 * g++.dg/cpp0x/alias-decl-23.C: New. Index: g++.dg/cpp0x/alias-decl-23.C ===

Re: [Ping]FW: [PATCH] Cilk Plus merging to trunk (2 of n)

2012-10-04 Thread Joseph S. Myers
On Thu, 4 Oct 2012, Iyer, Balaji V wrote: > Did you get a chance to look at this submission? I think I have > fixed all the changes you have mentioned. Is it OK for trunk? I expect to look at the revised specification and patch later this month. My initial impression from a glance at the

[C++ testcase] PR 53403

2012-10-04 Thread Paolo Carlini
Hi, I'm adding the testcase and closing the PR. Tested x86_64-linux. Thanks, Paolo. / 2012-10-04 Paolo Carlini PR c++/53403 * g++.dg/template/friend53.C Index: g++.dg/template/friend53.C

Re: patch to fix

2012-10-04 Thread Kenneth Zadeck
There are a bunch of ways to skin the cat. 1) we can define the extra mode. 2) if we get rid of the mode inside the wide int and replace it with an explicit precision and bitsize, then we can just make the size of the buffer twice as big as the analysis of the modes indicates. 3) or we can leav

[wwwdocs] SH 4.8 changes update

2012-10-04 Thread Oleg Endo
Hello, The atomic options of SH have been changed recently. The attached patch updates the 4.8 changes.html accordingly, plus some minor wording fixes. OK? Cheers, Oleg ? www_4_8_sh_changes_2.patch Index: htdocs/gcc-4.8/changes.html ==

Re: [libbacktrace] Fix warning as error in btest.c and hence `make test`

2012-10-04 Thread Gerald Pfeifer
On Thu, 4 Oct 2012, Ian Lance Taylor wrote: >> cc1: warnings being treated as errors >> /scratch/tmp/gerald/gcc-HEAD/libbacktrace/btest.c: In function 'f23': >> /scratch/tmp/gerald/gcc-HEAD/libbacktrace/btest.c:476: warning: 'expected' >> may be used uninitialized in this function >> gmake[3]: ***

Re: [PATCH] PR 53528 c++/ C++11 Generalized Attribute support

2012-10-04 Thread Jason Merrill
On 09/20/2012 02:59 AM, Dodji Seketeli wrote: + if ((flags & ATTR_FLAG_CXX11) + && !(flags & ATTR_FLAG_TYPE_IN_PLACE + && (TREE_CODE (*node) == RECORD_TYPE + || TREE_CODE (*node) == UNION_TYPE))) + { + /* unused is being used as a c++11 att

Re: PING^2: [patch] pr/54508: fix incomplete debug information for class

2012-10-04 Thread Paul_Koning
Updated patch: there were two existing testcases that needed to be adjusted because of this fix. Ran check RUNTESTFLAGS=dwarf2.exp, no regressions. paul ChangeLog: 2012-10-04 Paul Koning * dwarf2out.c (prune_unused_types_mark): Mark all of parent's children if paren

Re: patch to fix

2012-10-04 Thread Marc Glisse
On Wed, 3 Oct 2012, Kenneth Zadeck wrote: i have already converted the vrp code, so i have some guess at where you are talking about. (of course correct me if i am wrong). in the code that computes the range when two variables are multiplied together needs to do a multiplication that produce

Re: [Fortran, (RFC) patch] PR49110/51055 Assignment to alloc. deferred-length character vars

2012-10-04 Thread Janus Weil
Hi all, >>> Btw, note that we are using a double underscore scheme in other places >>> (like __class, __vtab, __vtype, etc). I have even used an '@' in one >>> place, namely (hidden) procedure pointer results ("ppr@"). Is there a >>> need to unify all those cases? >> >> >> It think it would be use

[BZ 50356] Obvious bugfix in h8300 bits

2012-10-04 Thread Jeff Law
This is a pretty obvious typo/thinko. Interestingly enough, fixing it makes absolutely no difference in the generated code for newlib ;-) One could make an argument it should just be zapped, but I'm not going to open that can of worms today. Obviously I tested this by building newlib before

Re: RFC: LRA for x86/x86-64 [0/9]

2012-10-04 Thread Steven Bosscher
On Tue, Oct 2, 2012 at 3:14 AM, Vladimir Makarov wrote: > Analogous live ranges are used in IRA as intermidiate step to build a > conflict graph. Right, ira-lives.c and lra-lives.c look very much alike, the only major difference is that the object of interest in an IRA live range is an ira_obje

Re: Propagate profile counts during switch expansion

2012-10-04 Thread Easwaran Raman
Hi Honza, I am addressing some of the questions you raise here. Will send an updated patch later. On Thu, Oct 4, 2012 at 6:19 AM, Jan Hubicka wrote: > > @@ -560,7 +577,6 @@ compute_outgoing_frequencies (basic_block b) > >return; > > } > > } > > - > >if (single_succ_p (b)) > >

[PATCH] gcc-{ar,nm,ranlib}: Find binutils binaries relative to self

2012-10-04 Thread Meador Inge
Hi All, Currently the gcc-{ar,nm,ranlib} utilities assume that binutils is in path when invoking the wrapped binutils program. This goes against the accepted practice in GCC to find sub-programs relative to where the GCC binaries are stored and to not make assumptions about the PATH. This patch

Re: [libbacktrace] Fix warning as error in btest.c and hence `make test`

2012-10-04 Thread Ian Lance Taylor
On Thu, Oct 4, 2012 at 12:03 PM, Gerald Pfeifer wrote: > Running `make test` on my nightly testers I noticed the following > in the log files: > > cc1: warnings being treated as errors > /scratch/tmp/gerald/gcc-HEAD/libbacktrace/btest.c: In function 'f23': > /scratch/tmp/gerald/gcc-HEAD/libbacktra

Re: PING^2: [patch] pr/54508: fix incomplete debug information for class

2012-10-04 Thread Paul_Koning
On Oct 4, 2012, at 12:09 PM, wrote: > Ping ^ 2... > > -- > > If the only reference in a source file is to a static method of a class, then > GCC would output debug information for the class name but not any of its > members or base classes. The attached patch fixes this by having > "

Re: PING^2: [patch] pr/54508: fix incomplete debug information for class

2012-10-04 Thread Paul_Koning
On Oct 4, 2012, at 2:58 PM, Jakub Jelinek wrote: > On Thu, Oct 04, 2012 at 06:32:20PM +, paul_kon...@dell.com wrote: >> --- testsuite/g++.dg/debug/dwarf2/pr54508.C (revision 0) >> +++ testsuite/g++.dg/debug/dwarf2/pr54508.C (revision 0) >> @@ -0,0 +1,67 @@ >> +// PR debug/54508 >> +// { dg-

Re: patch to fix constant math

2012-10-04 Thread Richard Sandiford
Kenneth Zadeck writes: > On 10/04/2012 12:58 PM, Richard Guenther wrote: >> On Thu, Oct 4, 2012 at 3:55 PM, Kenneth Zadeck >> wrote: >>> Let me talk about the mode here first. >>> >>> What this interface/patch provides is a facility where the constant math >>> that is done in optimizations is do

Re: [patch][lra] Improve initial program point density in lra-lives.c

2012-10-04 Thread Vladimir Makarov
On 10/04/2012 01:44 PM, Vladimir Makarov wrote: On 10/04/2012 12:56 PM, Steven Bosscher wrote: On Thu, Oct 4, 2012 at 6:12 PM, Vladimir Makarov wrote: so that I get the timings in the -ftime-report like so: CPROP : 43.14 ( 4%) usr integrated RA : 200.81 (17%)

[libbacktrace] Fix warning as error in btest.c and hence `make test`

2012-10-04 Thread Gerald Pfeifer
Running `make test` on my nightly testers I noticed the following in the log files: cc1: warnings being treated as errors /scratch/tmp/gerald/gcc-HEAD/libbacktrace/btest.c: In function 'f23': /scratch/tmp/gerald/gcc-HEAD/libbacktrace/btest.c:476: warning: 'expected' may be used uninitialized in t

Re: PING^2: [patch] pr/54508: fix incomplete debug information for class

2012-10-04 Thread Jakub Jelinek
On Thu, Oct 04, 2012 at 06:32:20PM +, paul_kon...@dell.com wrote: > --- testsuite/g++.dg/debug/dwarf2/pr54508.C (revision 0) > +++ testsuite/g++.dg/debug/dwarf2/pr54508.C (revision 0) > @@ -0,0 +1,67 @@ > +// PR debug/54508 > +// { dg-do compile } > +// { dg-options "-g2 -dA" } Better than

Re: RFC: LRA for x86/x86-64 [0/9]

2012-10-04 Thread Steven Bosscher
On Sat, Sep 29, 2012 at 10:26 PM, Steven Bosscher wrote: > To put it in another perspective, here are my timings of trunk vs lra > (both checkouts done today): > > trunk: > integrated RA : 181.68 (24%) usr 1.68 (11%) sys 183.43 > (24%) wall 643564 kB (20%) ggc > reload

Re: PING^2: [patch] pr/54508: fix incomplete debug information for class

2012-10-04 Thread Paul_Koning
On Oct 4, 2012, at 1:38 PM, Cary Coutant wrote: >> /* We also have to mark its parents as used. >> -(But we don't want to mark our parents' kids due to this.) */ >> +(But we don't want to mark our parent's kids due to this, >> +unless it is a class.) */ >> if (

Re: PATCH trunk: gengtype honoring mark_hook-s inside struct inside union-s

2012-10-04 Thread Basile Starynkevitch
On Wed, Oct 03, 2012 at 01:02:44PM +0200, Basile Starynkevitch wrote: > So I applied and I am proposing the following patch to gcc trunk 192031 > (Laurynas, I did take your remarks into account) > # patch to trunk > Index: gcc/gengtype.c > ===

Re: Use conditional casting with symtab_node

2012-10-04 Thread Diego Novillo
On Thu, Oct 4, 2012 at 2:14 PM, Lawrence Crowl wrote: > So, Jan Hubicka requested and approved the current spelling. > What now? I don't think we should hold this up. The names Jan requested seem reasonable enough. We seem to be running in circles here. Diego.

Re: patch to fix constant math

2012-10-04 Thread Kenneth Zadeck
On 10/04/2012 12:58 PM, Richard Guenther wrote: On Thu, Oct 4, 2012 at 3:55 PM, Kenneth Zadeck wrote: Let me talk about the mode here first. What this interface/patch provides is a facility where the constant math that is done in optimizations is done exactly the way that it would be done on t

Re: Convert more non-GTY htab_t to hash_table.

2012-10-04 Thread Lawrence Crowl
On 10/4/12, Richard Guenther wrote: > On Tue, 2 Oct 2012, Lawrence Crowl wrote: >> On 10/2/12, Richard Guenther wrote: >> > On Mon, 1 Oct 2012, Lawrence Crowl wrote: >> > > Change more non-GTY hash tables to use the new type-safe >> > > template hash table. Constify member function parameters th

Re: [patch][lra] Improve initial program point density in lra-lives.c

2012-10-04 Thread Vladimir Makarov
On 10/04/2012 12:56 PM, Steven Bosscher wrote: On Thu, Oct 4, 2012 at 6:12 PM, Vladimir Makarov wrote: 0.6% sounds really very different from my timings. How much time does create_start_finish_chains take for you? 0.65% (2.78s). Actually, I have a profile but I am not sure now that it is for

Re: PING^2: [patch] pr/54508: fix incomplete debug information for class

2012-10-04 Thread Cary Coutant
> /* We also have to mark its parents as used. > -(But we don't want to mark our parents' kids due to this.) */ > +(But we don't want to mark our parent's kids due to this, > +unless it is a class.) */ > if (die->die_parent) > - prune_unused_types_mark (d

Re: PATCH trunk: gengtype honoring mark_hook-s inside struct inside union-s

2012-10-04 Thread Basile Starynkevitch
On Thu, Oct 04, 2012 at 07:26:23PM +0200, Richard Guenther wrote: > On Thu, Oct 4, 2012 at 7:24 PM, Basile Starynkevitch > wrote: > > On Thu, Oct 04, 2012 at 06:51:35PM +0300, Laurynas Biveinis wrote: > >> > 2012-10-03 Basile Starynkevitch > >> > > >> > * gengtype.c (walk_type): Emit ma

Re: [PATCH] Teach VRP to handle if ((unsigned_narrowing_cast) x != 0) similarly to if ((x & 0xffff) != 0) (PR tree-optimization/54810)

2012-10-04 Thread Richard Guenther
On Thu, Oct 4, 2012 at 6:31 PM, Jakub Jelinek wrote: > Hi! > > This patch handles unsigned narrowing casts the same as > BIT_AND_EXPR with the unsigned narrow type's max value. > > Bootstrapped/regtested on x86_64-linux and i686-linux, > ok for trunk? Ok. Thanks, Richard. > 2012-10-04 Jakub Je

Re: PATCH trunk: gengtype honoring mark_hook-s inside struct inside union-s

2012-10-04 Thread Richard Guenther
On Thu, Oct 4, 2012 at 7:24 PM, Basile Starynkevitch wrote: > On Thu, Oct 04, 2012 at 06:51:35PM +0300, Laurynas Biveinis wrote: >> > 2012-10-03 Basile Starynkevitch >> > >> > * gengtype.c (walk_type): Emit mark_hook when inside a >> > struct of a union member. >> >> This is O

Re: [lra] patch to solve most scalability problems for LRA

2012-10-04 Thread Richard Guenther
On Thu, Oct 4, 2012 at 7:07 PM, Steven Bosscher wrote: > On Thu, Oct 4, 2012 at 5:37 PM, Vladimir Makarov wrote: >> The only issue now is PR54146 compilation time for IRA+LRA although it >> was improved significantly. I will continue work on PR54146. But now I >> am going to focus on proposal

Re: PATCH trunk: gengtype honoring mark_hook-s inside struct inside union-s

2012-10-04 Thread Basile Starynkevitch
On Thu, Oct 04, 2012 at 06:51:35PM +0300, Laurynas Biveinis wrote: > > 2012-10-03 Basile Starynkevitch > > > > * gengtype.c (walk_type): Emit mark_hook when inside a > > struct of a union member. > > This is OK. thanks, Committed revision 192092 to trunk. I believe this pat

Re: [Patch, Fortran] Fix some memory leaks

2012-10-04 Thread Steven Bosscher
On Thu, Oct 4, 2012 at 7:06 PM, Tobias Burnus wrote: > This patch fixes some memory leaks and other issues found by > http://scan5.coverity.com. > > Build and regtested on x86-64-linux. > OK for the trunk? Yes, thanks for plugging these! Some of them have been there since day 0 :-) Ciao! Steven

Re: [patch][lra] Improve initial program point density in lra-lives.c

2012-10-04 Thread Steven Bosscher
On Thu, Oct 4, 2012 at 6:56 PM, Steven Bosscher wrote: > "Crude, but efficient" (tm) :-) BTW with a similar approach I also time other bits of process_bb_lives: timevar_push (TV_HOIST); /* See if we'll need an increment at the end of this basic block. An increment is needed if the PSEUDOS

Re: [PATCH] Improve var-tracking memory disambiguation with frame pointer (PR debug/54796)

2012-10-04 Thread Jakub Jelinek
On Thu, Oct 04, 2012 at 06:42:47PM +0200, Steven Bosscher wrote: > On Thu, Oct 4, 2012 at 6:33 PM, Jakub Jelinek wrote: > > This patch fixes a few FAILs in the ix86 guality testsuite (mainly -Os), > > by better disambiguating sp based VALUEs (which usually have no MEM_EXPR > > and thus the alias Or

Re: [lra] patch to solve most scalability problems for LRA

2012-10-04 Thread Steven Bosscher
On Thu, Oct 4, 2012 at 5:37 PM, Vladimir Makarov wrote: > The only issue now is PR54146 compilation time for IRA+LRA although it > was improved significantly. I will continue work on PR54146. But now I > am going to focus on proposals from reviews. Right, there still are opportunities to impr

[Patch, Fortran] Fix some memory leaks

2012-10-04 Thread Tobias Burnus
This patch fixes some memory leaks and other issues found by http://scan5.coverity.com. Build and regtested on x86-64-linux. OK for the trunk? Tobias 2012-10-04 Tobias Burnus * expr.c (scalarize_intrinsic_call): Plug memory leak. * frontend-passes.c (gcc_assert): Extend assert. * interf

Adjust gcc.dg/lto/20120723_0.c for SPARC

2012-10-04 Thread Eric Botcazou
As noted by Martin in http://gcc.gnu.org/ml/gcc-patches/2012-08/msg00116.html, the testcase is invalid C and cannot pass on SPARC 32-bit because of the ABI. Tested on SPARC/Solaris 10, applied on the mainline. 2012-10-04 Eric Botcazou * gcc.dg/lto/20120723_0.c: Skip on SPARC 32-bit.

Re: patch to fix constant math

2012-10-04 Thread Richard Guenther
On Thu, Oct 4, 2012 at 3:55 PM, Kenneth Zadeck wrote: > Let me talk about the mode here first. > > What this interface/patch provides is a facility where the constant math > that is done in optimizations is done exactly the way that it would be done > on the target machine. What we have now is a

Re: [patch][lra] Improve initial program point density in lra-lives.c

2012-10-04 Thread Steven Bosscher
On Thu, Oct 4, 2012 at 6:12 PM, Vladimir Makarov wrote: >>> 0.6% sounds really very different from my timings. How much time does >>> create_start_finish_chains take for you? >>> >> 0.65% (2.78s). >> >> Actually, I have a profile but I am not sure now that it is for PR54146. >> It might be for PR2

Re: patch to fix

2012-10-04 Thread Marc Glisse
On Thu, 4 Oct 2012, Kenneth Zadeck wrote: On 10/04/2012 09:17 AM, Marc Glisse wrote: On Wed, 3 Oct 2012, Mike Stump wrote: On Oct 3, 2012, at 1:47 PM, Marc Glisse wrote: did you consider making the size of wide_int a template parameter, now that we are using C++? All with a convenient typede

Re: [patch][lra] Improve initial program point density in lra-lives.c (was: Re: RFC: LRA for x86/x86-64 [7/9])

2012-10-04 Thread Steven Bosscher
On Thu, Oct 4, 2012 at 5:31 PM, Vladimir Makarov wrote: > > Wow. I did not have such effect. What machine do you use? I do all my testing on gcc17. Ciao! Steven

Re: [PATCH] Improve var-tracking memory disambiguation with frame pointer (PR debug/54796)

2012-10-04 Thread Steven Bosscher
On Thu, Oct 4, 2012 at 6:33 PM, Jakub Jelinek wrote: > This patch fixes a few FAILs in the ix86 guality testsuite (mainly -Os), > by better disambiguating sp based VALUEs (which usually have no MEM_EXPR > and thus the alias Oracle can't be used for them) from frame pointer > based ones or global va

[PATCH] Teach VRP to handle if ((unsigned_narrowing_cast) x != 0) similarly to if ((x & 0xffff) != 0) (PR tree-optimization/54810)

2012-10-04 Thread Jakub Jelinek
Hi! This patch handles unsigned narrowing casts the same as BIT_AND_EXPR with the unsigned narrow type's max value. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2012-10-04 Jakub Jelinek PR tree-optimization/54810 * tree-vrp.c (register_edge_assert_for_

[PATCH] Improve var-tracking memory disambiguation with frame pointer (PR debug/54796)

2012-10-04 Thread Jakub Jelinek
Hi! This patch fixes a few FAILs in the ix86 guality testsuite (mainly -Os), by better disambiguating sp based VALUEs (which usually have no MEM_EXPR and thus the alias Oracle can't be used for them) from frame pointer based ones or global vars. Bootstrapped/regtested on x86_64-linux and i686-lin

Re: [PATCH] Rs6000 infrastructure cleanup (switches), revised patch #2c

2012-10-04 Thread Gunther Nikl
Michael Meissner schrieb: > On Tue, Oct 02, 2012 at 10:13:25AM +0200, Gunther Nikl wrote: >> Michael Meissner wrote: >>> Segher Boessenkool asked me on IRC to break out the fix in the last change. >>> This patch is just the change to set the default options if the user did not >>> use -mcpu= and th

Re: [PATCH, gdc] - Merging gdc (GNU D Compiler) into gcc

2012-10-04 Thread Iain Buclaw
On 4 October 2012 16:51, Mike Stump wrote: > On Oct 4, 2012, at 6:06 AM, Iain Buclaw wrote: >> I would like to get a bump on this. >> >> It's been a while, and there have been quite a number of changes since >> the initial post that address many of the issues raised. Rather than >> reposting pat

Re: [RFC] Make vectorizer to skip loops with small iteration estimate

2012-10-04 Thread Richard Guenther
On Thu, 4 Oct 2012, Jan Hubicka wrote: > > > So SOC cancels out in the runtime check. > > > I still think we need two formulas - one determining if vectorization is > > > profitable, other specifying the threshold for scalar path at runtime > > > (that > > > will generally give lower values). > >

Re: [patch][lra] Improve initial program point density in lra-lives.c

2012-10-04 Thread Vladimir Makarov
On 10/04/2012 11:45 AM, Vladimir Makarov wrote: On 10/04/2012 02:57 AM, Steven Bosscher wrote: On Thu, Oct 4, 2012 at 5:30 AM, Vladimir Makarov wrote: I was going to look at this code too but I was interesting in generation of less points and live ranges. It is strange that in my profiles, r

PING^2: [patch] pr/54508: fix incomplete debug information for class

2012-10-04 Thread Paul_Koning
Ping ^ 2... -- If the only reference in a source file is to a static method of a class, then GCC would output debug information for the class name but not any of its members or base classes. The attached patch fixes this by having "prune_unused_types_mark" mark all of the parent's childre

Re: Small PATCH to rs6000.c to fix cross-compiler build without gas

2012-10-04 Thread David Edelsohn
On Thu, Oct 4, 2012 at 11:38 AM, Jason Merrill wrote: > If configure doesn't think that the assembler supports weak symbols, > rs6000.c fails to compile because ASM_WEAKEN_DECL isn't defined. So let's > not use it in that case. > > OK for trunk? This patch is okay. Where are you compiling GCC f

Re: PATCH trunk: gengtype honoring mark_hook-s inside struct inside union-s

2012-10-04 Thread Laurynas Biveinis
> 2012-10-03 Basile Starynkevitch > > * gengtype.c (walk_type): Emit mark_hook when inside a > struct of a union member. This is OK. Thanks, -- Laurynas

Re: [patch][lra] Improve initial program point density in lra-lives.c (was: Re: RFC: LRA for x86/x86-64 [7/9])

2012-10-04 Thread Vladimir Makarov
On 10/04/2012 02:57 AM, Steven Bosscher wrote: On Thu, Oct 4, 2012 at 5:30 AM, Vladimir Makarov wrote: I was going to look at this code too but I was interesting in generation of less points and live ranges. It is strange that in my profiles, remove_some_program_points_and_update_live_ranges t

Re: [PATCH, gdc] - Merging gdc (GNU D Compiler) into gcc

2012-10-04 Thread Mike Stump
On Oct 4, 2012, at 6:06 AM, Iain Buclaw wrote: > I would like to get a bump on this. > > It's been a while, and there have been quite a number of changes since > the initial post that address many of the issues raised. Rather than > reposting patches, someone mentioned attaching changelog, well,

Re: RFC: LRA for x86/x86-64 [7/9] -- continuation

2012-10-04 Thread Richard Sandiford
Hi Vlad, This message is for lra-assigns.c. Sorry for the piecemeal reviews, never sure when I'll get time... > +/* This file contains a pass mostly assigning hard registers to reload > + pseudos. There is no any RTL code transformation on this pass. Maybe: /* This file's main objective is

[lra] patch to solve most scalability problems for LRA

2012-10-04 Thread Vladimir Makarov
The following patch solves most of LRA scalability problems. Itswitches on simpler algorithms in LRA. The first it switches off trying to reassign hard registers to spilled pseudos (they usually for such huge functions have long live ranges -- so the possibility to assign them something very

Profile housekeeping 7/n minor updating fixes

2012-10-04 Thread Jan Hubicka
Hi, here are few minor issues I run across while auditing the profile updating code. The function.c changes solve some misupdates in jump threading. tree-inline and except can be seen with -fprofile-feedback. Bootstrapped/regtested x86_64-linux, will commit it shortly. Honza * tree-inlin

PATCH to acinclude.m4 to fix gas version detection

2012-10-04 Thread Jason Merrill
Recent versions of binutils seem to have started putting ' around the version number in bfd/configure.in, which was confusing gcc configure. This patch allows us to detect the version number again. OK for trunk? commit f9ce75775fe4392ee92893c46e89e17dc31bb816 Author: Jason Merrill Date: Thu

Re: patch to fix

2012-10-04 Thread Kenneth Zadeck
Actually richi, this code is "correct" for some broken definition of correct. If all that is done is to convert the rtl parts of the compiler, then this code is the best you can do (of course an assertion that the length is not greater than 2 would be a useful addition). The code that is in

Small PATCH to rs6000.c to fix cross-compiler build without gas

2012-10-04 Thread Jason Merrill
If configure doesn't think that the assembler supports weak symbols, rs6000.c fails to compile because ASM_WEAKEN_DECL isn't defined. So let's not use it in that case. OK for trunk? commit 5f0878b79d1a42795aca2fabc8d70eefa2e29fa6 Author: Jason Merrill Date: Wed Oct 3 15:55:48 2012 -0400

Re: [testsuite] Add support for -fdump-ada-spec

2012-10-04 Thread Mike Stump
On Oct 4, 2012, at 4:10 AM, Eric Botcazou wrote: > the recent breakage of -fdump-ada-spec revealed that the switch isn't > exercised in the testsuite. This patch adds the missing support. > > Tested on x86_64-suse-linux, OK for mainline? Ok. > What of the 4.7 branch? I don't see the point…

Re: [patch][lra] Improve initial program point density in lra-lives.c (was: Re: RFC: LRA for x86/x86-64 [7/9])

2012-10-04 Thread Vladimir Makarov
On 10/04/2012 05:43 AM, Steven Bosscher wrote: On Wed, Oct 3, 2012 at 5:35 PM, Steven Bosscher wrote: The "worst" result is this: Compressing live ranges: from 726174 to 64496 - 8%, pre_count 40476128, post_count 12483414 But that's still a lot better than before the patch for the same functi

Re: RFA: darwin PATCH to fix build, internal visibility

2012-10-04 Thread Jason Merrill
On 10/04/2012 09:41 AM, Jack Howarth wrote: It appears that the patch should also special case the "scan-assembler .internal.*Foo.methodEv" tests in g++.dg/ext/visibility/pragma-override1.C and g++.dg/ext/visibility/pragma-override2.C on darwin as well... Done, thanks. Jason

Re: [patch][lra] Improve initial program point density in lra-lives.c (was: Re: RFC: LRA for x86/x86-64 [7/9])

2012-10-04 Thread Vladimir Makarov
On 10/04/2012 03:24 AM, Steven Bosscher wrote: On Thu, Oct 4, 2012 at 8:57 AM, Steven Bosscher wrote: On Thu, Oct 4, 2012 at 5:30 AM, Vladimir Makarov wrote: I was going to look at this code too but I was interesting in generation of less points and live ranges. It is strange that in my prof

[C++ testcase] PR 54323

2012-10-04 Thread Paolo Carlini
Hi, I'm adding the testcase and closing the PR. Tested x86_64-linux. Thanks, Paolo. / 2012-10-04 Paolo Carlini PR c++/54323 * g++.dg/cpp0x/pr54323.C: New. Index: g++.dg/cpp0x/pr54323.C ==

Re: patch to fix

2012-10-04 Thread Kenneth Zadeck
On 10/04/2012 09:17 AM, Marc Glisse wrote: On Wed, 3 Oct 2012, Mike Stump wrote: On Oct 3, 2012, at 1:47 PM, Marc Glisse wrote: did you consider making the size of wide_int a template parameter, now that we are using C++? All with a convenient typedef or macro so it doesn't show. I am asking

Re: libgo patch committed: Use libbacktrace

2012-10-04 Thread Ian Lance Taylor
On Thu, Oct 4, 2012 at 5:11 AM, Rainer Orth wrote: > Ian Lance Taylor writes: > >> This patch to libgo changes it to use libbacktrace. Previously >> backtraces required the Go package debug/elf to register itself with the >> runtime during the package initialization, which only worked if the >>

Re: Profile housekeeping 6/n (-fprofile-consistency-report)

2012-10-04 Thread Jan Hubicka
> On Thu, Oct 4, 2012 at 4:01 PM, Jan Hubicka wrote: > > * doc/invoke.texi (-fprofile-consistency-report): Document. > > * common.opt (fprofile-consistency-report): New. > > * toplev.h (dump_profile_consistency_report): Declare. > > * toplev.c (finalize): Call dump_p

Re: [RFC] Make vectorizer to skip loops with small iteration estimate

2012-10-04 Thread Jan Hubicka
> > So SOC cancels out in the runtime check. > > I still think we need two formulas - one determining if vectorization is > > profitable, other specifying the threshold for scalar path at runtime (that > > will generally give lower values). > > True, we want two values. But part of the scalar pat

Re: RFA: add lock_length attribute to break branch-shortening cycles

2012-10-04 Thread Joern Rennecke
Quoting Richard Guenther : I miss a few things in this description: - what is the value of lock_length supposed to be? From the "lock" prefix it sounds like it is something unchanging, maybe even constant, thus a maximum? - the length attribute still needs to be specified when lock_length i

Re: Profile housekeeping 6/n (-fprofile-consistency-report)

2012-10-04 Thread Steven Bosscher
On Thu, Oct 4, 2012 at 4:01 PM, Jan Hubicka wrote: > * doc/invoke.texi (-fprofile-consistency-report): Document. > * common.opt (fprofile-consistency-report): New. > * toplev.h (dump_profile_consistency_report): Declare. > * toplev.c (finalize): Call dump_profile_con

Profile housekeeping 6/n (-fprofile-consistency-report)

2012-10-04 Thread Jan Hubicka
Hi, this patch implements -fprofile-consistency-report that is useful to get an statistic about what pass are major offenders in keeping profile up-to-date. For example the following is output for combine.c Pass: fnsplit (after pass) mismatched in: +16 (freqs) +0 (counts); michma

Re: patch to fix constant math

2012-10-04 Thread Kenneth Zadeck
Let me talk about the mode here first. What this interface/patch provides is a facility where the constant math that is done in optimizations is done exactly the way that it would be done on the target machine. What we have now is a compiler that only does this if it convenient to do on the

Re: RFA: darwin PATCH to fix build, internal visibility

2012-10-04 Thread Jack Howarth
On Wed, Oct 03, 2012 at 03:26:14PM -0700, Mike Stump wrote: > On Oct 3, 2012, at 12:04 PM, Jason Merrill wrote: > > This patch fixes a couple of Darwin issues I noticed with a cross-compiler: > > > > 1) Adds a couple of consts to avoid const-correctness errors. > > 2) Treats visibility "internal"

Re: [RFA 1/5] New port: CR16: Remove "gdb" from noconfigdirs in configure.ac

2012-10-04 Thread Pedro Alves
On 10/04/2012 11:17 AM, Kaushik Phatak wrote: > Hi, > This patch is one of patch set to add a new port (National Instruments CR16) > in gdb. > This patch will, > - Remove "gdb" from noconfigdirs in top-level configure.ac. > - Add target-lobgloss I can't see how adding target-libgloss is relevant

Re: Propagate profile counts during switch expansion

2012-10-04 Thread Jan Hubicka
> Hi, > This patch propagates the profile counts during RTL expansion. In > many cases, there is no way to determine the exact count of an edge > generated during the expansion. So this patch uses some simple > heuristics to estimate the edge counts but ensures that the counts of > the basic block

Re: patch to fix

2012-10-04 Thread Marc Glisse
On Wed, 3 Oct 2012, Mike Stump wrote: On Oct 3, 2012, at 1:47 PM, Marc Glisse wrote: did you consider making the size of wide_int a template parameter, now that we are using C++? All with a convenient typedef or macro so it doesn't show. I am asking because in vrp I do some arithmetic that re

Re: [PATCH, gdc] - Merging gdc (GNU D Compiler) into gcc

2012-10-04 Thread Iain Buclaw
I would like to get a bump on this. It's been a while, and there have been quite a number of changes since the initial post that address many of the issues raised. Rather than reposting patches, someone mentioned attaching changelog, well, here it is. Repository is still located here: https://gi

Re: [patch][lra] Improve initial program point density in lra-lives.c (was: Re: RFC: LRA for x86/x86-64 [7/9])

2012-10-04 Thread Steven Bosscher
On Thu, Oct 4, 2012 at 1:30 PM, Richard Guenther wrote: > Isn't _REVERSE vs. non-_RESERVE still kind-of "random" order? Not at this stage. For cfglayout mode I would answer yes, but IRA/LRA operates in cfgrtl mode, so the sequence of insns and basic blocks must match. Therefore, if you walk the b

Re: [Patch] Fix PR53397

2012-10-04 Thread Richard Guenther
On Tue, Oct 2, 2012 at 6:40 PM, Kumar, Venkataramanan wrote: > Hi Richi, > > (Snip) >> + (!cst_and_fits_in_hwi (step)) >> +{ >> + if( loop->inner != NULL) >> +{ >> + if (dump_file && (dump_flags & TDF_DETAILS)) >> +{ >> + fprintf (dump_file, "Refe

Re: [Fortran, (RFC) patch] PR49110/51055 Assignment to alloc. deferred-length character vars

2012-10-04 Thread Janus Weil
Hi, >> One more comment: Since its appearance is a bit scattered in the code, >> how about using a small macro which prepends the "_F" prefix to a >> given variable name? >> >> Btw, note that we are using a double underscore scheme in other places >> (like __class, __vtab, __vtype, etc). I have ev

Re: patch to fix

2012-10-04 Thread Richard Guenther
On Wed, Oct 3, 2012 at 7:15 PM, Kenneth Zadeck wrote: > The enclosed patch is the third of at least four patches that fix the > problems associated with supporting integers on the target that are > wider than two HOST_WIDE_INTs. > > While GCC claims to support OI mode, and we have two public ports

Re: libgo patch committed: Use libbacktrace

2012-10-04 Thread Rainer Orth
Ian Lance Taylor writes: > This patch to libgo changes it to use libbacktrace. Previously > backtraces required the Go package debug/elf to register itself with the > runtime during the package initialization, which only worked if the > program actually imported debug/elf one way or another. Bo

Re: [patch][lra] Improve initial program point density in lra-lives.c (was: Re: RFC: LRA for x86/x86-64 [7/9])

2012-10-04 Thread Richard Guenther
On Thu, Oct 4, 2012 at 11:43 AM, Steven Bosscher wrote: > On Wed, Oct 3, 2012 at 5:35 PM, Steven Bosscher wrote: >> The "worst" result is this: >> Compressing live ranges: from 726174 to 64496 - 8%, pre_count 40476128, >> post_count 12483414 >> >> But that's still a lot better than before the pa

Re: [Fortran, (RFC) patch] PR49110/51055 Assignment to alloc. deferred-length character vars

2012-10-04 Thread Tobias Burnus
Hi Janus, Janus Weil wrote: When backporting to 4.6 and 4.7, do you intend to also bump the module version there? Does that make sense? Probably not. The .__result and the .saved_dovar are not ABI relevant, thus, they can be changed without problems - but also not that important. The module

Re: [Fortran, (RFC) patch] PR49110/51055 Assignment to alloc. deferred-length character vars

2012-10-04 Thread Janne Blomqvist
On Thu, Oct 4, 2012 at 1:50 PM, Janus Weil wrote: >>> Thanks for the suggestions. The attached patch changes all "."-something >>> symbol names, which I found. >>> >>> Build and regtested on x86-64-gnu-linux. >>> OK for the trunk and 4.7? (".saved_dovar" also occurs in 4.6; we could also >>> backp

Re: [Patch, Fortran, OOP] PR 54784: [4.7/4.8 Regression] wrong code in polymorphic allocation with SOURCE

2012-10-04 Thread Mikael Morin
Le 03/10/2012 18:48, Janus Weil a écrit : > Hi all, > > here is a small patch for a wrong-code regression with polymorphic > allocation. The problem is that we falsely detect the allocation > variable to be a polymorphic array (although it is a scalar). For > further details see the PR, in particu

[testsuite] Add support for -fdump-ada-spec

2012-10-04 Thread Eric Botcazou
Hi, the recent breakage of -fdump-ada-spec revealed that the switch isn't exercised in the testsuite. This patch adds the missing support. Tested on x86_64-suse-linux, OK for mainline? What of the 4.7 branch? 2012-10-04 Eric Botcazou * lib/gcc-dg.exp (cleanup-ada-spec): New proce

Re: [Fortran, (RFC) patch] PR49110/51055 Assignment to alloc. deferred-length character vars

2012-10-04 Thread Mikael Morin
Le 04/10/2012 12:17, Janus Weil a écrit : > > When backporting to 4.6 and 4.7, do you intend to also bump the module > version there? Does that make sense? > If the module version is different from that of trunk, please don't, as we would have two different module formats with the same module ver

  1   2   >