Re: Support for Runtime CPU type detection via builtins (issue5754058)

On Wed, 25 Apr 2012, H.J. Lu wrote: You can download an AVX2 emulator (SDE) from http://software.intel.com/en-us/avx/ to test AVX2 binaries. Hello, not related to this specific patch, but do you have a dejagnu board description that you could share that enables running the compiler normal

Re: [RFA] dwarf2.h (dwarf_location_atom): Add DW_OP_GNU_addr_index.

On Wed, Apr 25, 2012 at 04:56:17PM -0700, Doug Evans wrote: > On Wed, Apr 18, 2012 at 12:11 PM, Doug Evans wrote: > > This patch adds DW_OP_GNU_addr_index to dwarf2.h. > > > > Ok to commit? > > > > 2012-04-18  Doug Evans   > > > >        * dwarf2.h (dwarf_location_atom): Add DW_OP_GNU_addr_index.

Re: [RS6000] Fix PR53038, cfa_restore out of order

On Wed, Apr 25, 2012 at 02:00:48PM -0700, Richard Henderson wrote: > On 04/20/12 18:58, Alan Modra wrote: > > + add_reg_note (insn, REG_FRAME_RELATED_EXPR, set); > > + RTX_FRAME_RELATED_P (insn) = 1; > > You're probably better off using REG_CFA_REGISTER here, > rather than making dwarf2c

Re: PR c++/52538 Extend C++11 UDLs to be compatible with inttypes.h macros (issue6109043)

On Mon, Apr 23, 2012 at 8:28 AM, Gabriel Dos Reis wrote: > > Thanks.  Tom, I am satisfied with the diagnostic part. > I think the CPP part makes sense but it is your call. Hi, Tom, just a quick checkin to see if you've had a chance to review this, yet. Thanks, Ollie

libgo patch committed: Always define syscall.SO_REUSEPORT

This patch to libgo ensures that syscall.SO_REUSEPORT is defined. It fixes the only use of it in the standard library to check whether it has a valid value before using it. This should fix the build on Solaris 9. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline

[v3] hashtable doc tweaks

... putting in line breaks for doxygen, so that each base class is on a separate line. -benjamin2012-04-25 Benjamin Kosnik * include/bits/hashtable.h: Adjust doxygen markup for base classes. * include/bits/hashtable_policy.h: Same. diff --git a/libstdc++-v3/include/bits/hashtable.h b/li

Re: Support for Runtime CPU type detection via builtins (issue5754058)

Patch committed. Thanks, -Sri. On Wed, Apr 25, 2012 at 4:52 PM, H.J. Lu wrote: > On Wed, Apr 25, 2012 at 4:38 PM, Sriraman Tallam wrote: >> Hi H.J, >> >>   Could you please review this patch for AVX2 check? >> >>        * config/i386/i386-cpuinfo.c (FEATURE_AVX2): New enum value. >>        (get

Re: [RFA] dwarf2.h (dwarf_location_atom): Add DW_OP_GNU_addr_index.

> Ping. > This is approved on the binutils side. > I just need approval on the gcc side. My understanding is that a patch to sync binutils/include and gcc/include falls under the "trivial and obvious" rule. True? -cary

Committed: fix PR target/53120, constraint modifier "+" on operand tied by matching-constraint, "0".

The subject line points out the bug. This combination of constraints is invalid, and almost no other target has it (and none together with strict_low_part): you can't reload a read/write operand (one with a "+" modifier, such as a strict_low_part destination) for which there is an input-only match

[patch] fix test gcc.dg/bf-ms-layout.c

A couple of months ago Kai Tietz fixed several tests for MS layout of bitfields, including: 2012-02-23 Kai Tietz * gcc.dg/bf-ms-layout-2.c: Adjust offsets to fit ms-bitfield structure-layout. He missed changes to gcc.dg/bf-ms-layout.c which has the same layouts as bf-ms-la

Re: -finstrument-functions leads to unsats to _mm instrinsic wrappers

Ping .. David On Tue, Dec 27, 2011 at 10:46 AM, Xinliang David Li wrote: > Ping .. > > On Fri, Dec 9, 2011 at 9:42 AM, Xinliang David Li wrote: >> Ping .. >> >> On Wed, Dec 7, 2011 at 4:01 PM, Xinliang David Li wrote: >>> Build the test case in the patch file with -finstrument-functions, the

Re: [RFA] dwarf2.h (dwarf_location_atom): Add DW_OP_GNU_addr_index.

On Wed, Apr 18, 2012 at 12:11 PM, Doug Evans wrote: > Hi. > > This patch adds DW_OP_GNU_addr_index to dwarf2.h. > > Ok to commit? > > 2012-04-18  Doug Evans   > >        * dwarf2.h (dwarf_location_atom): Add DW_OP_GNU_addr_index. > > Index: include/dwarf2.h > ==

Re: Support for Runtime CPU type detection via builtins (issue5754058)

On Wed, Apr 25, 2012 at 4:38 PM, Sriraman Tallam wrote: > Hi H.J, > >   Could you please review this patch for AVX2 check? > >        * config/i386/i386-cpuinfo.c (FEATURE_AVX2): New enum value. >        (get_available_features): New argument. Check for AVX2. >        (__cpu_indicator_init): Modif

Re: Support for Runtime CPU type detection via builtins (issue5754058)

Hi H.J, Could you please review this patch for AVX2 check? * config/i386/i386-cpuinfo.c (FEATURE_AVX2): New enum value. (get_available_features): New argument. Check for AVX2. (__cpu_indicator_init): Modify call to get_available_features . * doc/extend.texi: Doc

Re: [PATCH 12/13] Adjust relevant test cases wrt -ftrack-macro-expansion=[0|2]

Hey hey! Looking good Dodji. Can't wait to use this stuff. > There are so many libstdc++ tests that were failing because of that > benign issue that I preferred to just run them with > -ftrack-macro-expansion diabled, after inspecting each of them to be > sure there was nothing more serious under

Re: [PR tree-optimization/52558]: RFC: questions on store data race

On 04/25/12 06:45, Richard Guenther wrote: On Tue, Apr 24, 2012 at 7:43 PM, Aldy Hernandez wrote: On 04/13/12 03:46, Richard Guenther wrote: On Fri, Apr 13, 2012 at 12:11 AM, Aldy Hernandezwrote: + /* ?? Perhaps we should cache this somewhere in the BB, or are + multiple levels of

Re: [v3] libstdc++/52689 testcase

On Wed, 25 Apr 2012 18:53:36 +0100 Jonathan Wakely wrote: > On 25 April 2012 08:33, Igor Zamyatin wrote: > > This testcase is reported as failed on x86 > > Yep. > > http://gcc.gnu.org/ml/gcc-testresults/2012-04/msg02547.html > > Benjamin? Ouch. Sorry about this guys, of course it wasn't thi

Re: [PATCH] Fix for PR51879 - Missed tail merging with non-const/pure calls

On 25/04/12 11:57, Richard Guenther wrote: >>> >> Hmm. I'm not sure we can conclude that they have the same value! >>> >> >>> >> +int bar (int); >>> >> +void baz (int); >>> >> +void bla (int); >>> >> + >>> >> +void >>> >> +foo (int y) >>> >> +{ >>> >> + int a; >>> >> + if (y == 6) >>> >> +{

Re: Support for Runtime CPU type detection via builtins (issue5754058)

On Wed, Apr 25, 2012 at 2:28 PM, H.J. Lu wrote: > On Wed, Apr 25, 2012 at 2:25 PM, Sriraman Tallam wrote: >> On Tue, Apr 24, 2012 at 7:39 PM, H.J. Lu wrote: >>> On Tue, Apr 24, 2012 at 7:06 PM, Sriraman Tallam >>> wrote: On Tue, Apr 24, 2012 at 5:24 PM, H.J. Lu wrote: > On Tue, Apr 2

Re: fix incorrect SRA transformation on non-integral VIEW_CONVERT argument

Thanks for your feedback Richard, On Apr 25, 2012, at 16:16 , Richard Guenther wrote: > I think much better would be to simply disallow any toplevel > VIEW_CONVERT_EXPR of BLKmode, > Does that fix your problems, too? If so I prefer that. Hmm, I think that this would fix the particular testscas

Re: Support for Runtime CPU type detection via builtins (issue5754058)

On Wed, Apr 25, 2012 at 2:25 PM, Sriraman Tallam wrote: > On Tue, Apr 24, 2012 at 7:39 PM, H.J. Lu wrote: >> On Tue, Apr 24, 2012 at 7:06 PM, Sriraman Tallam wrote: >>> On Tue, Apr 24, 2012 at 5:24 PM, H.J. Lu wrote: On Tue, Apr 24, 2012 at 5:10 PM, Sriraman Tallam wrote: > Hi,

Re: Support for Runtime CPU type detection via builtins (issue5754058)

On Tue, Apr 24, 2012 at 7:39 PM, H.J. Lu wrote: > On Tue, Apr 24, 2012 at 7:06 PM, Sriraman Tallam wrote: >> On Tue, Apr 24, 2012 at 5:24 PM, H.J. Lu wrote: >>> On Tue, Apr 24, 2012 at 5:10 PM, Sriraman Tallam >>> wrote: Hi,   Thanks for all the comments. I have made all the cha

Re: [Patch, fortran] PR 49010/24518 MOD/MODULO fixes, take 2

PING! On Thu, Apr 19, 2012 at 00:46, Janne Blomqvist wrote: > Hi, > > the attached patch implements a few fixes and cleanups for the MOD and > MODULO intrinsics. > > - When the arguments are constant, use mpfr_fmod instead of the naive > algorithms which are numerically unstable for large argumen

Re: [Patch, libfortran] Fix handling of temporary files

PING! On Thu, Apr 19, 2012 at 01:18, Janne Blomqvist wrote: > Hi, > > the attached patch implements some fixes for handling STATUS="SCRATCH" files. > > - Currently, we check GFORTRAN_TMPDIR, TMP, and TEMP environment > variables, but not the POSIX and GNU standard TMPDIR. As specifying a > tempor

[Patch, fortran] PR 52428 Reading of large negative values and range checking

Hi, currently when -frange-check is enabled, we check for overflow when doing a formatted read of an integer value. This check, however, is against the Fortran numerical model (see 13.4 in F2008), which defines a symmetric interval [-huge(), huge()], whereas all targets gfortran supports use a two

Re: [RS6000] Fix PR53038, cfa_restore out of order

On 04/20/12 18:58, Alan Modra wrote: > + add_reg_note (insn, REG_FRAME_RELATED_EXPR, set); > + RTX_FRAME_RELATED_P (insn) = 1; You're probably better off using REG_CFA_REGISTER here, rather than making dwarf2cfi.c guess what you meant. The guessing is rather tuned to prologues... r~

Re: [google-4_6] fix broken -S in streaming LIPO (issue6115052)

ok. David On Wed, Apr 25, 2012 at 1:08 PM, Rong Xu wrote: > Hi, > > This patch is for google-4_6 branch only. > It fixes the broken -S in streaming LIPO mode. > > Tested with bootstrap. > > Thanks, > > 2012-04-25   Rong Xu   > >        * gcc/gcc.c (ripa_lto_spec): Support -S. >        (cc1_optio

[google-4_6] fix broken -S in streaming LIPO (issue6115052)

Hi, This patch is for google-4_6 branch only. It fixes the broken -S in streaming LIPO mode. Tested with bootstrap. Thanks, 2012-04-25 Rong Xu * gcc/gcc.c (ripa_lto_spec): Support -S. (cc1_options): Ditto. Index: gcc/gcc.c ==

[lra] patch to fix some LRA failures of GCC tests on PA-RISC

The following patch fixes some testsuite regressions of LRA in comparison with reload on PA-RISC. There are still few regressions which I'll work on later. The patch was bootstrapped on x86/x86-64. Committed as rev. 186823. 2012-04-25 Vladimir Makarov * lra-constraints.c (get_op_m

Re: [PATCH] Validate the HLE memory models.

On 04/25/12 01:29, Andi Kleen wrote: > gcc/: > 2012-04-24 Andi Kleen > > * builtins.c (get_memmodel): Add val. Call target.memmodel_check > and return new variable. > * config/i386/i386.c (ix86_memmodel_check): Add. > (TARGET_MEMMODEL_MASK): Replace with TARGET_MEMMODEL_

FW: [PATCH][Cilkplus] Elemental function insertion

Sorry, I forgot to include Changelog entries. I am attaching the updated patch. Thanks, Balaji V. Iyer. From: Iyer, Balaji V Sent: Wednesday, April 25, 2012 3:08 PM To: gcc-patches@gcc.gnu.org Subject: [PATCH][Cilkplus] Elemental function insertion Hello

Re: [PATCH] Improve andq $0xffffffff, %reg handling (PR target/53110)

On 04/25/12 12:14, Jakub Jelinek wrote: > 2012-04-25 Jakub Jelinek > > PR target/53110 > * config/i386/i386.md (and3): For andq $0x, reg > instead expand it as zero extension. Ok. r~

[PATCH] Improve andq $0xffffffff, %reg handling (PR target/53110)

Hi! We have a splitter for reg1 = reg2 & 0x, but only if regnums are different. But movl %edi, %edi is a cheaper variant of andq $0x, %rdi even with the same register and doesn't clobber flags, so this patch attempts to expand it as a zero extension early. Bootstrapped/regtested

[PATCH][Cilkplus] Elemental function insertion

Hello Everyone, This patch is for the Cilkplus branch affecting both C and C++ compilers. This patch will insert elemental functions when the loop is vectorized. Thanking You, Yours Sincerely, Balaji V. Iyer.diff --git a/gcc/cilk.h b/gcc/cilk.h index 27d5dd0..27ccd16 100644 --- a/gcc/cilk.h

Re: Symbol table 13/many: reachability code rewrite

On 04/25/12 11:46, Jan Hubicka wrote: >>> On Wed, Apr 25, 2012 at 5:04 PM, Jan Hubicka wrote: + /* Return true when there are references to NODE. */ + + static bool + referred_to_p (symtab_node node) + { + int i; + struct ipa_ref *ref; + + for (i

Re: PATCH: PR debug/52857: DW_OP_GNU_regval_type is generated with INVALID_REGNUM

On 04/25/12 06:59, H.J. Lu wrote: > PR debug/52857 > * dwarf2out.c (dbx_reg_number): Assert return value != > INVALID_REGNUM. Ok. r~

Re: Symbol table 14/many: cleanups of cgraphunit.c

> Hello, > > Thanks for this work! > > Below are a bunch of spelling fixes ;-) Thanks! > >        The function can be called multiple times when multiple source level > > !       compilation units are combined. > > Is this still applicable? I thought -combine was removed. Or is this > for thing

Re: Symbol table 13/many: reachability code rewrite

> > On Wed, Apr 25, 2012 at 5:04 PM, Jan Hubicka wrote: > > > + /* Return true when there are references to NODE.  */ > > > + > > > + static bool > > > + referred_to_p (symtab_node node) > > > + { > > > +   int i; > > > +   struct ipa_ref *ref; > > > + > > > +   for (i = 0; ipa_ref_list_referring_

[v3] fix scoped_allocator problems

* include/std/scoped_allocator (scoped_allocator::__outermost): Do not pass non-POD to varargs function. * testsuite/20_util/scoped_allocator/1.cc: Fix test. This fixes a potential problem in and fixes a broken test (and ensures it actually runs!) Tested x86_64-linux, com

Re: FW: [v3] libstdc++/52689 testcase

On 25 April 2012 08:33, Igor Zamyatin wrote: > This testcase is reported as failed on x86 Yep. http://gcc.gnu.org/ml/gcc-testresults/2012-04/msg02547.html Benjamin? >> >> Noticed that this testcase wasn't put in as part of the patch. Fixed as >> follows. >> >> tested x86/linux >> >> -benjamin

Re: [PATCH 13/13] Switch -ftrack-macro-expansion=2 on by default.

> "Gaby" == Gabriel Dos Reis writes: Gaby> On Wed, Apr 25, 2012 at 9:33 AM, Dodji Seketeli wrote: >> Hopefully closing the series, this patch switches the compiler to >> -ftrack-macro-expansion=2 by default. >> >> Tested and bootstrapped on x86_64-unknown-linux-gnu against trunk. Gaby> Mak

Re: Symbol table 14/many: cleanups of cgraphunit.c

Hello, Thanks for this work! Below are a bunch of spelling fixes ;-) On Wed, Apr 25, 2012 at 6:32 PM, Jan Hubicka wrote: > --- 19,28 >  along with GCC; see the file COPYING3.  If not see >  .  */ > > ! /* This module implements main driver of compilation proc

Re: Symbol table 13/many: reachability code rewrite

> On Wed, Apr 25, 2012 at 5:04 PM, Jan Hubicka wrote: > > + /* Return true when there are references to NODE.  */ > > + > > + static bool > > + referred_to_p (symtab_node node) > > + { > > +   int i; > > +   struct ipa_ref *ref; > > + > > +   for (i = 0; ipa_ref_list_referring_iterate (&node->symb

Re: Symbol table 13/many: reachability code rewrite

On Wed, Apr 25, 2012 at 5:04 PM, Jan Hubicka wrote: > + /* Return true when there are references to NODE.  */ > + > + static bool > + referred_to_p (symtab_node node) > + { > +   int i; > +   struct ipa_ref *ref; > + > +   for (i = 0; ipa_ref_list_referring_iterate (&node->symbol.ref_list, i, > r

Re: various minor obvious fixes in th track-macro-expansion code

Manuel López-Ibáñez writes: > Hi Dodji, Hello Manuel, Sorry for my late reply, I was on the road. > I was going to commit this as obvious, but I want to make sure that it > doesn't conflict with your new track-macro-expansion patches. It can > also wait until you commit all your patches. [sni

Re: [Patch, testsuite] fix failure in test gcc.dg/vect/slp-perm-8.c

On 25/04/12 15:31, Richard Guenther wrote: > On Wed, Apr 25, 2012 at 4:27 PM, Greta Yorsh wrote: >> Richard Guenther wrote: >>> On Wed, Apr 25, 2012 at 3:34 PM, Greta Yorsh >>> wrote: Richard Guenther wrote: > On Wed, Apr 25, 2012 at 1:51 PM, Greta Yorsh > wrote: >> The test gcc

Re: [PATCH] Take branch misprediction effects into account when RTL loop unrolling (issue6099055)

I think the general mechanism applies to most of the targets. What is needed is target specific parameter (branch budget) tuning which can be done separately -- there exist a way to do that already. David On Wed, Apr 25, 2012 at 2:03 AM, Richard Guenther wrote: > On Tue, Apr 24, 2012 at 11:26 PM

Re: [C] improve missing initializers diagnostics

On 25 April 2012 16:46, H.J. Lu wrote: > On Sat, Apr 21, 2012 at 4:58 AM, Manuel López-Ibáñez > wrote: >> This patch improves missing initializers diagnostics. From: >> >> pr36446.c:13:3: warning: missing initializer [-Wmissing-field-initializers] >>   .h = {1}, >>   ^ >> pr36446.c:13:3: warning:

Re: [PATCH] Default to -gdwarf-4

On 04/25/12 06:47, Jakub Jelinek wrote: > 2012-04-25 Jakub Jelinek > > * common.opt (flag_debug_types_section): Default to 0. > (dwarf_version): Default to 4. > (dwarf_record_gcc_switches): Default to 1. > (dwarf_strict): Default to 0. > * toplev.c (process_options

Re: [RFA] Update config.sub to 2012-04-18 version.

> ChangeLog: > > * config.sub: Update to 2012-04-18 version from official repo. Thanks to everyone who answered. This patch is no in, both GCC & src. -- Joel

Re: [PATCH] Take branch misprediction effects into account when RTL loop unrolling (issue6099055)

On Wed, Apr 25, 2012 at 2:03 AM, Richard Guenther wrote: > On Tue, Apr 24, 2012 at 11:26 PM, Teresa Johnson wrote: >> This patch adds heuristics to limit unrolling in loops with branches that >> may increase >> branch mispredictions. It affects loops that are not frequently iterated, >> and tha

Re: [PATCH] Take branch misprediction effects into account when RTL loop unrolling (issue6099055)

On Tue, Apr 24, 2012 at 6:13 PM, Andi Kleen wrote: > tejohn...@google.com (Teresa Johnson) writes: > >> This patch adds heuristics to limit unrolling in loops with branches that >> may increase >> branch mispredictions. It affects loops that are not frequently iterated, >> and that are >> nested

Re: [PATCH 05/11] Make expand_location resolve to locus in main source file

I have re-based my tree on top of a recent tree that incorporates the changes for caret diagnostics and I had to update this patch accordingly. Here is its new version on trunk of today. It basically updates the new diagnostic_show_locus function to point to spelling locations. The patch does pa

Re: [PATCH] Take branch misprediction effects into account when RTL loop unrolling (issue6099055)

On Tue, Apr 24, 2012 at 4:38 PM, Steven Bosscher wrote: > On Tue, Apr 24, 2012 at 11:26 PM, Teresa Johnson wrote: > >>        * params.def (PARAM_MIN_ITER_UNROLL_WITH_BRANCHES): New param. >>        (PARAM_UNROLL_OUTER_LOOP_BRANCH_BUDGET): Ditto. > > You should add documentation for these new PAR

Re: [PATCH 13/13] Switch -ftrack-macro-expansion=2 on by default.

On Wed, Apr 25, 2012 at 9:33 AM, Dodji Seketeli wrote: > Hopefully closing the series, this patch switches the compiler to > -ftrack-macro-expansion=2 by default. > > Tested and bootstrapped on x86_64-unknown-linux-gnu against trunk. Makes sense to me; Tom? -- Gaby

Re: [PATCH 12/13] Adjust relevant test cases wrt -ftrack-macro-expansion=[0|2]

On Wed, Apr 25, 2012 at 9:16 AM, Dodji Seketeli wrote: > Even after all the patches I have already submitted for this > -ftrack-macro-expansion business, some test cases where errors happens > on tokens that are defined in macros see their output change in an > incompatible way, when you run them

Re: [PATCH 11/13] Fix va_start related location

On Wed, Apr 25, 2012 at 10:20 AM, Dodji Seketeli wrote: > Gabriel Dos Reis writes: > >> On Wed, Apr 25, 2012 at 9:04 AM, Dodji Seketeli wrote: >>> In gcc/testsuite/gcc.dg/pr30457.c, the first warning was not being >>> emitted because the relevant location was inside the var_start macro >>> defin

Re: [PATCH 08/11] Make conversion warnings work on NULL with -ftrack-macro-expansion

OK, thanks! -- Gaby

Re: [PATCH 11/13] Fix va_start related location

Gabriel Dos Reis writes: > On Wed, Apr 25, 2012 at 9:04 AM, Dodji Seketeli wrote: >> In gcc/testsuite/gcc.dg/pr30457.c, the first warning was not being >> emitted because the relevant location was inside the var_start macro >> defined in a system header.  It can even point to a token for a >> bu

[Ada] Atomic protected types

This patch cleans up the implementation of atomic protected types. No changes in behavior. Tested on x86_64-pc-linux-gnu, committed on trunk 2012-04-25 Hristian Kirtchev * exp_ch9.adb: Rename Lock_Free_Sub_Type to Lock_Free_Subprogram. Remove type Subprogram_Id. Rename

Re: Symbol table 13/many: reachability code rewrite

Hi, the fortran problem is caused by fact that fortran does nested funtions that are static constructors. I did not really think of that case in cgraph construction code. Fixed thus. Honza PR middle-end/53089 * cgraphunit.c (cgraph_process_new_functions): Do not enqueue new fun

RE: [Patch, testsuite] fix failure in test gcc.dg/vect/slp-perm-8.c

> -Original Message- > From: Richard Guenther [mailto:richard.guent...@gmail.com] > Sent: 25 April 2012 15:32 > To: Greta Yorsh > Cc: gcc-patches@gcc.gnu.org; mikest...@comcast.net; r...@cebitec.uni- > bielefeld.de; Richard Earnshaw > Subject: Re: [Patch, testsuite] fix failure in test gc

Re: [PATCH 08/11] Make conversion warnings work on NULL with -ftrack-macro-expansion

Gabriel Dos Reis writes: > Thanks. But a point of the suggestion was that we won't need the > same comment/explanation duplicated over at least 3 places. Just > one. All those three places deal exactly with one instance: null > pointer constant. That deserves a function in and of itself, whic

Re: [C] improve missing initializers diagnostics

On Sat, Apr 21, 2012 at 4:58 AM, Manuel López-Ibáñez wrote: > This patch improves missing initializers diagnostics. From: > > pr36446.c:13:3: warning: missing initializer [-Wmissing-field-initializers] >   .h = {1}, >   ^ > pr36446.c:13:3: warning: (near initialization for ‘m0.h.b’) > [-Wmissing-f

Re: [PATCH, tree-optimization] Fix for PR 52868

On Wed, Apr 25, 2012 at 4:32 PM, Igor Zamyatin wrote: > On Wed, Apr 25, 2012 at 1:14 PM, Richard Guenther > wrote: >> On Wed, Apr 25, 2012 at 10:56 AM, Igor Zamyatin wrote: >>> Hi all! >>> >>> I'd like to post for review the patch which makes some costs adjusting >>> in get_computation_cost_at r

[PATCH 13/13] Switch -ftrack-macro-expansion=2 on by default.

Hopefully closing the series, this patch switches the compiler to -ftrack-macro-expansion=2 by default. Tested and bootstrapped on x86_64-unknown-linux-gnu against trunk. libcpp/ * init.c (cpp_create_reader): Switch -ftrack-macro-expansion=2 on by default. Add comments. gcc/doc

Re: [PATCH, tree-optimization] Fix for PR 52868

On Wed, Apr 25, 2012 at 1:14 PM, Richard Guenther wrote: > On Wed, Apr 25, 2012 at 10:56 AM, Igor Zamyatin wrote: >> Hi all! >> >> I'd like to post for review the patch which makes some costs adjusting >> in get_computation_cost_at routine in ivopts part. >> As mentioned in the PR changes also fi

Re: [Patch, testsuite] fix failure in test gcc.dg/vect/slp-perm-8.c

On Wed, Apr 25, 2012 at 4:27 PM, Greta Yorsh wrote: > Richard Guenther wrote: >> On Wed, Apr 25, 2012 at 3:34 PM, Greta Yorsh >> wrote: >> > Richard Guenther wrote: >> >> On Wed, Apr 25, 2012 at 1:51 PM, Greta Yorsh >> >> wrote: >> >> > The test gcc.dg/vect/slp-perm-8.c fails on arm-none-eabi wi

RE: [Patch, testsuite] fix failure in test gcc.dg/vect/slp-perm-8.c

Richard Guenther wrote: > On Wed, Apr 25, 2012 at 3:34 PM, Greta Yorsh > wrote: > > Richard Guenther wrote: > >> On Wed, Apr 25, 2012 at 1:51 PM, Greta Yorsh > >> wrote: > >> > The test gcc.dg/vect/slp-perm-8.c fails on arm-none-eabi with neon > >> enabled: > >> > FAIL: gcc.dg/vect/slp-perm-8.c s

[C++ Patch] PR 53096

Hi, this PR is about the resolution of core/1333 being unimplemented, thus we reject things like: struct foo { foo(foo&) = default; // ERROR HERE }; (and this can be annoying, as explained by Eric on the reflector, for example when one has to resort to out-of-class defaulti

[PATCH 12/13] Adjust relevant test cases wrt -ftrack-macro-expansion=[0|2]

Even after all the patches I have already submitted for this -ftrack-macro-expansion business, some test cases where errors happens on tokens that are defined in macros see their output change in an incompatible way, when you run them with or without -ftrack-macro-expansion. I think this is expect

Re: fix incorrect SRA transformation on non-integral VIEW_CONVERT argument

On Wed, Apr 25, 2012 at 3:37 PM, Olivier Hainque wrote: > Hello, > > For the  "PA(1).Z := 44;" assignment in the attached Ada > testcase, we observe the gcc 4.5 SRA pass performing an > invalid transformation, turning: > >  struct { >    system__pack_48__bits_48 OBJ; >  } D.1432; > >  D.1432.OBJ =

Re: [PATCH 10/13] Fix location for static class members

On Wed, Apr 25, 2012 at 8:55 AM, Dodji Seketeli wrote: > Consider the test case g++.dg/other/offsetof5.C: > >    #include > >    struct A >    { >      char c; >      int &i; >    }; > >    int j = offsetof (A, i);            // { dg-warning "invalid > access|offsetof" } > >    template >    st

Re: [PATCH 11/13] Fix va_start related location

On Wed, Apr 25, 2012 at 9:04 AM, Dodji Seketeli wrote: > In gcc/testsuite/gcc.dg/pr30457.c, the first warning was not being > emitted because the relevant location was inside the var_start macro > defined in a system header.  It can even point to a token for a > builtin macro there.  This patch un

Re: [PATCH 08/11] Make conversion warnings work on NULL with -ftrack-macro-expansion

On Wed, Apr 25, 2012 at 8:42 AM, Dodji Seketeli wrote: > Gabriel Dos Reis writes: > >> On Wed, Apr 11, 2012 at 3:46 AM, Dodji Seketeli wrote: >>> There are various conversion related warnings that trigger on >>> potentially dangerous uses of NULL (or __null).  NULL is defined as a >>> macro in a

[PATCH 11/13] Fix va_start related location

In gcc/testsuite/gcc.dg/pr30457.c, the first warning was not being emitted because the relevant location was inside the var_start macro defined in a system header. It can even point to a token for a builtin macro there. This patch unwinds to the first token in real source code in that case. Test

PATCH: PR debug/52857: DW_OP_GNU_regval_type is generated with INVALID_REGNUM

Hi, We may generate DW_OP_GNU_regval_type with INVALID_REGNUM. This patch adds an assert to make sure that we don't. OK for trunk? Thanks. H.J. --- 2012-04-06 H.J. Lu PR debug/52857 * dwarf2out.c (dbx_reg_number): Assert return value != INVALID_REGNUM. diff --git a

Re: combine_conversions int->double->int

On Wed, 25 Apr 2012, Richard Guenther wrote: On Wed, Apr 25, 2012 at 10:12 AM, Marc Glisse wrote: Hello, a conversion like int->double->int is just the identity, as long as double is big enough to represent all ints exactly. The most natural way I found to do this optimization is the attached

[PATCH 10/13] Fix location for static class members

Consider the test case g++.dg/other/offsetof5.C: #include struct A { char c; int &i; }; int j = offsetof (A, i);// { dg-warning "invalid access|offsetof" } template struct S { T h; T &i; static const int j = offsetof (

Re: [PATCH, PR38785] Throttle PRE at -O3

On Wed, 25 Apr 2012, Maxim Kuvyrkov wrote: > OK. Gerald, does the patch for gcc-4.8/changes.html look OK? Yes, it does, thank you. Just add "a" and "the" in three places, as in "A new option", "the...optimization" and "at the...level" when committing it, please. Cheers, Gerald

Re: [PATCH] Make sizetypes no longer sign-extending

On Tue, 24 Apr 2012, Richard Guenther wrote: > On Tue, 24 Apr 2012, Richard Guenther wrote: > > > > > I've been carrying this patch for quite some while now and really > > want to go forward with it - the problem is that while all default > > languages work fine after this patch Ada shows some t

[PATCH] Default to -gdwarf-4

Hi! For reasonable debugging experience recent GCC versions need GDB >= 7.0 for quite some time, and DWARF4 is almost 2 years old now, and offers lots of improvements over DWARF2 we still default to. So, I'd like to make -gdwarf-4 (just the version, of course -g is needed to enable debug info gen

Re: [PING][Patch, Testsuite] fix failure in test gcc.dg/pr52283.c

On Apr 25, 2012, at 4:52 AM, Richard Guenther wrote: > On Wed, Apr 25, 2012 at 1:40 PM, Greta Yorsh wrote: >> PING! Here is the original post: >> http://gcc.gnu.org/ml/gcc-patches/2012-04/msg01235.html >> >> This patch fixes the failure in gcc.dg/pr52283.c by adding the missing >> dg-warning and

Re: [PATCH 08/11] Make conversion warnings work on NULL with -ftrack-macro-expansion

Gabriel Dos Reis writes: > On Wed, Apr 11, 2012 at 3:46 AM, Dodji Seketeli wrote: >> There are various conversion related warnings that trigger on >> potentially dangerous uses of NULL (or __null).  NULL is defined as a >> macro in a system header, so calling warning or warning_at on a virtual >

fix incorrect SRA transformation on non-integral VIEW_CONVERT argument

Hello, For the "PA(1).Z := 44;" assignment in the attached Ada testcase, we observe the gcc 4.5 SRA pass performing an invalid transformation, turning: struct { system__pack_48__bits_48 OBJ; } D.1432; D.1432.OBJ = D.1435; T1b.F = VIEW_CONVERT_EXPR(D.1432); into: SR.12_17 = D.143

[PATCH] Fix testsuite fallout of last patch

Committed, tested on x86_64-unknown-linux-gnu. Richard. 2012-04-25 Richard Guenther * gcc.target/i386/l_fma_float_5.c: Adjust. * gcc.target/i386/l_fma_double_4.c: Likewise. * gcc.target/i386/l_fma_float_2.c: Likewise. * gcc.target/i386/l_fma_float_6.c: Likewis

Re: [PATCH] reload: Try alternative with swapped operands before going to the next

Andreas Krebbel wrote: > 2011-11-17 Andreas Krebbel > > * reload.c (find_reloads): Change the loop nesting when trying an > alternative with swapped operands. This is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE ulrich.weig...@d

Re: PowerPC prologue and epilogue 6

On Wed, Apr 25, 2012 at 1:20 AM, Alan Modra wrote: > This patch adds a testcase to verify register saves and restores. > I tried to write it so that it will run on all powerpc targets.  From > past experience it probably won't.  OK to apply anyway, and fix > fallout later? > >        * gcc.target

Re: PR c/53066 Wshadow should not warn for shadowing an extern function

On Wed, Apr 25, 2012 at 6:54 AM, Joseph S. Myers wrote: > On Wed, 25 Apr 2012, Manuel López-Ibáñez wrote: > >> On 25 April 2012 00:01, Joseph S. Myers wrote: >> > On Sun, 22 Apr 2012, Manuel López-Ibáñez wrote: >> > >> >> Wshadow warns whenever any declaration shadows a global function >> >> decl

Re: PR c/53066 Wshadow should not warn for shadowing an extern function

On Wed, Apr 25, 2012 at 5:36 AM, Manuel López-Ibáñez wrote: > On 25 April 2012 00:01, Joseph S. Myers wrote: >> On Sun, 22 Apr 2012, Manuel López-Ibáñez wrote: >> >>> Wshadow warns whenever any declaration shadows a global function >>> declaration. This is almost always noise, since most (always?

Re: [Patch, testsuite] fix failure in test gcc.dg/vect/slp-perm-8.c

On Wed, Apr 25, 2012 at 1:51 PM, Greta Yorsh wrote: > The test gcc.dg/vect/slp-perm-8.c fails on arm-none-eabi with neon enabled: > FAIL: gcc.dg/vect/slp-perm-8.c scan-tree-dump-times vect "vectorized 1 > loops" 2 > > The test expects 2 loops to be vectorized, while gcc successfully vectorizes > 3

Re: [PATCH] Fix bitfield expansion (PR middle-end/52979)

On Wed, 25 Apr 2012, Jakub Jelinek wrote: > Hi! > > This patch fixes the attached execute/ testcases. In some cases > get_best_mode was ignoring bitregion_* restrictions and returned > mode that overlapped into adjacent non-bitfields, or store_bit_field_1 > for insv could ignore those restrictio

Re: PR c/53066 Wshadow should not warn for shadowing an extern function

On Wed, 25 Apr 2012, Manuel López-Ibáñez wrote: > On 25 April 2012 00:01, Joseph S. Myers wrote: > > On Sun, 22 Apr 2012, Manuel López-Ibáñez wrote: > > > >> Wshadow warns whenever any declaration shadows a global function > >> declaration. This is almost always noise, since most (always?) of the

Re: [PING][Patch, Testsuite] fix failure in test gcc.dg/pr52283.c

On Wed, Apr 25, 2012 at 1:40 PM, Greta Yorsh wrote: > PING! Here is the original post: > http://gcc.gnu.org/ml/gcc-patches/2012-04/msg01235.html > > This patch fixes the failure in gcc.dg/pr52283.c by adding the missing > dg-warning and dg-options. > > OK for trunk? Didn't I approve this already?

Re: Continue strict-volatile-bitfields fixes

On Wed, Apr 25, 2012 at 1:27 PM, Thomas Schwinge wrote: > Hi! > > On Thu, 19 Apr 2012 19:46:17 +0200, I wrote: >> Here is my current test case, reduced from gcc.dg/tree-ssa/20030922-1.c: >> >>     extern void abort (void); >> >>     enum tree_code >>     { >>       BIND_EXPR, >>     }; >>     stru

[Patch, testsuite] fix failure in test gcc.dg/vect/slp-perm-8.c

The test gcc.dg/vect/slp-perm-8.c fails on arm-none-eabi with neon enabled: FAIL: gcc.dg/vect/slp-perm-8.c scan-tree-dump-times vect "vectorized 1 loops" 2 The test expects 2 loops to be vectorized, while gcc successfully vectorizes 3 loops in this test using neon on arm. This patch adjusts the ex

[PATCH] Fix bitfield expansion (PR middle-end/52979)

Hi! This patch fixes the attached execute/ testcases. In some cases get_best_mode was ignoring bitregion_* restrictions and returned mode that overlapped into adjacent non-bitfields, or store_bit_field_1 for insv could ignore those restrictions completely. After fixing that I've run into several

Re: [rfc] PR tree-optimization/52633 - ICE due to vectorizer pattern detection collision

Richard Guenther wrote: > On Tue, 24 Apr 2012, Ulrich Weigand wrote: > > Does this look reasonable? Any comments or suggestions appreciated! > > Yes, getting rid of this fragile interaction by doing more work in > vect_recog_widen_shift_pattern sounds like the correct thing to do. OK, I'll try t

Re: [PR tree-optimization/52558]: RFC: questions on store data race

On Tue, Apr 24, 2012 at 7:43 PM, Aldy Hernandez wrote: > On 04/13/12 03:46, Richard Guenther wrote: >> >> On Fri, Apr 13, 2012 at 12:11 AM, Aldy Hernandez  wrote: > > > Richard.  Thanks so much for reviewing and providing an alternative > approach, which AFAICT provides superior results. > > >> A

Re: [rfc] PR tree-optimization/52633 - ICE due to vectorizer pattern detection collision

Jakub Jelinek wrote: > On Wed, Apr 25, 2012 at 10:29:36AM +0200, Richard Guenther wrote: > > > Does this look reasonable? Any comments or suggestions appreciated! > > > > Yes, getting rid of this fragile interaction by doing more work in > > vect_recog_widen_shift_pattern sounds like the correct

  1   2   >