Re: debug insns in SMS

2012-04-08 Thread Alexandre Oliva
On May 4, 2011, Revital1 Eres wrote: > Hello Alexandre >> I think this will restore proper functioning to SMS in the presence of >> debug insns. A while ago, we'd never generate deps of non-debug insns >> on debug insns. I introduced them to enable sched to adjust (reset) >> debug insns when n

Re: don't force debug insns after their PREV_INSNs

2012-04-08 Thread Alexandre Oliva
On Jun 3, 2011, Bernd Schmidt wrote: > On 06/03/2011 04:47 PM, Alexandre Oliva wrote: >> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=677681 can be >> “fixed” by disabling the artificial dependency of a debug insn on its >> previous insn. >> >> Debug insns will often depend on their pre

Re: fix incorrect debug temp added by df-problems

2012-04-08 Thread Alexandre Oliva
On Oct 27, 2011, Alexandre Oliva wrote: > pr43165.c -Os -g exercises a bug in df-problems WRT the introduction of > debug temps. After pro_and_epilogue, the function was optimized to this: > push bp > mov bp,sp > # debug insn referencing bp > pop bp > I don't know why we bother to preserve and

Re: [PATCH] Fix ICE in expand_cse_reciprocals (PR tree-optimization/42078)

2012-04-08 Thread Alexandre Oliva
On Jun 3, 2011, Alexandre Oliva wrote: > According to http://gcc.gnu.org/ml/gcc-patches/2009-11/msg01082.html > on Nov 20, 2009, Alexandre Oliva wrote: >> On Nov 19, 2009, Richard Guenther wrote: >>> In fact this exchanging of the LHS (or rather invalidating of the >>> SSA name value) should

[PR 50826] [DF] no debug temps for artificial uses

2012-04-08 Thread Alexandre Oliva
This patch is a small improvement to DF, for an issue I noticed while investigating PR 50826. We take note of, and may emit debug temps for, REGs for which we won't emit REG_DEAD/REG_UNUSED notes. This is a waste, removed with this patch. Regstrapped on x86_64-linux-gnu and i686-linux-gnu. Ok t

Re: fix left-over debug insns in DCE

2012-04-08 Thread Alexandre Oliva
On Jun 6, 2011, Alexandre Oliva wrote: > On Jun 6, 2011, Eric Botcazou wrote: >>> It might be too late for DF to do anything sensible to preserve the >>> debug info rather than just throw it away, as your partial approval >>> suggests. >> OK, let me think about this a little more. Ping? > H

Re: [PR48866] three alternative fixes

2012-04-08 Thread Alexandre Oliva
On Jun 2, 2011, Alexandre Oliva wrote: > On May 30, 2011, Alexandre Oliva wrote: >> On May 30, 2011, Alexandre Oliva wrote: >>> I have 3 different, mutually exclusive patches that fix PR 48866. The >>> problem is exponential time while dealing with an expression that >>> resulted from a long

Re: [trunk<-vta] Re: [vtab] Permit coalescing of user variables

2012-04-08 Thread Alexandre Oliva
Ping? (Updated with improved docs; should the options be renamed to -ftree-copyrename-* to match the option that covers the entire pass?) On Jun 4, 2011, Alexandre Oliva wrote: > On Oct 13, 2009, Alexandre Oliva wrote: >> On Jun 1, 2009, Alexandre Oliva wrote: >>> A long time ago, when vari

[PR51570] minimize ENTRY_VALUEs in debug location lists

2012-04-08 Thread Alexandre Oliva
gcc.dg/guality/pr45003-*.c have regressed with reordering of the exploration of the loc expansion space, in a way that didn't always privilege expansions without ENTRY_VALUEs over ones with it. This patch fixes it, by ensuring that we'll only ever use ENTRY_VALUEs if we can't help it given a maxim

Re: [PATCH] Caret diagnostics

2012-04-08 Thread Jason Merrill
On 04/08/2012 12:13 PM, Manuel López-Ibáñez wrote: To focus on the issue at hand, and independently of whether any bugs exist or not, and whether I am capable or not to fix them. What you are proposing is to change the current default of no line-wrapping to line-wrap at getenv("COLUMNS"), isn't i

Re: [SH] Fold big/little endian word code with MSW and LSW

2012-04-08 Thread Oleg Endo
On Fri, 2012-04-06 at 23:53 +0200, Oleg Endo wrote: > On Fri, 2012-04-06 at 10:46 +0900, Kaz Kojima wrote: > > From: Oleg Endo > > >> Exposing three-letter macro MSW and LSW globally looks not > > >> a good idea to me. > > > > > > Would 'HIGH_WORD' and 'LOW_WORD' be OK as an alternative? > > > >

__cxa_guard_acquire memory barriers

2012-04-08 Thread Alan Modra
Recently I was hunting for bugs in __cxa_guard_acquire/release that might result in pr52839. No bugs found, but I did notice that these functions use excessive memory barriers, no doubt from their conversion from sync to atomic builtins. Making the second __atomic_compare_exchange_n in __cxa_guar

[committed] Fix comment in tree-pretty-printer.h

2012-04-08 Thread Manuel López-Ibáñez
Committed as obvious. I wasn't sure if one should move the declaration to c-pretty-printer.h, but updating the comment cannot make any harm. (And why default_tree_printer is in toplev.c?) Index: gcc/tree-pretty-print.h === --- gcc/tr

Re: [SH] Document constraints, remove unused Sr0 constraint

2012-04-08 Thread Kaz Kojima
Oleg Endo wrote: > The attached patch updates the top comment block in constraints.md and > removes the unused Sr0 constraint. > Tested with 'make all-gcc'. > > OK? OK. Regards, kaz

Re: PATCH: Add OPTION_MASK_ISA_X86_64 and support TARGET_BI_ARCH == 2

2012-04-08 Thread Iain Sandoe
On 8 Apr 2012, at 15:54, H.J. Lu wrote: Despite the fact that bootstrap is restored, there remain problems with this patch and some more work is needed. (a) [trivial] the option 'mx32' is in i386.opt, which means it is exposed to all sub-targets, even if they don't support it. $ ./gcc/xgc

Re: [PATCH] Caret diagnostics

2012-04-08 Thread Gabriel Dos Reis
On Sun, Apr 8, 2012 at 11:52 AM, Manuel López-Ibáñez wrote: > On 8 April 2012 18:35, Gabriel Dos Reis wrote: >> On Sun, Apr 8, 2012 at 11:13 AM, Manuel López-Ibáñez >> wrote: >>> On 8 April 2012 06:09, Jason Merrill wrote: On 04/07/2012 06:29 PM, Manuel López-Ibáńez wrote: > +gete

Re: [PATCH, RFC] Extend __attribute__((format)) with user-specified conversion sequences

2012-04-08 Thread Mike Stump
On Apr 8, 2012, at 3:25 AM, Joseph S. Myers wrote: > In principle we want extensibility of format checking, and want it to be > as flexible as the built-in checking is regarding the peculiarities of > different formats - but we also don't want to export implementation > details of format checkin

Re: [PATCH] Caret diagnostics

2012-04-08 Thread Manuel López-Ibáñez
On 8 April 2012 18:35, Gabriel Dos Reis wrote: > On Sun, Apr 8, 2012 at 11:13 AM, Manuel López-Ibáñez > wrote: >> On 8 April 2012 06:09, Jason Merrill wrote: >>> On 04/07/2012 06:29 PM, Manuel López-Ibáńez wrote: >>> +getenv_columns (void) >>> >>> >>> I had been thinking to check COLUMNS on

Re: [PATCH] Caret diagnostics

2012-04-08 Thread Gabriel Dos Reis
On Sun, Apr 8, 2012 at 11:13 AM, Manuel López-Ibáñez wrote: > On 8 April 2012 06:09, Jason Merrill wrote: >> On 04/07/2012 06:29 PM, Manuel López-Ibáńez wrote: >> >>> +getenv_columns (void) >> >> >> I had been thinking to check COLUMNS once at the beginning of compilation; I >> don't think the va

Re: [PATCH] Caret diagnostics

2012-04-08 Thread Gabriel Dos Reis
On Sun, Apr 8, 2012 at 11:10 AM, Manuel López-Ibáñez wrote: > On 8 April 2012 17:14, Gabriel Dos Reis wrote: >> On Sun, Apr 8, 2012 at 7:06 AM, Manuel López-Ibáñez >> wrote: >>> On 8 April 2012 06:09, Jason Merrill wrote: On 04/07/2012 06:29 PM, Manuel López-Ibáńez wrote: > > I'll

Re: [PATCH] Caret diagnostics

2012-04-08 Thread Manuel López-Ibáñez
On 8 April 2012 06:09, Jason Merrill wrote: > On 04/07/2012 06:29 PM, Manuel López-Ibáńez wrote: > >> +getenv_columns (void) > > > I had been thinking to check COLUMNS once at the beginning of compilation; I > don't think the value can change while the compiler is running since we > don't respond

Re: [PATCH] Caret diagnostics

2012-04-08 Thread Manuel López-Ibáñez
On 8 April 2012 17:14, Gabriel Dos Reis wrote: > On Sun, Apr 8, 2012 at 7:06 AM, Manuel López-Ibáñez > wrote: >> On 8 April 2012 06:09, Jason Merrill wrote: >>> On 04/07/2012 06:29 PM, Manuel López-Ibáńez wrote: I'll be happy to change it to whatever is more understandable. I think >>>

Re: [PATCH] Caret diagnostics

2012-04-08 Thread Gabriel Dos Reis
On Sun, Apr 8, 2012 at 7:06 AM, Manuel López-Ibáñez wrote: > On 8 April 2012 06:09, Jason Merrill wrote: >> On 04/07/2012 06:29 PM, Manuel López-Ibáńez wrote: >>> >>> I'll be happy to change it to whatever is more understandable. I think >>> in CSS is called "padding". >> >> >> That wouldn't be a

Re: PATCH: Add OPTION_MASK_ISA_X86_64 and support TARGET_BI_ARCH == 2

2012-04-08 Thread H.J. Lu
On Sun, Apr 8, 2012 at 4:38 AM, Iain Sandoe wrote: > Hi H.J. > > > On 31 Mar 2012, at 20:24, Jack Howarth wrote: >> >> >>  The latest gcc-pr52784-2.patch patch also allows current gcc trunk to >> bootstrap on i386-apple-darwin10. > > > Despite the fact that bootstrap is restored, there remain prob

Re: Support for Runtime CPU type detection via builtins (issue5754058)

2012-04-08 Thread Gerald Pfeifer
On Thu, 29 Mar 2012, Sriraman Tallam wrote: > Hi, > > I have made a new patch to only have two builtins : > > * __builtin_cpu_is ("") > * __builtin_cpu_supports ("") > > apart from the cpu init builtin, __builtin_cpu_init. I don't see any .texi file as part of this change. Shouldn't this b

Re: [PATCH] Caret diagnostics

2012-04-08 Thread Manuel López-Ibáñez
On 8 April 2012 06:09, Jason Merrill wrote: > On 04/07/2012 06:29 PM, Manuel López-Ibáńez wrote: >> >> I'll be happy to change it to whatever is more understandable. I think >> in CSS is called "padding". > > > That wouldn't be any clearer; my confusion was that I thought you were > padding the ri

Re: PATCH: Add OPTION_MASK_ISA_X86_64 and support TARGET_BI_ARCH == 2

2012-04-08 Thread Iain Sandoe
Hi H.J. On 31 Mar 2012, at 20:24, Jack Howarth wrote: The latest gcc-pr52784-2.patch patch also allows current gcc trunk to bootstrap on i386-apple-darwin10. Despite the fact that bootstrap is restored, there remain problems with this patch and some more work is needed. (a) [trivial]

[SH] Document constraints, remove unused Sr0 constraint

2012-04-08 Thread Oleg Endo
Hi, The attached patch updates the top comment block in constraints.md and removes the unused Sr0 constraint. Tested with 'make all-gcc'. OK? Cheers, Oleg ChangeLog: * config/sh/constraints.md: Update list of constraints in comment block. (Sr0): Remove unused memory co

Re: [PATCH, RFC] Extend __attribute__((format)) with user-specified conversion sequences

2012-04-08 Thread Joseph S. Myers
On Sat, 31 Mar 2012, Eddie Kohler wrote: > The syntax is very simple. The extra argument, an even-length C string > constant, is interpreted as a set of character pairs. For example, "<%" says > "interpret the character '<' like you would '%'": as a conversion specifier > that consumes no argument