Re: [google] fix for undefined location list symbol in LIPO (issue5355042)

2011-11-04 Thread Cary Coutant
>> 2011-11-04   Rong Xu   >> >>        * gcc/dwarf2out.c (dwarf2out_decl): not emit type info >>          for unreachable functions in LIPO mode. Here's a follow-on patch to fix the build breakage caused by the declaration in the middle of a block. It also fixes up the style complaints that Diego

[commited, rtems] Sync gcc/config/rs6000/*rtems* with RTEMS-gcc

2011-11-04 Thread Ralf Corsepius
Hi, I have applied the 2 patches below to gcc-svn/trunk. They contain what RTEMS has been using for its powerpc target for some time. Ralf 2011-11-05 Ralf Corsépius * config/rs6000/t-rtems: Add -mcpu=8540/-mfloat-gprs=double multilib. Remove -mcpu=601 multilib. Remo

Re: New port^2: Renesas RL78

2011-11-04 Thread DJ Delorie
> > (define_expand "zero_extendqihi2" > > [(set (match_operand:HI 0 "nonimmediate_operand") > > (zero_extend:HI (match_operand:QI 1 "general_operand")))] > > "" > > "if (rl78_force_nonfar_2 (operands, gen_zero_extendqihi2)) > > DONE;" > > ) > > You should be a

Re: New port^2: Renesas RL78

2011-11-04 Thread Richard Henderson
> (define_expand "zero_extendqihi2" > [(set (match_operand:HI 0 "nonimmediate_operand") > (zero_extend:HI (match_operand:QI 1 "general_operand")))] > "" > "if (rl78_force_nonfar_2 (operands, gen_zero_extendqihi2)) > DONE;" > ) You should be able to simply rl78_

[PATCH,libgcc,avr-rtems] Filter out _exit

2011-11-04 Thread Ralf Corsepius
Hi, avr-rtems uses _exit from newlib and therefore filter out _exit from LIB1ASMFUNCS. I intend to commit the patch below, which is supposed to be a port of what RTEMS had used in gcc/config/avr/t-rtems in gcc < 4.7. Ralf 2011-11-05 Ralf Corsépius * config.host (avr-*-rtems*):

C++ PATCH for c++/26714 (lifetime of temps in mem-initializers for reference members)

2011-11-04 Thread Jason Merrill
After my previous patch for 48370 which adds extend_ref_init_temps, it is straightforward to fix this issue as well by extending ref init mem-initializers to match the lifetime of 'this'. Tested x86_64-pc-linux-gnu, applying to trunk. commit 30ed5835a92df18afef71802b5fa95899ceca227 Author: Jaso

Re: C++ PATCH for c++/48370 (extending lifetime of temps in aggregate initialization)

2011-11-04 Thread Jason Merrill
While working on a followup, I noticed that this patch runs temporary cleanups in the wrong order. Fixed (and tested) thus. Tested x86_64-pc-linux-gnu, applying to trunk. commit 376093f30953db1fc7b4537f7ca9253dea91c8a3 Author: Jason Merrill Date: Fri Nov 4 16:32:47 2011 -0400 PR c++/48

Re: PATCH: Add capability to contrib/compare_tests to handle directories

2011-11-04 Thread Quentin Neill
On Wed, Nov 2, 2011 at 12:32 PM, Quentin Neill wrote: > On Tue, Oct 4, 2011 at 4:57 PM, Mike Stump wrote: >> On Oct 4, 2011, at 2:37 PM, Quentin Neill wrote: >>> Ping? >> >> The problem with this patch is it reorders the listing so that lower >> priority things are after higher priority things.

[commited] Add custom RTEMS lm32 multilibs

2011-11-04 Thread Ralf Corsepius
Hi, I applied the patch below to SVN-trunk. We've been using it for the RTEMS toolchains for several months. Ralf 2011-11-05 Ralf Corsépius * config/lm32/t-rtems: New. * config.gcc (lm32-*-rtems*): Add t-rtems. Index: gcc/config.gcc

Re: [patch] 19/n: trans-mem: compiler tree/gimple stuff

2011-11-04 Thread Richard Henderson
On 11/04/2011 07:36 PM, Richard Henderson wrote: > On 11/04/2011 03:36 AM, Richard Guenther wrote: +case GIMPLE_TRANSACTION: + return (weights->tm_cost + + estimate_num_insns_seq (gimple_transaction_body (stmt), + weight

Re: serious libgcc regression added recently

2011-11-04 Thread David Miller
From: Jakub Jelinek Date: Thu, 3 Nov 2011 09:22:51 +0100 > I think much better would be to handle sparc*/s390*/powerpc* differently > here, just using #ifdef __LP64__ test. i?86/x86_64 is different because > of the third weirdo multilib option. I just tested and committed the following, it seem

Re: [patch] 19/n: trans-mem: compiler tree/gimple stuff

2011-11-04 Thread Richard Henderson
On 11/04/2011 03:36 AM, Richard Guenther wrote: >> > +case GIMPLE_TRANSACTION: >> > + return (weights->tm_cost >> > + + estimate_num_insns_seq (gimple_transaction_body (stmt), >> > + weights)); >> > + > Huh, so we now have non-lowered gimpl

Re: [patch] 19/n: trans-mem: compiler tree/gimple stuff

2011-11-04 Thread Richard Henderson
On 11/04/2011 04:53 PM, Aldy Hernandez wrote: >> Why is it necessary to know whether a clone is a tm clone? > > How do you mean? First, there are a few pretty printing places where we dump > that a function is a clone. It is easy to debug dumps when you know which > function is the clone and w

Re: [trans-mem] Avoid ICE with transaction expressions vs constant expressions.

2011-11-04 Thread Richard Henderson
On 11/04/2011 05:54 PM, Paolo Carlini wrote: > ... isn't translated correctly. Maybe better wrapping the strings in G_(). Ah, right. Fixed here, and the place I copied it from. r~ diff --git a/gcc/cp/parser.c b/gcc/cp/parser.c index 7a7cfe8..b6ac918 100644 --- a/gcc/cp/parser.c +++ b/gcc/cp/par

Re: RFA: Add Epiphany port

2011-11-04 Thread Joern Rennecke
Quoting Richard Henderson : Look much closer. These patterns are 100% identical. The *move_frame_1 pattern will _never_ be matched, because such an insn will always be matched by move_frame. move_frame only matches if: operands[1] == frame_pointer_rtx || operands[1] == arg_pointer_rtx mov

Re: [CRIS] Convert CRIS to constraints.md

2011-11-04 Thread Hans-Peter Nilsson
> From: Anatoly Sokolov > Date: Wed, 2 Nov 2011 20:37:12 +0100 > Comments? OK to install? > > * config/cris/constraints.md: New file. Whee! > * config/cris/cris.h (REG_CLASS_FROM_LETTER, CONSTRAINT_LEN, > CRIS_CONST_OK_FOR_LETTER_P, CONST_OK_FOR_CONSTRAINT_P, >

TARGET_FRAME_POINTER_REQUIRED (Was: Re: RFA: Add Epiphany port)

2011-11-04 Thread Joern Rennecke
Quoting Richard Henderson : static bool epiphany_frame_pointer_required (void) { return cfun->calls_alloca; Isn't this automatic? Only if EXIT_IGNORE_STACK is nonzero; it's zero for epiphany. But I think I can change that.

Re: P.S.: Re: RFA: Add Epiphany port

2011-11-04 Thread Richard Henderson
On 11/04/2011 05:40 PM, Joern Rennecke wrote: > Actually, it's not that simple. The not:SI operaration can be generated > by combine. But it won't generate (xor:SI (reg:SI foo) (const_int -1)) . > > So I need one_cmplsi2_i as combiner pattern no matter what. Oh, right. I forgot about combine n

Re: [trans-mem] Avoid ICE with transaction expressions vs constant expressions.

2011-11-04 Thread Paolo Carlini
Hi, There we actually two ICEs here -- one with -fgnu-tm that Torvald pointed me at, and one without -fgnu-tm that I of course stumbled upon while fumble-fingering the command-line to test the thing. Committed to branch. I believe that this: +error (keyword == RID_TRANSACTION_RELAXED +

P.S.: Re: RFA: Add Epiphany port

2011-11-04 Thread Joern Rennecke
Quoting Joern Rennecke : Quoting Richard Henderson : >>> (define_expand "one_cmplsi2" ... Why not combine these? I'm pretty sure that expand_binop will try the xor solution all on its own. Actually, it's expand_unop, and it doesn't. Left to its own devices, it will generate a libcall i

[trans-mem] Avoid ICE with transaction expressions vs constant expressions.

2011-11-04 Thread Richard Henderson
There we actually two ICEs here -- one with -fgnu-tm that Torvald pointed me at, and one without -fgnu-tm that I of course stumbled upon while fumble-fingering the command-line to test the thing. Committed to branch. r~ * cp/parser.c (enum non_integral_constant): Add NIC_TRANSACTION

Re: RFA: Add Epiphany port

2011-11-04 Thread Richard Henderson
On 11/04/2011 05:00 PM, Joern Rennecke wrote: >>> (define_insn_and_split "move_frame" >>> [(set (match_operand:SI 0 "gpr_operand" "=r") >>> (match_operand:SI 1 "register_operand" "r")) >>>(clobber (reg:CC CC_REGNUM))] >>> "operands[1] == frame_pointer_rtx || operands[1] == arg_point

Re: [rs6000] Fix PR 50906, eh_frame and other woes

2011-11-04 Thread Alan Modra
On Fri, Nov 04, 2011 at 06:19:07PM +, Iain Sandoe wrote: > I did wonder, when implementing the out-of-line saves for Darwin, > whether the setting in sysv4.h is a bit optimistic in firing for r31 > when -Os is on. > > whether it saves space, in reality, would presumably depend on > whether bra

Re: RFA: Add Epiphany port

2011-11-04 Thread Joern Rennecke
Quoting Richard Henderson : (define_special_predicate "any_gpr_operand" (match_code "subreg,reg") { return gpr_operand (op, mode); }) (define_special_predicate "any_gpr_operand" (match_operand 0 "gpr_operand")) though, I'm not sure what this achieves... while any_gpr_operand will ignor

Re: [patch] 19/n: trans-mem: compiler tree/gimple stuff

2011-11-04 Thread Aldy Hernandez
Richard, I am going to address your suggestions in pieces, with individual patchsets, so we can tackle the less trivial bits in separate patches. So don't worry, I'm not forgetting the rest your suggestions. Below I will address what I fix with this patch. +/* Nonzero in a FUNCTION_DECL mean

Re: increase call_saved_regs[] in caller-save.c

2011-11-04 Thread DJ Delorie
> The only way I can think of to have two pseudos assigned the same > hard reg at the same point in the insn stream is if the two pseudos > are known to have the same value. Since all we're doing is figuring out which hard regs need to be saved in pro/epilogue, it could be that the two pseudos ar

Go patch committed: Fix select case

2011-11-04 Thread Ian Lance Taylor
The Go frontend was miscompiling select { case v, ok := <- c: // v and ok had the wrong values here } This patch fixes the problem. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Many things to Aram Hăvărneanu who ver

Re: [patch] 17/n: trans-mem: compiler trans-mem main engine

2011-11-04 Thread Richard Henderson
On 11/04/2011 02:48 PM, Torvald Riegel wrote: > Removed unnecessary includes. > > * trans-mem.c: Removed unnecessary includes. Ok. r~

Re: [PATCH] Don't prevent merging of bbs because of user labels (PR tree-optimization/50693)

2011-11-04 Thread Richard Guenther
On Fri, Nov 4, 2011 at 9:38 PM, Jakub Jelinek wrote: > Hi! > > As has been suggested by Alexandre in the PR, this patch allows merging > basic blocks which couldn't be merged before because of user (non-forced) > labels at the beginning of the second basic blocks. > With this patch the user label

Re: [patch] 14/n: trans-mem: compiler documentation

2011-11-04 Thread Richard Henderson
On 11/04/2011 03:20 PM, Torvald Riegel wrote: > Better with the attached patch? Also mentions that these hooks are for > transactions. OK for branch? Ok. r~

Re: [PATCH Atom] Fix for PR target/50962 (bad AGU stall avoidance)

2011-11-04 Thread Richard Henderson
> + if (!TARGET_OPT_AGU || optimize_function_for_size_p (cfun)) Surely optimize_insn_for_size_p (), so that cold blocks are optimized for size. > + else if (ix86_use_lea_for_mov(insn, operands)) > + return "lea{q}\t{%a1, %0|%0, %a1}"; We're now getting the insn type and thus length wro

Re: [patch] 14/n: trans-mem: compiler documentation

2011-11-04 Thread Torvald Riegel
On Thu, 2011-11-03 at 20:24 +, Joseph S. Myers wrote: > On Thu, 3 Nov 2011, Aldy Hernandez wrote: > > > Index: gcc/doc/tm.texi.in > > === > > --- gcc/doc/tm.texi.in (.../trunk) (revision 180744) > > +++ gcc/doc/tm.texi.in

Re: [patch] 17/n: trans-mem: compiler trans-mem main engine

2011-11-04 Thread Joseph S. Myers
On Fri, 4 Nov 2011, Torvald Riegel wrote: > On Thu, 2011-11-03 at 20:38 +, Joseph S. Myers wrote: > > Make sure that you do need each #include present in this and any other new > > file. Since 2008 a lot of includes of tm.h and toplev.h have been removed > > and diagnostic-core.h introduced

Re: [PATCH Atom] Fix for PR target/50962 (bad AGU stall avoidance)

2011-11-04 Thread Ilya Enkovich
2011/11/3 Uros Bizjak : > Hello! > >> Here is a fix for PR 50962. Fix improves AGU stall avoidance >> optimization by adding opportunity to emit lea instead of mov when it >> is profitable. >> >> 2011-11-03  Enkovich Ilya   >> >>       PR target/50962 >>       * config/i386/i386-protos.h (ix86_use_

Re: cxx-mem-model merge [8 of 9] testsuite - gomp

2011-11-04 Thread Andrew MacLeod
On 11/04/2011 05:45 PM, Richard Henderson wrote: * gcc.dg/gomp/atomic-11.c: Remove test. Done. Andrew

Re: [patch] 15/n: trans-mem: compiler C++ changes

2011-11-04 Thread Richard Henderson
On 11/04/2011 01:59 PM, Jason Merrill wrote: > Right, my point is that the comment before > cp_parser_transaction_expression refers to compound_statement, which > seems wrong. > > ...because the compound-statement variant is handled in cp_parser_transaction. Oh, duh. I was so focused on the attr

Re: [patch] 17/n: trans-mem: compiler trans-mem main engine

2011-11-04 Thread Torvald Riegel
On Thu, 2011-11-03 at 20:38 +, Joseph S. Myers wrote: > Make sure that you do need each #include present in this and any other new > file. Since 2008 a lot of includes of tm.h and toplev.h have been removed > and diagnostic-core.h introduced as an alternative to diagnostic.h for > many user

Re: cxx-mem-model merge [8 of 9] testsuite - gomp

2011-11-04 Thread Richard Henderson
On 11/04/2011 01:53 PM, Jakub Jelinek wrote: > On Thu, Nov 03, 2011 at 07:51:05PM -0400, Andrew MacLeod wrote: >> These are the changed rth made to the GOMP testsuite.. looks >> primarily like consolidation to c-c++-common from 2 other >> directories. > > It seems gcc.dg/gomp/atomic-11.c has been

Re: cxx-mem-model merge [3 of 9] doc

2011-11-04 Thread Andrew MacLeod
On 11/04/2011 04:34 PM, Joseph S. Myers wrote: Likewise. I think I got all those, plus a couple of more I noticed along the way. * doc/extend.texi: Document __atomic built-in functions. * doc/invoke.texi: Document data race parameters. * doc/md.texi: Document atomic p

Re: [patch] 15/n: trans-mem: compiler C++ changes

2011-11-04 Thread Jason Merrill
On 11/04/2011 04:56 PM, Jason Merrill wrote: On 11/04/2011 04:14 PM, Richard Henderson wrote: On 11/04/2011 12:26 PM, Jason Merrill wrote: On 11/04/2011 03:23 PM, Richard Henderson wrote: (cp_parser_transaction_expression): Don't parse txn-attributes here. There's also the issue that the gra

Re: [patch] 15/n: trans-mem: compiler C++ changes

2011-11-04 Thread Jason Merrill
On 11/04/2011 04:14 PM, Richard Henderson wrote: On 11/04/2011 12:26 PM, Jason Merrill wrote: On 11/04/2011 03:23 PM, Richard Henderson wrote: (cp_parser_transaction_expression): Don't parse txn-attributes here. There's also the issue that the grammar uses compound-statement, whereas the

Re: cxx-mem-model merge [8 of 9] testsuite - gomp

2011-11-04 Thread Jakub Jelinek
On Thu, Nov 03, 2011 at 07:51:05PM -0400, Andrew MacLeod wrote: > These are the changed rth made to the GOMP testsuite.. looks > primarily like consolidation to c-c++-common from 2 other > directories. It seems gcc.dg/gomp/atomic-11.c has been dropped without replacement, instead of being moved.

[PATCH] Don't prevent merging of bbs because of user labels (PR tree-optimization/50693)

2011-11-04 Thread Jakub Jelinek
Hi! As has been suggested by Alexandre in the PR, this patch allows merging basic blocks which couldn't be merged before because of user (non-forced) labels at the beginning of the second basic blocks. With this patch the user label is thrown away (for -g0 or -g -fno-var-tracking-assignments) or

Re: cxx-mem-model merge [3 of 9] doc

2011-11-04 Thread Joseph S. Myers
On Fri, 4 Nov 2011, Andrew MacLeod wrote: > + GCC will allow any integral scalar or pointer type that is 1, 2, 4, or 8 > + bytes in length. 16 bytes integral types are also allowed if "16 bytes" appears to be used as an adjective; "16-byte" would be better. > + @samp{__int128_t} is supported by

PATCH: Check HARD_FRAME_POINTER_REGNUM instead of hard_frame_pointer_rtx in dwarf2out_frame_debug_expr

2011-11-04 Thread H.J. Lu
With Pmode == SImode and word_mode == DImode, we generate (insn/f 105 104 106 2 (set (mem:DI (pre_dec:SI (reg/f:SI 7 sp)) [0 S8 A8]) (reg:DI 6 bp)) x.cc:18 42 {*pushdi2_rex64} (nil)) to push frame pointer onto stack. Checking hard_frame_pointer_rtx fails since hard_frame_poin

Re: increase call_saved_regs[] in caller-save.c

2011-11-04 Thread Peter Bergner
On Fri, 2011-11-04 at 12:25 -0600, Jeff Law wrote: > The only way I can think of to have two pseudos assigned the same hard > reg at the same point in the insn stream is if the two pseudos are > known to have the same value. Having the same value is the more common way two overlapping pseudos don'

Re: Re: [Ping] RE: CR16 Port addition

2011-11-04 Thread Joseph S. Myers
On Fri, 4 Nov 2011, Jayant R. Sonar wrote: > Ping 5: For review > > Can someone please review the modified patch: > http://gcc.gnu.org/ml/gcc-patches/2011-10/msg01985.html You still have a spurious change to libstdc++-v3/configure without any corresponding change to a source file generating tha

Re: [patch] 15/n: trans-mem: compiler C++ changes

2011-11-04 Thread Richard Henderson
On 11/04/2011 12:26 PM, Jason Merrill wrote: > On 11/04/2011 03:23 PM, Richard Henderson wrote: >> (cp_parser_transaction_expression): Don't parse txn-attributes here. > > There's also the issue that the grammar uses compound-statement, whereas the > code parses a parenthesized expression. T

Re: [v3] doxygen markup for tr2

2011-11-04 Thread Benjamin Kosnik
One more buglet -benjamin2011-11-04 Benjamin Kosnik * scripts/run_doxygen: Fix sed quoting. diff --git a/libstdc++-v3/scripts/run_doxygen b/libstdc++-v3/scripts/run_doxygen index 3fef95f..7b601bc 100644 --- a/libstdc++-v3/scripts/run_doxygen +++ b/libstdc++-v3/scripts/run_doxygen @@ -261,7

Re: [google] fix for undefined location list symbol in LIPO (issue5355042)

2011-11-04 Thread Diego Novillo
On Fri, Nov 4, 2011 at 13:13, Rong Xu wrote: > Don't emit the type info if a function's context type is not > output. > > For google branch only. > > Tested with internal benchmark suite with -g. > > 2011-11-04   Rong Xu   > >        * gcc/dwarf2out.c (dwarf2out_decl): not emit type info >        

Re: [patch] 15/n: trans-mem: compiler C++ changes

2011-11-04 Thread Jason Merrill
On 11/04/2011 03:23 PM, Richard Henderson wrote: (cp_parser_transaction_expression): Don't parse txn-attributes here. There's also the issue that the grammar uses compound-statement, whereas the code parses a parenthesized expression. Jason

Re: [patch] 15/n: trans-mem: compiler C++ changes

2011-11-04 Thread Richard Henderson
On 11/04/2011 11:31 AM, Jason Merrill wrote: > Speaking of which, that function's comment doesn't match the code: > >> + transaction-expression: >> + __transaction_atomic txn-exception-spec[opt] compound-statement >> + __transaction_relaxed txn-exception-spec[opt] compound-statement Fix

[Committed] S/390: libgcc: Add -fPIC in t-crtstuff

2011-11-04 Thread Andreas Krebbel
Hi, I've committed the attached patch to fix the current bootstrap failure on s390 as described in: http://gcc.gnu.org/ml/gcc-patches/2011-11/msg00546.html Bye, -Andreas- 2011-11-04 Andreas Krebbel * config/s390/t-crtstuff: Add -fPIC to CRTSTUFF_T_CFLAGS_S variable. Index

Re: [C++ Patch] Trailing comma in enum

2011-11-04 Thread Ville Voutilainen
On 4 November 2011 20:53, Jason Merrill wrote: > Oops, I was ignoring the pings when looking for the actual patch.  :) > But in general I've been only been using maybe_warn_cpp0x for larger > features. Understood. Modification to cp-tree.h make rebuilds heavier, so I don't feel strongly about it.

Re: [patch] 16/n: trans-mem: compiler parser/front-end

2011-11-04 Thread Richard Henderson
On 11/03/2011 01:44 PM, Richard Henderson wrote: > On 11/03/2011 01:34 PM, Joseph S. Myers wrote: >> On Thu, 3 Nov 2011, Aldy Hernandez wrote: >> >>> +/* Parse a transaction attribute (GCC Extension). >>> + >>> + transaction-attribute: >>> + attributes >>> + [ [ any-word ] ] >> >> I don't

Re: [C++ Patch] Trailing comma in enum

2011-11-04 Thread Jason Merrill
On 11/04/2011 02:37 PM, Ville Voutilainen wrote: On 4 November 2011 19:38, Jason Merrill wrote: Applied. Sorry for the delay, thanks for the pings. So we want to pedwarn directly in parser, rather than use maybe_warn_cpp0x? Magnus did a newer revision of the patch that uses maybe_warn_cpp0x,

Re: cxx-mem-model merge - Unified changelogs

2011-11-04 Thread Andrew MacLeod
On 11/04/2011 11:53 AM, Andrew MacLeod wrote: OK, finally finished creating proper changelogs. I'll just throw all 8 of them in this one file if anyone wants to see then... And here they are compressed down to what will actually be checked into the 5 different ChangeLogs, matching the for

Re: cxx-mem-model merge [4 of 9] c-family

2011-11-04 Thread Andrew MacLeod
On 11/04/2011 02:32 PM, Jeff Law wrote: Here's the updated c-family file (with an updated changelog as well). I added a warning to common.c and updated builtins.c::get_memmodel where the same error was issued. That is changed to a warning as well. I also added an entry in the testsuite to ch

Re: cxx-mem-model merge [6 of 9] - libstdc++-v3

2011-11-04 Thread Andrew MacLeod
On 11/04/2011 02:14 PM, Jeff Law wrote: These are the changes to libstdc++ to make use of the new atomics. I changed the files to use the new atomics, and bkoz did a shuffling of the include file layout to better suit the new c++ approach. previously, libstdc++ provided a locked implementation

Re: [C++ Patch] Trailing comma in enum

2011-11-04 Thread Ville Voutilainen
On 4 November 2011 19:38, Jason Merrill wrote: > Applied.  Sorry for the delay, thanks for the pings. So we want to pedwarn directly in parser, rather than use maybe_warn_cpp0x? Magnus did a newer revision of the patch that uses maybe_warn_cpp0x, although I don't know what the usual policy for th

Re: cxx-mem-model merge [4 of 9] c-family

2011-11-04 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/04/11 07:58, Andrew MacLeod wrote: > On 11/04/2011 08:51 AM, Joseph S. Myers wrote: >> >> DR#109 applies: "A conforming implementation must not fail to >> translate a strictly conforming program simply because some >> possible execution of that

Re: [patch] 15/n: trans-mem: compiler C++ changes

2011-11-04 Thread Jason Merrill
On 11/04/2011 02:19 PM, Richard Henderson wrote: On 11/04/11 10:51, Jason Merrill wrote: Are you sure that [[attribute]] is the only way a [ can appear there? Yes. We're immediately following a keyword. The only two valid tokens that can follow that keyword are [ and {. Ah, I saw the cp_pa

Re: increase call_saved_regs[] in caller-save.c

2011-11-04 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/03/11 13:13, DJ Delorie wrote: >> But doesn't that imply that a hard register is getting inserted >> into the array more than once. While I don't see explicit code >> to prevent this, I'm having a hard time seeing how that can >> actually happen

Re: [patch] 15/n: trans-mem: compiler C++ changes

2011-11-04 Thread Richard Henderson
On 11/04/2011 11:16 AM, Aldy Hernandez wrote: > On 11/04/11 10:51, Jason Merrill wrote: >> On 11/03/2011 02:53 PM, Aldy Hernandez wrote: >>> + if (cp_lexer_next_token_is_not (parser->lexer, CPP_OPEN_SQUARE)) >>> + return NULL_TREE; >>> + cp_lexer_consume_token (parser->lexer); >>> + if (!cp_parser_

Re: [rs6000] Fix PR 50906, eh_frame and other woes

2011-11-04 Thread Iain Sandoe
Hello Alan, On 4 Nov 2011, at 13:07, Alan Modra wrote: Lots of bugs here. Most of them in TARGET_SPE_ABI code, but some also for other ABIs. 1) Marking an instruction setting up r11 for use by _save64gpr_* as frame-related results in r11 being set as the cfa for the rest of the function. Tha

Re: [patch] 15/n: trans-mem: compiler C++ changes

2011-11-04 Thread Aldy Hernandez
On 11/04/11 10:51, Jason Merrill wrote: On 11/03/2011 02:53 PM, Aldy Hernandez wrote: + if (cp_lexer_next_token_is_not (parser->lexer, CPP_OPEN_SQUARE)) + return NULL_TREE; + cp_lexer_consume_token (parser->lexer); + if (!cp_parser_require (parser, CPP_OPEN_SQUARE, RT_OPEN_SQUARE)) + goto error1

Re: RFA: Add Epiphany port

2011-11-04 Thread Richard Henderson
> (define_predicate "call_address_operand" > (match_code "symbol_ref,const,reg") > { > return (symbolic_operand (op, mode) || (GET_CODE (op) == REG)); > }) Nit. (define_predicate "call_address_operand" (ior (match_code "reg") (match_operand 0 "symbolic_operand"))) > (define_special_

Re: cxx-mem-model merge [9 of 9] testsuite - simulate-threads

2011-11-04 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/03/11 17:51, Andrew MacLeod wrote: > This part of the testsuite changes are those test added to > simulate-threads. The test infrastructure was brought over to > mainline a month ago or so by aldyh and renamed. The branch > specific tests st

Re: cxx-mem-model merge [6 of 9] - libstdc++-v3

2011-11-04 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/03/11 17:50, Andrew MacLeod wrote: > These are the changes to libstdc++ to make use of the new atomics. > I changed the files to use the new atomics, and bkoz did a > shuffling of the include file layout to better suit the new c++ > approach. >

Re: ping*2: [RFA:] testsuite infrastructure for options implied by dg-final methods

2011-11-04 Thread Hans-Peter Nilsson
> From: Mike Stump > Date: Fri, 4 Nov 2011 18:54:22 +0100 > On Nov 4, 2011, at 10:41 AM, Hans-Peter Nilsson wrote: > > I'll wait a few days. > > No need to wait. :-) If someone finds a way and is > motivated, they will fix this and the other instances. :-) Certainly the expected and preferre

Re: cxx-mem-model merge [8 of 9] testsuite - gomp

2011-11-04 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/03/11 17:51, Andrew MacLeod wrote: > These are the changed rth made to the GOMP testsuite.. looks > primarily like consolidation to c-c++-common from 2 other > directories. Yea, 99% is just moving things into a common directly, then a couple twid

Re: ping*2: [RFA:] testsuite infrastructure for options implied by dg-final methods

2011-11-04 Thread Mike Stump
On Nov 4, 2011, at 10:41 AM, Hans-Peter Nilsson wrote: > I'll wait a few days. No need to wait. :-) If someone finds a way and is motivated, they will fix this and the other instances. :-) If the hook is at the top or bottom of a routine, one can source the dejagnu file, then one might be ab

[C++ Patch, committed as obvious] Use ATTRIBUTE_UNUSED

2011-11-04 Thread Paolo Carlini
Hi, I bootstrapped and committed the below as obvious. Thanks, Paolo. /// 2011-11-04 Paolo Carlini * typeck.c (build_indirect_ref): Use ATTRIBUTE_UNUSED. * mangle.c (write_unnamed_type_name): Likewise. Index: typeck.c =

Re: [google] suppress LIPO notes (issue5356041)

2011-11-04 Thread Xinliang David Li
ok. David On Fri, Nov 4, 2011 at 10:39 AM, Rong Xu wrote: > Suppress another LIPO notes. Move it under fopt-info. > > For google branch only. > > Tested with internal branchmark suite. > > 2011-11-04   Rong Xu   > >        * gcc/c-family/c-opts.c: move the notes under fopt-info. > > Index: gcc/c

Re: ping*2: [RFA:] testsuite infrastructure for options implied by dg-final methods

2011-11-04 Thread Hans-Peter Nilsson
> From: Mike Stump > Date: Fri, 4 Nov 2011 17:53:05 +0100 > On Nov 4, 2011, at 6:47 AM, Hans-Peter Nilsson > wrote: > > Ping again, CC:ing testsuite maintainers. > > With the number of qualified individuals commenting in the > thread, I was going to stay out of it. If all the breakages > and

Re: [google] fix for undefined location list symbol in LIPO (issue5355042)

2011-11-04 Thread Xinliang David Li
Ok for google branches. David On Fri, Nov 4, 2011 at 10:13 AM, Rong Xu wrote: > Don't emit the type info if a function's context type is not > output. > > For google branch only. > > Tested with internal benchmark suite with -g. > > 2011-11-04   Rong Xu   > >        * gcc/dwarf2out.c (dwarf2out_

[SPARC] Fix PR target/50979

2011-11-04 Thread Eric Botcazou
We need this to please the mainline version of GNU as. Bootstrapped on SPARC/Linux, applied on mainline, 4.6 and 4.5 branches. 2011-11-04 Eric Botcazou PR target/50979 * config/sparc/sparc.h (ASM_CPU_SPEC): Pass -Av8 if -mcpu=v8. -- Eric Botcazou Index: config/sparc/sparc.

[google] suppress LIPO notes (issue5356041)

2011-11-04 Thread Rong Xu
Suppress another LIPO notes. Move it under fopt-info. For google branch only. Tested with internal branchmark suite. 2011-11-04 Rong Xu * gcc/c-family/c-opts.c: move the notes under fopt-info. Index: gcc/c-family/c-opts.c

Re: [C++ Patch] Trailing comma in enum

2011-11-04 Thread Jason Merrill
Applied. Sorry for the delay, thanks for the pings. Jason

Re: [build] Restore arm-eabi bootstrap (PR target/50978)

2011-11-04 Thread Paolo Bonzini
On 11/04/2011 06:24 PM, Rainer Orth wrote: Ok, but unless it's urgent, I'd like to go over it over the weekend and commit on monday. I'm about to leave relatively soon. Sure. Let me know if you cannot fix arm and sh. Paolo

Re: [build] Restore arm-eabi bootstrap (PR target/50978)

2011-11-04 Thread Rainer Orth
Paolo Bonzini writes: >>> ./config/t-rtems:HOST_LIBGCC2_CFLAGS = >>> -I$(srcdir)/../newlib/libc/sys/rtems/include > > This was LIBGCC2_INCLUDES before your patches. > > You're also missing it in many cases: arm, avr, bfin, moxie, h8300, lm32, > m32r, m68k, mips, powerpc, sh, m32c. Right, no ide

Re: [PATCH,PR50763] Follow-up patch to fix i686 bootstrap failure

2011-11-04 Thread Tom de Vries
On 11/02/2011 07:02 PM, Tom de Vries wrote: > On 10/26/2011 10:38 AM, Richard Guenther wrote: >> On Tue, Oct 25, 2011 at 2:15 PM, Tom de Vries wrote: >>> Richard, >>> >>> I have a patch for the i686 bootstrap problem reported in PR50763 comment >>> 10. >>> >>> pr50763-2.c looks like this before t

Re: [C++11 Patch] NSMI and aggregate type

2011-11-04 Thread Jason Merrill
We don't want to check DECL_INITIAL up there, as it might still be a bit-field size. So I moved the check down a bit and checked it in. Thanks! Jason commit 5b18fa4cd800c94783b70c1cef1b711b424afe0d Author: jason Date: Fri Nov 4 17:15:02 2011 + PR c++/50965 * class.c (check_fi

[google] fix for undefined location list symbol in LIPO (issue5355042)

2011-11-04 Thread Rong Xu
Don't emit the type info if a function's context type is not output. For google branch only. Tested with internal benchmark suite with -g. 2011-11-04 Rong Xu * gcc/dwarf2out.c (dwarf2out_decl): not emit type info for unreachable functions in LIPO mode. Index: gcc/dwarf2o

Re: [build] Restore arm-eabi bootstrap (PR target/50978)

2011-11-04 Thread Paolo Bonzini
Ok, so let's do the analysis. Looks like there are problems in t-rtems and sh/t-sh, in addition to ARM. But I think all of them can be changed. ./config/mcore/t-mcore:HOST_LIBGCC2_CFLAGS = -O3 -DNO_FLOATLIB_FIXUNSDFSI #-msifilter Used as tmake_file="mcore/t-mcore t-fdpbit" would

Re: cxx-mem-model merge [1 of 9] gcc-1

2011-11-04 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/04/11 10:00, Andrew MacLeod wrote: > On 11/04/2011 11:39 AM, Jeff Law wrote: >> On 11/03/11 17:49, Andrew MacLeod wrote: >>> This is the first of 2 parts for the patches to the GCC >>> directory, it includes the changelog for parts 1 and 2 >>> >

Re: cxx-mem-model merge [7 of 9] testsuite - functional verification

2011-11-04 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/04/11 09:56, Andrew MacLeod wrote: > On 11/04/2011 11:48 AM, Jeff Law wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >> >> On 11/03/11 17:50, Andrew MacLeod wrote: >>> The testsuite changes are split into 3 parts. >>> >>> This part is

Re: ping*2: [RFA:] testsuite infrastructure for options implied by dg-final methods

2011-11-04 Thread Mike Stump
On Nov 4, 2011, at 6:47 AM, Hans-Peter Nilsson wrote: > Ping again, CC:ing testsuite maintainers. With the number of qualified individuals commenting in the thread, I was going to stay out of it. If all the breakages and review point others had are resolved, Ok. I kinda don't like the brittl

Re: Reload related segfaults

2011-11-04 Thread Eric Botcazou
> OK to apply, assuming no regressions? > > * reload1.c (gen_reload): Don't use REGNO on SUBREGs. > * print-rtl.c (print_rtx): Don't segfault on negative regno. OK, thanks. -- Eric Botcazou

Re: [Patch,AVR]: Implement PR50931 (24-bit integers) [1-2/n]

2011-11-04 Thread Georg-Johann Lay
Denis Chertykov wrote: > 2011/11/2 Georg-Johann Lay : >> Georg-Johann Lay wrote: >>> To support the upcoming named address space support in avr, a 24-bit pointer >>> type is needed. This patch adds respective support of a 24-bit integer mode >>> called PSI. >>> >>> The patch supports more than is a

Re: [PATCH] Straight-line strength reduction, stage 1

2011-11-04 Thread William J. Schmidt
Richard, thanks for the quick reply! I realize there's a lot of traffic on gcc-patches right now, so I appreciate your time. On Fri, 2011-11-04 at 14:55 +0100, Richard Guenther wrote: > On Sun, Oct 30, 2011 at 5:10 PM, William J. Schmidt > wrote: > > Greetings, > > > > IVOPTS handles strength re

Re: [Ping] RE: CR16 Port addition

2011-11-04 Thread Richard Henderson
On 11/04/2011 06:28 AM, Jayant R. Sonar wrote: > Ping 5: For review > > Can someone please review the modified patch: > http://gcc.gnu.org/ml/gcc-patches/2011-10/msg01985.html > The port looks to be in good shape. > +;; Multiply and Accumulate Instructions "smachisi3/umachisi3" > +(define_ins

Re: [build] Restore arm-eabi bootstrap (PR target/50978)

2011-11-04 Thread Rainer Orth
Paolo Bonzini writes: >> yes, using += gets my behind this point, now in stage2. > > Grep finds: > > ./config/mcore/t-mcore:HOST_LIBGCC2_CFLAGS = -O3 -DNO_FLOATLIB_FIXUNSDFSI > #-msifilter > ./config/m32r/t-m32r:HOST_LIBGCC2_CFLAGS = -G 0 > ./config/t-rtems:HOST_LIBGCC2_CFLAGS = > -I$(srcdir)/.

Re: [build] Restore arm-eabi bootstrap (PR target/50978)

2011-11-04 Thread Paolo Bonzini
On 11/04/2011 04:59 PM, Matthias Klose wrote: > On 11/04/2011 10:58 AM, Rainer Orth wrote: >> Matthias Klose writes: >> >>> emutls_s.o indeed isn't built with -fPIC (it is on the 4.6 branch); PICFLAG >>> in >>> libgcc/Makefile is set but apparently not used. >> >> I think I see what's going on: c

Re: [C++ Patch / RFC] PR 48420

2011-11-04 Thread Jason Merrill
OK. Jason

Re: [trans-mem][build] Hack around top-level Makefile libstdc++ breakage

2011-11-04 Thread DJ Delorie
> I believe that C++ tests pick the correct bits/c++config for > -m32. Can't libitm do something similar? The problem is that the -I for the build is chosen at the toplevel, *before* iterating over the multilibs, whereas the -I for testing is chosen in dejagnu, *after* iterating over the multilib

Re: [trans-mem][build] Hack around top-level Makefile libstdc++ breakage

2011-11-04 Thread H.J. Lu
On Thu, Nov 3, 2011 at 10:57 PM, Richard Henderson wrote: > We currently have a problem building libitm because it uses the libstdc++ > header , and the toplevel Makefile passes a single set of > include paths for all multilibs.  In the recent merges from mainline, we > brought in changes to that

Re: [PATCH] Optimize v*gather* with masks with all high bits set

2011-11-04 Thread Richard Henderson
On 11/04/2011 08:53 AM, Jakub Jelinek wrote: > On Fri, Nov 04, 2011 at 08:48:30AM -0700, Richard Henderson wrote: >> On 11/04/2011 03:57 AM, Jakub Jelinek wrote: >>> + /* Optimize. If mask is known to have all high bits set, >>> +replace op0 with pc_rtx to signal that the instruction >>>

Re: cxx-mem-model merge [5 of 9] fortran

2011-11-04 Thread Andrew MacLeod
On 11/04/2011 11:50 AM, Jeff Law wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/03/11 17:50, Andrew MacLeod wrote: This patch simply mimics the builtin-types.def changes so that fortran can build. Looks OK. I'd think the ChangeLog could be simplified to just note which new things

Re: cxx-mem-model merge [1 of 9] gcc-1

2011-11-04 Thread Andrew MacLeod
On 11/04/2011 11:39 AM, Jeff Law wrote: On 11/03/11 17:49, Andrew MacLeod wrote: This is the first of 2 parts for the patches to the GCC directory, it includes the changelog for parts 1 and 2 Primarily it is all the stuff required to create builtins. new defs, support routines, config changes,

  1   2   >