-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 11/04/11 09:56, Andrew MacLeod wrote: > On 11/04/2011 11:48 AM, Jeff Law wrote: >> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 >> >> On 11/03/11 17:50, Andrew MacLeod wrote: >>> The testsuite changes are split into 3 parts. >>> >>> This part is all the new testsuite entries for testing the >>> atomics for functionality. ie, make sure they work as expected, >>> and generate errors when expected >> I spot checked various tests and it looks pretty good to me. >> >> Given the duplications in the the tests I wondered if we could >> play tricks with macros or something to simplify the testfiles, >> but I doubt it's worth the effort. Certainly not required. > I originally did that, but then changed it and decided it was > better this way. The point of tests is to help you figure out what > has failed... With all the macro packing and compression, it took > more effort to figure out what had gone wrong, and required > multiple files. Now its a simple self contained testcase you just > run. > > I figured once they are there they wont change much, so the > duplication isn't really a maintainability issue. That was my > logic :-) I'd kindof reached the same conclusion -- it'd help the initial review, but once in they wouldn't change much. Consider the suggest withdrawn.
jeff -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJOtBoIAAoJEBRtltQi2kC7tcAH/RaRMYnib1b8FgeQ9Kme6Wj2 Yv8UT7VWRxpczYJT58QaQAG1nnbEzne9Xu5BI2PVilhq3BVBK3WcDpeEaeU/4sLo 6o7KHuMb5hP2dLk7tZICDwLqOyYVitjaSHrKAnE5775g0Ltvwr7JWKL2Oocr6XMR msZdL7oyFXflrBtWqHQh2/Uo8VI+WJCa32BLdRSnwdLAt16BEeFSi9bMaGnpxTWk 7kbnlrcCD1zfrCBHslnBwGbQW5cNQ0SU6P3I5TK2iNMVKtvu6INkikjZNvCpto8A dUXEd0faycdYXasPWax18rih+YI46kRkmbYj9y/InR9rDX0/B2NM7bYvfvO2Zik= =xYlv -----END PGP SIGNATURE-----
