Re: PATCH RFA: New configure option --with-native-system-header-dir

2011-10-10 Thread Paolo Bonzini
On 10/09/2011 08:18 AM, Ian Lance Taylor wrote: +#undef NATIVE_HEADER_HEADER_COMPONENT +#define NATIVE_SYSTEM_HEADER_COMPONENT "MINGW" Typo (I think), otherwise okay. Paolo

Re: [wwwdocs] gcc-4.6/porting_to.html

2011-10-10 Thread Gerald Pfeifer
Hi Benjamin, On Wed, 16 Mar 2011, Benjamin Kosnik wrote: > Needs some more work, here's a rough draft. I realized this one hasn't made it in, but is really nice. I made a number of minor edits (typos, markup, simplifying headings,... among others). What do you think -- should we include this?

Re: Fix for PR libobjc/49883 ("clang + gcc 4.6 runtime = broken") and a small related clang fix

2011-10-10 Thread Mike Stump
On Oct 9, 2011, at 3:30 AM, Nicola Pero wrote: > Unfortunately, the report was correct in that clang is producing incorrect > code and > abusing the higher bits of the class->info field to store some other > information. The clang folks are pretty responsive. I'd always give them a chance to `f

Re: [google] record compiler options to .note sections

2011-10-10 Thread Dehao Chen
How about .gnu.switches.text.quote_paths? Thanks, Dehao On Tue, Oct 11, 2011 at 8:42 AM, Cary Coutant wrote: >> Ok for google branches. >> >> 1) document the difference of this option with -grecord-gcc-switches >> (this one only record codegen related options, and recorded in debug >> section),

Re: [patches] several gcc.target/powerpc tests require hard_float

2011-10-10 Thread Joseph S. Myers
On Mon, 10 Oct 2011, Janis Johnson wrote: > This patch skips several Power-specific tests if hard_float support > isn't available. OK for trunk? It looks like these are testing for particular instructions using FPRs and so powerpc_fprs is more appropriate; you don't want to match e500v2 hard f

Re: [C++ Patch / RFC] PR 33067

2011-10-10 Thread Jason Merrill
On 10/10/2011 12:40 PM, Paolo Carlini wrote: + // The fraction 643/2136 approximates log10(2) to 7 significant digits. + int max_digits10 = 2 + (is_decimal ? fmt->p : fmt->p * 643L / 2136); Please cite N1822 in the comment and convert it to C syntax. OK with that change. Jason

Re: [PATCH, testsuite]: Close and unlink test file before exit

2011-10-10 Thread Hans-Peter Nilsson
On Tue, 11 Oct 2011, Uros Bizjak wrote: > Hello! > > Remove another orphan file from the testsuite directory. > > 2011-10-11 Uros Bizjak > > * lib/target-supports.exp (check_effective_target_fd_truncate): > Close and unlink test file before exit. (can't quote attachment...) Or s

Re: [C++ Patch] PR 50660

2011-10-10 Thread Jason Merrill
On 10/11/2011 01:10 AM, Paolo Carlini wrote: Great, this works (and I even learned something ;) Shall I commit it when testing finishes? Please. Jason

[patches] several gcc.target/powerpc tests require hard_float

2011-10-10 Thread Janis Johnson
This patch skips several Power-specific tests if hard_float support isn't available. OK for trunk? 2011-10-10 Janis Johnson * gcc.target/powerpc/ppc-fma-3.c: Require hard_float. * gcc.target/powerpc/ppc-fma-4.c: Likewise. * gcc.target/powerpc/ppc-fma-5.c: Likewise.

Re: [google] record compiler options to .note sections

2011-10-10 Thread Cary Coutant
> Ok for google branches. > > 1) document the difference of this option with -grecord-gcc-switches > (this one only record codegen related options, and recorded in debug > section), and with -frecord-gcc-switches? > 2) may be better to use option name: -frecord-gcc-switches-in-object Sections whos

Re: [C++ Patch] PR 50660

2011-10-10 Thread Paolo Carlini
On 10/11/2011 01:46 AM, Jason Merrill wrote: On 10/10/2011 12:44 AM, Paolo Carlini wrote: If I just do this (I hope it's what you had in mind): - tree t = non_reference (totype); + tree t = totype; /*non_reference (totype); */ variadic111.C:16:22: warning: converting ‘false’ to pointer type fo

Re: [C++ Patch] PR 50660

2011-10-10 Thread Jason Merrill
On 10/10/2011 12:44 AM, Paolo Carlini wrote: If I just do this (I hope it's what you had in mind): - tree t = non_reference (totype); + tree t = totype; /*non_reference (totype); */ variadic111.C:16:22: warning: converting ‘false’ to pointer type for argument 3 of ‘void S::f(Args1 ..., Args2&&

Re: Intrinsics for N2965: Type traits and base classes

2011-10-10 Thread Benjamin Kosnik
This is looking pretty good, from the libstdc++ side. This latest round of gcc hacking fixes the previous testsuite fixes, so once you get the gcc bits OK'd by Jason you can check in. > I'd still like to see some testcases for the intrinsic, independent > of the library. Seems like some simple t

Re: [patch] Don't try to reload match_operator

2011-10-10 Thread Hans-Peter Nilsson
On Mon, 19 Sep 2011, Ulrich Weigand wrote: > Richard Earnshaw wrote: > > On 19/09/11 15:14, Ulrich Weigand wrote: > > > So it seems to me that for match_operator operands, the > > > goal_alternative_win flag should always be true ... > > > > > > Can you find out why this isn't true in your case? >

Re: PATCH RFA: New configure option --with-native-system-header-dir

2011-10-10 Thread Joseph S. Myers
On Sat, 8 Oct 2011, Ian Lance Taylor wrote: > This patch implements this proposal. Only lightly tested so far. How > does this look if testing succeeds? OK in the absence of build system maintainer objections within 24 hours. -- Joseph S. Myers jos...@codesourcery.com

Re: [C++ Patch / RFC] PR 33067

2011-10-10 Thread Joseph S. Myers
On Mon, 10 Oct 2011, Paolo Carlini wrote: > + // The fraction 643/2136 approximates log10(2) to 7 significant digits. Whatever the conclusion on the approach to take, note that we don't use C++ comments in GCC at present. -- Joseph S. Myers jos...@codesourcery.com

Re: [google] record compiler options to .note sections

2011-10-10 Thread Xinliang David Li
Ok for google branches. 1) document the difference of this option with -grecord-gcc-switches (this one only record codegen related options, and recorded in debug section), and with -frecord-gcc-switches? 2) may be better to use option name: -frecord-gcc-switches-in-object thanks, David On Sun,

[PATCH, testsuite]: Close and unlink test file before exit

2011-10-10 Thread Uros Bizjak
Hello! Remove another orphan file from the testsuite directory. 2011-10-11 Uros Bizjak * lib/target-supports.exp (check_effective_target_fd_truncate): Close and unlink test file before exit. Tested on x86_64-pc-linux-gnu, committed to mainline SVN. Uros. Index: lib/target-su

[gimplefe][patch] The symbol table for declarations

2011-10-10 Thread Sandeep Soni
Hi, The following patch is a basic attempt to build a symbol table that stores the names of all the declarations made in the input file. Index: gcc/gimple/parser.c === --- gcc/gimple/parser.c (revision 174754) +++ gcc/gimple/parser.c

[gimplefe][patch] A bugfix for a missed symbol

2011-10-10 Thread Sandeep Soni
Ketaki had pointed a minor bug a long time back. This patch fixes it. Index: parser.c === --- parser.c(revision 174754) +++ parser.c(working copy) @@ -882,6 +882,7 @@ switch (code) { case INTEGER_TYPE: + gl_c

Re: fix for c++/44473, mangling of decimal types, checked in

2011-10-10 Thread Peter Bergner
On Mon, 2011-10-10 at 14:18 -0700, Janis Johnson wrote: > Sorry, I didn't see that note about backports, but then I'm way behind > on gcc mail. Heh, no problem. I can sympathize! > Peter, would you be able to test this patch for a backport? I'm kind of > swamped right now, and decimal float i

Re: fix for c++/44473, mangling of decimal types, checked in

2011-10-10 Thread Janis Johnson
On 10/10/2011 02:13 PM, Peter Bergner wrote: > On Wed, 2011-10-05 at 11:40 -0500, Peter Bergner wrote: >> On Fri, 2011-09-30 at 10:37 -0700, Janis Johnson wrote: >>> Patch http://gcc.gnu.org/ml/gcc-patches/2010-12/msg00625.html was >>> approved by Jason last December but I never got around to check

Re: fix for c++/44473, mangling of decimal types, checked in

2011-10-10 Thread Peter Bergner
On Wed, 2011-10-05 at 11:40 -0500, Peter Bergner wrote: > On Fri, 2011-09-30 at 10:37 -0700, Janis Johnson wrote: > > Patch http://gcc.gnu.org/ml/gcc-patches/2010-12/msg00625.html was > > approved by Jason last December but I never got around to checking > > it in. Paolo Carlini said in PR44473 th

Re: [PATCH, testsuite, i386] FMA3 testcases + typo fix in MD

2011-10-10 Thread Uros Bizjak
On Mon, Oct 10, 2011 at 10:56 PM, Uros Bizjak wrote: >>> BTW, don't you also need "-mfmpath=sse" in dg-options? >>> >> >> According to doc/invoke.texi >> ... >> @itemx -mfma >> ... >> These options will enable GCC to use these extended instructions in >> generated code, even without @option{-mfpm

Re: [PATCH, testsuite, i386] FMA3 testcases + typo fix in MD

2011-10-10 Thread Uros Bizjak
On Thu, Oct 6, 2011 at 3:48 PM, Kirill Yukhin wrote: >> >> BTW, don't you also need "-mfmpath=sse" in dg-options? >> > > According to doc/invoke.texi > ... > @itemx -mfma > ... > These options will enable GCC to use these extended instructions in > generated code, even without @option{-mfpmath=sse

Re: [RFC] Slightly fix up vgather* patterns

2011-10-10 Thread Richard Henderson
On 10/08/2011 08:43 AM, Jakub Jelinek wrote: > (define_expand "avx2_gathersi" > - [(set (match_operand:VEC_GATHER_MODE 0 "register_operand" "") > - (unspec:VEC_GATHER_MODE > - [(match_operand:VEC_GATHER_MODE 1 "register_operand" "") > -(match_operand: 2 "memory_operand" "") > -

[PATCH] [Annotalysis] Bugfix for spurious thread safety warnings with shared mutexes

2011-10-10 Thread Delesley Hutchins
This patch fixes an error where Annotalysis generates bogus warnings when a shared lock is released in a function that has a "universal lock" -- typically produced when gcc cannot parse a lock expression. Bootstrapped and passed gcc regression testsuite on x86_64-unknown-linux-gnu. Okay for googl

Patch committed: Correct demangling of qualified function types

2011-10-10 Thread Ian Lance Taylor
PR 48665 points out that qualified function types are not correctly demangled. These types can only appear as template parameters. This patch fixes the problem. Bootstrapped and ran C++ testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian 2011-10-10 Ian Lance Taylor

[testsuite] modify powerpc test for hard_float target, skip powerpc/warn-[12].c for soft-float

2011-10-10 Thread Janis Johnson
Tests gcc.target/powerpc/warn-[12].c fail for soft-float multilibs with the unexpected warning "-mvsx requires hardware floating point [enabled by default]". This patch skips those tests for soft-float multilibs and modifies the powerpc check for a soft-float effective target to return true for ei

Re: [Patch] PR c++/26256

2011-10-10 Thread Fabien Chêne
Hi, 2011/9/26 Jason Merrill : > On 09/25/2011 05:06 PM, Fabien Chêne wrote: >> >> +  else if ((using_decl = strip_using_decl (member)) != member) > >> +  /* If it is a using decl, use its underlying decl.  */ >> +  type_decl = strip_using_decl (type_decl); > >> -      if (DECL_NAME (field) == name

PR c++/30195

2011-10-10 Thread Fabien Chêne
2011/9/23 Jason Merrill : > On 09/22/2011 05:11 PM, Fabien Chêne wrote: >> >> 2011/9/22 Jason Merrill: > >>> I don't, it just seemed strange to handle functions differently from >>> other >>> decls here.  But when I look more closely I see that we're in >>> lookup_field_1, which isn't interested in

Re: Force aliases to be output when cgraph decides so

2011-10-10 Thread Jan Hubicka
> Honza, > > I filed PR50689. After your change, the alias is moved from near the > end of the file to just before the definition. AIX assembler is a > single pass assembler that does not allow forward references. I see, I guess the easy bugfix is to make the aliases output afterwards. I will

[patch] remove empty directory in libgomp

2011-10-10 Thread Matthias Klose
2011-10-10 Matthias Klose * config/posix95: Remove empty directory. The last files in config/posix95 were removed in r177568. Comitted as obvious. Matthias

Re: [v3] cxxabi.h vs. unwind-cxx.h

2011-10-10 Thread Benjamin Kosnik
Here's a patch that works for both C and C++. tested x86/linux -benjamin 2011-10-10 Benjamin Kosnik PR libstdc++/49818 * config/abi/pre/gnu.ver (CXXABI_1.3.6): Add symbols. * testsuite/util/testsuite_abi.cc: Same. * libsupc++/unwind-cxx.h: Move required eh API... * libsupc++/cxxabi.h:

Re: Force aliases to be output when cgraph decides so

2011-10-10 Thread David Edelsohn
Honza, I filed PR50689. After your change, the alias is moved from near the end of the file to just before the definition. AIX assembler is a single pass assembler that does not allow forward references. - David On Sun, Sep 25, 2011 at 6:27 AM, Jan Hubicka wrote: >> Jan, >> >> This patch caus

Re: PATCH RFA: New configure option --with-native-system-header-dir

2011-10-10 Thread DJ Delorie
> + yes|no) AC_MSG_ERROR([bad value ${withval} given for > --with-native-system-header-dir]) ;; > + /*) ;; > + *) AC_MSG_ERROR([--with-native-system-header-dir argument ${withval} must > be an absolute directory]) ;; This doesn't handle DOS-style absolute paths (like c:/Users). Not sure if we

Re: [Patch, Fortran] Fix PR 50564

2011-10-10 Thread Thomas Koenig
Hi Tobias, In conclusion: I am fine with the FORALL part, but not with the DO CONCURRENT part. Yep, you're right. I have modified the patch accordingly. Here is what I committed. Best regards Thomas Index: fortran/ChangeLog ==

Re: [PATCH, testsuite]: Remove *.gdb files from testsuite dir

2011-10-10 Thread Uros Bizjak
On Sun, Oct 9, 2011 at 9:38 PM, Uros Bizjak wrote: > Attached patch removes *.gdb temporary files from testsuite directory. > > 2011-10-09  Uros Bizjak   > >        * lib/gcc-gdb-test.exp (gdb-test): Delete $cmd_file before return. > > Tested on x86_64-pc-linux-gnu {,-m32}. OK for mainline and br

Re: [C++ Patch / RFC] PR 33067

2011-10-10 Thread Paolo Carlini
Hi, On 10/10/2011 07:59 PM, Gabriel Dos Reis wrote: Yes, I suspect the max_digits10 patch would be definitely an improvement. Good. It's at the beginning of this thread, passes testing. Please have a closer look. I did, but you seemed to show a preference for '6' digits which prompted my comme

Re: [C++ Patch / RFC] PR 33067

2011-10-10 Thread Gabriel Dos Reis
On Mon, Oct 10, 2011 at 1:07 PM, Paolo Carlini wrote: > On 10/10/2011 07:59 PM, Gabriel Dos Reis wrote: >> >> Yes, I suspect the max_digits10 patch would be definitely an improvement. > > Good. It's at the beginning of this thread, passes testing. Please have a > closer look. I did, but you seeme

Re: [C++ Patch / RFC] PR 33067

2011-10-10 Thread Paolo Carlini
On 10/10/2011 07:59 PM, Gabriel Dos Reis wrote: Yes, I suspect the max_digits10 patch would be definitely an improvement. Good. It's at the beginning of this thread, passes testing. Please have a closer look. If you like it, we can have it for 4.7.0 and otherwise also mark this specific PR as

Re: [C++ Patch / RFC] PR 33067

2011-10-10 Thread Gabriel Dos Reis
On Mon, Oct 10, 2011 at 12:30 PM, Paolo Carlini wrote: > On 10/10/2011 07:28 PM, Gabriel Dos Reis wrote: >> >> A GCC user not interested in numerics probably won't care. However, I do >> not think that extends to people who do care about numerics and have >> literals in their program. If GCC displ

Re: [PATCH 1/5] Use MADV_DONTNEED for freeing in garbage collector

2011-10-10 Thread Andi Kleen
> So can we move the param patch back as a possible followup? I can drop it, however it will still mean fragmentation on any non Linux (or rather non MADV_DONTNEED) hosts. -Andi

Re: [C++ Patch / RFC] PR 33067

2011-10-10 Thread Paolo Carlini
On 10/10/2011 07:28 PM, Gabriel Dos Reis wrote: A GCC user not interested in numerics probably won't care. However, I do not think that extends to people who do care about numerics and have literals in their program. If GCC displays an error message with literals truncated, it is not at clear t

Re: [C++ Patch / RFC] PR 33067

2011-10-10 Thread Gabriel Dos Reis
On Mon, Oct 10, 2011 at 12:16 PM, Paolo Carlini wrote: > On 10/10/2011 07:13 PM, Gabriel Dos Reis wrote: >> >> on this particular input, '6' looks OK. However, the question is why '6'? >> Why can't we retain the original number spelling from the source code and >> use that instead? > > Yes, that w

Re: [C++ Patch / RFC] PR 33067

2011-10-10 Thread Paolo Carlini
On 10/10/2011 07:13 PM, Gabriel Dos Reis wrote: on this particular input, '6' looks OK. However, the question is why '6'? Why can't we retain the original number spelling from the source code and use that instead? Yes, that would be 49152, no? It's quite a bit of work, I don't think somebody w

Re: [C++ Patch / RFC] PR 33067

2011-10-10 Thread Gabriel Dos Reis
On Mon, Oct 10, 2011 at 7:47 AM, Paolo Carlini wrote: > On 10/10/2011 02:13 PM, Paolo Carlini wrote: >> >> . looks like we want to do something else, not printing the number at all. >> See audit trail. > > An option, for 4.7 at least, would be, instead of just closing 33067 as a > duplicate of the

Re: [Patch,AVR]: Avoid unwind warning from toplev.c

2011-10-10 Thread Denis Chertykov
2011/10/10 Georg-Johann Lay : > toplev.c complains about "unwind tables currently require a frame pointer for > correctness". > > This patchlet supplies a fix to avoid build warnings/test fails in that it > sets > flag_omit_frame_pointer to 0 if unwind needs FP. > > toplev.c:process_options sets f

[PATCH]: Fix PR bootstrap/50665

2011-10-10 Thread Uros Bizjak
Hello! Attached patch moves DOI_vec_perm index to the right place. 2011-10-10 Uros Bizjak PR bootstrap/50665 * optabs.h (DOI_vec_perm): Rename from OTI_vec_perm. Move from enum optab_index to enum direct_optab_index. (vec_perm_optab): Update. Tested by bootst

int_cst_hash_table mapping persistence and the garbage collector

2011-10-10 Thread Gary Funck
Recently, a few UPC test programs failed to compile due to mis-matches of parameters in a prototype and its corresponding function definition. The mis-match was based upon the apparent inequality of UPC layout qualifiers (blocking factors). UPC blocking factors are integer constants. They are re

Re: [patch, libgo] remove empty directories

2011-10-10 Thread Ian Lance Taylor
Matthias Klose writes: > libgo currently has some empty directories. ok to remove? > > D go/encoding/line > D go/exp/ogle > D go/exp/eval > D go/exp/draw > D go/exp/draw/x11 Yes, thanks. Ian

[Patch,AVR]: Avoid unwind warning from toplev.c

2011-10-10 Thread Georg-Johann Lay
toplev.c complains about "unwind tables currently require a frame pointer for correctness". This patchlet supplies a fix to avoid build warnings/test fails in that it sets flag_omit_frame_pointer to 0 if unwind needs FP. toplev.c:process_options sets flag_unwind_tables depending on flag_non_call_

Re: Rename vshuffle/vec_shuffle to vec_perm

2011-10-10 Thread Richard Henderson
On 10/09/2011 06:09 AM, Joseph S. Myers wrote: > That looks like it broke "make pdf" (something did at about that time and > this patch is the most likely candidate). > >> +@cindex @code{vec_perm_const@var{m}) instruction pattern > > has opening '{' matched with closing ')'. > Fixed, thanks.

Re: simulate-thread changes to avoid infinite loops

2011-10-10 Thread Jeff Law
On 10/10/11 09:54, Aldy Hernandez wrote: Hi folks. This was a change Andrew had made to the simulate-thread framework to avoid infinite loops in hostile threads. I forgot to merge this in my original submission, and am doing so now. The original patch is here: http://permalink.gmane.org/gmane.

Re: [PATCH, testsuite, i386] FMA3 testcases + typo fix in MD

2011-10-10 Thread Kirill Yukhin
Thank you K On Mon, Oct 10, 2011 at 8:08 PM, H.J. Lu wrote: > On Sun, Oct 9, 2011 at 12:49 PM, Kirill Yukhin > wrote: >> Hi guys, >> This is a Ping. Could anyboady with appropriate rights commit that? >> >> > > I checked it in for you. Please provide ChangeLog entries together > with the new p

Re: [PATCH, testsuite, i386] FMA3 testcases + typo fix in MD

2011-10-10 Thread H.J. Lu
On Sun, Oct 9, 2011 at 12:49 PM, Kirill Yukhin wrote: > Hi guys, > This is a Ping. Could anyboady with appropriate rights commit that? > > I checked it in for you. Please provide ChangeLog entries together with the new patch next time. -- H.J.

Re: [patch tree-optimization]: Improve handling of conditional-branches on targets with high branch costs

2011-10-10 Thread Kai Tietz
2011/10/10 Richard Guenther : > On Mon, Oct 10, 2011 at 5:07 PM, Kai Tietz wrote: >> 2011/10/10 Richard Guenther : >>> On Mon, Oct 10, 2011 at 4:06 PM, Kai Tietz wrote: 2011/10/10 Richard Guenther : > On Mon, Oct 10, 2011 at 2:29 PM, Kai Tietz > wrote: >> Recent patch had a thi

simulate-thread changes to avoid infinite loops

2011-10-10 Thread Aldy Hernandez
Hi folks. This was a change Andrew had made to the simulate-thread framework to avoid infinite loops in hostile threads. I forgot to merge this in my original submission, and am doing so now. The original patch is here: http://permalink.gmane.org/gmane.comp.gcc.patches/247678 My patch is a

Re: [PATCH] Mark static const strings as read-only.

2011-10-10 Thread Eric Botcazou
> So, the patch for build_constant_desc does not have the desired effect. OK, too bad that we need to play this back-and-forth game with MEMs. So the original patch is OK (with TREE_READONLY (base) on the next line to mimic what is done just above and without the gcc/ prefix in the ChangeLog).

Re: [Patch,AVR]: Reuse __tablejump2__

2011-10-10 Thread Denis Chertykov
2011/10/10 Georg-Johann Lay : > This patch does better re-usage of __tablejump2__ from libgcc so that > switch/case statements with jump tables become smaller because the sequence > needs 6 to 9 words compared to 2 when JMPing to __tablejump2__. > > Moreover, __tablejump2__ does no more rely in the

[PATCH] Fix PR50389

2011-10-10 Thread Richard Guenther
This fixes missed placements of VUSEs during gimplify_and_update_call_from_tree. The gimplifier doesn't fill out virtual operands (it doesn't call update_stmt) - for a reason, we'd mark it for renaming else. So we have to stick a VUSE on every stmt that can possibly have one. update_stmt will

Re: [4/4] Make SMS schedule register moves

2011-10-10 Thread Ayal Zaks
On Mon, Oct 10, 2011 at 1:57 PM, Richard Sandiford wrote: > Ayal Zaks writes: >>> I agree it's natural to schedule moves for intra-iteration dependencies >>> in the normal get_sched_window way.  But suppose we have a dependency: >>> >>>   A --(T,N,1)--> B >>> >>> that requires two moves M1 and M2

Re: [patch tree-optimization]: Improve handling of conditional-branches on targets with high branch costs

2011-10-10 Thread Richard Guenther
On Mon, Oct 10, 2011 at 5:07 PM, Kai Tietz wrote: > 2011/10/10 Richard Guenther : >> On Mon, Oct 10, 2011 at 4:06 PM, Kai Tietz wrote: >>> 2011/10/10 Richard Guenther : On Mon, Oct 10, 2011 at 2:29 PM, Kai Tietz wrote: > Recent patch had a thinko on rhs of inner lhs check for TRUTH-IF.

Re: [PATCH] sel-sched: forbid differing modes in substitution (PR 50205)

2011-10-10 Thread Alexander Monakov
Ping? On Wed, 7 Sep 2011, Alexander Monakov wrote: > Hello, > > The patch repairs a problem when we attempt to substitute an insn like > (... (cmp (mem (reg:DI ax)) (reg:SI ax))) (note different modes) through > (set (reg:DI ax) (reg:DI dx)), which leaves the (reg:SI ax) part of the > comparison

Re: [patch tree-optimization]: Improve handling of conditional-branches on targets with high branch costs

2011-10-10 Thread Michael Matz
Hi, On Mon, 10 Oct 2011, Kai Tietz wrote: > extern int foo (void); /* foo modifies gbl1 */ > int gbl1 = 0; > > int foo (int ns1) > { > if (ns1 && foo () && gbl1) > return 1; > return 0; > } > > so chain of trees has to look like this: > (ANDIF (ns1 (ANDIF foo () gbl1)) Okay, indeed. I

Re: [PATCH] Don't assume that constants can clobber vtbl

2011-10-10 Thread Martin Jambor
On Mon, Oct 10, 2011 at 05:05:14PM +0200, Martin Jambor wrote: > Hi, > > sorry that taking care of the devirtualization patches takes me longer > than expected for various reasons. But I have not forgotten about > this. Ah, please ignore the attachment, I was trying to persuade mutt to add it to

[PATCH] Verify stuff after IPA split

2011-10-10 Thread Richard Guenther
Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2011-10-10 Richard Guenther * ipa-split.c (pass_split_functions): Add verification TODOs. (pass_feedback_split_functions): Likewise. Index: gcc/ipa-split.c ===

Re: [PATCH] sel-sched: fix merging of LHS reg availability (PR 50340)

2011-10-10 Thread Alexander Monakov
Ping. This is now a P1 bug, as it breaks spec2k gcc on ia64. On Tue, 13 Sep 2011, Alexander Monakov wrote: > Hello, > > This patches fixes an ICE on an assert that performs a sanity check on > target_available field of expr_t, which is tri-state: LHS register is > available (1), not available (

Re: [Patch,testsuite,AVR]: target-supports.exp: AVR does not support TLS

2011-10-10 Thread Rainer Orth
Georg-Johann Lay writes: >> This has nothing to do with AVR, but is PR middle-end/50638. It breaks >> TLS on all emutls targets. A patch has been posted and approved, but >> apparently not yet installed. > > Thanks for the notice. > The GCC documentation says that TLS need support of a dynamic

Re: [PATCH] Mark static const strings as read-only.

2011-10-10 Thread Tom de Vries
On 10/10/2011 03:44 PM, Eric Botcazou wrote: >> The patch makes sure that the src_mem computed here in >> expand_builtin_memcpy is marked as MEM_READONLY_P: >> ... >> src_mem = get_memory_rtx (src, len); >> ... >> >> build and reg-tested on i686, arm, and mips. >> >> OK for trunk? > > Do you

Re: [Patch,testsuite,AVR]: target-supports.exp: AVR does not support TLS

2011-10-10 Thread Georg-Johann Lay
d ~/test >> (gdb) r >> GNU C (GCC) version 4.7.0 20111010 (experimental) (avr) >> compiled by GNU C version 4.3.2 [gcc-4_3-branch revision 141291], GMP >> version 5.0.1, MPFR version 3.0.0-p8, MPC version 0.8.2 >> GGC heuristics: --param ggc-min-expan

Re: [patch tree-optimization]: Improve handling of conditional-branches on targets with high branch costs

2011-10-10 Thread Kai Tietz
2011/10/10 Richard Guenther : > On Mon, Oct 10, 2011 at 4:06 PM, Kai Tietz wrote: >> 2011/10/10 Richard Guenther : >>> On Mon, Oct 10, 2011 at 2:29 PM, Kai Tietz wrote: Recent patch had a thinko on rhs of inner lhs check for TRUTH-IF.  It has to be checked that the LHS code is same as o

Re: [PATCH] Don't assume that constants can clobber vtbl

2011-10-10 Thread Martin Jambor
Hi, sorry that taking care of the devirtualization patches takes me longer than expected for various reasons. But I have not forgotten about this. On Sat, Oct 01, 2011 at 01:58:57PM +1300, Maxim Kuvyrkov wrote: > This patch makes detect_type_change analysis assume that only ADDR_EXPRs can > be

Re: [patch tree-optimization]: Improve handling of conditional-branches on targets with high branch costs

2011-10-10 Thread Richard Guenther
On Mon, Oct 10, 2011 at 4:06 PM, Kai Tietz wrote: > 2011/10/10 Richard Guenther : >> On Mon, Oct 10, 2011 at 2:29 PM, Kai Tietz wrote: >>> Recent patch had a thinko on rhs of inner lhs check for TRUTH-IF.  It >>> has to be checked that the LHS code is same as outer CODE, as >>> otherwise we would

Re: [PATCH 1/5] Use MADV_DONTNEED for freeing in garbage collector

2011-10-10 Thread Richard Guenther
On Mon, Oct 10, 2011 at 4:04 PM, Andi Kleen wrote: >> Shouldn't we prefer still "mapped" pages when allocating?  Thus, keep >> the freepages list "sorted"? > > Possibly. I can look at it in a followup if you want. > I would prefer to not complicate this patch too much. > >> >> With the new params

Re: [PATCH 4/5] Add a freeing threshold for the garbage collector.

2011-10-10 Thread Richard Guenther
On Mon, Oct 10, 2011 at 3:58 PM, Andi Kleen wrote: > On Mon, Oct 10, 2011 at 12:20:53PM +0200, Richard Guenther wrote: >> On Sun, Oct 9, 2011 at 9:55 PM, Andi Kleen wrote: >> > From: Andi Kleen >> > >> > Add a threshold to avoid freeing pages back too early to the OS. >> > This avoid virtual mem

[PATCH] Fix PR50195

2011-10-10 Thread Richard Guenther
Canonicalize x*x to pow(x,2) only when optimizing which is when we do optimized expansion. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2011-10-10 Richard Guenther PR middle-end/50195 * fold-const.c (fold_binary_loc): Canonicalize x*x to pow (x, 2)

Re: [patch tree-optimization]: Improve handling of conditional-branches on targets with high branch costs

2011-10-10 Thread Kai Tietz
2011/10/10 Richard Guenther : > On Mon, Oct 10, 2011 at 2:29 PM, Kai Tietz wrote: >> Recent patch had a thinko on rhs of inner lhs check for TRUTH-IF.  It >> has to be checked that the LHS code is same as outer CODE, as >> otherwise we wouldn't apply different TRUTH-IF only on inner RHS of >> LHS,

Re: [PATCH 1/5] Use MADV_DONTNEED for freeing in garbage collector

2011-10-10 Thread Andi Kleen
> Shouldn't we prefer still "mapped" pages when allocating? Thus, keep > the freepages list "sorted"? Possibly. I can look at it in a followup if you want. I would prefer to not complicate this patch too much. > > With the new params to call release_pages less, how does this > interact with us

Re: [PATCH 4/5] Add a freeing threshold for the garbage collector.

2011-10-10 Thread Andi Kleen
On Mon, Oct 10, 2011 at 12:20:53PM +0200, Richard Guenther wrote: > On Sun, Oct 9, 2011 at 9:55 PM, Andi Kleen wrote: > > From: Andi Kleen > > > > Add a threshold to avoid freeing pages back too early to the OS. > > This avoid virtual memory map fragmentation. > > > > Based on a idea from Honza >

Re: [PATCH 3/5] On a Linux kernel ask explicitely for a huge page in ggc

2011-10-10 Thread Andi Kleen
On Mon, Oct 10, 2011 at 12:29:03PM +0200, Jakub Jelinek wrote: > On Mon, Oct 10, 2011 at 12:15:14PM +0200, Richard Guenther wrote: > > On Sun, Oct 9, 2011 at 9:55 PM, Andi Kleen wrote: > > > From: Andi Kleen > > > > > > Benchmarks show slightly faster build times on a kernel > > > build, near the

Re: [PATCH 2/5] Increase the GGC quite size to 2MB

2011-10-10 Thread Jan Hubicka
> From: Andi Kleen > > Using 2MB allows modern kernels to use 2MB huge pages on x86. > > gcc/: > > 2011-10-08 Andi Kleen > > * ggc-page.c (GGC_QUIRE_SIZE): Increase to 512 > --- > gcc/ggc-page.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/gcc/ggc-p

Re: [PATCH 3/5] On a Linux kernel ask explicitely for a huge page in ggc

2011-10-10 Thread Andi Kleen
On Mon, Oct 10, 2011 at 12:15:14PM +0200, Richard Guenther wrote: > On Sun, Oct 9, 2011 at 9:55 PM, Andi Kleen wrote: > > From: Andi Kleen > > > > Benchmarks show slightly faster build times on a kernel > > build, near the measurement error unfortunately. > > > > This will only work with a recent

Re: [PATCH] Mark static const strings as read-only.

2011-10-10 Thread Eric Botcazou
> The patch makes sure that the src_mem computed here in > expand_builtin_memcpy is marked as MEM_READONLY_P: > ... > src_mem = get_memory_rtx (src, len); > ... > > build and reg-tested on i686, arm, and mips. > > OK for trunk? Do you get the same result by calling gen_const_mem from build_c

Re: patch ping: thread testing infrastructure

2011-10-10 Thread Aldy Hernandez
On 10/07/11 17:50, Mike Stump wrote: On Oct 7, 2011, at 2:52 PM, Aldy Hernandez wrote: First, thanks so much for tackling this review. I don't think anyone's overly enthusiastic about reviewing dejagnu crap^H^H^H^Hcode. I'll review it. :-) The last version looks fine to me, watch out for f

Re: Avoid double mangling at WHOPR

2011-10-10 Thread Jan Hubicka
> Can you try the "obvious" and simply mangle all local statics at > partitioning time? (leaving the non-conflict case for a further > improvement) Hmm, it needs to be done with non-WHOPR too, but sure I can give it a try. I should however finally push out the weakref bits. (here one can produce

Re: Avoid double mangling at WHOPR

2011-10-10 Thread Richard Guenther
On Mon, 10 Oct 2011, Jan Hubicka wrote: > > > Actually it seems to me that mangling at WPA makes more sense - you don't > > > get > > > symbol name sensitive on partitioning decisions so things go a bit more > > > consistently. Partitioning depends on global properties of program so any > > > co

[Patch,AVR]: Reuse __tablejump2__

2011-10-10 Thread Georg-Johann Lay
This patch does better re-usage of __tablejump2__ from libgcc so that switch/case statements with jump tables become smaller because the sequence needs 6 to 9 words compared to 2 when JMPing to __tablejump2__. Moreover, __tablejump2__ does no more rely in the content of EIND (by using EIJMP) and u

Re: Avoid double mangling at WHOPR

2011-10-10 Thread Jan Hubicka
> > Actually it seems to me that mangling at WPA makes more sense - you don't > > get > > symbol name sensitive on partitioning decisions so things go a bit more > > consistently. Partitioning depends on global properties of program so any > > code > > that depends on particular partitioning deci

Re: New warning for expanded vector operations

2011-10-10 Thread Artem Shinkarov
On Mon, Oct 10, 2011 at 12:02 PM, Richard Guenther wrote: > On Fri, Oct 7, 2011 at 9:44 AM, Artem Shinkarov > wrote: >> On Fri, Oct 7, 2011 at 6:22 AM, Artem Shinkarov >> wrote: >>> On Wed, Oct 5, 2011 at 12:35 PM, Richard Guenther >>> wrote: On Wed, Oct 5, 2011 at 1:28 PM, Artem Shinkarov

Re: Avoid double mangling at WHOPR

2011-10-10 Thread Richard Guenther
On Mon, 10 Oct 2011, Jan Hubicka wrote: > > On Sun, 9 Oct 2011, Jan Hubicka wrote: > > > > > Hi, > > > whopr currently produce local_static.1234.43124 type symbols. This is > > > because > > > everything gets mangled at WPA time and then again at ltrans time. This > > > simply > > > avoids the

Re: Avoid double mangling at WHOPR

2011-10-10 Thread Jan Hubicka
> On Sun, 9 Oct 2011, Jan Hubicka wrote: > > > Hi, > > whopr currently produce local_static.1234.43124 type symbols. This is > > because > > everything gets mangled at WPA time and then again at ltrans time. This > > simply > > avoids the second mangling. This save some space & makes WHOPR/non_

Re: Ping^3: PR middle-end/48660: Assigning to BLKmode RESULT_DECL

2011-10-10 Thread Richard Guenther
On Mon, Oct 10, 2011 at 2:35 PM, Richard Sandiford wrote: > Ping for: > >    http://gcc.gnu.org/ml/gcc-patches/2011-09/msg00558.html > > which fixes an expand-time bug in thunks that return BLKmode structures > in registers.  Tested on x86_64-linux-gnu and arm-linux-gnueabi. Ok with the changes s

Re: [patch tree-optimization]: Improve handling of conditional-branches on targets with high branch costs

2011-10-10 Thread Richard Guenther
On Mon, Oct 10, 2011 at 2:29 PM, Kai Tietz wrote: > Recent patch had a thinko on rhs of inner lhs check for TRUTH-IF.  It > has to be checked that the LHS code is same as outer CODE, as > otherwise we wouldn't apply different TRUTH-IF only on inner RHS of > LHS, which is of course wrong. > > Index

Re: [C++ Patch / RFC] PR 33067

2011-10-10 Thread Paolo Carlini
On 10/10/2011 02:13 PM, Paolo Carlini wrote: . looks like we want to do something else, not printing the number at all. See audit trail. An option, for 4.7 at least, would be, instead of just closing 33067 as a duplicate of the much more general 49152, doing something like: Index: c-family/c-p

Ping^3: PR middle-end/48660: Assigning to BLKmode RESULT_DECL

2011-10-10 Thread Richard Sandiford
Ping for: http://gcc.gnu.org/ml/gcc-patches/2011-09/msg00558.html which fixes an expand-time bug in thunks that return BLKmode structures in registers. Tested on x86_64-linux-gnu and arm-linux-gnueabi. Thanks, Richard

Re: [patch tree-optimization]: Improve handling of conditional-branches on targets with high branch costs

2011-10-10 Thread Kai Tietz
Recent patch had a thinko on rhs of inner lhs check for TRUTH-IF. It has to be checked that the LHS code is same as outer CODE, as otherwise we wouldn't apply different TRUTH-IF only on inner RHS of LHS, which is of course wrong. Index: gcc/gcc/fold-const.c ===

Re: [patch] C6X unwinding/exception handling

2011-10-10 Thread Paul Brook
> Index: libjava/exception.cc > === > --- libjava/exception.cc (revision 179739) > +++ libjava/exception.cc (working copy) > @@ -135,6 +135,7 @@ > { >_Unwind_Ptr Start; >_Unwind_Ptr LPStart; > + _Unwind_Ptr ttype_ba

Re: [PATCH] Remove "bogus" g++.dg/init/copy7.C testcase

2011-10-10 Thread Richard Guenther
On Mon, Aug 15, 2011 at 2:42 PM, Richard Guenther wrote: > > The g++.dg/init/copy7.C testcase checks whether the C++ frontend > guards memcpy it emits via a conditional verifying that src != dst > because calling memcpy with overlapping source / destination is > not supported. > > The testcase is

Re: [C++ Patch / RFC] PR 33067

2011-10-10 Thread Paolo Carlini
. looks like we want to do something else, not printing the number at all. See audit trail. Paolo.

  1   2   >