Re: df_insn_refs_record's handling of global_regs[]

2007-10-22 Thread David Miller
From: "Seongbae Park (박성배, 朴成培)" <[EMAIL PROTECTED]> Date: Mon, 22 Oct 2007 11:31:18 -0700 > On x86-64, no regression in 4.2 with the patch. > So both 4.2 and mainline patches are OK. Thank you for doing this extra regression testing. > I'd appreciate it if you can add the testcase > - it's up t

Re: df_insn_refs_record's handling of global_regs[]

2007-10-22 Thread Seongbae Park (박성배, 朴成培)
Hi Dave, On x86-64, no regression in 4.2 with the patch. So both 4.2 and mainline patches are OK. I'd appreciate it if you can add the testcase - it's up to you whether to add it in a separate patch or with this patch. Thanks for fixing it. Seongbae On 10/19/07, Seongbae Park (박성배, 朴成培) <[EMAIL

Re: df_insn_refs_record's handling of global_regs[]

2007-10-19 Thread H.J. Lu
On Fri, Oct 19, 2007 at 05:42:58PM -0700, Seongbae Park (박성배, 朴成培) wrote: > On 10/19/07, David Miller <[EMAIL PROTECTED]> wrote: > > From: "Seongbae Park (박성배, 朴成培)" <[EMAIL PROTECTED]> > > Date: Fri, 19 Oct 2007 17:25:14 -0700 > > > > > If you're not in a hurry, can you wait > > > till I run the r

Re: df_insn_refs_record's handling of global_regs[]

2007-10-19 Thread Seongbae Park (박성배, 朴成培)
On 10/19/07, David Miller <[EMAIL PROTECTED]> wrote: > From: "Seongbae Park (박성배, 朴成培)" <[EMAIL PROTECTED]> > Date: Fri, 19 Oct 2007 17:25:14 -0700 > > > If you're not in a hurry, can you wait > > till I run the regtest against 4.2 on x86-64 ? > > I've already discussed the patch with Kenny > > and

Re: df_insn_refs_record's handling of global_regs[]

2007-10-19 Thread David Miller
From: "Seongbae Park (박성배, 朴成培)" <[EMAIL PROTECTED]> Date: Fri, 19 Oct 2007 17:25:14 -0700 > If you're not in a hurry, can you wait > till I run the regtest against 4.2 on x86-64 ? > I've already discussed the patch with Kenny > and we agreed that this is the right approach, > but I'd like to see

Re: df_insn_refs_record's handling of global_regs[]

2007-10-19 Thread Seongbae Park (박성배, 朴成培)
On 10/19/07, David Miller <[EMAIL PROTECTED]> wrote: > From: "Seongbae Park (박성배, 朴成培)" <[EMAIL PROTECTED]> > Date: Tue, 16 Oct 2007 22:56:49 -0700 > > > Did you replace the DF_REF_REG_USE with DEF ? > > If so, that's not correct. We need to add DEF as well as USE: > ... > > Then, we'll need to c

Re: df_insn_refs_record's handling of global_regs[]

2007-10-19 Thread David Miller
From: "Seongbae Park (박성배, 朴成培)" <[EMAIL PROTECTED]> Date: Tue, 16 Oct 2007 22:56:49 -0700 > Did you replace the DF_REF_REG_USE with DEF ? > If so, that's not correct. We need to add DEF as well as USE: ... > Then, we'll need to change the df_invalidated_by_call loop > not to add global_regs[] a

Re: df_insn_refs_record's handling of global_regs[]

2007-10-17 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Tue, 16 Oct 2007 23:04:22 -0700 (PDT) > I will do some regression testing of the following patch against > gcc-4.2.x: > > --- ./gcc/df-scan.c.ORIG 2007-10-16 02:07:46.0 -0700 > +++ ./gcc/df-scan.c 2007-10-16 23:00:32.0 -0700 > @@

Re: df_insn_refs_record's handling of global_regs[]

2007-10-16 Thread David Miller
From: "Seongbae Park (박성배, 朴成培)" <[EMAIL PROTECTED]> Date: Tue, 16 Oct 2007 22:56:49 -0700 > We need to add DEF as well as USE: > > diff -r fd0f94fbe89d gcc/df-scan.c > --- a/gcc/df-scan.c Wed Oct 10 03:32:43 2007 + > +++ b/gcc/df-scan.c Tue Oct 16 22:52:44 2007 -0700 > @@ -3109,8 +31

Re: df_insn_refs_record's handling of global_regs[]

2007-10-16 Thread Seongbae Park (박성배, 朴成培)
On 10/16/07, David Miller <[EMAIL PROTECTED]> wrote: > From: "Seongbae Park (박성배, 朴成培)" <[EMAIL PROTECTED]> > Date: Tue, 16 Oct 2007 21:53:37 -0700 > > Annyoung haseyo, Park-sanseng-nim, :) > > loop-invariant.cc uses ud-chain. > > So if there's something wrong with the chain, > > it could go nuts

Re: df_insn_refs_record's handling of global_regs[]

2007-10-16 Thread David Miller
From: "Seongbae Park (박성배, 朴成培)" <[EMAIL PROTECTED]> Date: Tue, 16 Oct 2007 21:53:37 -0700 Annyoung haseyo, Park-sanseng-nim, > loop-invariant.cc uses ud-chain. > So if there's something wrong with the chain, > it could go nuts. > Can you send me the rtl dump of loop2_invariant pass ? I have fou

Re: df_insn_refs_record's handling of global_regs[]

2007-10-16 Thread Seongbae Park (박성배, 朴成培)
On 10/16/07, David Miller <[EMAIL PROTECTED]> wrote: > From: David Miller <[EMAIL PROTECTED]> > Date: Tue, 16 Oct 2007 03:12:23 -0700 (PDT) > > > I have a bug I'm trying to investigate where, starting in gcc-4.2.x, > > the loop invariant pass considers a computation involving a global > > register

Re: df_insn_refs_record's handling of global_regs[]

2007-10-16 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Tue, 16 Oct 2007 03:12:23 -0700 (PDT) > I have a bug I'm trying to investigate where, starting in gcc-4.2.x, > the loop invariant pass considers a computation involving a global > register variable as invariant across a call. The basic structure > of t

df_insn_refs_record's handling of global_regs[]

2007-10-16 Thread David Miller
I have a bug I'm trying to investigate where, starting in gcc-4.2.x, the loop invariant pass considers a computation involving a global register variable as invariant across a call. The basic structure of the code is: register unsigned long regvar asm ("foo"); func(arg) { for (...) {