Re: How do we write unused arguments?

2015-11-05 Thread Jeff Law
On 11/05/2015 02:32 AM, Bernd Schmidt wrote: When reviewing patches I'm never quite sure which of the following we should be using: some_target_hook (tree decl, machine_mode mode ATTRIBUTE_UNUSED) some_target_hook (tree decl, machine_mode ARG_UNUSED (mode)) some_target_hook (tree decl, machine

Re: How do we write unused arguments?

2015-11-05 Thread Jakub Jelinek
On Thu, Nov 05, 2015 at 11:19:36AM +, Richard Earnshaw wrote: > > It depends, if the argument is conditionally (based on preprocessor macros) > > used, then we need the first form. > > If it is completely unused, I also prefer the last form, but there are cases > > where one wants to document t

Re: GCC XML diagnostics

2015-11-05 Thread David Malcolm
On Thu, 2015-11-05 at 05:34 +0300, Mikhail Maltsev wrote: > Hi all! > > I'm pleased to say that two students of Lomonosov Moscow State University, > Yuri > Kemaev and Pavel Adamenko decided to work on a project related to GCC and > hopefully will become new contributors. Excellent. > I'll be as

Re: How do we write unused arguments?

2015-11-05 Thread Richard Earnshaw
On 05/11/15 10:48, Jakub Jelinek wrote: > On Thu, Nov 05, 2015 at 11:45:24AM +0100, Marek Polacek wrote: >> On Thu, Nov 05, 2015 at 10:32:11AM +0100, Bernd Schmidt wrote: >>> When reviewing patches I'm never quite sure which of the following we should >>> be using: >>> >>> some_target_hook (tree de

Re: How do we write unused arguments?

2015-11-05 Thread Jakub Jelinek
On Thu, Nov 05, 2015 at 11:45:24AM +0100, Marek Polacek wrote: > On Thu, Nov 05, 2015 at 10:32:11AM +0100, Bernd Schmidt wrote: > > When reviewing patches I'm never quite sure which of the following we should > > be using: > > > > some_target_hook (tree decl, machine_mode mode ATTRIBUTE_UNUSED) >

Re: How do we write unused arguments?

2015-11-05 Thread Marek Polacek
On Thu, Nov 05, 2015 at 10:32:11AM +0100, Bernd Schmidt wrote: > When reviewing patches I'm never quite sure which of the following we should > be using: > > some_target_hook (tree decl, machine_mode mode ATTRIBUTE_UNUSED) > > some_target_hook (tree decl, machine_mode ARG_UNUSED (mode)) > > some

Re: How do we write unused arguments?

2015-11-05 Thread Ramana Radhakrishnan
On Thu, Nov 5, 2015 at 9:32 AM, Bernd Schmidt wrote: > When reviewing patches I'm never quite sure which of the following we should > be using: > > some_target_hook (tree decl, machine_mode mode ATTRIBUTE_UNUSED) > > some_target_hook (tree decl, machine_mode ARG_UNUSED (mode)) > > some_target_hook

How do we write unused arguments?

2015-11-05 Thread Bernd Schmidt
When reviewing patches I'm never quite sure which of the following we should be using: some_target_hook (tree decl, machine_mode mode ATTRIBUTE_UNUSED) some_target_hook (tree decl, machine_mode ARG_UNUSED (mode)) some_target_hook (tree decl, machine_mode /* mode */) some_target_hook (tree dec