On Thu, Nov 05, 2015 at 11:45:24AM +0100, Marek Polacek wrote:
> On Thu, Nov 05, 2015 at 10:32:11AM +0100, Bernd Schmidt wrote:
> > When reviewing patches I'm never quite sure which of the following we should
> > be using:
> >
> > some_target_hook (tree decl, machine_mode mode ATTRIBUTE_UNUSED)
> >
> > some_target_hook (tree decl, machine_mode ARG_UNUSED (mode))
> >
> > some_target_hook (tree decl, machine_mode /* mode */)
> >
> > some_target_hook (tree decl, machine_mode)
> >
> > Any opinions? I'm leaning towards the last version since it's idiomatic in
> > the language we're using and has the least amount of visual clutter. If no
> > one comments, I'll start enforcing that in patch reviews. Currently no one
> > seems sure and everything is getting totally inconsistent.
>
> FWIW, I also like the last version best.
It depends, if the argument is conditionally (based on preprocessor macros)
used, then we need the first form.
If it is completely unused, I also prefer the last form, but there are cases
where one wants to document the purpose of the unused argument or something
similar and in that case the third one is useful.
Jakub
