Re: [PATCH v2 11/14] drm/msm/dpu: Share SSPP info for multi-rect case

2024-10-10 Thread Dmitry Baryshkov
On Fri, 11 Oct 2024 at 09:54, Jun Nie wrote: > > Dmitry Baryshkov 于2024年10月10日周四 21:21写道: > > > > On Wed, Oct 09, 2024 at 04:50:24PM GMT, Jun Nie wrote: > > > Share SSPP info for multi-rect case if virtual plane is not enabled. > > > Otherwise, the 2nd half of DMA content is not displayed due to

Re: [PATCH v2 11/14] drm/msm/dpu: Share SSPP info for multi-rect case

2024-10-10 Thread Jun Nie
Dmitry Baryshkov 于2024年10月10日周四 21:21写道: > > On Wed, Oct 09, 2024 at 04:50:24PM GMT, Jun Nie wrote: > > Share SSPP info for multi-rect case if virtual plane is not enabled. > > Otherwise, the 2nd half of DMA content is not displayed due to sspp > > pointer of r_pipe is null. > > Fixes? Yeah. It i

Re: [PATCH v2 05/14] drm/msm/dpu: handle pipes as array

2024-10-10 Thread Jun Nie
Dmitry Baryshkov 于2024年10月10日周四 21:08写道: > > On Wed, Oct 09, 2024 at 04:50:18PM GMT, Jun Nie wrote: > > Store pipes in array with removing dedicated r_pipe. There are > > 2 pipes in a drm plane at most currently. While 4 pipes are > > needed for new usage case. This change generalize the handling

Re: [PATCH v2 09/14] drm/msm/dpu: blend pipes per mixer pairs config

2024-10-10 Thread Jun Nie
Dmitry Baryshkov 于2024年10月10日周四 21:15写道: > > On Wed, Oct 09, 2024 at 04:50:22PM GMT, Jun Nie wrote: > > Blend pipes by set of mixer pair config. The first 2 pipes are for left > > half screen with the first set of mixer pair config. And the later 2 pipes > > are for right in quad pipe case. > > >

Re: [PATCH v2 08/14] drm/msm/dpu: update mixer number info earlier

2024-10-10 Thread Jun Nie
Dmitry Baryshkov 于2024年10月10日周四 21:12写道: > > On Wed, Oct 09, 2024 at 04:50:21PM GMT, Jun Nie wrote: > > Update mixer number info earlier so that the plane nopipe check > > can have the info to clip the plane. Otherwise, the first nonpipe > > check will have mixer number as 0 and plane is not check

Re: [PATCH] drm/msm/dpu: Don't always set merge_3d pending flush

2024-10-10 Thread Dmitry Baryshkov
On Wed, Oct 09, 2024 at 08:41:13PM GMT, Jessica Zhang wrote: > Don't set the merge_3d pending flush bits if the mode_3d is > BLEND_3D_NONE. > > Always flushing merge_3d can cause timeout issues when there are > multiple commits with concurrent writeback enabled. > > This is because the video phys

Re: [PATCH v2 14/14] drm/msm/dpu: Enable quad-pipe for DSC and dual-DSI case

2024-10-10 Thread Dmitry Baryshkov
On Wed, Oct 09, 2024 at 04:50:27PM GMT, Jun Nie wrote: > Request 4 mixers and 4 DSC for the case that both dual-DSI and DSC are > enabled. We prefer to use 4 pipes for dual DSI case for it is power optimal > for DSC. > > Signed-off-by: Jun Nie > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c

Re: [PATCH v2 13/14] drm/msm/dpu: support SSPP assignment for quad-pipe case

2024-10-10 Thread Dmitry Baryshkov
On Wed, Oct 09, 2024 at 04:50:26PM GMT, Jun Nie wrote: > Support SSPP assignment for quad-pipe case with unified method. > The first 2 pipes can share a set of mixer config and enable > multi-rect mode if condition is met. It is also the case for > the later 2 pipes. > > Signed-off-by: Jun Nie >

Re: [PATCH v2 12/14] drm/msm/dpu: support plane splitting in quad-pipe case

2024-10-10 Thread Dmitry Baryshkov
On Wed, Oct 09, 2024 at 04:50:25PM GMT, Jun Nie wrote: > Clip plane into pipes per left and right half screen ROI if topology > is quad pipe. Why? Please provide an explanation for the reviewers not knowing the details. > Then split the clipped rectangle by half if the rectangle > width still exc

Re: [PATCH v2 11/14] drm/msm/dpu: Share SSPP info for multi-rect case

2024-10-10 Thread Dmitry Baryshkov
On Wed, Oct 09, 2024 at 04:50:24PM GMT, Jun Nie wrote: > Share SSPP info for multi-rect case if virtual plane is not enabled. > Otherwise, the 2nd half of DMA content is not displayed due to sspp > pointer of r_pipe is null. Fixes? > > Signed-off-by: Jun Nie > --- > drivers/gpu/drm/msm/disp/dp

Re: [PATCH v2 10/14] drm/msm/dpu: Support quad-pipe in SSPP checking

2024-10-10 Thread Dmitry Baryshkov
On Wed, Oct 09, 2024 at 04:50:23PM GMT, Jun Nie wrote: > Move requreiment check to routine of every pipe check. Because there is s/Because there is/There will be/ > multiple SSPPs for quad-pipe case in future. > > Signed-off-by: Jun Nie > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 2

Re: [PATCH v2 09/14] drm/msm/dpu: blend pipes per mixer pairs config

2024-10-10 Thread Dmitry Baryshkov
On Wed, Oct 09, 2024 at 04:50:22PM GMT, Jun Nie wrote: > Blend pipes by set of mixer pair config. The first 2 pipes are for left > half screen with the first set of mixer pair config. And the later 2 pipes > are for right in quad pipe case. > > Signed-off-by: Jun Nie > --- > drivers/gpu/drm/msm/

Re: [PATCH v2 08/14] drm/msm/dpu: update mixer number info earlier

2024-10-10 Thread Dmitry Baryshkov
On Wed, Oct 09, 2024 at 04:50:21PM GMT, Jun Nie wrote: > Update mixer number info earlier so that the plane nopipe check > can have the info to clip the plane. Otherwise, the first nonpipe > check will have mixer number as 0 and plane is not checked. > > Signed-off-by: Jun Nie > --- > drivers/gp

Re: [PATCH v2 07/14] drm/msm/dpu: bind correct pingpong for quad pipe

2024-10-10 Thread Dmitry Baryshkov
On Wed, Oct 09, 2024 at 04:50:20PM GMT, Jun Nie wrote: > There are 2 interfaces and 4 pingpong in quad pipe. Map the 2nd > interface to 3rd PP instead of the 2nd PP. > > Signed-off-by: Jun Nie Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 11 ---

Re: [PATCH v2 05/14] drm/msm/dpu: handle pipes as array

2024-10-10 Thread Dmitry Baryshkov
On Wed, Oct 09, 2024 at 04:50:18PM GMT, Jun Nie wrote: > Store pipes in array with removing dedicated r_pipe. There are > 2 pipes in a drm plane at most currently. While 4 pipes are > needed for new usage case. This change generalize the handling > to pipe pair and ease handling to another pipe pai

Re: [PATCH v2 01/14] drm/msm/dpu: polish log for resource allocation

2024-10-10 Thread Dmitry Baryshkov
On Wed, Oct 09, 2024 at 04:50:14PM GMT, Jun Nie wrote: > Add resource allocation type info. Please describe changes properly. > > Signed-off-by: Jun Nie > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 23 +++ > 1 file changed, 19 insertions(+), 4 deletions(-) > > diff --g

Re: [PATCH v2 00/14] drm/msm/dpu: Support quad pipe with dual-DSI

2024-10-10 Thread Dmitry Baryshkov
On Wed, Oct 09, 2024 at 04:50:13PM GMT, Jun Nie wrote: > > --- > 2 or more SSPPs and dual-DSI interface are need for super wide DSI panel. > And 4 DSC are prefered for power optimal in this case. This patch set > extend number of pipes to 4 and revise related mixer blending logic > to support quad

Re: [PATCH 2/2] drm/msm/dpu: configure DSC per number in use

2024-10-10 Thread Dmitry Baryshkov
On Wed, Oct 09, 2024 at 02:38:43PM GMT, Jun Nie wrote: > Only 2 DSC engines are allowed, or no DSC is involved currently. > We need 4 DSC in quad-pipe topology in future. So let's only configure > DSC engines in use, instread of maximum number of DSC engines. > > Signed-off-by: Jun Nie > --- > d

Re: [RFC PATCH 1/2] drm/drm_file: Add display of driver's internal memory size

2024-10-10 Thread Tvrtko Ursulin
On 09/10/2024 23:55, Adrián Larumbe wrote: Hi Tvrtko, On 04.10.2024 14:41, Tvrtko Ursulin wrote: Hi Adrian, On 03/10/2024 00:45, Adrián Larumbe wrote: Some drivers must allocate a considerable amount of memory for bookkeeping structures and GPU's MCU-kernel shared communication regions. Th

Re: [PATCH] drm/msm/dpu: don't always program merge_3d block

2024-10-10 Thread Dmitry Baryshkov
On Thu, 10 Oct 2024 at 06:46, Jessica Zhang wrote: > > Only program the merge_3d block for the video phys encoder when the 3d > blend mode is not NONE Please describe why, not what. > > Fixes: 3e79527a33a8 ("drm/msm/dpu: enable merge_3d support on sm8150/sm8250") > Suggested-by: Abhinav Kumar >

Re: [PATCH 2/2] drm/msm/dpu: configure DSC per number in use

2024-10-10 Thread Dmitry Baryshkov
On Thu, 10 Oct 2024 at 04:47, Jun Nie wrote: > > Dmitry Baryshkov 于2024年10月10日周四 06:10写道: > > > > On Wed, 9 Oct 2024 at 09:39, Jun Nie wrote: > > > > > > Only 2 DSC engines are allowed, or no DSC is involved currently. > > > > Can't parse this phrase. > > How about this: > If DSC is enabled, the