On 3/30/2005 9:30 PM Karl Denninger wrote:
On Wed, Mar 30, 2005 at 10:44:38AM -0800, Drew Tomlinson wrote:
I missed the beginning of this thread and apologize if my question has
already been covered. But can you tell me if this issue might be the
reason my PC locks up intermittently ? I have
On Tue, Apr 05, 2005 at 08:25:04PM -0500, Karl Denninger wrote:
>
> This patch appears to be "safe".
>
> I have about 2 hours on the production machine right now post-rebuild (which
> had to complete first) with the added "callout_drain" in, have taken two DMA
> WRITE retries, and have not yet se
On Thu, Mar 31, 2005 at 11:06:08AM -0600, Karl Denninger wrote:
> On Thu, Mar 31, 2005 at 12:02:20PM -0500, Matthew N. Dodd wrote:
> > On Wed, 30 Mar 2005, Karl Denninger wrote:
> > > Removing the FIRST delta, which is:
> > >
> > > 218a219,221
> > > if (!dumping)
> > > callout_reset
On Thu, Mar 31, 2005 at 12:02:20PM -0500, Matthew N. Dodd wrote:
> On Wed, 30 Mar 2005, Karl Denninger wrote:
> > Removing the FIRST delta, which is:
> >
> > 218a219,221
> > if (!dumping)
> > callout_reset(&request->callout, request->timeout * hz,
> > (timeou
On Wed, 2005-03-30 at 23:30 -0600, Karl Denninger wrote:
> BTW its NOT your hardware at fault here - the same hardware that returns
> these complaints for me on 5.x works perfectly with 4.11. There have been
> changes made to the ATA code that apparently interact VERY badly with
> some control
On Wed, Mar 30, 2005 at 10:44:38AM -0800, Drew Tomlinson wrote:
> >
> I missed the beginning of this thread and apologize if my question has
> already been covered. But can you tell me if this issue might be the
> reason my PC locks up intermittently ? I have whatever cheap card came
> with a
Ok, here's what I've got so far.
Pulling the SECOND delta both gets rid of the stability problem AND the
requeue fix (e.g. getting rid of that denies the essential purpose of the
deltas in the first place.)
Removing the FIRST delta, which is:
218a219,221
if (!dumping)
callout_r
Nevermind on my update - somehow "cvs" got the wrong tag (5.3-RELEASE) on my
sandbox build.
Doing it again :)
--
--
Karl Denninger ([EMAIL PROTECTED]) Internet Consultant & Kids Rights Activist
http://www.denninger.netMy home on the net - links to everything I do!
http://scubaforum.o
On Tue, Mar 29, 2005 at 11:43:18PM -0600, Karl Denninger wrote:
> Here's the diff and some thoughts
>
> Fs:/usr/src/sys/dev/ata> cvs diff -r 1.32.2.5 ata-queue.c
> Index: ata-queue.c
> ===
> RCS file: /usr/cvs/src/sys/dev/ata/ata-
On Wed, Mar 30, 2005 at 12:06:11AM -0600, Karl Denninger wrote:
> On Wed, Mar 30, 2005 at 12:50:31AM -0500, Matthew N. Dodd wrote:
> > On Tue, 29 Mar 2005, Karl Denninger wrote:
> > > 245a252
> > >> request->donecount = 0;
> > >
> > > Without the last delta the requeue doesn't happen at a
On 3/30/2005 9:39 AM Karl Denninger wrote:
On Wed, Mar 30, 2005 at 12:07:22PM -0500, Jim Trigg wrote:
On Wed, March 30, 2005 12:43 am, Karl Denninger said:
Here's the diff and some thoughts
[snip, including first diff]
241,243c244,249
<
< /* if reinit succeeded and ret
On Wed, Mar 30, 2005 at 12:07:22PM -0500, Jim Trigg wrote:
> On Wed, March 30, 2005 12:43 am, Karl Denninger said:
> > Here's the diff and some thoughts
>
> [snip, including first diff]
>
> > 241,243c244,249
> > <
> > < /* if reinit succeeded and retries still permit, reinject request
>
On Wed, March 30, 2005 12:43 am, Karl Denninger said:
> Here's the diff and some thoughts
[snip, including first diff]
> 241,243c244,249
> <
> < /* if reinit succeeded and retries still permit, reinject request
> */
> < if (ata_reinit(ch) && request->retries-- > 0 &&
> request->de
On Wed, Mar 30, 2005 at 12:50:31AM -0500, Matthew N. Dodd wrote:
> On Tue, 29 Mar 2005, Karl Denninger wrote:
> > 245a252
> >> request->donecount = 0;
> >
> > Without the last delta the requeue doesn't happen at all.
>
> So you're saying that this change:
>
> 1.42: When resubmitti
On Tue, 29 Mar 2005, Karl Denninger wrote:
245a252
request->donecount = 0;
Without the last delta the requeue doesn't happen at all.
So you're saying that this change:
1.42: When resubmitting a timed out request, reset donecount.
produces the problem?
--
10 40 80 C0 00 FF FF FF FF
Here's the diff and some thoughts
Fs:/usr/src/sys/dev/ata> cvs diff -r 1.32.2.5 ata-queue.c
Index: ata-queue.c
===
RCS file: /usr/cvs/src/sys/dev/ata/ata-queue.c,v
retrieving revision 1.32.2.5
retrieving revision 1.32.2.6
diff -r1
On Tue, 29 Mar 2005, Karl Denninger wrote:
Pretty sure its the requeue (e.g. 1.40 and 1.42).
Isolate the specific change please.
--
10 40 80 C0 00 FF FF FF FF C0 00 00 00 00 10 AA AA 03 00 00 00 08 00
___
freebsd-stable@freebsd.org mailing list
http://lis
On Tue, Mar 29, 2005 at 11:40:48PM -0500, Matthew N. Dodd wrote:
> On Tue, 29 Mar 2005, Karl Denninger wrote:
> > 1.42: When resubmitting a timed out request, reset donecount.
> > 1.41: Reset timeout when we are back from interrupt.
> > 1.40: Correct logical error, result was that retries wasn't
On Tue, 29 Mar 2005, Karl Denninger wrote:
1.42: When resubmitting a timed out request, reset donecount.
1.41: Reset timeout when we are back from interrupt.
1.40: Correct logical error, result was that retries wasn't always made but
failure reported instead.
1.39: Do not retry on reques
19 matches
Mail list logo
