On 3/30/2005 9:39 AM Karl Denninger wrote:

On Wed, Mar 30, 2005 at 12:07:22PM -0500, Jim Trigg wrote:


On Wed, March 30, 2005 12:43 am, Karl Denninger said:


Here's the diff and some thoughts....


[snip, including first diff]



241,243c244,249
<
< /* if reinit succeeded and retries still permit, reinject request
*/
< if (ata_reinit(ch) && request->retries-- > 0 &&
request->device->param){
---


/*
* if reinit succeeds, retries still permit and device didn't
* get removed by the reinit, reinject request
*/
if (!ata_reinit(ch) && request->retries-- > 0
&& request->device->param){


[snip third diff]



The second diff is really just a formatting and comment change.. you're
certainly correct that the changes are small! :-)


No, it is not -- it reverses the sense of the first condition.  At first
glance that is what I would expect to be the core of the problem, but I
don't have appropriate hardware to test on.  (It also adds a third
condition, but that is presumably the intent of the change and should give
the desired results once the first condition is corrected.)



You're correct of course - I missed the "!".  Too darn late at night...

I've got my sandbox up and the world rebuilt so its consistent with the
machine that's having the problem - will add a SATA disk and see if I can duplicate this and then figure out what's going on here this afternoon - and hopefully how to fix it.


I missed the beginning of this thread and apologize if my question has already been covered. But can you tell me if this issue might be the reason my PC locks up intermittently ? I have whatever cheap card came with a Maxtor 160 GB SATA drive installed in this machine and the PC ran fine with Windows. Now I'm trying install FBSD from the 5.4-BETA ISO I downloaded from the ftp site. The PC runs POST fine and always boots from the CD to the boot menu. After picking the default option 1 (normal boot) the PC locks up anywhere from the dmesg output to sysinstall actually beginning to install the base package after doing the fdisk and disklabel stuff. Should I download 5.3-RELEASE and try installing from that?

Thanks,

Drew
_______________________________________________
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "[EMAIL PROTECTED]"

Reply via email to