Re: failed bsd.qt.mk fix...

2011-07-03 Thread Chris Rees
On 3 July 2011 18:08, Alberto Villa wrote: > On Sunday 03 July 2011 15:25:09 Chris Rees wrote: >> As I read it, while it supports a system where cc is a link to clang, >> it still clobbers whatever ${CC} variable I have set. > > this is wrong. here is how the logic works: > - find if cc is gcc or

Re: failed bsd.qt.mk fix...

2011-07-03 Thread Alberto Villa
On Sunday 03 July 2011 15:25:09 Chris Rees wrote: > As I read it, while it supports a system where cc is a link to clang, > it still clobbers whatever ${CC} variable I have set. this is wrong. here is how the logic works: - find if cc is gcc or clang - if CXX is the default c++, then we're using t

Re: failed bsd.qt.mk fix...

2011-07-03 Thread Chris Rees
On 2 July 2011 00:36, Alberto Villa wrote: > On Friday 01 July 2011 21:00:07 Rene Ladan wrote: >> Wouldn't it be better to use ${CC} instead of cc in the above patch so >> that clang is also (a bit more) supported? > > no. please, read the whole logic to understand how it works. that check is > do

Re: failed bsd.qt.mk fix...

2011-07-01 Thread Alberto Villa
On Friday 01 July 2011 21:00:07 Rene Ladan wrote: > Wouldn't it be better to use ${CC} instead of cc in the above patch so > that clang is also (a bit more) supported? no. please, read the whole logic to understand how it works. that check is done to support cc == clang, which means that clang is

Re: failed bsd.qt.mk fix...

2011-07-01 Thread Oliver Pinter
The original (commited patch in ports) is not my patch. I only wrote a fixup to make it usable, after avillas commit breaked the ports. On 7/1/11, Rene Ladan wrote: > Op 01-07-2011 20:54, Oliver Pinter schreef: >> On 7/1/11, Oliver Pinter wrote: >>> after reverting this: >>> http://www.freebsd.o

Re: failed bsd.qt.mk fix...

2011-07-01 Thread Rene Ladan
Op 01-07-2011 20:54, Oliver Pinter schreef: > On 7/1/11, Oliver Pinter wrote: >> after reverting this: >> http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.qt.mk.diff?r1=1.24;r2=1.25 >> everything look fine.. > > or use this patch: > > op@pandora-d ~> less /tmp/diff > --- bsd.qt.mk 2011-07-01

Re: failed bsd.qt.mk fix...

2011-07-01 Thread Oliver Pinter
On 7/1/11, Oliver Pinter wrote: > after reverting this: > http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.qt.mk.diff?r1=1.24;r2=1.25 > everything look fine.. > > On 7/1/11, Oliver Pinter wrote: >> awk: syntax error at source line 1 >> context is >> NR == 1 { gsub(/[()]/, "", >>> ) <<

Re: failed bsd.qt.mk fix...

2011-07-01 Thread Oliver Pinter
after reverting this: http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.qt.mk.diff?r1=1.24;r2=1.25 everything look fine.. On 7/1/11, Oliver Pinter wrote: > awk: syntax error at source line 1 > context is > NR == 1 { gsub(/[()]/, "", >>> ) <<< > awk: illegal statement at source line 1 >

failed bsd.qt.mk fix...

2011-07-01 Thread Oliver Pinter
awk: syntax error at source line 1 context is NR == 1 { gsub(/[()]/, "", >>> ) <<< awk: illegal statement at source line 1 "/usr/ports/Mk/bsd.qt.mk", line 115: warning: "cc --version 2> /dev/null | awk 'NR == 1 { gsub(/[()]/, "", ); print }'" returned non-zero status awk: syntax error at