[Differential] D10485: Replace dhcp option 150 by 66

2017-04-26 Thread tsoome (Toomas Soome)
tsoome added a comment. I think we should really keep both 66 and 150. But also definitely we should point out in docs that in case of option 66, the ip address should be used, as in current code, we do not have name resolver. This does add some more complications to the validation and feedb

[Differential] D10485: Replace dhcp option 150 by 66

2017-05-01 Thread tsoome (Toomas Soome)
tsoome added a comment. In https://reviews.freebsd.org/D10485#218907, @kczekirda wrote: > Until I go forward with your comments about the code I want to highlight it's not possible to support option 150, because we have to ask DHCP server for this option. PXE client (I mean network card

[Differential] D10485: Replace dhcp option 150 by 66

2017-05-02 Thread tsoome (Toomas Soome)
tsoome added a comment. In https://reviews.freebsd.org/D10485#219245, @kczekirda wrote: > @rgrimes > Please try to boot CURRENT over tftp protocol and without any third part software like iPXE. > > @tsoome > > > Note that dhcp servers in real life can offer all the configured

[Differential] D10485: Replace dhcp option 150 by 66

2017-05-02 Thread tsoome (Toomas Soome)
tsoome added a comment. btw, I did test with my vmware fusion VM, the pxe boot is sending out: DHCP: Message type = DHCPDISCOVER DHCP: Requested Options: DHCP:1 (Subnet Mask) DHCP:2 (UTC Time Offset) DHCP:3 (Router) DHCP:5 (IEN 116 Name Servers) DHCP:6 (DNS Ser

[Differential] D10485: Replace dhcp option 150 by 66

2017-05-03 Thread tsoome (Toomas Soome)
tsoome added a comment. In https://reviews.freebsd.org/D10485#219375, @kczekirda wrote: > @tsoome > I based on the Intel's PXE Specification and there 66 exists. > > Nevermind, let's focus on the root-path. If we cannot use prefix tftp, maybe it can be a suffix? iPXE ignores bad r

[Differential] D10485: Replace dhcp option 150 by 66

2017-05-03 Thread tsoome (Toomas Soome)
tsoome added a comment. well, the root path idea is not bad (IMO;) just I have a bit the same concern that at the end of the day it still may not be enough for whatever reason and then we are still back on the beginning:D REVISION DETAIL https://reviews.freebsd.org/D10485 EMAIL PREFERENCE

[Differential] D10603: distinguish NFS versus TFTP boot by rootpath

2017-05-06 Thread tsoome (Toomas Soome)
tsoome accepted this revision. This revision has a positive review. REVISION DETAIL https://reviews.freebsd.org/D10603 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: kczekirda, oshogbo, tsoome, bapt, sbruno, freebsd-net-list, #network Cc: rgrimes _

[Differential] D10603: distinguish NFS versus TFTP boot by rootpath

2017-05-17 Thread tsoome (Toomas Soome)
tsoome added a comment. In https://reviews.freebsd.org/D10603#223301, @bapt wrote: > We need to find a better mechanism, as this break usage where rootpath /something was before this patch expecting NFS to be located on the same serveur as the tftp server. This is now broken (it is used

[Differential] D10603: distinguish NFS versus TFTP boot by rootpath

2017-05-17 Thread tsoome (Toomas Soome)
tsoome added a comment. In https://reviews.freebsd.org/D10603#223317, @bapt wrote: > so ipxe will catch and use: iscsi:/ tftp:/ nfs:/ http:/ https:/ etc, maybe we should use tftpfs:/ > > In this case pxe will give a message saying (ignore unsupported root path) and continue what do y

[Differential] D10603: distinguish NFS versus TFTP boot by rootpath

2017-05-17 Thread tsoome (Toomas Soome)
tsoome added a comment. In https://reviews.freebsd.org/D10603#223350, @bapt wrote: > What I mean is we cannot use the one I listed above because they are interpreted by ipxe. For example if one netboots from qemu it will use ipxe under the hood first, then if you pass rootpath tftp:/ ipx