rgrimes accepted this revision as: rgrimes.
This revision is now accepted and ready to land.
CHANGES SINCE LAST ACTION
https://reviews.freebsd.org/D19422/new/
REVISION DETAIL
https://reviews.freebsd.org/D19422
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences
rgrimes added a comment.
RFC1048 is obsoleted, first by 1533, then by 2132. Please lets follow
current RFC's when seeking information and refering to them. Refering to
obsolete RFC's is going to lead to obsolete code. I see at least in the
comment of adding vend_end that yo
rgrimes added a comment.
In https://reviews.freebsd.org/D10485#217709, @kczekirda wrote:
> @rgrimes
> RFC1048 is here, because 1048 is a part of names of functions or variables
in bootp.c, I think we should rename them. I updated the description of
revision with part about
rgrimes added a comment.
In https://reviews.freebsd.org/D10485#217756, @asomers wrote:
> In https://reviews.freebsd.org/D10485#217709, @kczekirda wrote:
>
> >
>
>
> @kczekirda I'm not worried about compatibility with the PXE standard. I'm
w
rgrimes added inline comments.
INLINE COMMENTS
> bootp.c:443
> + if (tag == TAG_TFTP_SERVER_NAME) {
> + val = strsep(&cp, VEND_INFO_END);
> + if ((ipaddr = inet_addr(val)) != INADDR_NONE)
You marked this as done but it stil
rgrimes added a comment.
I have done some more digging, in rfc3492 section 4 the ietf has reclassified
options: 4. Reclassifying Options The site-specific option codes 128 to 223
are hereby reclassified as publicly defined options. This leaves 31
site-specific options, 224 to 254
rgrimes added a comment.
The more I look at PXE and DHCP the sicker I get. Your right, a client well
not normally request option 150, for that matter I am not sure it well request
66 either, though I suspect many do, and probably many of them also wrongly
interpret that as a dotted quad
rgrimes added a comment.
I am happy with this, it moves us forward, and removes the option 150 hack.
I am pretty sure that you can actually dole out more than 1 tftp server by
careful use of dhcp server configurations, ie the dhcp server has full control
over what next-server you are told
