[Differential] [Updated, 2, 470 lines] D1438: FreeBSD callout rewrite and cleanup

hselasky updated this revision to Diff 3809. hselasky added a comment. Update diff after r278623. No other changes. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1438?vs=3734&id=3809 REVISION DETAIL https://reviews.freebsd.org/D1438 AFFECTED FILES share/man/man9/Makefile share/

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

hselasky added a comment. Hi, rrs + hiren: I think the problem is this: In "_callout_stop_safe()" we sometimes exit having "cc_migration_cpu(cc, direct) = CPUBLOCK;". Now if a second call to "_callout_stop_safe()" happens before the pending callback has returned, which is using a mutex, we ar

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

hselasky added a comment. If you change how "cc_migration_cpu(cc, direct)" works, the "cc_cce_migrating()" checks become invalid. I think you need to introduce yet another callout flag REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbr

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

rrs added a comment. Hans: I don't get your call sequence, I sent you an email on it.. Hiren: Can you go up the call chain and dump the callout structure c in 0x80760064 in callout_lock (c=0xf8000d81dc98) at /usr/src/sys/kern/kern_timeout.c:530 There is something funny here, becau

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

hiren added a comment. >>! In D1711#88, @rrs wrote: > Hans: > > I don't get your call sequence, I sent you an email on it.. > > Hiren: > > Can you go up the call chain and dump the callout structure > c in > 0x80760064 in callout_lock (c=0xf8000d81dc98) at > /usr/src/sys/kern/kern_

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

hiren added a comment. >>! In D1711#86, @hselasky wrote: > Hi, > > rrs + hiren: > > I think the problem is this: > > In "_callout_stop_safe()" we sometimes exit having "cc_migration_cpu(cc, > direct) = CPUBLOCK;". Now if a second call to "_callout_stop_safe()" happens > before the pending cal

Re: Adding new media types to if_media.h

On Monday, February 16, 2015 8:50:56 pm Mike Karels wrote: > On Feb 9, gnn wrote: > > > On 8 Feb 2015, at 22:41, Mike Karels wrote: > > > > Sorry to reply to a thread after such a long delay, but I think it is > > > unresolved, and needs more discussion. I'd like to elaborate a bit on > > > my g

Re: Adding new media types to if_media.h

Looks good to me. Thanks for doing this! -a On 16 February 2015 at 17:50, Mike Karels wrote: > On Feb 9, gnn wrote: > >> On 8 Feb 2015, at 22:41, Mike Karels wrote: > >> > Sorry to reply to a thread after such a long delay, but I think it is >> > unresolved, and needs more discussion. I'd li

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

rrs added a comment. Hiren: Thats helpful.. as I said this is strange. The callout you posted shows its associated with CPU 0, (c_cpu == 0), and yet the mtx on that (which is what we are spinning on) is free (its owned == 4). So why would we have crashed holding the spin lock too long? Unless j

[Differential] [Request, 120 lines] D1870: Add tests for nvlist_clone

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1870 AFFECTED FILES lib/libnv/tests/nv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd ___ fr

[Differential] [Request, 82 lines] D1872: Add test cases for nvlist_move_*

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1872 AFFECTED FILES lib/libnv/tests/nv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd ___ fr

[Differential] [Request, 206 lines] D1874: Add tests for nvlist_free* functions

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1874 AFFECTED FILES lib/libnv/tests/nv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd ___ fr

[Differential] [Request, 7 lines] D1868: Make libnv headers includable from C++

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1868 AFFECTED FILES lib/libnv/dnv.h lib/libnv/nv.h To: rstone, jfvogel Cc: freebsd-net, pjd _

[Differential] [Request, 309 lines] D1869: Tests of basic nvlist add functions

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1869 AFFECTED FILES lib/libnv/Makefile lib/libnv/tests/Makefile lib/libnv/tests/nv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd __

[Differential] [Request, 185 lines] D1871: Add tests for nvlist_pack/unpack

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1871 AFFECTED FILES lib/libnv/tests/nv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd ___ fr

[Differential] [Closed] D1660: Add support for mac-addr parameter

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1660 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Closed] D1661: Add some security-related config parameters

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1661 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Request, 292 lines] D1873: Add tests for nvlist_take_*

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1873 AFFECTED FILES lib/libnv/tests/nv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd ___ fr

[Differential] [Closed] D1659: Register ixl as an SR-IOV-capable driver during attach

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1659 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Closed] D1656: Handle VFLR events from VFs

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1656 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Request, 290 lines] D1875: Add tests for dnv_get_*

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1875 AFFECTED FILES lib/libnv/tests/Makefile lib/libnv/tests/dnv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd __

[Differential] [Closed] D1655: Add support for GET_STATS VC message

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1655 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Request, 259 lines] D1881: Allow Illumos code to co-exist with nv(9)

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1881 AFFECTED FILES sys/cddl/compat/opensolaris/sys/nvpair.h To: rstone, jfvogel Cc: freebsd-net, pjd _

[Differential] [Request, 395 lines] D1879: Don't allocate memory for operations that do not insert

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION SUMMARY Almost every operation performed on an nvlist was allocating a new string to hold the key name. The nvlist_exists* family of functions would always return false if th

[Differential] [Request, 39 lines] D1880: Prevent creation of an invalid nvlist

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION SUMMARY If an nvlist is set as a child of another nvlist with nvlist_move_nvlist then fail the operation and set the parent nvlist to the error state. REVISION DETAIL https

[Differential] [Closed] D1654: Add support for CONFIG_PROMISCUOUS_MODE VC message

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1654 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Request, 60 lines] D1878: Add function to force an nvlist into the error state

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION SUMMARY Add an nvlist_set_error() function that can be used to force an nvlist into the error state. This is useful both for writing tests and for writing APIs that use nvlis

[Differential] [Closed] D1658: Add sysctls for per-VF hardware counters

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1658 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Request, 288 lines] D1876: Add tests for dnvlist_take_*

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1876 AFFECTED FILES lib/libnv/tests/dnv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd ___ f

[Differential] [Request, 82 lines] D1877: Implement asprintf in libkern

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1877 AFFECTED FILES sys/conf/files sys/libkern/asprintf.c sys/sys/systm.h To: rstone, jfvogel Cc: freebsd-net, pjd

[Differential] [Closed] D1657: Allow VFs to run while the PF is admin down

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1657 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Request, 471 lines] D1882: Add macros to make code compile in kernel

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION SUMMARY Make it possible to compile libnv in the kernel. Mostly this involves wrapping functions that have a different signature in the kernel and in userland (e.g. malloc())

[Differential] [Closed] D1646: Add support for RESET_VF VC message

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1646 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Closed] D1652: Add support for ADD/DEL_ETHER_ADDRESS VC messages

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1652 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Request, 1, 516 lines] D1883: Move libnv into the kernel and hook it into the kernel build

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1883 AFFECTED FILES lib/libnv/Makefile lib/libnv/dnv.h lib/libnv/dnvlist.c lib/libnv/nv.h lib/libnv/nv_impl.h lib/libnv/nvlist.c

[Differential] [Closed] D1651: Add support for ENABLE/DISABLE_QUEUES VC messages

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1651 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Closed] D1653: Add support for ADD/DEL_VLAN VC messages

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1653 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Closed] D1649: Add support for CONFIG_VSI_QUEUES VC message

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1649 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Closed] D1650: Add support for CONFIG_IRQ_MAP VC message

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1650 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Closed] D1643: Implement resetting a VF

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1643 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Closed] D1642: Implement PCI SR-IOV method to initialize individual VFs

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1642 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Closed] D1647: Add support for GET_VF_RESOURCES VC message

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1647 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Closed] D1645: Add support for VERSION VC message

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1645 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Closed] D1641: Implement PCI SR-IOV initialization methods

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1641 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Closed] D1644: Add infrastructure for handling the VC msg channel from VFs

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1644 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Closed] D1640: Refactor network stack state separate from VSI state

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1640 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

rrs added a comment. Hiren: There also should have been a printf before the panic string printf( "spin lock %p (%s) held by %p (tid %d) too long\n", m, m->lock_object.lo_name, td, td->td_tid); Can we see what that lovely printf has displayed? In theory the lo_name should be "callou

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

hiren added a comment. >>! In D1711#91, @rrs wrote: > Hiren: > > Thats helpful.. as I said this is strange. The callout you posted shows its > associated with CPU 0, (c_cpu == 0), and yet > the mtx on that (which is what we are spinning on) is free (its owned == 4). > So why would we have crash

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

rrs added a comment. Wow, but look at the flags here. They are cc_flags == 0. That means its *not* on the wheel and yet the thing it points to (our victim) *thinks* its on the wheel. This is not good.. We are stuck in a lock trying to reschedule the timeout (a lock that is not locked by the way

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

hiren added a comment. >>! In D1711#92, @rrs wrote: > Hiren: > > There also should have been a printf before the panic string > printf( "spin lock %p (%s) held by %p (tid %d) too long\n", > m, m->lock_object.lo_name, td, td->td_tid); > > Can we see what that lovely printf has displa

FreeBSD 10.1-RC4-p1

Hi, I hope this is correct mailing list to report an issue in network.subr. At line 764 in function ipv6_down() & file /etc/network.subr , shouldn't the statement 'case $_inet in ' be 'case $_inet6 in'. Thanks Ashutosh =

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

rrs added a comment. Hiren: You have the wrong structure type. In the printf before panic it is giving you the lock that was spinning.. that would be in the callout_cpu structure I bet.. I mis-told you in email. So if you did print *(struct callout_cpu *)0x81364180 It should show you

FreeBSD 10.1-RC4-p1 - issue in ipv6_down() in /etc/network.subr

Just modified the subject for more relevance. Thanks, Ashutosh +91 9899653573 -Original Message- From: owner-freebsd-...@freebsd.org [mailto:owner-freebsd-...@freebsd.org] On Behalf Of Ashutosh Kumar Sent: Tuesday, February 17, 2015 11:59 PM To: freebsd-net@freebsd.org Subject: FreeBSD

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

hiren added a comment. >>! In D1711#96, @rrs wrote: > Hiren: > > You have the wrong structure type. > > In the printf before panic it is giving you the lock that was spinning.. that > would be in the callout_cpu structure I bet.. I mis-told you in email. > > So if you did > > print *(struct ca

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

hselasky added a comment. randall: Let me try to explain a bit slower: Assume that a callout has been cancelled and is now migrating to another CPU. c->c_cpu = CPUBLOCK. Upon calling _callout_stop_safe() we will enter the callout_lock() function which will wait for the condition "c->c_cpu == C

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

rrs added a comment. Hans: Let me explain to you how I think you are wrong, you are missing a small subtle thing here When we do the callout_stop we set cc_migration_cpu() = CPUBLOCK *NOT* c->c_cpu = CPUBLOCK; You are confusing the two things. The CPUBLOCK is used in two different places

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

hselasky added a comment. randall: You are right I confused the two c_cpu values. Let my try to shoot again: static struct callout_cpu * callout_cpu_switch(struct callout *c, struct callout_cpu *cc, int new_cpu) { struct callout_cpu *new_cc; MPASS(c != NULL && cc != NULL);

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

rrs added a comment. Hans: I think your wrong here. The caller of callout_cpu_switch() is holding the CC_LOCK(). Now there are only two callers of this function. Either the actual callout code itself (softclock_call_cc()) or the callout_reset_sbt_on(). In the case of callout_reset_sbt_on(). So

[Differential] [Changed Subscribers] D1438: FreeBSD callout rewrite and cleanup

wblock added a subscriber: wblock. wblock added a comment. This is as much as I have time for at the moment. I'll add doc to the reviewers list INLINE COMMENTS share/man/man9/timeout.9:73 That is kind of a difficult sentence to parse. Does this retain the meaning? API is used to schedu

[Differential] [Updated] D1438: FreeBSD callout rewrite and cleanup

wblock added a reviewer: doc. REVISION DETAIL https://reviews.freebsd.org/D1438 To: hselasky, jhb, adrian, markj, emaste, sbruno, imp, lstewart, rwatson, gnn, rrs, kostikbel, delphij, neel, erj, remkolodder, bcr, brueffer, brd, allanjude, wblock Cc: wblock, freebsd-net ___

Re: FreeBSD 10.1-RC4-p1

On Feb 17, 2015, at 10:29, Ashutosh Kumar wrote: > At line 764 in function ipv6_down() & file /etc/network.subr , shouldn't the > statement 'case $_inet in ' be 'case $_inet6 in'. You are correct. I just fixed this. Thanks! -- Rui Paulo ___ freebs