[Differential] [Request, 2 lines] D1694: sfxge: Move txq->next pointer to part writable on completion path

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY In fact the pointer is used only if more than one TXQ is processed in one interrupt. It is used (read-write) on completion path only. Also it makes the first part of

[Differential] [Request, 35 lines] D1697: sfxge: Expect required init_state on data path and in periodic calls

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY Sponsored by: Solarflare Communications, Inc. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1697 AFFECTED FILES sys/dev/sfxge/sfxge_ev.c sys/dev/sfx

[Differential] [Request, 14 lines] D1698: sfxge: Make it possible to build without EVQ statistics

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY Sponsored by: Solarflare Communications, Inc. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1698 AFFECTED FILES sys/dev/sfxge/common/efx_ev.c sys/de

[Differential] [Request, 20 lines] D1699: sfxge: Remove extra cache-line alignment and reorder sfxge_evq_t

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY Remove the first member alignment to cacheline since it is nop. Use __aligned() for the whole structure to make sure that the structure size is cacheline aligned. Remo

[Differential] [Request, 16 lines] D1700: sfxge: fixed TSO code to cope with VLAN headers

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY Submitted by: Artem V. Andreev Sponsored by: Solarflare Communications, Inc. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1700 AFFECTED FILES sy

[Differential] [Updated] D1692: sfxge: Change sfxge_ev_qpoll() proto to avoid EVQ pointers array access

arybchik set the repository for this revision to rS (FreeBSD src repository). REVISION DETAIL https://reviews.freebsd.org/D1692 To: arybchik, gnn Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebs

[Differential] [Request, 17 lines] D1701: sfxge: Add evq argument to sfxge_tx_qcomplete()

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY It removes necessity to get evq pointer by its index in soft context. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1701 AFFECTED FILES sys/dev/sfxge/sf

[Differential] [Request, 2 lines] D1702: sfxge: Do not bzero() DMA allocated memory once again

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY sfxge_dma_alloc() calls bus_dmamem_alloc() with BUS_DMA_ZERO flag, so allocated memory is already filled in by zeros BRANCH /head REVISION DETAIL https://reviews.fre

[Differential] [Request, 1 lines] D1703: sfxge: Remove unused esm_size member of the efsys_mem_t structure

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY esm_size is not even initialized properly when memory is allocated. Sponsored by: Solarflare Communications, Inc. BRANCH /head REVISION DETAIL https://reviews.f

[Differential] [Request, 2 lines] D1704: sfxge: Pass correct address to free allocated memory in the case of load error

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY Most likely is was just memory leak on the error handling path since typically efsys_mem_t is filled in by zeros on allocation. Sponsored by: Solarflare Communicati

[Differential] [Request, 2 lines] D1705: sfxge: Use SFXGE_MODERATION to initialize event moderation

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY Sponsored by: Solarflare Communications, Inc. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1705 AFFECTED FILES sys/dev/sfxge/sfxge_ev.c To: arybchik

[Differential] [Request, 15 lines] D1706: sfxge: implemented parameter to restrict RSS channels

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY Submitted by: Artem V. Andreev Sponsored by: Solarflare Communications, Inc. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1706 AFFECTED FILES sh

[Differential] [Request, 30 lines] D1707: sfxge: access statistics buffers under port lock

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY Allow access to statistics data not only from sysctl handlers. Submitted by: Boris Misenov Sponsored by: Solarflare Communications, Inc. BRANCH /head REVISIO

Re: [Differential] [Request, 30 lines] D1707: sfxge: access statistics buffers under port lock

El día Wednesday, January 28, 2015 a las 09:12:42AM +, arybchik (Andrew Rybchenko) escribió: > arybchik created this revision. > arybchik added a reviewer: gnn. > arybchik added a subscriber: freebsd-net. > > REVISION SUMMARY > Allow access to statistics data not only from sysctl handlers.

[Differential] [Request, 151 lines] D1708: sfxge: Separate software Tx queue limit for non-TCP traffic

arybchik created this revision. arybchik added a reviewer: gnn. arybchik added a subscriber: freebsd-net. REVISION SUMMARY Add separate software Tx queue limit for non-TCP traffic to make total limit higher and avoid local drops of TCP packets because of no backpressure. There is no point

Jails, VIMAGE, and VLANs

Hello, I am having a very frustrating issue with VIMAGE jails using VLANs on 10.1-RELEASE. I posted this earlier to the FreeBSD forum, then realized that this is probably a better place. Let me tell you about my issue: If I set up my jails using a regular ethernet interface (em0), a bridge,

[Differential] [Request, 895 lines] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other

rrs created this revision. rrs added reviewers: gnn, rwatson, imp, hselasky, adrian, sbruno, lstewart. rrs added a subscriber: freebsd-net. REVISION SUMMARY The callout code had two specific bugs within it after the new CPU migration feature was added. 1) The callout_active() call at times c

Problems with DNSSEC -- answer in fragmented UDP doesn't work

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 I could not resolve names with DNSSEC (for example, in freebsd.org domain) on two of my installations, one with FreeBSD 11 and other with FreeBSD 9.3. Symptoms are the same: answer is sent as fragmented IP/UDP packet and second part of answer is

[Differential] [Changed Subscribers] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other

erj added a subscriber: erj. REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, imp, hselasky, adrian, sbruno, lstewart Cc: erj, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freeb

Re: Problems with DNSSEC -- answer in fragmented UDP doesn't work

On 01/28/15 17:13, Lev Serebryakov wrote: > > I could not resolve names with DNSSEC (for example, in freebsd.org > domain) on two of my installations, one with FreeBSD 11 and other with > FreeBSD 9.3. > > Symptoms are the same: answer is sent as fragmented IP/UDP packet and > second part of ans

Problems with IP fragments (was: Problems with DNSSEC -- answer in fragmented UDP doesn't work)

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 28.01.2015 20:38, Matthew Seaman wrote: > What do you get if you run the reply size test at DNS-OARC ? > > https://www.dns-oarc.net/oarc/services/replysizetest 0 lines (empty answer) at CURRENT, only "rst.x1013.rs.dns-oarc.net." on 9.3. Looks

[Differential] [Changed Subscribers] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other

neel added a subscriber: neel. REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, imp, hselasky, adrian, sbruno, lstewart Cc: neel, erj, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listin

Re: Problems with IP fragments (was: Problems with DNSSEC -- answer in fragmented UDP doesn't work)

On Wed, Jan 28, 2015 at 9:53 AM, Lev Serebryakov wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > On 28.01.2015 20:38, Matthew Seaman wrote: > > > What do you get if you run the reply size test at DNS-OARC ? > > > > https://www.dns-oarc.net/oarc/services/replysizetest > 0 lines (em

Re: Problems with IP fragments

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 28.01.2015 21:04, Freddie Cash wrote: >> Looks like "IP Fragments Filtered", but I don't understand — why >> and where?! >> >> I'm using ipfw on both hosts, but I don't have any special rules >> about IP fragments at all! And as these systems a

[Differential] [Updated] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests).

hselasky added a comment. Hi, Should the callout_test module be put in a separate directory? sys/modules/test_frwk sys/modules/test_frwk/callout When more tests are added that makes it easy exclude them from the build. --HPS REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, r

[Differential] [Requested Changes To] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by othe

hselasky requested changes to this revision. hselasky added a comment. This revision now requires changes to proceed. See comments given. INLINE COMMENTS sys/kern/kern_timeout.c:674 cc_exec_cancel(cc, direct) should be true when c_lock == NULL, because the callback cannot be stopped then. sy

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

rrs added a comment. Moving the tests to a sub-dir sounds like a good idea as well.. Thanks Hans.. INLINE COMMENTS sys/kern/kern_timeout.c:674 Hans, no *you must* set it to false here in the soft clock so you can recognize if it is requested to be stopped (if possible). The return codes are

Re: Problems with IP fragments

We use the following for udp fragments specifically this issue actually. # udp frags (large dnssec responses) add 02030 allow udp from any to me frag On 1/28/15, 1:08 PM, "Lev Serebryakov" wrote: >-BEGIN PGP SIGNED MESSAGE- >Hash: SHA512 > >On 28.01.2015 21:04, Freddie Cash wrote: > >

FreeBSD & Netmap Advocacy on Nanog

Hello, I don't know who follows NANOG, but a recent discussion raised a positive position much likely suitable to the advocacy mailing list, concerning FreeBSD Netmap vs Intel DPDK and so on. I believe it's worth sharing this guy's point of view and case: http://mailman.nanog.org/pipermail/nanog

[Differential] [Updated, 895 lines] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other

rrs updated this revision to Diff 3503. rrs added a comment. This addresses all of the concerns of Hans. I still need help with getting MK_TESTKERN to properly be placed in the /mk infrastructure, I have pending queries to GNN and JHB on this... CHANGES SINCE LAST UPDATE https://reviews.freebs

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

hselasky added a comment. Did you upload the correct patch? INLINE COMMENTS sys/kern/kern_timeout.c:674 I don't mean inside the if (c_lock != NULL) { } There should be an else case after it. if (c_lock != NULL) { ... } else { /* The callout cannot be stopped now */ cc_exec_ca

[Differential] [Changed Subscribers] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other

delphij added a subscriber: delphij. REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, imp, adrian, sbruno, lstewart, hselasky Cc: delphij, neel, erj, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org

[Differential] [Accepted] D1643: Implement resetting a VF

jfvogel accepted this revision. jfvogel added a comment. This revision is now accepted and ready to land. See no problems. REVISION DETAIL https://reviews.freebsd.org/D1643 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list

[Differential] [Accepted] D1642: Implement PCI SR-IOV method to initialize individual VFs

jfvogel accepted this revision. This revision is now accepted and ready to land. BRANCH review_D1642 REVISION DETAIL https://reviews.freebsd.org/D1642 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd

[Differential] [Accepted] D1641: Implement PCI SR-IOV initialization methods

jfvogel accepted this revision. jfvogel added a comment. This revision is now accepted and ready to land. Don't see any issues, of course the proof will come in the actual use when we have the infrastructure :) BRANCH review_D1641 REVISION DETAIL https://reviews.freebsd.org/D1641 To: rstone

[Differential] [Accepted] D1644: Add infrastructure for handling the VC msg channel from VFs

jfvogel accepted this revision. jfvogel added a comment. This revision is now accepted and ready to land. Fine REVISION DETAIL https://reviews.freebsd.org/D1644 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists

[Differential] [Accepted] D1645: Add support for VERSION VC message

jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1645 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/f

[Differential] [Accepted] D1646: Add support for RESET_VF VC message

jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1646 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/f

[Differential] [Accepted] D1647: Add support for GET_VF_RESOURCES VC message

jfvogel accepted this revision. jfvogel added a comment. This revision is now accepted and ready to land. seems fine REVISION DETAIL https://reviews.freebsd.org/D1647 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http:/

[Differential] [Requested Changes To] D1648: Add stubs for deprecated VC messages

jfvogel requested changes to this revision. jfvogel added a comment. This revision now requires changes to proceed. Let's not mention Linux in our comments, either say nothing or think of something else :) REVISION DETAIL https://reviews.freebsd.org/D1648 To: rstone, jfvogel Cc: freebsd-net _

[Differential] [Accepted] D1649: Add support for CONFIG_VSI_QUEUES VC message

jfvogel accepted this revision. jfvogel added a comment. This revision is now accepted and ready to land. Don't see any problems. REVISION DETAIL https://reviews.freebsd.org/D1649 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailin

[Differential] [Accepted] D1650: Add support for CONFIG_IRQ_MAP VC message

jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1650 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/f

[Differential] [Accepted] D1651: Add support for ENABLE/DISABLE_QUEUES VC messages

jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1651 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/f

[Differential] [Accepted] D1652: Add support for ADD/DEL_ETHER_ADDRESS VC messages

jfvogel accepted this revision. jfvogel added a comment. This revision is now accepted and ready to land. Good. BRANCH review_D1652 REVISION DETAIL https://reviews.freebsd.org/D1652 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org m

[Differential] [Accepted] D1653: Add support for ADD/DEL_VLAN VC messages

jfvogel accepted this revision. jfvogel added a comment. This revision is now accepted and ready to land. No issues. REVISION DETAIL https://reviews.freebsd.org/D1653 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http:/

[Differential] [Accepted] D1654: Add support for CONFIG_PROMISCUOUS_MODE VC message

jfvogel accepted this revision. jfvogel added a comment. This revision is now accepted and ready to land. No problems REVISION DETAIL https://reviews.freebsd.org/D1654 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http:

[Differential] [Accepted] D1655: Add support for GET_STATS VC message

jfvogel accepted this revision. This revision is now accepted and ready to land. BRANCH review_D1655 REVISION DETAIL https://reviews.freebsd.org/D1655 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd

[Differential] [Accepted] D1656: Handle VFLR events from VFs

jfvogel accepted this revision. jfvogel added a comment. This revision is now accepted and ready to land. Looks good. Again, will need real world testing when we have infrastructure. REVISION DETAIL https://reviews.freebsd.org/D1656 To: rstone, jfvogel Cc: freebsd-net _

[Differential] [Accepted] D1657: Allow VFs to run while the PF is admin down

jfvogel accepted this revision. This revision is now accepted and ready to land. BRANCH review_D1657 REVISION DETAIL https://reviews.freebsd.org/D1657 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd

Netmap support for Linux Containers (veth)

Hello Dr. Luigi Rizzo and netmap contributors, I am looking to integrate netmap capabilities into linux’s veth (Virtual Ethernet device) for netmap support within linux containers. Does a patch currently exist? If not, do you have any intuition as to what it would take to add netmap capabilit

[Differential] [Accepted] D1658: Add sysctls for per-VF hardware counters

jfvogel accepted this revision. This revision is now accepted and ready to land. BRANCH review_D1658 REVISION DETAIL https://reviews.freebsd.org/D1658 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd

Re: Netmap support for Linux Containers (veth)

On Wed, Jan 28, 2015 at 5:11 PM, Luke McHale wrote: > Hello Dr. Luigi Rizzo and netmap contributors, > > I am looking to integrate netmap capabilities into linux’s veth (Virtual > Ethernet device) for netmap support within linux containers. Does a patch > currently exist? If not, do you have any

[Differential] [Accepted] D1659: Register ixl as an SR-IOV-capable driver during attach

jfvogel accepted this revision. jfvogel added a comment. This revision is now accepted and ready to land. can't wait to see the infrastructure in place :) REVISION DETAIL https://reviews.freebsd.org/D1659 To: rstone, jfvogel Cc: freebsd-net ___ freeb

[Differential] [Accepted] D1660: Add support for mac-addr parameter

jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1660 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/f

[Differential] [Accepted] D1661: Add some security-related config parameters

jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1661 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/f

[Differential] [Updated] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests).

imp added a comment. For the commit, I'd separate out the timeout fix from the kernel testframework. REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, adrian, sbruno, lstewart, hselasky, imp Cc: delphij, neel, erj, freebsd-net

Re: Netmap support for Linux Containers (veth)

Hello Dr. Luigi Rizzo, Thank you for your quick reply! I’m glad to see veth is already in the works. While I am new to netmap, we are aiming to utilize it in several of our projects. I currently have two tasks, including: - patch veth - patch eTSEC (gianfar) controller Since these tasks are

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

rrs added a comment. Hans: We have discussed that, and *no* it will *not* return the incorrect thing once it can't be stopped. There is code in the callout_reset_sbt_on() that makes sure zero is returned. The only way that zero will *not* be returned is if the PENDING flag is set. That won't hap

[Bug 137089] [lagg] lagg falsely triggers IPv6 duplicate address detection

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=137089 Hiren Panchasara changed: What|Removed |Added CC||hi...@freebsd.org --- Comment #

[Differential] [Changed Subscribers] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other

emaste added a subscriber: emaste. REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, adrian, sbruno, lstewart, hselasky, imp Cc: emaste, delphij, neel, erj, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freeb

[Differential] [Accepted] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests).

hselasky accepted this revision. hselasky added a comment. This revision is now accepted and ready to land. This looks usable. REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, adrian, sbruno, lstewart, imp, hselasky Cc: emaste, delphij, neel, erj, freebsd-net __