hselasky requested changes to this revision. hselasky added a comment. This revision now requires changes to proceed.
See comments given. INLINE COMMENTS sys/kern/kern_timeout.c:674 cc_exec_cancel(cc, direct) should be true when c_lock == NULL, because the callback cannot be stopped then. sys/kern/kern_timeout.c:1059 Is this comment be properly formatted with regard to filling lines till end of line? ALT+Q in emacs?? sys/modules/callout_test/callout_test.c:58 Should these variables all be static? sys/modules/callout_test/callout_test.c:69 Possibly this define is redundant. sys/modules/callout_test/callout_test.c:254 Is this check really needed? sys/sys/callout_test.h:1 Upper case inclusion guard. sys/sys/callout_test.h:1 Missing copyright for header file. sys/sys/kern_testfrwk.h:43 Should this function be typedefed: typedef void (kern_testframework_func_t)(struct kern_test *); REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, imp, adrian, sbruno, lstewart, hselasky Cc: neel, erj, freebsd-net _______________________________________________ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
