[Differential] D1944: PF and VIMAGE fixes

kristof abandoned this revision. REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: kristof, trociny, gnn, zec, rodrigc, glebius, eri, bz, nvass-gmx.com Cc: ryan_timewasted.me, mmoll, javier_ovi_yahoo.com, farr

[Differential] D1944: PF and VIMAGE fixes

kristof commandeered this revision. kristof edited reviewers, added: nvass-gmx.com; removed: kristof. kristof added a comment. I'm commandeering this so it can be closed, because the patch fro bz@ (https://reviews.freebsd.org/D6924) has been included. REVISION DETAIL https://reviews.freebsd

[Differential] D1944: PF and VIMAGE fixes

bz added a comment. Can I have you guys have a look at https://reviews.freebsd.org/D6924 Thanks REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, trociny, kristof, gnn, zec, rodrigc, gl

[Differential] D1944: PF and VIMAGE fixes

___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Differential] D1944: PF and VIMAGE fixes

nvass-gmx.com added a comment. Thanks for taking a look Kristof, I believe all your points are valid. Thing is that all eventhandlers need a more thorough look. They don't work as they should; be it virtualized or not, be it a VIMAGE or GENERIC kernel. I am trying to take a look but I ha

[Differential] D1944: PF and VIMAGE fixes

kristof added inline comments. INLINE COMMENTS sys/netpfil/pf/pf_if.c:130 I don't understand why this is required. Surely if an ifnet lives in V_ifnet (so, lives in the current vnet) ifp->if_vnet is always going to be curvnet? sys/netpfil/pf/pf_if.c:141 Why add curvnet here? pfi_attach_ifn

[Differential] [Commented On] D1944: PF and VIMAGE fixes

nvass-gmx.com added a comment. Sure, I will take a look REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, trociny, kristof, gnn, zec, rodrigc, glebius, eri Cc: mmoll, javier_ovi_yahoo.co

[Differential] [Commented On] D1944: PF and VIMAGE fixes

mmoll added a comment. Nikos, could you have a look into PR 205743? REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, trociny, kristof, gnn, zec, rodrigc, glebius, eri Cc: mmoll, javier_

[Differential] [Commented On] D1944: PF and VIMAGE fixes

robak added a comment. @bz: you've made some commits to VIMAGE code in past few days, how do they relate to this revision? Any chance you could review it and comment/commit on this? REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/

[Differential] [Commented On] D1944: PF and VIMAGE fixes

robak added a comment. Any news on that review? REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, trociny, kristof, gnn, zec, rodrigc, glebius, eri Cc: mmoll, javier_ovi_yahoo.com, farro

[Differential] [Commented On] D1944: PF and VIMAGE fixes

robak added a comment. Just to add an end-user update, this stuff keeps leaking, even in 10.2-p7, every single time a VIMAGE jail is being stopped. REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-

[Differential] [Commented On] D1944: PF and VIMAGE fixes

nvass-gmx.com added a comment. Hi from me as well, just want to say that I am here too and I am willing to work on this even if i have to do it scratch;) Please review:) Nikos REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/setti

[Differential] [Commented On] D1944: PF and VIMAGE fixes

rodrigc added a comment. @glebius : if you have time can you review this? you have expressed interest in PF + VIMAGE fixes in the past. @bz : do you have time to review this? I understand you are going to be doing some VIMAGE work REVISION DETAIL https://reviews.freebsd.org/D1944 E

[Differential] [Commented On] D1944: PF and VIMAGE fixes

rodrigc added a comment. @mmoll : It would be nice if @glebius could review this patch. He previously committed some patches I committed to FreeBSD which attempted to fix this problem, so he has an interest in this area. REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES

[Differential] [Commented On] D1944: PF and VIMAGE fixes

mmoll added a subscriber: mmoll. mmoll added a comment. what's the status here? REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, trociny, kristof, gnn, zec, rodrigc, glebius, eri Cc: mmol

[Differential] [Changed Subscribers] D1944: PF and VIMAGE fixes

javier_ovi_yahoo.com added a subscriber: javier_ovi_yahoo.com. REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, trociny, kristof, gnn, zec, rodrigc, glebius, eri Cc: javier_ovi_yahoo.com, f

[Differential] [Commented On] D1944: PF and VIMAGE fixes

rodrigc added a comment. @glebius: Nikos updated the patch. Can you review it? REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, trociny, kristof, gnn, zec, rodrigc, glebius, eri Cc: farr

[Differential] [Updated] D1944: PF and VIMAGE fixes

eri added a reviewer: eri. REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, trociny, kristof, gnn, zec, rodrigc, glebius, eri Cc: farrokhi, julian, robak, freebsd-virtualization-list, freeb

[Differential] [Commented On] D1944: PF and VIMAGE fixes

nvass-gmx.com added a comment. Hi, could you write an email to me and freebsd-virtualizat...@freebsd.org with the necessary steps to re-produce the problem? REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To:

[Differential] [Changed Subscribers] D1944: PF and VIMAGE fixes

farrokhi added a subscriber: farrokhi. REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, trociny, kristof, gnn, glebius, rodrigc, zec Cc: farrokhi, julian, robak, freebsd-virtualization-list

[Differential] [Commented On] D1944: PF and VIMAGE fixes

robak added a comment. Is there anything else I can do to provide some useful information? I've attached these screenshots only because the machine becomes unresponsive when this happens (and drops active ssh connections). I am happy to execute any test/information gathering suite you may need.

[Differential] [Updated] D1944: PF and VIMAGE fixes

zec added a comment. In https://reviews.freebsd.org/D1944#62124, @robak wrote: > I managed to crash freshly fetched and built 10-S today, with > GENERIC+VIMAGE+RACCT while stopping a jail, attaching console screenshots. > > F183647: Screen Shot 2015-07-19 at 17.48.26.png >

[Differential] [Commented On] D1944: PF and VIMAGE fixes

robak added a comment. I managed to crash freshly fetched and built 10-S today, with GENERIC+VIMAGE+RACCT while stopping a jail, attaching console screenshots. F183647: Screen Shot 2015-07-19 at 17.48.26.png F183649: Screen Shot 2015-07-19 at 18.33.39.png

[Differential] [Commented On] D1944: PF and VIMAGE fixes

robak added a comment. Is there any update on those fixes? REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, zec, trociny, kristof, gnn, glebius, rodrigc Cc: julian, robak, freebsd-virtual

[Differential] [Commented On] D1944: PF and VIMAGE fixes

robak added a comment. Is there any chance to get these changes committed in time for 10.2-RELEASE? It would be great if we could have working VNET/PF before 11.0-R comes out... REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/e

[Differential] [Updated, 170 lines] D1944: PF and VIMAGE fixes

nvass-gmx.com updated this revision to Diff 6288. nvass-gmx.com added a comment. Updated to today's head branch. Please review CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1944?vs=5290&id=6288 REVISION DETAIL https://reviews.freebsd.org/D1944 AFFECTED FILES sys/net/pfvar.h sy

[Differential] [Commented On] D1944: PF and VIMAGE fixes

nvass-gmx.com added a comment. In https://reviews.freebsd.org/D1944#47915, @glebius wrote: > Thanks a lot, Nikos. > > I've fixed the problem of sleeping in UMA on kldunload. It was out the scope > of the patch. I also committed the first part of the patch - mutexes > initialization. > > Nikos,

[Differential] [Requested Changes To] D1944: PF and VIMAGE fixes

glebius requested changes to this revision. glebius added a comment. This revision now requires changes to proceed. Thanks a lot, Nikos. I've fixed the problem of sleeping in UMA on kldunload. It was out the scope of the patch. I also committed the first part of the patch - mutexes initializati

[Differential] [Accepted] D1944: PF and VIMAGE fixes

rodrigc accepted this revision. rodrigc added a comment. This revision has a positive review. Looks OK to me. We can hopefully fix some of the LOR's later. @glebius : can you provide your feedback on this patch? REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://r

[Differential] [Commented On] D1944: PF and VIMAGE fixes

rodrigc added a comment. I can confirm that: kldunload -f pf.ko does work to unload the module. That is good. I saw this warning message in dmesg: lock order reversal: (sleepable after non-sleepable) 1st 0x823b72e0 pf rulesets (pf rulesets) @ /opt2/branches/head/sys/modules/pf

[Differential] [Commented On] D1944: PF and VIMAGE fixes

nvass-gmx.com added a comment. In https://reviews.freebsd.org/D1944#47231, @rodrigc wrote: > I tested this patch. > > # kldload pf > # kldunload pf > kldunload: can't unload file: Device busy > > > The fact that the pf module cannot be unloaded was one of the > reasons that @glebius used t

[Differential] [Commented On] D1944: PF and VIMAGE fixes

rodrigc added a comment. I tested this patch. # kldload pf # kldunload pf kldunload: can't unload file: Device busy The fact that the pf module cannot be unloaded was one of the reasons that @glebius used to back out the entire changeset last time I committed your pf changes. Can you fix

[Differential] [Commented On] D1944: PF and VIMAGE fixes

rodrigc added a comment. In https://reviews.freebsd.org/D1944#46127, @julian wrote: > in case I didn't point you at this before... > > http://p4web.freebsd.org/@md=d&cd=//depot/projects/vimage/&cdf=//depot/projects/vimage/porting_to_vimage.txt&c=win@//depot/projects/vimage/porting_to_vimage.tx

[Differential] [Commented On] D1944: PF and VIMAGE fixes

nvass-gmx.com added a comment. This guilde is definitely invaluable, I have seen it. It would be great if we could move it in the source tree. Regarding PF it can be further simplified. I think the logic right is OK but there are many *init* functions for sure and some of these functions can go

[Differential] [Commented On] D1944: PF and VIMAGE fixes

julian added a subscriber: julian. julian added a comment. in case I didn't point you at this before... http://p4web.freebsd.org/@md=d&cd=//depot/projects/vimage/&cdf=//depot/projects/vimage/porting_to_vimage.txt&c=win@//depot/projects/vimage/porting_to_vimage.txt?ac=22 REVISION DETAIL https:

[Differential] [Updated, 197 lines] D1944: PF and VIMAGE fixes

nvass-gmx.com updated this revision to Diff 5290. nvass-gmx.com added a comment. Hi, Please review this. It updates the previous patch, with another way to unload pf. Eventhandlers are also touched, they should behave correctly now. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D194

[Differential] [Commented On] D1944: PF and VIMAGE fixes

nvass-gmx.com added a comment. Yes, I am trying to fix the issues. It needs more work. I will update when I have a new patch REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, zec, trociny

[Differential] [Commented On] D1944: PF and VIMAGE fixes

glebius added a comment. Recently Nikos has asked questions on kernel debugging. So, I guess, he is working. REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, zec, trociny, glebius, rodri

[Differential] [Commented On] D1944: PF and VIMAGE fixes

robak added a subscriber: robak. robak added a comment. Is there any update on these fixes? I've just happened to bump my 10.1-RELEASE into 10-STABLE and created few VIMAGE based jails. As soon as I stop any of them, and I can reproduce it every time, the host OS crashes. That makes the entire

[Differential] [Updated] D1944: PF and VIMAGE fixes

gnn added a comment. Any update on this? REVISION DETAIL https://reviews.freebsd.org/D1944 To: nvass-gmx.com, bz, zec, trociny, glebius, rodrigc, kristof, gnn Cc: freebsd-virtualization, freebsd-pf, freebsd-net ___ freebsd-net@freebsd.org mailing lis

[Differential] [Commented On] D1944: PF and VIMAGE fixes

nvass-gmx.com added a comment. >>! In D1944#11, @kristof wrote: > Don't we still need to do all of this somewhere? >>! In D1944#11, @kristof wrote: > Don't we still need to do all of this somewhere? INLINE COMMENTS sys/netpfil/pf/pf_ioctl.c:325 pf_unload is called before pf_vnet_unit, this

[Differential] [Commented On] D1944: PF and VIMAGE fixes

kristof added inline comments. INLINE COMMENTS sys/netpfil/pf/pf_ioctl.c:325 It's not clear to me why this is done here, rather than in pf_unload(). The initialisation is done in pf_load() after all. sys/netpfil/pf/pf_ioctl.c:3725 Don't we still need to do all of this somewhere? REVISION DE

[Differential] [Updated] D1944: PF and VIMAGE fixes

rodrigc added a reviewer: kristof. REVISION DETAIL https://reviews.freebsd.org/D1944 To: nvass-gmx.com, gnn, bz, zec, trociny, glebius, rodrigc, kristof Cc: freebsd-virtualization, freebsd-pf, freebsd-net ___ freebsd-net@freebsd.org mailing list http:

[Differential] [Commented On] D1944: PF and VIMAGE fixes

nvass-gmx.com added a comment. >>! In D1944#8, @glebius wrote: > Nikos, > > acking that I see the patches. Right now I'm waiting for pf to stablize after > recent patches to fragment handling. Kristof is working on the known problem. > Meanwhile you can finish your patch moving from "almost there

[Differential] [Updated] D1944: PF and VIMAGE fixes

glebius added a comment. Nikos, acking that I see the patches. Right now I'm waiting for pf to stablize after recent patches to fragment handling. Kristof is working on the known problem. Meanwhile you can finish your patch moving from "almost there" to "there" :) If you got any questions about

[Differential] [Updated] D1944: PF and VIMAGE fixes

rodrigc added a comment. Nikos has posted these patches to improve VIMAGE support in PF. If some of the folks who are experienced with PF and VIMAGE could take a look, that would be really great. REVISION DETAIL https://reviews.freebsd.org/D1944 To: nvass-gmx.com, glebius, gnn, bz, zec

[Differential] [Updated] D1944: PF and VIMAGE fixes

rodrigc added a reviewer: gnn. REVISION DETAIL https://reviews.freebsd.org/D1944 To: nvass-gmx.com, glebius, rodrigc, gnn Cc: freebsd-virtualization, freebsd-pf, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/lis

[Differential] [Updated] D1944: PF and VIMAGE fixes

rodrigc added reviewers: bz, zec, trociny. REVISION DETAIL https://reviews.freebsd.org/D1944 To: nvass-gmx.com, glebius, rodrigc, gnn, bz, zec, trociny Cc: freebsd-virtualization, freebsd-pf, freebsd-net ___ freebsd-net@freebsd.org mailing list http:/

[Differential] [Changed Subscribers] D1944: PF and VIMAGE fixes

rodrigc added a subscriber: freebsd-virtualization. REVISION DETAIL https://reviews.freebsd.org/D1944 To: nvass-gmx.com, glebius, rodrigc Cc: freebsd-virtualization, freebsd-pf, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd

[Differential] [Changed Subscribers] D1944: PF and VIMAGE fixes

rodrigc added subscribers: freebsd-net, freebsd-pf. REVISION DETAIL https://reviews.freebsd.org/D1944 To: nvass-gmx.com, glebius, rodrigc Cc: freebsd-pf, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/fr

Re: pf and vimage

Thanks very useful! Do you have an "official" page to look for update. What do you think of putting it on the FreeBSD Wiki? Fabien Le 20 août 09 à 18:17, Julian Elischer a écrit : there were some people looking at adding vnet support to pf. Since we discussed it last, the rules of the game hav

Re: pf and vimage

Fabien Thomas wrote: Thanks very useful! Do you have an "official" page to look for update. you can always find teh latest here: http://p4db.freebsd.org/depotTreeBrowser.cgi?FSPC=//depot/projects/vimage named "porting_to_vimage.txt" What do you think of putting it on the FreeBSD Wiki? Fab

pf and vimage

there were some people looking at adding vnet support to pf. Since we discussed it last, the rules of the game have significantly changed for the better. With the addition of some new facilitiesin FreeBSD, the work needed to virtualize a module has significantly decreased. The following doc give