Re: funny ECMP

2010-09-16 Thread Ingo Flaschberger
Hi Qing, version 4 o patch... fixed deleting interface loopback routes. Kind regards, Ingo Flaschbergerdiff -u -r /usr_diff/src/sys/contrib/ipfilter/netinet/ip_pool.c /router/usr/src/sys/contrib/ipfilter/netinet/ip_pool.c --- /usr_diff/src/sys/contrib/ipfilter/netinet/ip_pool.c2

Re: funny ECMP

2010-09-12 Thread Qing Li
I have not been able to reproduce the crash based on the steps you outlined in the bug. I do see there is a logic error in the "for" loop right above the crashing point can trigger a crash. I am looking at your latest patch. -- Qing On Fri, Sep 10, 2010 at 8:05 PM, Ingo Flaschberger wrote: > D

RE: funny ECMP

2010-09-10 Thread Ingo Flaschberger
Dear Li, attached latest version of ecmp patch. Kind regards, Ingo Flaschbergerdiff -r -u /usr_diff/src/sys/contrib/ipfilter/netinet/ip_pool.c /usr/src/sys/contrib/ipfilter/netinet/ip_pool.c --- /usr_diff/src/sys/contrib/ipfilter/netinet/ip_pool.c2007-10-18 21:42:38.0 +

RE: funny ECMP

2010-08-26 Thread Ingo Flaschberger
Hi again, had a very small typo (copy&paste and compare..) attached new version of patch; now everything works and error disappeared. Kind regards, Ingo Flaschberger diff -r -u /usr/src/sys/contrib/ipfilter/netinet/ip_pool.c /router/usr/src/sys/contrib/ipfilter/netinet/ip_pool.c --- /u

RE: funny ECMP

2010-08-26 Thread Ingo Flaschberger
Hi, with the help from OpenBSD I was able to get working code. Patch attached; applies fo Freebsd 8.1 Stable I was not able to implement all OpenBSD code in function rn_delete from sys/net/radix.c Currently I also see this (non critical) warnings: rn_delete: inconsistent annotation ifaddr cac

RE: funny ECMP

2010-08-25 Thread Ingo Flaschberger
Hi, currently I stick at this (last?) problem: assume routingtable:net gw postion type 1 route 10.13.13.0/24 10.11.11.1 2 route 10.13.13.0/24 10.11.11.2 3 interface route 10.

RE: funny ECMP

2010-08-24 Thread Ingo Flaschberger
Dear Bjoern, I looked at some similar problem for someone end of April and the crude workaround was to disable (#if 0) the following code in in_lltable_lookup(): #if 0 if (!(flags & LLE_IFADDR) && in_lltable_rtcheck(ifp, flags, l3addr) != 0) goto done; #endif I had since defere

RE: funny ECMP

2010-08-24 Thread Bjoern A. Zeeb
On Tue, 24 Aug 2010, Ingo Flaschberger wrote: Hey, in arp-lookup code, the lowest weight + without gateway should be choosen. Sure, but such a configuration did not make much sense. when the in_lltable_lookup code tries to lookup the arp entry, the rtalloc_mpath_fib already has choosen th

RE: funny ECMP

2010-08-24 Thread Ingo Flaschberger
Dear Li, I hoped, that now, as freebsd has multi-route support (as other unix really have for a long long time) everything would be easier. But multipath support of freebsd is in my opinion, in a "experimental" state. Yes, agreed. It will be in the experimental state until there is vari

RE: funny ECMP

2010-08-24 Thread Li, Qing
> > > Sure, but such a configuration did not make much sense. > > Why not? > Use CARP and OSPF and you have such a configuration. > Okay, I will try that. > > I hoped, that now, as freebsd has multi-route support (as other unix > really have for a long long time) everything would be easie

RE: funny ECMP

2010-08-24 Thread Ingo Flaschberger
Dear Li, in arp-lookup code, the lowest weight + without gateway should be choosen. Sure, but such a configuration did not make much sense. when the in_lltable_lookup code tries to lookup the arp entry, the rtalloc_mpath_fib already has choosen that this packet should go the direkt way. S

RE: funny ECMP

2010-08-24 Thread Ingo Flaschberger
Dear Li, Sure, but such a configuration did not make much sense. Why not? Use CARP and OSPF and you have such a configuration. I read your other email explaining why your system is configured this way but I am still unclear from you text. Router 1 and Router 2 share 1 Ipadress via VRRP

RE: funny ECMP

2010-08-24 Thread Li, Qing
> > > I am trying to figure out, if the routing table have > > > > 10.13.13.0/24 10.11.11.1 > > 10.13.13.0/24 link#1 > > > > And if I do "ssh 10.13.13.2", which route should be used? > > the route with the lower weight. > if they have the same weight, use any of them. > I get the pr

RE: funny ECMP

2010-08-24 Thread Ingo Flaschberger
Dear Li, I am trying to figure out, if the routing table have 10.13.13.0/24 10.11.11.1 10.13.13.0/24 link#1 And if I do "ssh 10.13.13.2", which route should be used? the route with the lower weight. if they have the same weight, use any of them. in arp-lookup code, the l

RE: funny ECMP

2010-08-24 Thread Li, Qing
Tuesday, August 24, 2010 11:28 AM > To: Li, Qing > Cc: n...@freebsd.org > Subject: RE: funny ECMP > > Dear Li, > > > The indirect route is colliding with the interface route, both have > > the same mask. > > > > How do you expect this to work ? > >

RE: funny ECMP

2010-08-24 Thread Ingo Flaschberger
Dear Li, The indirect route is colliding with the interface route, both have the same mask. How do you expect this to work ? How would the routing code differentiate between on-link nodes and the those needing to be routed through 10.11.11.1 ? in_lltable_rtcheck if (rt == NULL || (!(

RE: funny ECMP

2010-08-24 Thread Li, Qing
Hi, The indirect route is colliding with the interface route, both have the same mask. How do you expect this to work ? How would the routing code differentiate between on-link nodes and the those needing to be routed through 10.11.11.1 ? -- Qing > > one of the problems: > sysctl -w net.inet.

RE: funny ECMP

2010-08-24 Thread Ingo Flaschberger
Hi, one of the problems: sysctl -w net.inet.flowtable.enable=0 route add 10.13.13.0/24 10.11.11.1 -weight 2 ifconfig em1 alias 10.13.13.90/24 arp-resolve fails: arpresolve: can't allocate llinfo for 10.13.13.95 in sys/netinet/in.c: in_lltable_lookup calls in_lltable_rtcheck which calls rtalloc1

RE: funny ECMP

2010-08-23 Thread Li, Qing
> > > >> As Qing Li mentioned months ago, there are problems with static > routes > >> and interfaces. > >> > > > > Do you have the exact link to the email thread? > > There were no pending ECMP related issues since my last round of > > commits > > as far as I can remember. > > http://lists.fre

RE: funny ECMP

2010-08-23 Thread Ingo Flaschberger
Hi, I have forgotten to mention, that I do the current tests with flowtables disabled. Kind regards, Ingo Flaschberger ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any ma

RE: funny ECMP

2010-08-23 Thread Li, Qing
Hi, > > I have changed the route selection code of ecmp to > balance only between routes of the same weight. > (see attached file) > > > As Qing Li mentioned months ago, there are problems with static routes > and interfaces. > Do you have the exact link to the email thread? There were

RE: funny ECMP

2010-08-23 Thread Ingo Flaschberger
Dear Li, nice to hear from you. 1st: i have send in a bugfix: http://www.freebsd.org/cgi/query-pr.cgi?pr=149917 I have changed the route selection code of ecmp to balance only between routes of the same weight. (see attached file) As Qing Li mentioned months ago, there are problems with st

Re: funny ECMP

2010-08-23 Thread Ingo Flaschberger
Hi, I have changed the route selection code of ecmp to balance only between routes of the same weight. (see attached file) As Qing Li mentioned months ago, there are problems with static routes and interfaces. Example 1: ifconfig em1 alias 10.13.13.90/24 ping 10.13.13.95 ok route add