[Differential] D12457: Complete INADDR_HASH lock protection

rwatson added a subscriber: bz. rwatson added a comment. Many of these changes are not sufficient to address the underlying problems in this code, as the lock covers loop iteration but fails to protect the stability of the 'ifp' or 'ia' pointer outside of the loop. It could be that this prev

[Differential] D12453: mbuf: Remove UDP_IPV4_EX, which is never defined.

rwatson accepted this revision. rwatson added a comment. This revision is now accepted and ready to land. This seems generally sensible. I'm not quite sure about keeping the "Non-standard RSS hash types" comment, as M_HASHTYPE_OPAQUE is basically intended to be a catch-all for any other

[Differential] [Accepted] D1805: [sockbuf] Don't access fields directly, use accessor functions

rwatson accepted this revision. rwatson added a comment. Seems sensible. REVISION DETAIL https://reviews.freebsd.org/D1805 To: davide, kmacy, np, lstewart, rrs, julian, adrian, rwatson Cc: emaste, freebsd-net ___ freebsd-net@freebsd.org mailing list

[Differential] [Requested Changes To] D1809: [sockbuf] Don't expose lock details when isn't needed

rwatson requested changes to this revision. rwatson added a comment. This revision now requires changes to proceed. Looks like some serious transcription errors are in this patch. INLINE COMMENTS sys/kern/uipc_sockbuf.c:225 Should this be so->so_rcv? sys/kern/uipc_sockbuf.c:234 Should this be

[Differential] [Updated] D1809: [sockbuf] Don't expose lock details when isn't needed

rwatson added a comment. Seems reasonable. I'm slightly surprised that any code other than sbwait() actually implements the sleep on sb_acc, and wonder if either a use of abstraction improvement, or an actual abstraction improvement, is needed to fix t4_ddp.c. REVISION DETAIL https://reviews

[Differential] [Commented On] D1761: Extend LRO support to accumulate more than 65535 bytes

rwatson added a comment. np@'s comments are good ones, both with respect to ACK clocking and BPF -- but this will also affect local firewalls that do state tracking and/or transformation, and likewise will run into problems. Given this discussion, I'm increasingly convinced that this is Not A G

[Differential] [Updated] D1761: Extend LRO support to accumulate more than 65535 bytes

rwatson added a comment. Historically, I believe that we've allowed additional trailer content/padding to be included at the end of mbuf chains that isn't in the IP datagram, and is silently ignored, as it isn't included in the IP packet length. I may misunderstand what was going on there, but

[Differential] [Commented On] D1201: Allow UMA allocated memory to be freed when VNET jails are torn down.

rwatson added a comment. This patch is probably safe if limited to UDP. REVISION DETAIL https://reviews.freebsd.org/D1201 To: rodrigc, alfredperlstein, melifaro, glebius, hrs, wollman, bryanv, rpaulo, adrian, bz, gnn, hiren, rwatson Cc: freebsd-net, emaste, gnn, rwatson __