rwatson added a subscriber: bz.
rwatson added a comment.

  Many of these changes are not sufficient to address the underlying problems 
in this code, as the lock covers loop iteration but fails to protect the 
stability of the 'ifp' or 'ia' pointer outside of the loop. It could be that 
this prevents the crash you are seeing as the issue is iteration over entries 
being deleted from the list, or that the problem you are seeing is masked by 
changes in timing (as it involves using an ifp, ia, etc, being removed). It 
would be useful to think a little harder about our goals here. @bz and I have 
been pondering for some time a somewhat coarser, rmlock-based synchronisation 
approach to use in these circumstances, but have not prototyped this yet.

REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D12457

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: eugen_grosbein.net, ae, avg, mav, rwatson
Cc: bz, imp, freebsd-net-list
_______________________________________________
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

Reply via email to