[Differential] D12457: Complete INADDR_HASH lock protection

rwatson added a subscriber: bz. rwatson added a comment. Many of these changes are not sufficient to address the underlying problems in this code, as the lock covers loop iteration but fails to protect the stability of the 'ifp' or 'ia' pointer outside of the loop. It

[Differential] D12453: mbuf: Remove UDP_IPV4_EX, which is never defined.

rwatson accepted this revision. rwatson added a comment. This revision is now accepted and ready to land. This seems generally sensible. I'm not quite sure about keeping the "Non-standard RSS hash types" comment, as M_HASHTYPE_OPAQUE is basically intended to be a catch-al

[Differential] [Accepted] D1805: [sockbuf] Don't access fields directly, use accessor functions

rwatson accepted this revision. rwatson added a comment. Seems sensible. REVISION DETAIL https://reviews.freebsd.org/D1805 To: davide, kmacy, np, lstewart, rrs, julian, adrian, rwatson Cc: emaste, freebsd-net ___ freebsd-net@freebsd.org mailing list

[Differential] [Requested Changes To] D1809: [sockbuf] Don't expose lock details when isn't needed

rwatson requested changes to this revision. rwatson added a comment. This revision now requires changes to proceed. Looks like some serious transcription errors are in this patch. INLINE COMMENTS sys/kern/uipc_sockbuf.c:225 Should this be so->so_rcv? sys/kern/uipc_sockbuf.c:234 Should t

[Differential] [Updated] D1809: [sockbuf] Don't expose lock details when isn't needed

rwatson added a comment. Seems reasonable. I'm slightly surprised that any code other than sbwait() actually implements the sleep on sb_acc, and wonder if either a use of abstraction improvement, or an actual abstraction improvement, is needed to fix t4_ddp.c. REVISION DETAIL

[Differential] [Commented On] D1761: Extend LRO support to accumulate more than 65535 bytes

rwatson added a comment. np@'s comments are good ones, both with respect to ACK clocking and BPF -- but this will also affect local firewalls that do state tracking and/or transformation, and likewise will run into problems. Given this discussion, I'm increasingly convinced that thi

[Differential] [Updated] D1761: Extend LRO support to accumulate more than 65535 bytes

rwatson added a comment. Historically, I believe that we've allowed additional trailer content/padding to be included at the end of mbuf chains that isn't in the IP datagram, and is silently ignored, as it isn't included in the IP packet length. I may misunderstand what was goin

[Differential] [Commented On] D1201: Allow UMA allocated memory to be freed when VNET jails are torn down.

rwatson added a comment. This patch is probably safe if limited to UDP. REVISION DETAIL https://reviews.freebsd.org/D1201 To: rodrigc, alfredperlstein, melifaro, glebius, hrs, wollman, bryanv, rpaulo, adrian, bz, gnn, hiren, rwatson Cc: freebsd-net, emaste, gnn, rwatson

Re: kern/129846: [panic] /usr/sbin/ppp causes panic "Sleeping thread owns a non-sleepable lock

Synopsis: [panic] /usr/sbin/ppp causes panic "Sleeping thread owns a non-sleepable lock Responsible-Changed-From-To: freebsd-net->rwatson Responsible-Changed-By: rwatson Responsible-Changed-When: Wed Mar 11 20:50:01 UTC 2009 Responsible-Changed-Why: Grab ownership. http://www.freebsd

Re: kern/130652: [kernel] [patch] Possible deadlock in rt_check() (sys/net/route.c)

Synopsis: [kernel] [patch] Possible deadlock in rt_check() (sys/net/route.c) Responsible-Changed-From-To: freebsd-net->rwatson Responsible-Changed-By: rwatson Responsible-Changed-When: Sat Feb 21 15:22:13 UTC 2009 Responsible-Changed-Why: Grab ownership of this PR since I'm taking a

Re: kern/88336: [ipsec] [patch] setkey(8) -D fails to report all SAs

Old Synopsis: [kernel] [patch] setkey(8) -D fails to report all SAs New Synopsis: [ipsec] [patch] setkey(8) -D fails to report all SAs Responsible-Changed-From-To: freebsd-bugs->freebsd-net Responsible-Changed-By: rwatson Responsible-Changed-When: Mon Feb 9 23:26:47 UTC 2009 Responsible-Chan

Re: kern/112722: [udp] IP v4 udp fragmented packet reject

Synopsis: [udp] IP v4 udp fragmented packet reject State-Changed-From-To: feedback->open State-Changed-By: rwatson State-Changed-When: Fri Feb 6 22:51:58 UTC 2009 State-Changed-Why: Transition to open: the original submitter is no longer using this configuration, so we'll need someone to

Re: kern/93378: [tcp] Slow data transfer in Postfix and Cyrus IMAP (workaround known)

Synopsis: [tcp] Slow data transfer in Postfix and Cyrus IMAP (workaround known) State-Changed-From-To: open->feedback State-Changed-By: rwatson State-Changed-When: Mon Feb 2 15:18:25 UTC 2009 State-Changed-Why: Dear Juris: I was wondering if you had received Anton's follow-up regarding

Re: kern/130605: [tcp] Certain hardware produces "Network is unreachable" errors for scanning tools

Synopsis: [tcp] Certain hardware produces "Network is unreachable" errors for scanning tools State-Changed-From-To: open->feedback State-Changed-By: rwatson State-Changed-When: Mon Feb 2 13:32:50 UTC 2009 State-Changed-Why: Hi Jason: Thanks for your detailed bug report. It see

Re: kern/112722: [udp] IP v4 udp fragmented packet reject

Synopsis: [udp] IP v4 udp fragmented packet reject State-Changed-From-To: open->feedback State-Changed-By: rwatson State-Changed-When: Mon Feb 2 11:31:13 UTC 2009 State-Changed-Why: Dear Kent: I apologize for the delay in response to this problem report. Could I ask you to: (1) Confirm

Re: kern/116077: [ip] [patch] 6.2-STABLE panic during use of multi-cast networking client

Synopsis: [ip] [patch] 6.2-STABLE panic during use of multi-cast networking client State-Changed-From-To: open->closed State-Changed-By: rwatson State-Changed-When: Mon Feb 2 11:24:14 UTC 2009 State-Changed-Why: This bug is now reported to be fixed by the referenced commit; if you experie

Re: kern/117717: [panic] Kernel panic with Bittorrent client.

Synopsis: [panic] Kernel panic with Bittorrent client. Responsible-Changed-From-To: rwatson->net Responsible-Changed-By: rwatson Responsible-Changed-When: Sat Jan 3 12:32:27 UTC 2009 Responsible-Changed-Why: Transfer to net@ after changing to suspended -- I've been unable to reprod

Re: kern/128790: [netinet] [patch] bug in IP_MINTTL setsockopt() implementation

Synopsis: [netinet] [patch] bug in IP_MINTTL setsockopt() implementation Responsible-Changed-From-To: freebsd-net->rwatson Responsible-Changed-By: rwatson Responsible-Changed-When: Thu Nov 13 00:15:55 UTC 2008 Responsible-Changed-Why: Grab ownership of this PR, I can take a look at this. h

Re: kern/122082: [in_pcb] NULL pointer dereference in in_pcbdrop

Synopsis: [in_pcb] NULL pointer dereference in in_pcbdrop State-Changed-From-To: open->feedback State-Changed-By: rwatson State-Changed-When: Fri Oct 31 12:52:03 UTC 2008 State-Changed-Why: Could I ask you to confirm whether this still occurs with the most recent 7-STABLE? If so, could I t

Re: kern/127528: [icmp]: icmp socket receives icmp replies not owned by the process.

Synopsis: [icmp]: icmp socket receives icmp replies not owned by the process. State-Changed-From-To: open->feedback State-Changed-By: rwatson State-Changed-When: Mon Sep 22 14:22:16 UTC 2008 State-Changed-Why: Request feedback based on correspondence to date -- the delivery of ICMP messages

Re: bin/112557: [patch] ppp(8) lock file should not use symlink name

Synopsis: [patch] ppp(8) lock file should not use symlink name Responsible-Changed-From-To: freebsd-bugs->freebsd-net Responsible-Changed-By: rwatson Responsible-Changed-When: Sun Mar 9 13:07:30 UTC 2008 Responsible-Changed-Why: Over to maintainers. http://www.freebsd.org/cgi/query-pr.cgi

Re: kern/95665: [if_tun] "ping: sendto: No buffer space available" with TUN interface (easily reproducable with test program)

Synopsis: [if_tun] "ping: sendto: No buffer space available" with TUN interface (easily reproducable with test program) State-Changed-From-To: suspended->closed State-Changed-By: rwatson State-Changed-When: Sat Mar 8 20:24:15 UTC 2008 State-Changed-Why: Closing the PR as it appears

Re: kern/93378: [tcp] Slow data transfer in Postfix and Cyrus IMAP (workaround known)

Synopsis: [tcp] Slow data transfer in Postfix and Cyrus IMAP (workaround known) Responsible-Changed-From-To: freebsd-bugs->net Responsible-Changed-By: rwatson Responsible-Changed-When: Sat Mar 8 20:58:36 UTC 2008 Responsible-Changed-Why: Over to maintainers. http://www.freebsd.org/cgi/qu

Re: kern/121274: [panic] Panic in ether_input() with different NIC's.

Synopsis: [panic] Panic in ether_input() with different NIC's. State-Changed-From-To: open->feedback State-Changed-By: rwatson State-Changed-When: Sun Mar 2 15:03:57 UTC 2008 State-Changed-Why: Could you run memtest86 or some other memory testing tool on the box? While this could w

Re: kern/115360: [ipv6] IPv6 address and if_bridge don't play well together.

Synopsis: [ipv6] IPv6 address and if_bridge don't play well together. State-Changed-From-To: feedback->closed State-Changed-By: rwatson State-Changed-When: Sun Jan 27 13:04:33 UTC 2008 State-Changed-Why: Close due to feedback timeout (>2 months). If you have further information to