mike-karels.net added a comment.
I disagree; congestion is congestion, not "congestion for everyone but me".
I'd prefer to leave the cwnd change until it is replaced by something more
modern.
REVISION DETAIL
https://reviews.freebsd.org/D5872
EMAIL PREFERENCES
https://reviews.freebsd.or
mike-karels.net added a comment.
btw, I think the line to set the snd_cwnd should remain for now, until
something replaces it. ENOBUFS signals local congestion.
REVISION DETAIL
https://reviews.freebsd.org/D5872
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreference
mike-karels.net added a comment.
Setting a retransmission timer on an ACK makes no sense; I don't think
tcp_output will send an ACK on a retransmission timeout.
Setting timers in the ENOBUFS case is at best a partial fix. If the ACK is
lost locally, we know; if it is lost elsewhere, we
mike-karels.net added a comment.
I believe that the original code is wrong, and the change is not sufficient
to fix it. The retransmit timer should be running if and only if we have
sent data into the receive window and are awaiting an ACK. The persist
timer should be running if and onl
mike-karels.net added a comment.
>>! In D1965#11, @gnn wrote:
> BTW Mike Karels was in favor of this in an email thread. He's not yet on
> phabricator but I'll ask him here as well.
Agreed, with minor exceptions. Given the ixl changes, I don't think the vtnet
example is worth keeping, and I th
mike-karels.net added a subscriber: mike-karels.net.
BRANCH
/head
REVISION DETAIL
https://reviews.freebsd.org/D1965
To: erj, adrian, jfvogel, gnn
Cc: mike-karels.net, glebius, freebsd-net
___
freebsd-net@freebsd.org mailing list
http://lists.freebs
