mike-karels.net added a comment.

  Setting a retransmission timer on an ACK makes no sense; I don't think 
tcp_output will send an ACK on a retransmission timeout.
  
  Setting timers in the ENOBUFS case is at best a partial fix.  If the ACK is 
lost locally, we know; if it is lost elsewhere, we don't. We need timers in any 
case.
  
  Setting  a local timer for the ACK case is no better for latency than having 
the other end run a retransmit timer..
  
  If there is a problem with setting the retransmit timer for a FIN, let's fix 
that.  Otherwise, I stand by my recommendation of deleting the code to set a 
timer.

REVISION DETAIL
  https://reviews.freebsd.org/D5872

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: sepherosa_gmail.com, network, glebius, lstewart, adrian, delphij, 
decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, 
freebsd-net-list, transport, jtl, hiren
Cc: mike-karels.net, jtl
_______________________________________________
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

Reply via email to