Re: svn commit: r314948 - in head: lib/libstand sys/boot/i386/libi386

2017-05-26 23:09 GMT+02:00 Baptiste Daroussin : > On Fri, May 26, 2017 at 12:27:45PM +0300, Andriy Gapon wrote: > > On 09/03/2017 08:01, Mariusz Zaborski wrote: > > > Author: oshogbo > > > Date: Thu Mar 9 06:01:24 2017 > > > New Revision: 314948 > > > URL: https://svnweb.freebsd.org/changeset/bas

[Differential] D10603: distinguish NFS versus TFTP boot by rootpath

kczekirda added a comment. https://reviews.freebsd.org/D10854 REVISION DETAIL https://reviews.freebsd.org/D10603 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: kczekirda, oshogbo, tsoome, bapt, sbruno, freebsd-net-list, #network Cc: avg, rgrimes __

[Differential] D10603: distinguish NFS versus TFTP boot by rootpath

kczekirda added a comment. tftpfs it's not bad, but you don't know what ipxe will do in the next commit. The problem is that we want to think about all. REVISION DETAIL https://reviews.freebsd.org/D10603 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To:

[Differential] D10603: distinguish NFS versus TFTP boot by rootpath

kczekirda added a comment. In https://reviews.freebsd.org/D10603#223305, @tsoome wrote: > In https://reviews.freebsd.org/D10603#223301, @bapt wrote: > > > We need to find a better mechanism, as this break usage where rootpath /something was before this patch expecting NFS to be locate

[Differential] D10485: Replace dhcp option 150 by 66

kczekirda abandoned this revision. kczekirda added a comment. Continuation in D10603 REVISION DETAIL https://reviews.freebsd.org/D10485 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: kczekirda, bapt, oshogbo, tsoome

[Differential] D10603: distinguish NFS versus TFTP boot by rootpath

kczekirda created this revision. REVISION SUMMARY Don't use DHCP 150 option to decide which protocol use to netboot. When root-path includes ip address - go thru NFS, if ip address not exists in root-path - go thru TFTP from server which ip address is in next-server. But there is one limita

[Differential] D10485: Replace dhcp option 150 by 66

kczekirda added a comment. And the last one possible solution: In https://reviews.freebsd.org/D10485#218945, @tsoome wrote: > But also there is much simpler way to distinguish NFS versus TFTP boot - because that is the problem - how to understand if we should go for NFS of for TFTP

[Differential] D10485: Replace dhcp option 150 by 66

kczekirda added a comment. @tsoome I based on the Intel's PXE Specification and there 66 exists. Nevermind, let's focus on the root-path. If we cannot use prefix tftp, maybe it can be a suffix? iPXE ignores bad root-path like: "192.168.22.19:/:tftp" F1206360: Screenshot at 2017-05

[Differential] D10485: Replace dhcp option 150 by 66

kczekirda added a comment. @rgrimes Please try to boot CURRENT over tftp protocol and without any third part software like iPXE. @tsoome > Note that dhcp servers in real life can offer all the configured data. And well, we can process both 66 and 150 just because that data may be

[Differential] D10485: Replace dhcp option 150 by 66

kczekirda added a reviewer: jhb. REVISION DETAIL https://reviews.freebsd.org/D10485 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: kczekirda, bapt, oshogbo, tsoome, sbruno, #network, freebsd-net-list, imp, jhb Cc: rgrimes, garga, ler, asomers

[Differential] D10485: Replace dhcp option 150 by 66

kczekirda added a comment. Until I go forward with your comments about the code I want to highlight it's not possible to support option 150, because we have to ask DHCP server for this option. PXE client (I mean network card firmware) never asks about option 150. I can't see any chance to us

[Differential] D10485: Replace dhcp option 150 by 66

kczekirda marked 2 inline comments as done. kczekirda added a comment. @asomers this change exactly provides compatibility with PXE standard, because in the PXE specification option 150 doesn't exist, but 66 does. netproto variable and option 150 appears in r305125. Documentation and re

[Differential] D10485: Replace dhcp option 150 by 66

kczekirda updated this revision to Diff 27744. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D10485?vs=27699&id=27744 REVISION DETAIL https://reviews.freebsd.org/D10485 AFFECTED FILES /usr/src/lib/libstand/bootp.c /usr/src/lib/libstand/bootp.h /usr/src/sys/boot/i386/libi386/pxe

[Differential] D10485: Replace dhcp option 150 by 66

kczekirda edited the summary of this revision. REVISION DETAIL https://reviews.freebsd.org/D10485 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: kczekirda, bapt, oshogbo, tsoome, sbruno, #network, freebsd-net-list, imp Cc: rgrimes, garga, ler, asomers

[Differential] D10485: Replace dhcp option 150 by 66

kczekirda added reviewers: freebsd-net-list, imp. REVISION DETAIL https://reviews.freebsd.org/D10485 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: kczekirda, bapt, oshogbo, tsoome, sbruno, #network, freebsd-net-list, imp __

[Differential] D9847: Try to extract the RFC1048 data from PXE

kczekirda updated this revision to Diff 25936. kczekirda marked 2 inline comments as done. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D9847?vs=25931&id=25936 REVISION DETAIL https://reviews.freebsd.org/D9847 AFFECTED FILES /usr/src/lib/libstand/bootp.c /usr/src/lib/libstand/bo

[Differential] D9847: Try to extract the RFC1048 data from PXE

kczekirda updated this revision to Diff 25931. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D9847?vs=25917&id=25931 REVISION DETAIL https://reviews.freebsd.org/D9847 AFFECTED FILES /usr/src/lib/libstand/bootp.c /usr/src/lib/libstand/bootp.h /usr/src/sys/boot/i386/libi386/pxe.c

[Differential] D9847: Try to extract the RFC1048 data from PXE

kczekirda updated this revision to Diff 25917. kczekirda marked an inline comment as done. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D9847?vs=25916&id=25917 REVISION DETAIL https://reviews.freebsd.org/D9847 AFFECTED FILES /usr/src/lib/libstand/bootp.c /usr/src/lib/libstand/bo

[Differential] D9847: Try to extract the RFC1048 data from PXE

kczekirda updated this revision to Diff 25916. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D9847?vs=25915&id=25916 REVISION DETAIL https://reviews.freebsd.org/D9847 AFFECTED FILES /usr/src/lib/libstand/bootp.c /usr/src/lib/libstand/bootp.h /usr/src/sys/boot/i386/libi386/pxe.c

[Differential] D9847: Try to extract the RFC1048 data from PXE

kczekirda updated this revision to Diff 25915. kczekirda marked an inline comment as done. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D9847?vs=25914&id=25915 REVISION DETAIL https://reviews.freebsd.org/D9847 AFFECTED FILES /usr/src/lib/libstand/bootp.c /usr/src/lib/libstand/bo

[Differential] D9847: Try to extract the RFC1048 data from PXE

kczekirda updated this revision to Diff 25914. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D9847?vs=25913&id=25914 REVISION DETAIL https://reviews.freebsd.org/D9847 AFFECTED FILES /usr/src/lib/libstand/bootp.c /usr/src/lib/libstand/bootp.h /usr/src/sys/boot/i386/libi386/pxe.c

[Differential] D9847: Try to extract the RFC1048 data from PXE

kczekirda updated this revision to Diff 25913. kczekirda marked 3 inline comments as done. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D9847?vs=25843&id=25913 REVISION DETAIL https://reviews.freebsd.org/D9847 AFFECTED FILES /usr/src/lib/libstand/bootp.c /usr/src/lib/libstand/bo

[Differential] D9847: Try to extract the RFC1048 data from PXE

kczekirda added a reviewer: freebsd-net-list. REVISION DETAIL https://reviews.freebsd.org/D9847 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: kczekirda, oshogbo, bapt, tsoome, glebius, #network, freebsd-net-list ___

[Differential] D8740: remove network mask calculation for Classful network

kczekirda added a reviewer: freebsd-net-list. REVISION DETAIL https://reviews.freebsd.org/D8740 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: kczekirda, bapt, imp, ian, oshogbo, tsoome, #network, glebius, freebsd-net-list Cc: glebius