Re: MFC VIMAGE fixes to 11-stable

2017-04-20 Thread peter . blok
Yeah, you are right. To keep the pf code as unchanged as possible, it is sometimes unclear whether something is virtualised or not. The SLIST_HEAD and RB_HEAD in pfvar.h need virtualisation as well. > On 20 Apr 2017, at 21:41, Marko Zec wrote: > > On Thu, 20 Apr 2017 21:24:33 +0200 > mailto:p

Re: MFC VIMAGE fixes to 11-stable

2017-04-20 Thread Marko Zec
On Thu, 20 Apr 2017 21:41:28 +0200 Marko Zec wrote: > [This sender failed our fraud detection checks and may not be who > they appear to be. Learn about spoofing at > http://aka.ms/LearnAboutSpoofing] > > On Thu, 20 Apr 2017 21:24:33 +0200 > wrote: > > > It doesn’t solve my problem, but below

Re: MFC VIMAGE fixes to 11-stable

2017-04-20 Thread Marko Zec
On Thu, 20 Apr 2017 21:24:33 +0200 wrote: > It doesn’t solve my problem, but below is the stack back trace that > leads to the problem that allocation doen for the default vnet are > given back as part of the vnet destroy. > > #0 0x807ff275 at pfr_destroy_kentry+0x35 > #1 0x807fe

Re: MFC VIMAGE fixes to 11-stable

2017-04-20 Thread peter . blok
It doesn’t solve my problem, but below is the stack back trace that leads to the problem that allocation doen for the default vnet are given back as part of the vnet destroy. #0 0x807ff275 at pfr_destroy_kentry+0x35 #1 0x807fe47c at pfr_remove_kentries+0x1fc #2 0x808053cd

[Bug 217637] One TCP connection accepted TWO times

2017-04-20 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217637 --- Comment #81 from commit-h...@freebsd.org --- A commit references this bug: Author: tuexen Date: Thu Apr 20 19:19:34 UTC 2017 New revision: 317208 URL: https://svnweb.freebsd.org/changeset/base/317208 Log: Syncoockies can be used in c

Re: Intel 82545 & TSO

2017-04-20 Thread Vijay Singh
Sure I can do that, but I don't have control over the ESX systems we are running on. If the hardware supports TSO, then it shouldn't be too hard to supplement "lem" to support it as well. The descriptor format seems to be the same, so most likely copying over some code from "em" should do it. On T

Re: Intel 82545 & TSO

2017-04-20 Thread Sean Bruno
On 04/05/17 15:54, Vijay Singh wrote: > This is from FreeBSD 10.3. > > On Wed, Apr 5, 2017 at 2:53 PM, Sean Bruno > wrote: > > > > On 04/05/17 10:26, Vijay Singh wrote: > > I am running FreeBSD as a guest on ESX 5.x and see Intel device > 0x100F in >

Re: MFC VIMAGE fixes to 11-stable

2017-04-20 Thread peter . blok
I’ll test this today. > On 20 Apr 2017, at 15:32, Kristof Provost wrote: > > On 20 Apr 2017, at 15:28, Marko Zec wrote: >> Right. But pfi_attach_group_event() and the other handlers cited above >> _do_ in fact invoke CURVNET_SET(vnet0) on entry, overriding the proper >> vnet choice from the call

Re: MFC VIMAGE fixes to 11-stable

2017-04-20 Thread Kristof Provost
On 20 Apr 2017, at 15:28, Marko Zec wrote: Right. But pfi_attach_group_event() and the other handlers cited above _do_ in fact invoke CURVNET_SET(vnet0) on entry, overriding the proper vnet choice from the caller. Yes, that does look wrong. I should have looked a bit further. Therefore the p

Re: MFC VIMAGE fixes to 11-stable

2017-04-20 Thread Marko Zec
On Thu, 20 Apr 2017 15:13:42 +0200 Kristof Provost wrote: > On 20 Apr 2017, at 12:42, Marko Zec wrote: > > The real culprit lies somewhere in PF code which operates on a wrong > > vnet. Without a backtrace it's difficult to guess, but a quick read > > reveals that > > > > pfi_initialize() > > >

Re: MFC VIMAGE fixes to 11-stable

2017-04-20 Thread Kristof Provost
On 20 Apr 2017, at 12:42, Marko Zec wrote: The real culprit lies somewhere in PF code which operates on a wrong vnet. Without a backtrace it's difficult to guess, but a quick read reveals that pfi_initialize() is called from the default vnet context, and subsequently registers interface eventh

Re: MFC VIMAGE fixes to 11-stable

2017-04-20 Thread peter . blok
Hi Marko, Thanks for the pointer. It was not my intention to have this committed, but it helped identify other problems. I have asked this before in -current, but got no answer so I posted it here to get an answer. If you look inside slab_free_item there is a KASSERT for just this, so that’s w

Re: MFC VIMAGE fixes to 11-stable

2017-04-20 Thread Marko Zec
On Wed, 19 Apr 2017 21:31:50 +0200 wrote: ... > I also have a change in zone_release to fix another panic and leak in > slab_free_item. The issue is that zone_release tries to release a keg > that never belonged to the zone it is trying to release. With my > limited knowledge, i think that should