smh added a comment.
book -> bool
REVISION DETAIL
https://reviews.freebsd.org/D9847
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: kczekirda, oshogbo, bapt, tsoome, glebius, freebsd-net-list, #network, gnn,
smh
Cc: smh
smh added inline comments.
INLINE COMMENTS
> pxe.c:296
> +
> + if (dhcp_try_rfc1048(bootplayer.vendor.d,
> BOOTP_DHCPVEND)) {
> + if (pxe_debug)
Didn't spot this before but does this need a more explicit test as this method
returns and isn't not
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217413
--- Comment #5 from b...@kobyla.org ---
Sometimes link speed drops to 100baseTX (mostly on em/bce) without the any
message to dmesg or syslog and then FreeBSD panics after the try of re-connect
the cable to fix the speed (it gets 1G speed ag
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217413
b...@kobyla.org changed:
What|Removed |Added
Summary|panic: Assertion err == 0 |panic: Assertion err == 0
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217413
Shawn Webb changed:
What|Removed |Added
CC||shawn.w...@hardenedbsd.org
--- Commen
On Fri, Mar 3, 2017 at 6:00 AM, Gleb Smirnoff wrote:
> On Sun, Feb 26, 2017 at 11:37:59PM +0800, Sepherosa Ziehau wrote:
> S> r314268 -> solisten
> S>
> S> 1KB:
> S> Performance (reqs/s)
> S> 77916.71 -> 26240.37
> S> Latency average
> S> 121ms -> 294ms
> ...
> S> So what I have seen is solisten's
asomers added inline comments.
INLINE COMMENTS
> jhujhiti_adjectivism.org wrote in nd6.c:1295
> > It's totally valid for an interface to have multiple addresses assigned,
> > each of which is on a different fib.
>
> Is this true? I'm not aware of a way this could happen. Interface routes are
>
jhujhiti_adjectivism.org added inline comments.
INLINE COMMENTS
> asomers wrote in nd6.c:1295
> Remember, the interface fib only matters for forwarding packets. It's
> totally valid for an interface to have multiple addresses assigned, each of
> which is on a different fib. So, to correctly d
On Thu, Mar 02, 2017 at 02:00:51PM -0800, Gleb Smirnoff wrote:
T> I did similar testing, and my results are the following, for three
T> consecutive runs:
T>
T> solistenhead (r306199)
T> req/s63k,63k,63k 46k,47k,44k
T> latency 213,214,208 232,233,22
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217509
Ngie Cooper changed:
What|Removed |Added
Assignee|freebsd-b...@freebsd.org|freebsd-net@FreeBSD.org
Se
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217508
Conrad Meyer changed:
What|Removed |Added
Assignee|freebsd-b...@freebsd.org|freebsd-net@FreeBSD.org
--
You are
kczekirda updated this revision to Diff 25917.
kczekirda marked an inline comment as done.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D9847?vs=25916&id=25917
REVISION DETAIL
https://reviews.freebsd.org/D9847
AFFECTED FILES
/usr/src/lib/libstand/bootp.c
/usr/src/lib/libstand/bo
smh requested changes to this revision.
smh added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> pxe.c:300
> + bootp(pxe_sock, BOOTP_PXE);
> + } else if (pxe_debug)
> + printf("pxe_open:
kczekirda updated this revision to Diff 25916.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D9847?vs=25915&id=25916
REVISION DETAIL
https://reviews.freebsd.org/D9847
AFFECTED FILES
/usr/src/lib/libstand/bootp.c
/usr/src/lib/libstand/bootp.h
/usr/src/sys/boot/i386/libi386/pxe.c
kczekirda updated this revision to Diff 25915.
kczekirda marked an inline comment as done.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D9847?vs=25914&id=25915
REVISION DETAIL
https://reviews.freebsd.org/D9847
AFFECTED FILES
/usr/src/lib/libstand/bootp.c
/usr/src/lib/libstand/bo
smh requested changes to this revision.
smh added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> pxe.c:300
> + bootp(pxe_sock, BOOTP_PXE);
> + } else {
> + if (pxe_debug)
You can squash
On Sun, Feb 26, 2017 at 11:37:59PM +0800, Sepherosa Ziehau wrote:
S> r314268 -> solisten
S>
S> 1KB:
S> Performance (reqs/s)
S> 77916.71 -> 26240.37
S> Latency average
S> 121ms -> 294ms
...
S> So what I have seen is solisten's performance is 1/3 of r314268, and
S> average latency doubles.
I did si
kczekirda updated this revision to Diff 25914.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D9847?vs=25913&id=25914
REVISION DETAIL
https://reviews.freebsd.org/D9847
AFFECTED FILES
/usr/src/lib/libstand/bootp.c
/usr/src/lib/libstand/bootp.h
/usr/src/sys/boot/i386/libi386/pxe.c
kczekirda updated this revision to Diff 25913.
kczekirda marked 3 inline comments as done.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D9847?vs=25843&id=25913
REVISION DETAIL
https://reviews.freebsd.org/D9847
AFFECTED FILES
/usr/src/lib/libstand/bootp.c
/usr/src/lib/libstand/bo
smh requested changes to this revision.
smh added a reviewer: smh.
smh added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> bootp.h:151
> +
> +#ifndef BOOTP
> +#define BOOTP
Is this needed as it looks like its to ensure its only included once by the
_BOOTP_H_
gnn accepted this revision.
gnn added a reviewer: gnn.
This revision has a positive review.
REVISION DETAIL
https://reviews.freebsd.org/D9847
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: kczekirda, oshogbo, bapt, tsoome, glebius, freebsd-net-list, #netwo
To whom it might concern:
Well, at least it does concern me. Why is support for multiple interrupts and
queues not enabled on bce(4)?
Whole block of code is surrounded with #ifdef 0 ... #endif
https://github.com/freebsd/freebsd/blob/master/sys/dev/bce/if_bce.c#L1108
--
| pozdrawiam / greeting
22 matches
Mail list logo
