smh requested changes to this revision.
smh added a reviewer: smh.
smh added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> bootp.h:151
> +
> +#ifndef BOOTP
> +#define BOOTP
Is this needed as it looks like its to ensure its only included once by the
_BOOTP_H_ should achieve that
> pxe.c:282
> + if (socktodesc(pxe_sock) == NULL) {
> + printf("pxe_open: bad socket. %d\n", pxe_sock);
> + return (ENXIO);
The formatting here is a bit odd, remove the "." ?
> pxe.c:299
> + bootp(pxe_sock, BOOTP_PXE);
> + } else
> + printf("pxe_open: loaded RFC1048 data from PXE
> Cache\n");
Should this only be output under verbose boot or pxe_debug?
REVISION DETAIL
https://reviews.freebsd.org/D9847
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: kczekirda, oshogbo, bapt, tsoome, glebius, freebsd-net-list, #network, gnn,
smh
Cc: smh
_______________________________________________
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
