[Differential] [Accepted] D1881: Allow Illumos code to co-exist with nv(9)

will accepted this revision. will added a reviewer: will. will added a comment. Ok, LGTM. Thanks for your effort! REVISION DETAIL https://reviews.freebsd.org/D1881 To: rstone, jfvogel, will Cc: will, emaste, pjd, freebsd-net ___ freebsd-net@freebsd.

[Differential] [Commented On] D1881: Allow Illumos code to co-exist with nv(9)

rstone added a comment. Err, that was supposed to be "installed it into a couple of *VMs*" REVISION DETAIL https://reviews.freebsd.org/D1881 To: rstone, jfvogel Cc: will, emaste, pjd, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.

[Differential] [Commented On] D1881: Allow Illumos code to co-exist with nv(9)

rstone added a comment. Ok, I did a full buildworld/buildkernel (with device zfs in my kernel config) and installed it into a couple of zfs. I tested creating a zpool out of a mfs disk, creating filesystems, setting some properties, doing a git clone into a file system, and then doing a zfs se

[Bug 194314] [ixgbe] driver makes some dangerous assumptions with struct mbuf sizing with IXGBE_RX_COPY_LEN

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194314 Garrett Cooper,425-314-3911 changed: What|Removed |Added CC||e...@freebsd.org

[Differential] [Commented On] D1438: FreeBSD callout rewrite and cleanup

wblock added inline comments. INLINE COMMENTS share/man/man9/timeout.9:98 Missing the word "if". share/man/man9/timeout.9:126 British->American: s/behaviour/behavior/ share/man/man9/timeout.9:140 Add comma after "zero". share/man/man9/timeout.9:295 Use "cannot". "can not" with a space mea

[Differential] [Updated, 120 lines] D1870: Add tests for nvlist_clone

rstone updated this revision to Diff 3862. rstone added a comment. This revision now requires review to proceed. Fix the test case to actually test the clone CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1870?vs=3813&id=3862 BRANCH review_D1870 REVISION DETAIL https://reviews.fre

[Differential] [Closed] D1877: Implement asprintf in libkern

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1877 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "fr

[Differential] [Closed] D1878: Add function to force an nvlist into the error state

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1878 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "fr

[Differential] [Closed] D1869: Tests of basic nvlist add functions

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1869 To: rstone, jfvogel Cc: emaste, pjd, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mai

[Differential] [Closed] D1868: Make libnv headers includable from C++

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1868 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "fr

[Differential] [Closed] D1872: Add test cases for nvlist_move_*

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1872 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail t

[Differential] [Closed] D1871: Add tests for nvlist_pack/unpack

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1871 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail t

[Differential] [Closed] D1873: Add tests for nvlist_take_*

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1873 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail t

[Differential] [Closed] D1874: Add tests for nvlist_free* functions

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1874 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail t

[Differential] [Closed] D1875: Add tests for dnv_get_*

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1875 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail t

[Differential] [Closed] D1876: Add tests for dnvlist_take_*

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1876 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail t

Re: Adding new media types to if_media.h

It does look good! We already have at least a half-dozen new media types to add. --- - Eric Joyner On Tue, Feb 17, 2015 at 9:26 AM, Adrian Chadd wrote: > Looks good to me. > > Thanks for doing this! > > > -a > > > On 16 February 2015 at 17:50, Mike Karels wrote: > > On Feb 9, gnn wrote: > > >

[Differential] [Changed Subscribers] D1869: Tests of basic nvlist add functions

emaste added a subscriber: emaste. REVISION DETAIL https://reviews.freebsd.org/D1869 To: rstone, jfvogel Cc: emaste, pjd, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send a

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

hiren added a comment. Another panic from an almost *idle* box: Sanitized panic #6 Dump header from device /dev/da0s1b Architecture: amd64 Architecture Version: 2 Dump Length: 6525980672B (6223 MB) Blocksize: 512 Dumptime: Thu Feb 19 06:16:57 2015 Hostname: xx

[Bug 197059] network locks up with IPv6 udp traffic

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197059 --- Comment #5 from Dmitry Sivachenko --- I can confirm this patch fixes my problem. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-net@freebsd.org maili

[Bug 197059] network locks up with IPv6 udp traffic

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197059 --- Comment #4 from Andrey V. Elsukov --- Created attachment 153179 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=153179&action=edit On output path send IPV6_PATHMTU ancillary data only to the socket, that had initiated an error

[Differential] [Commented On] D1879: Don't allocate memory for operations that do not insert

pjd added inline comments. INLINE COMMENTS lib/libnv/nvlist.c:276 'false' should be returned here. lib/libnv/nvlist.c:1094 'false' instead of '0'. lib/libnv/nvlist.c: 'false', not '0'. REVISION DETAIL https://reviews.freebsd.org/D1879 To: rstone, jfvogel Cc: freebsd-net, pjd

[Differential] [Commented On] D1878: Add function to force an nvlist into the error state

pjd added a comment. Other that the minor nit above, it looks good. INLINE COMMENTS lib/libnv/nvlist.c:144 I'd assert that error is != 0. REVISION DETAIL https://reviews.freebsd.org/D1878 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@fr

[Differential] [Commented On] D1877: Implement asprintf in libkern

pjd added inline comments. INLINE COMMENTS sys/conf/files:3185 Please sort properly (asprintf.c goes after arc4random.c). REVISION DETAIL https://reviews.freebsd.org/D1877 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing

[Differential] [Accepted] D1876: Add tests for dnvlist_take_*

pjd accepted this revision. pjd added a reviewer: pjd. pjd added a comment. Looks good. REVISION DETAIL https://reviews.freebsd.org/D1876 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/

[Differential] [Accepted] D1875: Add tests for dnv_get_*

pjd accepted this revision. pjd added a reviewer: pjd. pjd added a comment. Looks good. REVISION DETAIL https://reviews.freebsd.org/D1875 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/

[Differential] [Accepted] D1874: Add tests for nvlist_free* functions

pjd accepted this revision. pjd added a reviewer: pjd. pjd added a comment. Looks good. REVISION DETAIL https://reviews.freebsd.org/D1874 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/

[Differential] [Accepted] D1873: Add tests for nvlist_take_*

pjd accepted this revision. pjd added a reviewer: pjd. pjd added a comment. Looks good. REVISION DETAIL https://reviews.freebsd.org/D1873 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/