Re: [igb] add DROP_EN to each RX queue config if TX flow control is disabled

2014-09-13 Thread Adrian Chadd
On 13 September 2014 13:09, Eric Joyner wrote: > This looks good to me. The only comment I have is that according to the I350 > datasheet, DROP_EN is already set on all the queues but 0 by default, but I > haven't checked for the other adapters covered by igb. Right, but the igb_initialize_receiv

if_lagg(4) accounting changes

2014-09-13 Thread Alexander V. Chernikov
Hello list. I'd like to commit some changes to lagg counters which might be worth discussion. Diff is available at https://reviews.freebsd.org/D781 Quoting its summary: While counting packets using per-cpu counters might not introduce any significant overhead at current rates, we do not need to

[Bug 185967] [lagg] [patch] Link Aggregation LAGG: LACP not working in 10.0

2014-09-13 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=185967 --- Comment #11 from oliv...@cochard.me --- (In reply to kvedulv from comment #10) > Hi Oliver, > > (In reply to olivier from comment #8) > > The patch didn't solve Lagg regression between 9.2 and 10-stable (r267244). > > > > My configurat

Re: [igb] add DROP_EN to each RX queue config if TX flow control is disabled

2014-09-13 Thread Eric Joyner
This looks good to me. The only comment I have is that according to the I350 datasheet, DROP_EN is already set on all the queues but 0 by default, but I haven't checked for the other adapters covered by igb. --- - Eric Joyner On Mon, Sep 8, 2014 at 10:12 PM, Adrian Chadd wrote: > Hi, > > This p