Re: Infinite loop in tcp_output on RELENG_5

2004-10-09 Thread Kris Kennaway
On Sat, Oct 09, 2004 at 12:40:38PM +0400, Gleb Smirnoff wrote: > On Fri, Oct 08, 2004 at 08:39:00PM -0700, Kris Kennaway wrote: > K> This might be related to SACK, which is one of the situations where we > K> loop back to the again label, but that's just a guess. > > Does it panics with net.inet.t

Re: Infinite loop in tcp_output on RELENG_5

2004-10-09 Thread Robert Watson
On Fri, 8 Oct 2004, Kris Kennaway wrote: > pointyhat (SMP machine running RELENG_5) has twice in the past 2 days > gone into an infinite loop in the tcp_output() function (repeatedly > breaking into DDB and continuing, I can see it at different points in > the code). I made tcp_output keep a cou

Re: Infinite loop in tcp_output on RELENG_5

2004-10-09 Thread Gleb Smirnoff
On Fri, Oct 08, 2004 at 08:39:00PM -0700, Kris Kennaway wrote: K> This might be related to SACK, which is one of the situations where we K> loop back to the again label, but that's just a guess. Does it panics with net.inet.tcp.sack.enable=0 ? -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE _

Re: Calling m_pullup in ether_input

2004-10-09 Thread Luigi Rizzo
On Sat, Oct 09, 2004 at 12:34:34AM +0400, Gleb Smirnoff wrote: > On Fri, Oct 08, 2004 at 06:15:15PM +0300, Giorgos Keramidas wrote: > G> In ether_input() we unconditionaly discard the mbufs whose m_len is less than > G> ETHER_HDR_LEN. A bit higher M_PKTHDR has been checked but the check made > G>