Re: [patch] small fix to stop gcc warning for lib/libstand/assert.c

2010-03-15 Thread Alexander Best
John Baldwin schrieb am 2010-03-15: > On Saturday 13 March 2010 08:52:19 am Alexander Best wrote: > > hello, > > this patch fixes the following gcc warning: > > /usr/src/lib/libstand/assert.c:43: warning: implicit declaration of > > function 'exit' > > by using abort() instead of exit() (which

Re: [patch] small fix to stop gcc warning for lib/libstand/assert.c

2010-03-15 Thread John Baldwin
On Saturday 13 March 2010 08:52:19 am Alexander Best wrote: > hello, > > this patch fixes the following gcc warning: > > /usr/src/lib/libstand/assert.c:43: warning: implicit declaration of > function 'exit' > > by using abort() instead of exit() (which is illegal anyway). looking at > lib/libc/

Re: [patch] small fix to stop gcc warning for lib/libstand/assert.c

2010-03-14 Thread Alexander Best
Mark Linimon schrieb am 2010-03-14: > On Sun, Mar 14, 2010 at 01:12:14PM +0100, Alexander Best wrote: > > ah ok. thanks for the hint. just wanted to spare linimon from > > dealing with > > such minor prs. ;) > It's much more efficient for the project to have them in GNATS. > I tend to triage PRs

Re: [patch] small fix to stop gcc warning for lib/libstand/assert.c

2010-03-14 Thread Mark Linimon
On Sun, Mar 14, 2010 at 01:12:14PM +0100, Alexander Best wrote: > ah ok. thanks for the hint. just wanted to spare linimon from dealing with > such minor prs. ;) It's much more efficient for the project to have them in GNATS. I tend to triage PRs with the TV on, so it's not like the trivial ones

Re: [patch] small fix to stop gcc warning for lib/libstand/assert.c

2010-03-14 Thread Garrett Cooper
On Sun, Mar 14, 2010 at 4:12 AM, Alexander Best wrote: > Garrett Cooper schrieb am 2010-03-14: >> On Sat, Mar 13, 2010 at 9:24 PM, Doug Barton >> wrote: >> > On 03/13/10 05:52, Alexander Best wrote: >> >> hello, > >> >> this patch fixes the following gcc warning: > >> > For all such issues, pleas

Re: [patch] small fix to stop gcc warning for lib/libstand/assert.c

2010-03-14 Thread Alexander Best
Garrett Cooper schrieb am 2010-03-14: > On Sat, Mar 13, 2010 at 9:24 PM, Doug Barton > wrote: > > On 03/13/10 05:52, Alexander Best wrote: > >> hello, > >> this patch fixes the following gcc warning: > > For all such issues, please file a PR first so it doesn't get lost. > > When > > you get the

Re: [patch] small fix to stop gcc warning for lib/libstand/assert.c

2010-03-13 Thread Garrett Cooper
On Sat, Mar 13, 2010 at 9:24 PM, Doug Barton wrote: > On 03/13/10 05:52, Alexander Best wrote: >> hello, >> >> this patch fixes the following gcc warning: > > For all such issues, please file a PR first so it doesn't get lost. When > you get the PR confirmation back, feel free to alert the list to

Re: [patch] small fix to stop gcc warning for lib/libstand/assert.c

2010-03-13 Thread Doug Barton
On 03/13/10 05:52, Alexander Best wrote: > hello, > > this patch fixes the following gcc warning: For all such issues, please file a PR first so it doesn't get lost. When you get the PR confirmation back, feel free to alert the list to its existence. hth, Doug -- ... and that's just