On Sun, Mar 14, 2010 at 4:12 AM, Alexander Best <alexbes...@wwu.de> wrote: > Garrett Cooper schrieb am 2010-03-14: >> On Sat, Mar 13, 2010 at 9:24 PM, Doug Barton <do...@freebsd.org> >> wrote: >> > On 03/13/10 05:52, Alexander Best wrote: >> >> hello, > >> >> this patch fixes the following gcc warning: > >> > For all such issues, please file a PR first so it doesn't get lost. >> > When >> > you get the PR confirmation back, feel free to alert the list to >> > its >> > existence. > >> Yes, please submit a proper PR for this because it's a code bug; >> FYI, your solution isn't complete though (it's close): > > ah ok. thanks for the hint. just wanted to spare linimon from dealing with > such minor prs. ;) > >> ABORT(3) FreeBSD Library Functions Manual >> ABORT(3) > >> NAME >> abort -- cause abnormal program termination > >> LIBRARY >> Standard C Library (libc, -lc) > >> SYNOPSIS >> #include <stdlib.h> > >> void >> abort(void); > >> Please be explicit and add stdlib.h. > > adding stdlib.h isn't going to work since stand.h is used to declare function > prototypes which are also in stdlib.h. adding stdlib.h will cause gcc to > complain about multiple definitions. stand.h e.g. has it's own printf and some > other stuff.
Excellent point -- which means that any and all blanks in libstand could and should be filled in with equivalents in libc, i.e. you need to make sure that abort(3) has a proper function definition in libstand. Cheers, -Garrett _______________________________________________ freebsd-hackers@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to "freebsd-hackers-unsubscr...@freebsd.org"
