Re: Sign fixes for disklabel(8)

2002-11-16 Thread Bruce Evans
On Sat, 16 Nov 2002, Julian Elischer wrote: > On Sat, 16 Nov 2002, Bruce Evans wrote: > > Removing clauses gives maximal diffs and loses even some of the sub-minimal > > bounds checking (values less than 0 were just errors in some cases, but > > they are now converted to large unsigned values and

Re: Sign fixes for disklabel(8)

2002-11-16 Thread Bruce Evans
On Sat, 16 Nov 2002, Julian Elischer wrote: > On Sat, 16 Nov 2002, Bruce Evans wrote: > > > On Sat, 16 Nov 2002, Tim Robbins wrote: > > > > > On Fri, Nov 15, 2002 at 03:59:25PM -0800, Julian Elischer wrote: > > Labels should be able to handle disks much larger than 1TB (under -current > > where t

Re: Sign fixes for disklabel(8)

2002-11-16 Thread Juli Mallett
* De: Julian Elischer <[EMAIL PROTECTED]> [ Data: 2002-11-16 ] [ Subjecte: Re: Sign fixes for disklabel(8) ] > + u_int v; > [...] > + v = strtoul(tp, NULL, 10); strtoul returns 'unsigned long', not 'unsigned int', and this can o

Re: Sign fixes for disklabel(8)

2002-11-16 Thread Julian Elischer
On Sat, 16 Nov 2002, Bruce Evans wrote: > On Sat, 16 Nov 2002, Julian Elischer wrote: > > > On Fri, 15 Nov 2002, Nate Lawson wrote: > > > In the overflow case, strtoul returns ULONG_MAX. Or if you're interested > > > in catching invalid characters, use endptr. > > > > I'm not that interested i

Re: Sign fixes for disklabel(8)

2002-11-16 Thread Julian Elischer
On Sat, 16 Nov 2002, Bruce Evans wrote: > On Sat, 16 Nov 2002, Tim Robbins wrote: > > > On Fri, Nov 15, 2002 at 03:59:25PM -0800, Julian Elischer wrote: > > > > > Here are the diffs to allow disklabel to correctly create partitions > > > > 1TB (up to 2TB is useful with UFS2) pending a different

Re: Sign fixes for disklabel(8)

2002-11-16 Thread Bruce Evans
On Sat, 16 Nov 2002, Julian Elischer wrote: > On Fri, 15 Nov 2002, Nate Lawson wrote: > > In the overflow case, strtoul returns ULONG_MAX. Or if you're interested > > in catching invalid characters, use endptr. > > I'm not that interested in catching those cases.. they were not caught > before an

Re: Sign fixes for disklabel(8)

2002-11-16 Thread Bruce Evans
On Sat, 16 Nov 2002, Tim Robbins wrote: > On Fri, Nov 15, 2002 at 03:59:25PM -0800, Julian Elischer wrote: > > > Here are the diffs to allow disklabel to correctly create partitions > > > 1TB (up to 2TB is useful with UFS2) pending a different partitionning > > scheme. It also allows you to correc

Re: Sign fixes for disklabel(8)

2002-11-16 Thread Julian Elischer
On Fri, 15 Nov 2002, Julian Elischer wrote: (patches not copied) also two now unneeded occurrences of " (unsigned)v" replaced by "v" To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message

Re: Sign fixes for disklabel(8)

2002-11-16 Thread Julian Elischer
On Fri, 15 Nov 2002, Nate Lawson wrote: > On Sat, 16 Nov 2002, Tim Robbins wrote: > > On Fri, Nov 15, 2002 at 03:59:25PM -0800, Julian Elischer wrote: > > > > > Here are the diffs to allow disklabel to correctly create partitions > > > > 1TB (up to 2TB is useful with UFS2) pending a different p

Re: Sign fixes for disklabel(8)

2002-11-15 Thread Nate Lawson
On Sat, 16 Nov 2002, Tim Robbins wrote: > On Fri, Nov 15, 2002 at 03:59:25PM -0800, Julian Elischer wrote: > > > Here are the diffs to allow disklabel to correctly create partitions > > > 1TB (up to 2TB is useful with UFS2) pending a different partitionning > > scheme. It also allows you to correc

Re: Sign fixes for disklabel(8)

2002-11-15 Thread Tim Robbins
On Fri, Nov 15, 2002 at 03:59:25PM -0800, Julian Elischer wrote: > Here are the diffs to allow disklabel to correctly create partitions > > 1TB (up to 2TB is useful with UFS2) pending a different partitionning > scheme. It also allows you to correctly make smaller partitions beyond > 1TB which is

Re: Sign fixes for disklabel(8)

2002-11-15 Thread Julian Elischer
On Fri, 15 Nov 2002, Julian Elischer wrote: > > Here are the diffs to allow disklabel to correctly create partitions > > 1TB (up to 2TB is useful with UFS2) pending a different partitionning > scheme. It also allows you to correctly make smaller partitions beyond > 1TB which is nice if you don'