On Sat, 16 Nov 2002, Julian Elischer wrote: > On Fri, 15 Nov 2002, Nate Lawson wrote: > > In the overflow case, strtoul returns ULONG_MAX. Or if you're interested > > in catching invalid characters, use endptr. > > I'm not that interested in catching those cases.. they were not caught > before and I'm looking for the minimal diff.. > > I've just removed the clause. See new patch attached..
Removing clauses gives maximal diffs and loses even some of the sub-minimal bounds checking (values less than 0 were just errors in some cases, but they are now converted to large unsigned values and not checked at all). > A sensible thing might be to compare against a "sensible" value > but who knows what that value should be? Values should only be restricted to avoid ones that can't possibly work. This is mostly already done. > I include the new diff for your coments I'll wait for a later one with more of the suggested changes incorporated (strtoul() should use base 10, and most things shouldn't be changed, etc.). Bruce To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message
