Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Tomoaki AOKI
On Wed, 9 Nov 2022 14:12:21 -0800 Mark Millard wrote: > On Nov 9, 2022, at 12:56, Warner Losh wrote: > > > On Wed, Nov 9, 2022 at 1:54 PM Patrick M. Hausen wrote: > > > > > Am 09.11.2022 um 21:51 schrieb Warner Losh : > > > Yes. For safety, boot loader upgrade is mandatory when you do a zpool

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Tomoaki AOKI
On Wed, 9 Nov 2022 23:04:17 +0100 "Patrick M. Hausen" wrote: > Hi, > > > Am 09.11.2022 um 22:59 schrieb Alexander Leidinger > > : > > Quoting "Patrick M. Hausen" (from Wed, 9 Nov 2022 > > 22:47:28 +0100): > >> > >> I apologize, should have included that in the last mail. > >> This is a curre

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Mark Millard
On Nov 9, 2022, at 12:56, Warner Losh wrote: > On Wed, Nov 9, 2022 at 1:54 PM Patrick M. Hausen wrote: > > > Am 09.11.2022 um 21:51 schrieb Warner Losh : > > Yes. For safety, boot loader upgrade is mandatory when you do a zpool > > upgrade of the root filesystem. > > It was definitely needed i

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Patrick M. Hausen
Hi, > Am 09.11.2022 um 22:59 schrieb Alexander Leidinger : > Quoting "Patrick M. Hausen" (from Wed, 9 Nov 2022 22:47:28 > +0100): >> >> I apologize, should have included that in the last mail. >> This is a current FreeBSD 13.1-p2 hosting system we run. >> [ List of features from an active root

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Alexander Leidinger
Quoting "Patrick M. Hausen" (from Wed, 9 Nov 2022 22:47:28 +0100): Hi, Am 09.11.2022 um 22:38 schrieb Patrick M. Hausen : Am 09.11.2022 um 22:26 schrieb Alexander Leidinger : On quick look I haven't found a place where a compatibility setting is used for the rpool during the creation,

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Patrick M. Hausen
Hi, > Am 09.11.2022 um 22:38 schrieb Patrick M. Hausen : >> Am 09.11.2022 um 22:26 schrieb Alexander Leidinger : >> On quick look I haven't found a place where a compatibility setting is used >> for the rpool during the creation, so I can't point out what the exact >> difference is. >> Given tha

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Patrick M. Hausen
Hi, > Am 09.11.2022 um 22:26 schrieb Alexander Leidinger : > On quick look I haven't found a place where a compatibility setting is used > for the rpool during the creation, so I can't point out what the exact > difference is. > Given that empty_bpobj is not in the list of the boot code, it can'

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Alexander Leidinger
Quoting Brooks Davis (from Wed, 9 Nov 2022 21:18:41 +): On Wed, Nov 09, 2022 at 09:19:47PM +0100, Alexander Leidinger wrote: Quoting Mark Millard (from Wed, 9 Nov 2022 12:10:18 -0800): > On Nov 9, 2022, at 11:58, Alexander Leidinger > wrote: > >> Quoting "Patrick M. Hausen" (from Wed

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Alexander Leidinger
Quoting "Patrick M. Hausen" (from Wed, 9 Nov 2022 22:11:29 +0100): Hi, Am 09.11.2022 um 22:05 schrieb Alexander Leidinger : Attention, "upgrade" is overloaded here. "OS upgrade" will not render the pool unbootable (modulo bugs), but "zpool upgrade rpool" will (except we have provisions

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Brooks Davis
On Wed, Nov 09, 2022 at 09:19:47PM +0100, Alexander Leidinger wrote: > Quoting Mark Millard (from Wed, 9 Nov 2022 > 12:10:18 -0800): > > > On Nov 9, 2022, at 11:58, Alexander Leidinger > > wrote: > > > >> Quoting "Patrick M. Hausen" (from Wed, 9 Nov 2022 > >> 20:49:37 +0100): > >> > >>> H

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Alexander Leidinger
Quoting Warner Losh (from Wed, 9 Nov 2022 13:53:59 -0700):   On Wed, Nov 9, 2022 at 12:47 PM Alexander Leidinger wrote: Quoting Warner Losh (from Wed, 9 Nov 2022 08:54:33 -0700): as well. I'd settle for a good script that could be run as root (better would be not as root) that

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Patrick M. Hausen
Hi, > Am 09.11.2022 um 22:05 schrieb Alexander Leidinger : > Attention, "upgrade" is overloaded here. "OS upgrade" will not render the > pool unbootable (modulo bugs), but "zpool upgrade rpool" will (except we have > provisions that zpool upgrade doesn't enable all features in case the bootfs >

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Alexander Leidinger
Quoting Warner Losh (from Wed, 9 Nov 2022 13:56:43 -0700): On Wed, Nov 9, 2022 at 1:54 PM Patrick M. Hausen wrote: Hi Warner, > Am 09.11.2022 um 21:51 schrieb Warner Losh : > Yes. For safety, boot loader upgrade is mandatory when you do a zpool upgrade of the root filesystem. > It was defin

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Patrick M. Hausen
Hi, > Am 09.11.2022 um 21:56 schrieb Warner Losh > > If all you do is upgrade, then no, modulo bugs that we've thankfully not had > yet. It's when you enable something on the zpool that you can run into > trouble, but that's true independent of upgrade :) Thanks. That lets me sleep way better

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Warner Losh
On Wed, Nov 9, 2022 at 1:54 PM Patrick M. Hausen wrote: > Hi Warner, > > > Am 09.11.2022 um 21:51 schrieb Warner Losh : > > Yes. For safety, boot loader upgrade is mandatory when you do a zpool > upgrade of the root filesystem. > > It was definitely needed in the OpenZFS jump, and we've had one o

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Warner Losh
On Wed, Nov 9, 2022 at 12:47 PM Alexander Leidinger wrote: > Quoting Warner Losh (from Wed, 9 Nov 2022 08:54:33 > -0700): > > > as well. I'd settle for a good script that could be run as root (better > > would be not as root) that would take a filesystem that was created > > by makefs -t zfs and

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Patrick M. Hausen
Hi Warner, > Am 09.11.2022 um 21:51 schrieb Warner Losh : > Yes. For safety, boot loader upgrade is mandatory when you do a zpool upgrade > of the root filesystem. > It was definitely needed in the OpenZFS jump, and we've had one or two other > flag days since. That's a given and not a problem.

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Warner Losh
On Wed, Nov 9, 2022 at 12:02 PM Patrick M. Hausen wrote: > Hi all, > > > Am 09.11.2022 um 16:54 schrieb Warner Losh : > > >>There is a fixed list of features we support in the boot loader: > > >>[...] > > >>Any feature not on this list will cause the boot loader to > > >> reject the p

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Patrick M. Hausen
Hi, > Am 09.11.2022 um 21:31 schrieb Alexander Leidinger : > Some features are used directly when enabled. Some features go back to the > enabled state when some conditions are met. Some features are not reversible > without re-creating the pool (e.g. device_removal). The zzpool-features > man-

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Alexander Leidinger
Quoting "Patrick M. Hausen" (from Wed, 9 Nov 2022 21:19:23 +0100): Hi, Am 09.11.2022 um 21:15 schrieb Alexander Leidinger : Quoting "Patrick M. Hausen" (from Wed, 9 Nov 2022 21:02:52 +0100): Yet, I made it a habit to whenever I see this message: --- status: Some supported feat

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Alexander Leidinger
Quoting Mark Millard (from Wed, 9 Nov 2022 12:10:18 -0800): On Nov 9, 2022, at 11:58, Alexander Leidinger wrote: Quoting "Patrick M. Hausen" (from Wed, 9 Nov 2022 20:49:37 +0100): Hi, Am 09.11.2022 um 20:45 schrieb Alexander Leidinger : But "zpool set feature@edonr=enabled rpool"

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Patrick M. Hausen
Hi, > Am 09.11.2022 um 21:15 schrieb Alexander Leidinger : > Quoting "Patrick M. Hausen" (from Wed, 9 Nov 2022 21:02:52 > +0100): >> Yet, I made it a habit to whenever I see this message: >> >> --- >> status: Some supported features are not enabled on the pool. The pool can >> stil

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Alexander Leidinger
Quoting "Patrick M. Hausen" (from Wed, 9 Nov 2022 21:02:52 +0100): Hi, Am 09.11.2022 um 20:58 schrieb Alexander Leidinger : Quoting "Patrick M. Hausen" (from Wed, 9 Nov 2022 20:49:37 +0100): Hi, Am 09.11.2022 um 20:45 schrieb Alexander Leidinger : But "zpool set feature@edonr=en

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Mark Millard
On Nov 9, 2022, at 11:58, Alexander Leidinger wrote: > Quoting "Patrick M. Hausen" (from Wed, 9 Nov 2022 20:49:37 > +0100): > >> Hi, >> >>> Am 09.11.2022 um 20:45 schrieb Alexander Leidinger >>> : >>> But "zpool set feature@edonr=enabled rpool" (or any other feature not in >>> the list we t

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Alexander Leidinger
Quoting "Patrick M. Hausen" (from Wed, 9 Nov 2022 20:49:37 +0100): Hi, Am 09.11.2022 um 20:45 schrieb Alexander Leidinger : But "zpool set feature@edonr=enabled rpool" (or any other feature not in the list we talk about) would render it unbootable. Sorry, just to be sure. So an active

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Mark Millard
On Nov 9, 2022, at 11:02, Patrick M. Hausen wrote: > >> Am 09.11.2022 um 16:54 schrieb Warner Losh : There is a fixed list of features we support in the boot loader: [...] Any feature not on this list will cause the boot loader to reject the pool. > > I admit that I

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Patrick M. Hausen
Hi, > Am 09.11.2022 um 20:45 schrieb Alexander Leidinger : > But "zpool set feature@edonr=enabled rpool" (or any other feature not in the > list we talk about) would render it unbootable. Sorry, just to be sure. So an active change of e.g. checksum or compression algorithm might render the syst

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Alexander Leidinger
Quoting Warner Losh (from Wed, 9 Nov 2022 08:54:33 -0700): as well. I'd settle for a good script that could be run as root (better would be not as root) that would take a filesystem that was created by makefs -t zfs and turn on these features after an zpool upgrade. I have the vague outlines of

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Alexander Leidinger
Quoting "Patrick M. Hausen" (from Wed, 9 Nov 2022 20:02:55 +0100): Hi all, Am 09.11.2022 um 16:54 schrieb Warner Losh : >>There is a fixed list of features we support in the boot loader: >>[...] >>Any feature not on this list will cause the boot loader to >> reject the pool. I

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Alexander Leidinger
Quoting Warner Losh (from Wed, 9 Nov 2022 08:54:33 -0700): On Wed, Nov 9, 2022 at 5:46 AM Alexander Leidinger wrote: Quoting Alexander Leidinger (from Tue, 08 Nov 2022 10:50:53 +0100): > Should the above list be sorted in some way? Maybe in the same order > as the zpool-features lists th

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Patrick M. Hausen
Hi all, > Am 09.11.2022 um 16:54 schrieb Warner Losh : > >>There is a fixed list of features we support in the boot loader: > >>[...] > >>Any feature not on this list will cause the boot loader to > >> reject the pool. I admit that I do not grasp the full implications of this threa

Re: changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Warner Losh
On Wed, Nov 9, 2022 at 5:46 AM Alexander Leidinger wrote: > Quoting Alexander Leidinger (from Tue, 08 > Nov 2022 10:50:53 +0100): > > > Quoting Warner Losh (from Mon, 7 Nov 2022 14:23:11 > -0700): > > > >> > >> > >> On Mon, Nov 7, 2022 at 4:15 AM Alexander Leidinger > >> wrote: > >> > >>

changes to the zfs boot (was: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script)

2022-11-09 Thread Alexander Leidinger
Quoting Alexander Leidinger (from Tue, 08 Nov 2022 10:50:53 +0100): Quoting Warner Losh (from Mon, 7 Nov 2022 14:23:11 -0700):   On Mon, Nov 7, 2022 at 4:15 AM Alexander Leidinger wrote: Quoting Li-Wen Hsu (from Mon, 7 Nov 2022 03:39:19 GMT): The branch main has been update