https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211823
--- Comment #9 from Konstantin Belousov ---
(In reply to Konstantin Belousov from comment #8)
This work was most likely already done by OpenBSD or, likely, NetBSD.
Searching for their commit which modified the type is probably much less
te
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211823
--- Comment #8 from Konstantin Belousov ---
(In reply to Kirk McKusick from comment #7)
There are explicit mentions of 2^15-1 as the max valid values for ipg on UFS1
filesystems. Are they wrong ?
That is the thing that needs to be audited
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211823
Kirk McKusick changed:
What|Removed |Added
CC||mckus...@freebsd.org
--- Comment #
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211823
--- Comment #6 from Christian Heckendorf ---
Both variables hold the same value in their internal representation (0xcc00)
but cg_old_niblk overflows into negative values due to type limitations that
fs_ipg doesn't have. Clearly check_cgmagi
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211823
Konstantin Belousov changed:
What|Removed |Added
Resolution|--- |Not A Bug
Status
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211823
--- Comment #4 from Christian Heckendorf ---
If the value in cgp->cg_old_niblk happens to be negative then you'll end up
with a mess, or am I mistaken?
(gdb) p (uint32_t)(int16_t)52224
$1 = 4294953984
--
You are receiving this mail becau
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211823
--- Comment #3 from Konstantin Belousov ---
(In reply to Christian Heckendorf from comment #2)
I prefer to keep the code as is.
The cast is not needed, C compiler does silent standard-mandated promotion of
the integer variables to the same
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211823
--- Comment #2 from Christian Heckendorf ---
This patch may very well be wrong since I have no knowledge of UFS internals
but I assumed since these variables were being compared that the values were
compatible (the value of sblock.fs_ipg ab
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211823
Konstantin Belousov changed:
What|Removed |Added
CC||k...@freebsd.org,
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211823
Bug ID: 211823
Summary: [patch] fsck_ffs incorrectly failing in check_cgmagic
Product: Base System
Version: 10.3-RELEASE
Hardware: Any
OS: Any
Status: New
10 matches
Mail list logo
