Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-24 Thread Igor Filatov
Updated the driver. Skipping calibration for 0x0903 till we know more. I'll ask Kt soon but I need to prepare first because I have a few Qs of my own. On Wed, Jan 24, 2018 at 4:33 PM Sébastien Béchet < sebastien.bec...@osinix.com> wrote: > I do not know. I am not the right person I updated the qu

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-24 Thread Sébastien Béchet
I do not know. I am not the right person I updated the questions with our latest comments. Maybe you can ask directly kt@elan? see [questions](https://github.com/sbechet/elanfp/#preparation-of-questions-for-ktelan). On 2018-01-24 13:50, Igor Filatov wrote: Sebastien, Are you sure it's abou

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-24 Thread Igor Filatov
Sebastien, Are you sure it's about firmware versions, not the devices themselves? Do we have 0x0903 with different firmware? On Wed, Jan 24, 2018 at 12:10 PM Sébastien Béchet < sebastien.bec...@osinix.com> wrote: > For sure. > > Better code in attachment (correctly remove 4024 access for 0903).

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-24 Thread Sébastien Béchet
For sure. Better code in attachment (correctly remove 4024 access for 0903). On 2018-01-24 11:03, Igor Filatov wrote: I have a feeling that for 0903 commands 4023 and 4024 mean something different. I-byte mean is weird. given 2-byte "pixels". diff --git a/libfprint/drivers/elan.c b/libfprint/d

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-24 Thread Igor Filatov
I have a feeling that for 0903 commands 4023 and 4024 mean something different. I-byte mean is weird. given 2-byte "pixels". On Wed, 24 Jan 2018, 11:59 Sébastien Béchet, wrote: > Hello Igor, > > This hack for firmware <= 0x0153 working. > > ___ fprint

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-24 Thread Sébastien Béchet
Hello Igor, This hack for firmware <= 0x0153 working. diff --git a/libfprint/drivers/elan.c b/libfprint/drivers/elan.c index 1152509..a2cc013 100644 --- a/libfprint/drivers/elan.c +++ b/libfprint/drivers/elan.c @@ -45,6 +45,9 @@ static struct fpi_frame_asmbl_ctx assembling_ctx = { }; struct

Re: [fprint] elan patch + poc 0x903 and 0x0C03

2018-01-24 Thread Sébastien Béchet
Hello Igor, Thank you very much for your driver modification. It remains a problem for firmware version 1.53. get_calib_mean_cmd answer length is 1 not 2. see: https://github.com/sbechet/elanfp#hardware-report see: https://github.com/sbechet/elanfp/blob/master/elanfp.c#L178 MEAN_H only. I ha