Re: Installer language selection issue

2012-12-21 Thread Om
On Dec 21, 2012 2:10 PM, "Alex Harui" wrote: > > Om, > Do you have any objections if I > re-arrange that to require the use of file:// URLs to speed up testing? > Then we'll always be using the same code paths. I will also use file:// to > skip the mirror lookup. > I am not sure if I understand

Re: Installer language selection issue

2012-12-21 Thread Alex Harui
Om, I was testing out the installer today. I noticed there is a backdoor for local files that copies instead of downloading to speed up testing, but that means there are different code paths. Do you have any objections if I re-arrange that to require the use of file:// URLs to speed up testing?

Re: Installer language selection issue

2012-12-20 Thread Alex Harui
I just checked in the ability to specify -language=xx_YY on the command-line for the installer that override the default language. I was able to reproduce the missing strings problem without your changes and it appears to be fixed with your changes. On 12/20/12 4:09 PM, "Chema Balsas" wrote: >

Re: Installer language selection issue

2012-12-20 Thread Chema Balsas
I've committed the changes (r1424769). I've also added a rough (though complete) first translation to spanish. I've built the installer and it picks up fine my locale (es_ES) and all the strings. Please, verify that it is also working for other locales. Cheers, Chema 2012/12/20 Om > On Thu, De

Re: Installer language selection issue

2012-12-20 Thread Om
On Thu, Dec 20, 2012 at 2:44 PM, Chema Balsas wrote: > Hi, > > I've been digging around the installer, and I think I've found the issue > with the languages... I'm not very comfortable with the code, so I want to > ask before breaking anything ;) > > The problem seems to come from ViewResourceCon

Re: Installer language selection issue

2012-12-20 Thread Alex Harui
On 12/20/12 2:47 PM, "Chema Balsas" wrote: > Also, since we're no longer incubating, we should probably remove the > suffix from the installer name, right? ;) Yes. And I agree on your points below as well. > > 2012/12/20 Chema Balsas > >> Hi, >> >> I've been digging around the installer,

Re: Installer language selection issue

2012-12-20 Thread Chema Balsas
Also, since we're no longer incubating, we should probably remove the suffix from the installer name, right? ;) 2012/12/20 Chema Balsas > Hi, > > I've been digging around the installer, and I think I've found the issue > with the languages... I'm not very comfortable with the code, so I want to

Re: Installer language selection issue

2012-12-20 Thread Chema Balsas
Hi, I've been digging around the installer, and I think I've found the issue with the languages... I'm not very comfortable with the code, so I want to ask before breaking anything ;) The problem seems to come from ViewResourceConstants.as, line 191 if(n>1) messageStringsContentLocalized = .

Re: Installer language selection issue

2012-12-20 Thread Chema Balsas
Hi, I checked the submitted patch, and it does fix the issue of the license agreements box to appear empty. However, I also can't see the labels for the "Browse", "Next" and "Install Log". Was this known before? If you change the locale back and forth in the dropdown, then all texts are shown cor

Re: Installer language selection issue

2012-12-20 Thread Justin Mclean
Hi, > The more people who can help test the Installer with other languages, the > better it would be for us to make a confident release. Please take a look > when you get a chance. Just suggestion but can you make an "official" release candidate and put it up, if we test off trunk it may be ha

Re: Installer language selection issue

2012-12-20 Thread Alex Harui
I will try to get to it tonight. It would be nice if you could add a hook at startup (maybe command-line option or reading from the .xml file) that overrides the language/locale default it picks up from the player/os. That would enable us to simulate what folks in different countries will experie

Re: Installer language selection issue

2012-12-20 Thread Om
Bump... The more people who can help test the Installer with other languages, the better it would be for us to make a confident release. Please take a look when you get a chance. Source code is available here: https://svn.apache.org/repos/asf/incubator/flex/utilities/trunk Thanks, Om On Thu, De