Om, I was testing out the installer today. I noticed there is a backdoor for local files that copies instead of downloading to speed up testing, but that means there are different code paths. Do you have any objections if I re-arrange that to require the use of file:// URLs to speed up testing? Then we'll always be using the same code paths. I will also use file:// to skip the mirror lookup.
BTW, I guess we have to finalize the vote and post the SDK to its final home before making the final RC for the installer so its sources can point to the right place? On 12/20/12 2:55 PM, "Om" <bigosma...@gmail.com> wrote: > On Thu, Dec 20, 2012 at 2:44 PM, Chema Balsas <jbal...@gmail.com> wrote: > >> Hi, >> >> I've been digging around the installer, and I think I've found the issue >> with the languages... I'm not very comfortable with the code, so I want to >> ask before breaking anything ;) >> >> The problem seems to come from ViewResourceConstants.as, line 191 >> >> if(n>1) >> messageStringsContentLocalized = ... >> >> This never happens, as the localeChain is initialized inside >> selectDefaultLanguage() as resourceManager.localeChain = [ userLocale ]; >> >> It's also worth noting that if all the strings are not in the locale, an >> error is thrown. Shouldn't we have a base locale to inherit from? Urls for >> instance don't usually need translation, so they could default in general >> to the root locale. >> >> A possible fix is to append the root locale "en_US" when initializing >> localeChain, like >> >> resourceManager.localeChain = [ userLocale, "en_US" ]; >> >> This seems to fix all problems and I can see the existing "es_ES" strings >> and the default "en_US" strings for the missing ones. >> >> It's been a while since I've worked around these, so maybe this is not the >> solution at all... let me know what you think and how should this be >> addressed. >> Cheers, >> Chema >> >> >> > I think your analysis makes sense. Please go ahead and make the changes as > you mentioned. I can help test your changes. > > Thanks, > Om > > > >> 2012/12/20 Chema Balsas <jbal...@gmail.com> >> >>> Hi, >>> >>> I checked the submitted patch, and it does fix the issue of the license >>> agreements box to appear empty. However, I also can't see the labels for >>> the "Browse", "Next" and "Install Log". Was this known before? >>> >>> If you change the locale back and forth in the dropdown, then all texts >>> are shown correctly. >>> >>> >>> 2012/12/20 Alex Harui <aha...@adobe.com> >>> >>>> I will try to get to it tonight. It would be nice if you could add a >> hook >>>> at startup (maybe command-line option or reading from the .xml file) >> that >>>> overrides the language/locale default it picks up from the player/os. >>>> That >>>> would enable us to simulate what folks in different countries will >>>> experience. That would enable to you verify that the patch worked >>>> yourself. >>>> Last time we went through this, I had to stop in the debugger and zap >> the >>>> variable by hand. It would make it easier to test if we could override >> in >>>> some way. >>>> >>>> >>>> On 12/20/12 1:04 PM, "Om" <bigosma...@gmail.com> wrote: >>>> >>>>> Bump... >>>>> >>>>> The more people who can help test the Installer with other languages, >>>> the >>>>> better it would be for us to make a confident release. Please take a >>>> look >>>>> when you get a chance. >>>>> Source code is available here: >>>>> https://svn.apache.org/repos/asf/incubator/flex/utilities/trunk >>>>> >>>>> Thanks, >>>>> Om >>>>> >>>>> On Thu, Dec 20, 2012 at 12:46 AM, Om <bigosma...@gmail.com> wrote: >>>>> >>>>>> Commit 1424368 (hopefully) fixes this issue. >>>>>> >>>>>> Stefan Horochovec had provided this patch a while ago and attached it >>>> to >>>>>> the JIRA bug: https://issues.apache.org/jira/browse/FLEX-33223 >>>>>> >>>>>> Can you please test it and see if the issue is gone? >>>>>> >>>>>> Thanks, >>>>>> Om >>>>>> >>>>>> On Wed, Dec 19, 2012 at 12:22 PM, Chema Balsas <jbal...@gmail.com> >>>> wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> I was checking the installer, and was starting to add a translation >>>> for >>>>>>> the >>>>>>> es_ES locale. After compiling and launching it, There are lots of >>>> buttons >>>>>>> with empty labels. If you select a different locale and then back to >>>>>>> spanish, then the labels appear. >>>>>>> >>>>>>> I remember reading something like this before the previous version >> was >>>>>>> released... is this the same issue? Is it supposed to be fixed >> before >>>> this >>>>>>> version is released? >>>>>>> >>>>>>> Cheers, >>>>>>> Chema >>>>>>> >>>>>>> 2012/12/19 Alex Harui <aha...@adobe.com> >>>>>>> >>>>>>>>> -----Original Message----- >>>>>>>>> From: omup...@gmail.com [mailto:omup...@gmail.com] On Behalf Of >> Om >>>>>>>>> Sent: Wednesday, December 19, 2012 9:36 AM >>>>>>>>> To: flex-dev@incubator.apache.org >>>>>>>>> Subject: Re: [VOTE] Apache Flex 4.9 Release Candidate 4 >>>>>>>>> >>>>>>>>>> >>>>>>>>>>> 1. Would there be value in adding drop downs that let users >>>>>>> switch >>>>>>>>>> between >>>>>>>>>>> FP swc versions and AIR sdk versions? >>>>>>>>>> I would say no. I wouldn't want to take the time to test this >>>>>>>>>> additional functionality. Could the two URLs it will hit (based >> on >>>>>>>>>> the answer to #2) be stored in an external .XML file? That would >>>>>>> make >>>>>>>>>> it easier to folks to use different versions and for us to update >>>> an >>>>>>>>>> already released installer if Adobe goes and moves things around >>>>>>>>>> again. >>>>>>>>>> >>>>>>>>>> >>>>>>>>> Yes, we load all the download urls from an external config file: >>>>>>>>> http://incubator.apache.org/flex/sdk-installer-config.xml >>>>>>>>> >>>>>>>>> My thinking is that we will have a different config for each >> FP/AIR >>>>>>>> combination >>>>>>>>> we want to support. Just show a simple dropdown at the launch of >>>> the >>>>>>> app >>>>>>>>> (default to 11.4/3.4). Depending on what the user selects, we >> grab >>>>>>> the >>>>>>>>> corresponding config url. A pretty straightforward >> implementation. >>>>>>> But >>>>>>>> this >>>>>>>>> could wait until Installer 2.5 if we dont want to hold up Flex 4.9 >>>>>>>> release. >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Om >>>>>>>> >>>>>>>> I just built and ran the installer from sources on Win7. >>>>>>>> FB4.7 accepted the results as a new SDK. >>>>>>>> I created a new Flex project and it showed up in IE8 and FF15. >>>>>>>> I didn't see any warnings or errors. >>>>>>>> >>>>>>>> So, I would say we don't take the time to test all of the >>>> permutations >>>>>>> of >>>>>>>> configs. Adobe is not open next week so I will be working from >> home >>>>>>>> and testing the installer is slow because of the internet speeds I >>>> get >>>>>>> at >>>>>>>> home, so >>>>>>>> the less downloading I need to do, the better. >>>>>>>> >>>>>>>> Alex Harui >>>>>>>> Apache Flex Team >>>>>>>> http://blogs.adobe.com/aharui >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>>> >>>> >>>> -- >>>> Alex Harui >>>> Flex SDK Team >>>> Adobe Systems, Inc. >>>> http://blogs.adobe.com/aharui >>>> >>>> >>> >> -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
