Re: compiler files in pending svn load are in my whiteboard area

2012-04-03 Thread Carol Frampton
On 4/3/12 4 :43AM, "Justin Mclean" wrote: >Hi, > >Basically using the contrib library made the ant script easier to write >and understand. I do agree as you pointed out that was at a cost to >people who want to compile the SDK. > >The patch you supplied does fix this issue but the contrib lib i

Re: compiler files in pending svn load are in my whiteboard area

2012-04-03 Thread Justin Mclean
Hi, > committers (who want to test the change to the code before committing it). It will need to wait until the modules code is committed into the trunk (which hopefully will occur this weekend). Once that happens I'll take a look at the patch and applying it to the patches branch. Thanks, Ju

Re: compiler files in pending svn load are in my whiteboard area

2012-04-03 Thread Left Right
> > The patch you supplied does fix this issue but the contrib lib is also > required for Mustella. Perhaps it's best to wait until that donated and > then see how the build scripts can be improved? > > But Mustella isn't included in the SDK yet, it's only needed for committers (who want to test th

Re: compiler files in pending svn load are in my whiteboard area

2012-04-03 Thread Justin Mclean
Hi, Basically using the contrib library made the ant script easier to write and understand. I do agree as you pointed out that was at a cost to people who want to compile the SDK. The patch you supplied does fix this issue but the contrib lib is also required for Mustella. Perhaps it's best to

Re: compiler files in pending svn load are in my whiteboard area

2012-04-03 Thread Left Right
Oh, come on, seriously... there are people doing (or wanting to do) a Maven build - let them staff their build with gigabytes of nonsense, please, don't do it in the basic setup... Remember an old man who liked to shave so much he was known for his razor? What's redundant is wrong. This particular

Re: compiler files in pending svn load are in my whiteboard area

2012-04-03 Thread Justin Mclean
Hi, > hmm, why the ant contrib can not be in something like i.e. ant.lib > subdirectory? Binary files should only be included if there's no other option I believe (although I'm not 100% sure on the "official" rules). However the ant script could download and install the ant contrib jar file to

Re: compiler files in pending svn load are in my whiteboard area

2012-04-03 Thread Jarosław Szczepankiewicz
hmm, why the ant contrib can not be in something like i.e. ant.lib subdirectory? it is from apache with (i suppose) compatible license? if we add it to the ant file it will not require additional configuration / copying to the ant. It can be included at runtime without knowledge / configuration, us

Re: compiler files in pending svn load are in my whiteboard area

2012-04-02 Thread Justin Mclean
Hi, Perhaps the Ant Script could download/install the ANT contrib and/or echo instructions for doing so? Thanks, Justin

Re: compiler files in pending svn load are in my whiteboard area

2012-04-02 Thread Left Right
> Also mustella requires ant-contrib. I think ant-contrib > should just be documented as part of the required software (which sorry I > missed since I've had ant installed for so long). > > Also the formatting in the patch you submitted is messed up. Each indent > should be 4 spaces. It looks l

Re: compiler files in pending svn load are in my whiteboard area

2012-04-02 Thread Carol Frampton
I'm not sure I agree with this. While the script does work, it is much harder to read. Also mustella requires ant-contrib. I think ant-contrib should just be documented as part of the required software (which sorry I missed since I've had ant installed for so long). Also the formatting in the p

Re: compiler files in pending svn load are in my whiteboard area

2012-04-01 Thread Left Right
https://issues.apache.org/jira/browse/FLEX-35 I posted the patch. It seem to work for me. Best. Oleg

Re: compiler files in pending svn load are in my whiteboard area

2012-04-01 Thread Left Right
While we are at it, what is the convention for property names in Ant scripts? I can find these: CAPS_LOCK_IS_HERE, names.with.dots and sTuRdYcApS, which one should I use if I need to add a new property? Best. Oleg

Re: compiler files in pending svn load are in my whiteboard area

2012-04-01 Thread Left Right
> > > Oleg, if you want to see something like this get done, it is best to do it > yourself and submit the patch. > > I absolutely will. Was just asking whether this was intended.

Re: compiler files in pending svn load are in my whiteboard area

2012-04-01 Thread Alex Harui
On 4/1/12 3:32 AM, "olegsivo...@gmail.com" wrote: > Hi Justin, I understand what it's used for. I am asking that because I > think that simplicity of compilation for others > simplicity of writing for > the author. > Besides, I know a lot of people who would, out of principle disallow ant > co

Re: compiler files in pending svn load are in my whiteboard area

2012-04-01 Thread Left Right
Hi Justin, I understand what it's used for. I am asking that because I think that simplicity of compilation for others > simplicity of writing for the author. Besides, I know a lot of people who would, out of principle disallow ant contrib libraries. And I quite share their viewpoint. Compilation s

Re: compiler files in pending svn load are in my whiteboard area

2012-04-01 Thread Justin Mclean
Hi, > Was this conrib library inherited or added on purpose? I'd rather we loose > it. It's not required really. It's needed for the if ant task which is used in the download ant script. While it possible to write conditional ant tasks without it it makes them much simpler and easier to underst

Re: compiler files in pending svn load are in my whiteboard area

2012-03-31 Thread Left Right
Was this conrib library inherited or added on purpose? I'd rather we loose it. It's not required really. Best. Oleg

RE: compiler files in pending svn load are in my whiteboard area

2012-03-31 Thread Michael A. Labriola
>Just a note to anyone trying to compiling that the download.xml script uses >the ant task which is not part of the standard ant install. >You'll need to get it form here: >http://sourceforge.net/projects/ant-contrib/files/ant-contrib/ant-contrib-1.0b2/ Also on windows, it is best to run these

Re: compiler files in pending svn load are in my whiteboard area

2012-03-31 Thread Justin Mclean
Hi, Just a note to anyone trying to compiling that the download.xml script uses the ant task which is not part of the standard ant install. You'll need to get it form here: http://sourceforge.net/projects/ant-contrib/files/ant-contrib/ant-contrib-1.0b2/ On OSX you need to download the file and