Hi Jose,
> I signed my iCLA with my personal email: pepebarragan at me dot com.
> How it could simultaneously use it with this one in the list?
Should be no issues with that.
Justin
I signed my iCLA with my personal email: pepebarragan at me dot com.
How it could simultaneously use it with this one in the list?
On Aug 22, 2012, at 6:20 PM, Jose Barragan
wrote:
> Hi Justin,
>
> I just read, signed, scanned, and sent my iCLA to secret...@apache.org.
>
> Jose
>
>
> On Aug
Hi Justin,
I just read, signed, scanned, and sent my iCLA to secret...@apache.org.
Jose
On Aug 22, 2012, at 1:35 AM, Justin Mclean wrote:
> Hi,
>
>> if I need sign any document, I'll do in order i guess contribute in any kind
>> works thats need
> If you want you can sign and submit an ICL.
Hi, for what I read anonymous people should only refer the commit "Is
shared for donation" and does not required the signed ICLA.
But, I preferred to sign the ICLA and send it to secret...@apache.org since
my intention is to work in this project in the long term and be a committer
in the end.
@Jo
On Tue, Aug 21, 2012 at 5:22 PM, Om wrote:
> For interest here's how I applied the patch:
>
>> curl https://github.com/apache/flex/pull/7.patch | patch -p1
>>
>> So I think we can say that this is the best way on how to apply github
>> pull requests. Now just have to work out how to close them in
For interest here's how I applied the patch:
> curl https://github.com/apache/flex/pull/7.patch | patch -p1
>
> So I think we can say that this is the best way on how to apply github
> pull requests. Now just have to work out how to close them in github :-)
>
>
Maybe this helps?
http://developer.
Hi,
> if I need sign any document, I'll do in order i guess contribute in any kind
> works thats need
If you want you can sign and submit an ICL. [1] But for small patches like
this it's not needed.
> but if any anonymous community people need too, may be nobody contribute
> using this way.
Hi Justin,
Done too, if I need sign any document, I'll do in order i guess contribute in
any kind works thats need, but if any anonymous community people need too, may
be nobody contribute using this way.
I hope get an enough flexibility workflow as we can absorb external little (or
big) con
> So do we know if this is an issue with the encoding of the github patch or
> with the original commit/push to github?
It seems the issue was with the original commit as far as I understand, but
that is what I was really trying to confirm. I wanted to know that I was
solving the right prob
Hi,
Sorry "legally" is probably too strong a word there - no one is sending the
police around just yet :-) Just need to be clear about what is being donated
for a committer to be able to commit something and a patch (URL or file) in
JIRA the best place to do that.
Thanks,
Justin
Hi,
> I just sent two pull-request fixing the carlosrovira's commit, review and
> choose one of them, please.
As discussed in other threads can you please add the pull request link into
JIRA. [1]
While I can find your github pull request [2] easily enough I'm not able to
apply it legally as i
done +1
On Aug 21, 2012, at 9:00 AM, Justin Mclean wrote:
> Hi,
>
>> [1] https://issues.apache.org/jira/browse/INFRA-5171
>
> Watched and voted for!
>
> Justin
Hi Justin,
I just sent two pull-request fixing the carlosrovira's commit, review and
choose one of them, please.
Thanks,
Jose
On Aug 21, 2012, at 2:05 AM, Justin Mclean wrote:
> Hi,
>
> And I'm still not sure why "native2ascii -encoding UTF-8 -reverse" fixed the
> patch but you then get
Hi,
> [1] https://issues.apache.org/jira/browse/INFRA-5171
Watched and voted for!
Justin
> I was about to open an INFRA ticket to request the new mirrors after the
> SVN restructure
> I'd still do that otherwise any patches we git from git are going to be
> more and more out of date as time goes on.
>
> Thanks,
> Justin
>
>
Alrighty, I submitted a JIRA issue [1].
-omar
[1] https://is
Hi,
> Hmm... not sure how messy that can get yet if we keep SVN mirroring to Git
> and merging patches into Git and sending them to SVN via git-svn.
Well as far as I can work out the git mirrors will lag behind the SVN master
repo so sometimes you get a changes that don't quite match but you coul
On Mon, Aug 20, 2012 at 11:20 PM, Justin Mclean wrote:
> Hi,
>
> > We do want to get those mirrors back up before we move forward right?
> I'd guess that would take less time/infra has less objections (if at all)
> to that than the read/write Git repo so ask for the mirrors first.
>
> In order to
Hi,
> I want to try using git-svn to get code from GitHub/Git back to SVN, but I
> think the Git mirrors need to be updated before I try to mess with that.
Working with patch files is probably simpler, but would be good to know if it's
possible.
Thanks,
Justin
Hi,
> We do want to get those mirrors back up before we move forward right?
I'd guess that would take less time/infra has less objections (if at all) to
that than the read/write Git repo so ask for the mirrors first.
In order to have a read/write git repo we would have to disconnect it from
bei
On Mon, Aug 20, 2012 at 10:42 PM, Justin Mclean wrote:
> Hi,
>
> > * create patch file from pull request
> > 1) Commit & Push
> > 2) Create Pull Request
> > 3) Save Patch File & Correct Encoding
> >
> > * create patch file with git format-patch
> > 1) Commit & Push
> > 2) Create Patch File (gi
Hi,
> * create patch file from pull request
> 1) Commit & Push
> 2) Create Pull Request
> 3) Save Patch File & Correct Encoding
>
> * create patch file with git format-patch
> 1) Commit & Push
> 2) Create Patch File (git format-patch)
Not 100% we have an encoding issue it may be what was che
Hi
Instead of using the patch file from a pull request it would be also
possible to create the patch file in the local repository with "git
format-patch .." ( http://git-scm.com/docs/git-format-patch )
I used this command to create my few patches. It could be even more
efficient than using the pul
Hi,
And I'm still not sure why "native2ascii -encoding UTF-8 -reverse" fixed the
patch but you then get an issue in applying it.
Thanks,
Justin
Hi,
>> It was in another translation es_ES file inside this project, but I can not
>> remember exactly what was that file. Making some file search would help.
All the other es_ES file are correctly encoded as far a sI can see.
So do we know if this is an issue with the encoding of the github pa
>It was in another translation es_ES file inside this project, but I can not
>remember exactly what was that file. Making some file search would help.
Justin,
Perhaps I misunderstood. It seems like this code was manually entered from this
response. Is that the case?
Mike
It was in another translation es_ES file inside this project, but I can not
remember exactly what was that file. Making some file search would help.
Right now I must turn off laptop. Please let me know what's the expected
format and I'll update the patch accordingly
Thanks on advance!
El martes,
>but I made it look like the first one since I saw other spanish translation
>transforming the special chars like that.
Where did you do that work?
Mike
>Yep look like the patch file is not UTF8 encoded?
Yeh, its not actually encoded at all. If it were, I would expect to see:
utf32 - 0x00F3
utf16 - 0x00F3
utf8 - 0xC3 0xB3
So, is it coming out of github's character patch generation code that way
directly? If so, we could write a bit of code
Hi Mike and Justin,
The line showed by mike as the example:
+invalidCharPostcodeError=El c\u00f3digo postal contiene caract\u00e9res
inv\u00e1lidos.
could be changed to this:
+invalidCharPostcodeError=El código postal contiene caractéres inválidos.
but I made it look like the first one since I
Hi,
> Can you help me _see_ the Unicode issue better. I am clearly missing
> something. In the example patch, I see things like:
> +invalidCharPostcodeError=El c\u00f3digo postal contiene caract\u00e9res
> inv\u00e1lidos.
>
> Is this what you are referring to?
Yep look like the patch file is n
>Anyone have any ideas on this? Using curl and the patch URL for a pull request
>from github to apply a githib patch to SVN looks possible if we can sort out
>the unicode issue.
Justin,
Can you help me _see_ the Unicode issue better. I am clearly missing something.
In the example patch, I see
Hi,
Anyone have any ideas on this? Using curl and the patch URL for a pull request
from github to apply a githib patch to SVN looks possible if we can sort out
the unicode issue.
Thanks,
Justin
Hi Justin,
the problems you see things like "c\u00f3digo"? I set this kind on code
based en what I see on other spanish files.
2012/8/18 Justin Mclean
> Hi,
>
> > https://github.com/apache/flex/pull/3
>
> Looks to me like it still has the same issue:
> https://github.com/apache/flex/pull/3.patc
Hi,
> https://github.com/apache/flex/pull/3
Looks to me like it still has the same issue:
https://github.com/apache/flex/pull/3.patch
Thanks,
Justin
As I comented in other thread I put a new pull request fixing the enconding
problem:
https://github.com/apache/flex/pull/3
Thanks
2012/8/18 Omar Gonzalez
> On Friday, August 17, 2012, Justin Mclean wrote:
>
> > Hi,
> >
> > So here is what I think is the minimal amount of work to get a Github
On Friday, August 17, 2012, Justin Mclean wrote:
> Hi,
>
> So here is what I think is the minimal amount of work to get a Github
> pull request committed in SVN.
>
> I had tried playing about with patching between repos but it got complex
> fast.
>
> First off pull requests can be viewed as patch
Hi,
So here is what I think is the minimal amount of work to get a Github pull
request committed in SVN.
I had tried playing about with patching between repos but it got complex fast.
First off pull requests can be viewed as patches in Github:
https://github.com/apache/flex/pull/2.patch
BTW T
37 matches
Mail list logo
