Re: Committing to Trunk

2012-02-21 Thread Jun Heider
On Feb 20, 2012, at 6:29 PM, Alex Harui wrote: > On 2/20/12 5:15 PM, "Justin Mclean" wrote: >> >>> On another note, have we decided on a standard process for committing to >>> trunk? >> Well for lower risk smaller changes I'm all for CTR, f

Re: Committing to Trunk

2012-02-21 Thread Jun Heider
On Feb 20, 2012, at 6:15 PM, Justin Mclean wrote: >> Now that Carol has gotten the trunk populated, I was wondering if we need to >> wait until the Mustella tests are in before committing to trunk? > Just as an aside I've selected those issues as it was something tha

Re: Committing to Trunk

2012-02-21 Thread Justin Mclean
Hi, > Sure. If there is no test for it, then there is no way you can "break the > build" by checking it in. Not having access to Mustella I can't really say if it tests for something or not I can only guess. Hopefully it will be donated soon. :-) > Since you are not a committer yet, we just nee

Re: Committing to Trunk

2012-02-20 Thread Alex Harui
On 2/20/12 7:33 PM, "Justin Mclean" wrote: > Hi, > >> Definitely no need to wait to commit changes for which there are no Mustella >> tests. However, I thought we were going to try to cut a release that was >> close to "parity" first. > Can we do that without Mustella? or the compiler? Sure.

Re: Committing to Trunk

2012-02-20 Thread Justin Mclean
Hi, > Definitely no need to wait to commit changes for which there are no Mustella > tests. However, I thought we were going to try to cut a release that was > close to "parity" first. Can we do that without Mustella? or the compiler? I guess the question is do we wait around until we have every

Re: Committing to Trunk

2012-02-20 Thread Alex Harui
On 2/20/12 5:15 PM, "Justin Mclean" wrote: > Hi there. > >> Now that Carol has gotten the trunk populated, I was wondering if we need to >> wait until the Mustella tests are in before committing to trunk? > Just as an aside I've selected those issu

Re: Committing to Trunk

2012-02-20 Thread Justin Mclean
Hi there. > Now that Carol has gotten the trunk populated, I was wondering if we need to > wait until the Mustella tests are in before committing to trunk? Just as an aside I've selected those issues as it was something that could be easily verified without Mustella (ie no real fra

Re: Committing to Trunk

2012-02-20 Thread Jun Heider
On Feb 20, 2012, at 6:02 PM, Bertrand Delacretaz wrote: > On Mon, Feb 20, 2012 at 4:42 PM, Jun Heider wrote: >> >> Is the JIRA hooked up to the SVN repo? For instance being able to add a >> "RE: {Ticket Number}" to the commit message? > > Yes, if you start a commit message with FLEX-1234 the c

Re: Committing to Trunk

2012-02-20 Thread Bertrand Delacretaz
On Mon, Feb 20, 2012 at 4:42 PM, Jun Heider wrote: > > On Feb 20, 2012, at 5:38 PM, Bertrand Delacretaz wrote: > ...I think personally, with JIRA being around my preference would be a > Review-Then-Commit. > Is the JIRA hooked up to the SVN repo? For instance being able to add a > "RE: {Ticket Nu

Re: Committing to Trunk

2012-02-20 Thread Jun Heider
On Feb 20, 2012, at 5:38 PM, Bertrand Delacretaz wrote: > On Mon, Feb 20, 2012 at 4:30 PM, Jun Heider wrote: >> ...have we decided on a standard process for committing to trunk? For >> instance is +1 voting on the ML the >> Apache version of code reviews - I hope not since

Re: Committing to Trunk

2012-02-20 Thread Jun Heider
On Feb 20, 2012, at 5:37 PM, Michael A. Labriola wrote: > > Jun, > > Thanks for asking. I was looking at the same thing today for Justin's patch. > > Mike > Yep, Justin's patches are the ones I noticed. Thanks Justin! :)

Re: Committing to Trunk

2012-02-20 Thread Bertrand Delacretaz
On Mon, Feb 20, 2012 at 4:30 PM, Jun Heider wrote: > ...have we decided on a standard process for committing to trunk? For > instance is +1 voting on the ML the > Apache version of code reviews - I hope not since that seems like it'd be too > slow and cumbersome... The m

RE: Committing to Trunk

2012-02-20 Thread Michael A. Labriola
>Now that Carol has gotten the trunk populated, I was wondering if we need to >wait until the Mustella tests are in before committing to trunk? The reason I >ask is I know that there's been some patches submitted to the JIRA >tickets >and it would be nice to start getting w

Committing to Trunk

2012-02-20 Thread Jun Heider
Now that Carol has gotten the trunk populated, I was wondering if we need to wait until the Mustella tests are in before committing to trunk? The reason I ask is I know that there's been some patches submitted to the JIRA tickets and it would be nice to start getting work committed. On an