[flac-dev] Lets do a 1.3.2 release

HI all, I think its time for a new release. The current code base is stable and I've been building it for x86_64/linux, powerpc/linux, armhf/linux, x86_64/darwin in a Jenkins build bot. I'm pretty sure others have been building regularly on their platforms of interest. I made a first pass on an u

Re: [flac-dev] Lets do a 1.3.2 release

Great stuff! For the checklist, can I suggest you also make sure all resulting FLAC files are encoded with the new date in their encoder string? As for the changelog, I have kept track of those changes that might be more interesting for end-users and developers using the format (so no build-sy

Re: [flac-dev] Lets do a 1.3.2 release

Erik de Castro Lopo wrote: > I'm currently reading through the emails from the 1.3.1 release to see > what else needs to be done. > > So, please test and remind me of anything I may have forgotten. Looking at the bug list at SF: - "libFLAC and flac need

[flac-dev] [PATCH] doc: specify that quantized LPC shift must be non-negative

Refs http://sourceforge.net/p/flac/bugs/424/ --- doc/html/format.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/html/format.html b/doc/html/format.html index 8598941..2ce82c2 100644 --- a/doc/html/format.html +++ b/doc/html/format.html @@ -1578,7 +1578,7 @@

Re: [flac-dev] Lets do a 1.3.2 release

Currently, using the Makefile.lite build system with MinGW-w64 will produce a libFLAC.a that depends on libwin_utf8_io.a. Without it, a project building with just libFLAC.a will generate undefined reference errors at link time. metadata_iterators.c: fopen_utf8, chmod_utf8, utime_utf8, _stat64_utf8

Re: [flac-dev] [PATCH] doc: specify that quantized LPC shift must be non-negative

Tristan Matthews wrote: > Refs http://sourceforge.net/p/flac/bugs/424/ > - Quantized linear predictor coefficient shift > needed in bits (NOTE: this number is signed two's-complement). > + Quantized linear predictor coefficient shift > need

[flac-dev] [PATCH] limit padding value

Fix the problem with too big padding value that overflows block length. padding.patch Description: Binary data ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

[flac-dev] [PATCH] for too big picture file

The patch doesn't allow to embed too big picture that overflows metadata block length. picture.patch Description: Binary data ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

[flac-dev] [PATCH] for total_samples_estimate

The patch should fix bug total_estimate.patch Description: Binary data ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

[flac-dev] warning: inlining failed in call to 'FLAC__bitwriter_write_raw_uint32.constprop':

Building with MinGW-w64 GCC 5.3.0 via Makefile.lite, I get the following warnings: bitwriter.c: In function 'FLAC__bitwriter_write_utf8_uint64': bitwriter.c:324:19: warning: inlining failed in call to 'FLAC__bitwriter_write_raw_uint32.constprop': --param large-function-growth limit reached [-Winli

Re: [flac-dev] warning: inlining failed in call to 'FLAC__bitwriter_write_raw_uint32.constprop':

Evan Ramos wrote: > Would it be better to remove the inline keyword from the declaration > of FLAC__bitwriter_write_raw_uint32 (and by extension, remove inline > from FLAC__bitwriter_write_zeroes and add it to > FLAC__bitwriter_write_unary_unsigned)? I suspect that the cache misses > caused by cod

Re: [flac-dev] Lets do a 1.3.2 release

Evan Ramos wrote: > If so, I can provide a patch that does this. Yes please. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http

Re: [flac-dev] Lets do a 1.3.2 release

> Yes please. Patch attached. -Evan merge win_utf8_io into libFLAC.patch Description: Binary data ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] Lets do a 1.3.2 release

Evan Ramos wrote: > > Yes please. > > Patch attached. Sorry, I misunderstood your intention. The utf8_static library should stay as a separate component, but should be statically linked as needed (ie its only needed for Windows) Erik -- -

Re: [flac-dev] [PATCH] limit padding value

lvqcl wrote: > Fix the problem with too big padding value that overflows block length. Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing l

Re: [flac-dev] [PATCH] for too big picture file

lvqcl wrote: > The patch doesn't allow to embed too big picture that overflows > metadata block length. Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ f

Re: [flac-dev] Lets do a 1.3.2 release

Erik de Castro Lopo wrote: >> Patch attached. > > Sorry, I misunderstood your intention. The utf8_static library should > stay as a separate component, but should be statically linked as needed > (ie its only needed for Windows) My patch does not touch src/share/utf8, only src/share/win_utf8_io,

Re: [flac-dev] [PATCH] for total_samples_estimate

lvqcl wrote: > The patch should fix bug Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list

Re: [flac-dev] [PATCH] add a check in FLAC__bitwriter_write_raw_uint32()

lvqcl wrote: > FLAC__bitwriter_write_raw_uint32() assumes that the unused bits of the > 'val' argument are equal to zero, and doesn't check it (an assert was > added recently, but it's disabled in non-debug builds anyway). > > But it makes more difficult to catch metadata length overflow (such as

Re: [flac-dev] Lets do a 1.3.2 release

Evan Ramos wrote: > Erik de Castro Lopo wrote: > > >> Patch attached. > > > > Sorry, I misunderstood your intention. The utf8_static library should > > stay as a separate component, but should be statically linked as needed > > (ie its only needed for Windows) > > My patch does not touch src/sha

Re: [flac-dev] Lets do a 1.3.2 release

Evan Ramos wrote: >> Sorry, I misunderstood your intention. The utf8_static library should >> stay as a separate component, but should be statically linked as needed >> (ie its only needed for Windows) > > My patch does not touch src/share/utf8, only src/share/win_utf8_io, > which the objects in l

[flac-dev] [PATCH] minor fix for win_utf8_io.c

I noticed that share/win_utf8_io.h includes windows.h anyway, so another include in win_utf8_io.c is unnecessary. Also, the comment there is incorrect. win_utf8_io.patch Description: Binary data ___ flac-dev mailing list flac-dev@xiph.org http://lists.

Re: [flac-dev] [PATCH] minor fix for win_utf8_io.c

lvqcl писал(а) в своём письме Sat, 09 Jan 2016 03:21:09 +0300: I noticed that share/win_utf8_io.h includes windows.h anyway, so another include in win_utf8_io.c is unnecessary. Also, the comment there is incorrect. Disregard that patch, here is a better version that also removes declaration

Re: [flac-dev] Lets do a 1.3.2 release

lvqcl wrote: > IIRC libFLAC.a built with "./autogen.sh && ./configure && make" > contains all functions from win_utf8_io. So I think it's possible > to change some Makefile.lite or maybe build/*.mk files so that > there will be no need to add -lwin_utf8_io to -lFLAC. Version 2 of my patch attache